)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e3bbb09affdbe49aa662157cdbe9e31db37ebc79","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-27 21:05:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt is not controller-"},{"line_number":8,"context_line":"but instead, the subcloud name."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The collect script uses the standard prompt with the substring \"controller-\""},{"line_number":11,"context_line":"within expect, when running \"collect -sc subcloudx\" where x is 1,2,3,... ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1321466f_4e4d8d5f","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":31},"updated":"2021-10-27 23:20:12.000000000","message":"Indicate this is for subcloud collects","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a6cf04e9e5993ed307d4824548721f00e5968a7c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-27 21:05:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt is not controller-"},{"line_number":8,"context_line":"but instead, the subcloud name."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The collect script uses the standard prompt with the substring \"controller-\""},{"line_number":11,"context_line":"within expect, when running \"collect -sc subcloudx\" where x is 1,2,3,... ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0388c248_764da1ad","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":31},"in_reply_to":"1321466f_4e4d8d5f","updated":"2021-11-09 20:29:57.000000000","message":"Done","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e3bbb09affdbe49aa662157cdbe9e31db37ebc79","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt is not controller-"},{"line_number":8,"context_line":"but instead, the subcloud name."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The collect script uses the standard prompt with the substring \"controller-\""},{"line_number":11,"context_line":"within expect, when running \"collect -sc subcloudx\" where x is 1,2,3,... ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the subcloud bootstrapping stage fails and the login prompt never"},{"line_number":14,"context_line":"changes to controller-0 then collect from that subcloud will fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"adbf7d8b_e3713a0b","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":74},"updated":"2021-10-27 23:20:12.000000000","message":"I would say that where a subcloud is properly provisioned and configured the active controller\u0027s login prompt is \u0027controller-0 or 1.","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e3bbb09affdbe49aa662157cdbe9e31db37ebc79","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-27 21:05:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt is not controller-"},{"line_number":8,"context_line":"but instead, the subcloud name."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The collect script uses the standard prompt with the substring \"controller-\""},{"line_number":11,"context_line":"within expect, when running \"collect -sc subcloudx\" where x is 1,2,3,... ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the subcloud bootstrapping stage fails and the login prompt never"},{"line_number":14,"context_line":"changes to controller-0 then collect from that subcloud will fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6844845f_6f225c06","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":74},"updated":"2021-10-27 23:20:12.000000000","message":"lines too long. 72 is the limit I think","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a6cf04e9e5993ed307d4824548721f00e5968a7c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-27 21:05:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt is not controller-"},{"line_number":8,"context_line":"but instead, the subcloud name."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The collect script uses the standard prompt with the substring \"controller-\""},{"line_number":11,"context_line":"within expect, when running \"collect -sc subcloudx\" where x is 1,2,3,... ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the subcloud bootstrapping stage fails and the login prompt never"},{"line_number":14,"context_line":"changes to controller-0 then collect from that subcloud will fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4294ade8_0e10ba9a","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":74},"in_reply_to":"6844845f_6f225c06","updated":"2021-11-09 20:29:57.000000000","message":"Done","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a6cf04e9e5993ed307d4824548721f00e5968a7c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt is not controller-"},{"line_number":8,"context_line":"but instead, the subcloud name."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The collect script uses the standard prompt with the substring \"controller-\""},{"line_number":11,"context_line":"within expect, when running \"collect -sc subcloudx\" where x is 1,2,3,... ."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the subcloud bootstrapping stage fails and the login prompt never"},{"line_number":14,"context_line":"changes to controller-0 then collect from that subcloud will fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4290630f_fbcbe320","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":74},"in_reply_to":"adbf7d8b_e3713a0b","updated":"2021-11-09 20:29:57.000000000","message":"Done","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e3bbb09affdbe49aa662157cdbe9e31db37ebc79","unresolved":true,"context_lines":[{"line_number":13,"context_line":"If the subcloud bootstrapping stage fails and the login prompt never"},{"line_number":14,"context_line":"changes to controller-0 then collect from that subcloud will fail."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Tes Plan:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PASS: Verify that collect works after manually modifying PS1 on the"},{"line_number":19,"context_line":"subcloud"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"20e90759_8bfd65c0","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":4},"updated":"2021-10-27 23:20:12.000000000","message":"nit: type \u0027Test\u0027","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a6cf04e9e5993ed307d4824548721f00e5968a7c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"If the subcloud bootstrapping stage fails and the login prompt never"},{"line_number":14,"context_line":"changes to controller-0 then collect from that subcloud will fail."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Tes Plan:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PASS: Verify that collect works after manually modifying PS1 on the"},{"line_number":19,"context_line":"subcloud"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"622ef147_7ee85141","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":4},"in_reply_to":"20e90759_8bfd65c0","updated":"2021-11-09 20:29:57.000000000","message":"Done","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e3bbb09affdbe49aa662157cdbe9e31db37ebc79","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Tes Plan:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PASS: Verify that collect works after manually modifying PS1 on the"},{"line_number":19,"context_line":"subcloud"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1948992"},{"line_number":22,"context_line":"Change-Id: I20523bce76bc3c15f003ff4924299b58513bc57f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c3d40810_6935ec7c","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":8},"updated":"2021-10-27 23:20:12.000000000","message":"A fault inserted test case is fine but this can\u0027t be the only test. \n\nThere must also be some regression tests that verify the update did not break anything.\n\nI\u0027d like to see a real case of when collect is run against a subcloud that failed config in a way that allowed login but the login prompt never changed.","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"028f7729e2db5d823926356f9ec345d2d7af0d58","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Tes Plan:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PASS: Verify that collect works after manually modifying PS1 on the"},{"line_number":19,"context_line":"subcloud"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1948992"},{"line_number":22,"context_line":"Change-Id: I20523bce76bc3c15f003ff4924299b58513bc57f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b5c43d6e_1b6c416e","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":8},"in_reply_to":"44554491_8c9762ee","updated":"2021-11-24 15:37:21.000000000","message":"Done","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"737a846d8e4b0c9983f366ce7b19491824832718","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Tes Plan:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PASS: Verify that collect works after manually modifying PS1 on the"},{"line_number":19,"context_line":"subcloud"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1948992"},{"line_number":22,"context_line":"Change-Id: I20523bce76bc3c15f003ff4924299b58513bc57f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"44554491_8c9762ee","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":8},"in_reply_to":"a61f199e_5ab6a906","updated":"2021-11-11 16:19:51.000000000","message":"Unable to reproduce a situation where the prompt becomes \"subcloud1\".","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a6cf04e9e5993ed307d4824548721f00e5968a7c","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Tes Plan:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PASS: Verify that collect works after manually modifying PS1 on the"},{"line_number":19,"context_line":"subcloud"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1948992"},{"line_number":22,"context_line":"Change-Id: I20523bce76bc3c15f003ff4924299b58513bc57f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a61f199e_5ab6a906","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":8},"in_reply_to":"c3d40810_6935ec7c","updated":"2021-11-09 20:29:57.000000000","message":"I am trying to figure out how this can be done. I\u0027ll attempt a couple more times to make it fail in the desired way.","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"1a74c83e77fdfaad28a30a0a1d6883131fb74746","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"PASS: Clean the longs on controller-0 by using"},{"line_number":42,"context_line":"collect --clean"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Closes-Bug: 1948992"},{"line_number":45,"context_line":"Change-Id: I20523bce76bc3c15f003ff4924299b58513bc57f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"73e06963_03ce7252","line":43,"updated":"2021-11-18 01:14:16.000000000","message":"You need a signed-off-by.  This is typically added using the -s option in git commit (I think)","commit_id":"662548bbca0d7cf0efe0f06965bf2be29bcbef0c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"7054e5969eb5d6cb1ccb7e076b81a2016cd6d413","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"PASS: Clean the longs on controller-0 by using"},{"line_number":42,"context_line":"collect --clean"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Closes-Bug: 1948992"},{"line_number":45,"context_line":"Change-Id: I20523bce76bc3c15f003ff4924299b58513bc57f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"172c667c_0431d0a6","line":43,"in_reply_to":"73e06963_03ce7252","updated":"2021-11-24 15:34:01.000000000","message":"Done","commit_id":"662548bbca0d7cf0efe0f06965bf2be29bcbef0c"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"1967dfc95a9ed0faa6b411ed6aec015140265ac5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-18 11:43:35 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt"},{"line_number":8,"context_line":"is not controller- but instead, the subcloud name. This"},{"line_number":9,"context_line":"issue pertains to subcloud collects."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The collect script uses the standard prompt with the"},{"line_number":12,"context_line":"substring \"controller-\" within expect, when running"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"0cddf873_1e000de8","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":36},"updated":"2021-11-19 20:37:26.000000000","message":"Title line should fit on 1 line","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-18 11:43:35 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt"},{"line_number":8,"context_line":"is not controller- but instead, the subcloud name. This"},{"line_number":9,"context_line":"issue pertains to subcloud collects."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The collect script uses the standard prompt with the"},{"line_number":12,"context_line":"substring \"controller-\" within expect, when running"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"8bc7f600_24ad0290","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":36},"in_reply_to":"0cddf873_1e000de8","updated":"2021-11-24 00:49:34.000000000","message":"Agree, and be less than 72 characters","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"7054e5969eb5d6cb1ccb7e076b81a2016cd6d413","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-18 11:43:35 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the collect script to allow its use when the prompt"},{"line_number":8,"context_line":"is not controller- but instead, the subcloud name. This"},{"line_number":9,"context_line":"issue pertains to subcloud collects."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The collect script uses the standard prompt with the"},{"line_number":12,"context_line":"substring \"controller-\" within expect, when running"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5c0e04f1_24e8dd60","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":36},"in_reply_to":"8bc7f600_24ad0290","updated":"2021-11-24 15:34:01.000000000","message":"Done","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The collect script uses the standard prompt with the"},{"line_number":12,"context_line":"substring \"controller-\" within expect, when running"},{"line_number":13,"context_line":"\"collect -sc subcloudx\" where x is 1,2,3,... ."},{"line_number":14,"context_line":"When a subcloud is properly provisioned and configured"},{"line_number":15,"context_line":"the active controller\u0027s login prompt is \u0027controller-0\u0027"},{"line_number":16,"context_line":"or 1."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"76311b72_f0da488f","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":40},"updated":"2021-11-24 00:49:34.000000000","message":"This is really ${subcloud} where that can be any valid hostname. There is no requirement that subclouds be named \u0027subcloud#\u0027.","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"7054e5969eb5d6cb1ccb7e076b81a2016cd6d413","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The collect script uses the standard prompt with the"},{"line_number":12,"context_line":"substring \"controller-\" within expect, when running"},{"line_number":13,"context_line":"\"collect -sc subcloudx\" where x is 1,2,3,... ."},{"line_number":14,"context_line":"When a subcloud is properly provisioned and configured"},{"line_number":15,"context_line":"the active controller\u0027s login prompt is \u0027controller-0\u0027"},{"line_number":16,"context_line":"or 1."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"50d8d0fe_8eab5f7e","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":40},"in_reply_to":"76311b72_f0da488f","updated":"2021-11-24 15:34:01.000000000","message":"Done","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":16,"context_line":"or 1."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"However, if the subcloud bootstrapping stage fails and the"},{"line_number":19,"context_line":"login prompt never changes to controller-0 then"},{"line_number":20,"context_line":"collect from that subcloud will fail."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Test Plan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"92107148_d7f84a3c","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":42},"updated":"2021-11-24 00:49:34.000000000","message":"nit: Suggest ... \u0027changes from the subcloud name to \u0027controller-#\u0027 ...","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"7054e5969eb5d6cb1ccb7e076b81a2016cd6d413","unresolved":false,"context_lines":[{"line_number":16,"context_line":"or 1."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"However, if the subcloud bootstrapping stage fails and the"},{"line_number":19,"context_line":"login prompt never changes to controller-0 then"},{"line_number":20,"context_line":"collect from that subcloud will fail."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Test Plan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"417b1840_c0da1aa5","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":42},"in_reply_to":"92107148_d7f84a3c","updated":"2021-11-24 15:34:01.000000000","message":"Done","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Test Plan:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"PASS: Verify that collect works after manually modifying"},{"line_number":25,"context_line":"PS1 on the subcloud."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"PASS: Verify named subcloud collect (-sc -a -p -n \u003cname\u003e)"},{"line_number":28,"context_line":"and ensure no regression"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"10c97393_0be100fc","line":25,"range":{"start_line":24,"start_character":6,"end_line":25,"end_character":20},"updated":"2021-11-24 00:49:34.000000000","message":"I believe manual modify will only modify that current shell. If you change it then login to the subcloud from another xterm is the prompt still changed ?","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":25,"context_line":"PS1 on the subcloud."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"PASS: Verify named subcloud collect (-sc -a -p -n \u003cname\u003e)"},{"line_number":28,"context_line":"and ensure no regression"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"PASS: Verify collection of all logs from all subclouds"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"f2af34e8_083d50e5","line":28,"range":{"start_line":28,"start_character":11,"end_line":28,"end_character":24},"updated":"2021-11-24 00:49:34.000000000","message":"What does \u0027no regression\u0027 mean in htis context.\n\nSuggest creating a \u0027Regression:\u0027 heading and list the regression test cases under it. This allows the reviewer to easily distinguish between test targetted at the changes compared to the regression tests.","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":27,"context_line":"PASS: Verify named subcloud collect (-sc -a -p -n \u003cname\u003e)"},{"line_number":28,"context_line":"and ensure no regression"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"PASS: Verify collection of all logs from all subclouds"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"PASS: Verify collection of all logs from all hosts in"},{"line_number":33,"context_line":"the system"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7c35d3fc_1c946163","line":30,"range":{"start_line":30,"start_character":20,"end_line":30,"end_character":35},"updated":"2021-11-24 00:49:34.000000000","message":"nit: Suggest leaving this out. Would then read \u0027Verify collect from all subclouds\u0027\n\nnit: suggest similar change for others below.","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"7054e5969eb5d6cb1ccb7e076b81a2016cd6d413","unresolved":false,"context_lines":[{"line_number":27,"context_line":"PASS: Verify named subcloud collect (-sc -a -p -n \u003cname\u003e)"},{"line_number":28,"context_line":"and ensure no regression"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"PASS: Verify collection of all logs from all subclouds"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"PASS: Verify collection of all logs from all hosts in"},{"line_number":33,"context_line":"the system"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"06f67cdf_72e2c7e7","line":30,"range":{"start_line":30,"start_character":20,"end_line":30,"end_character":35},"in_reply_to":"7c35d3fc_1c946163","updated":"2021-11-24 15:34:01.000000000","message":"Done","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":30,"context_line":"PASS: Verify collection of all logs from all subclouds"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"PASS: Verify collection of all logs from all hosts in"},{"line_number":33,"context_line":"the system"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"PASS: Create a log on the subcloud and then delete using"},{"line_number":36,"context_line":"collect --clean -sc subcloud1 from the controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"4288b80c_823224f5","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":10},"updated":"2021-11-24 00:49:34.000000000","message":"nit: suggest spacing these out to align with the word \u0027Verify\u0027. Same for all.","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":32,"context_line":"PASS: Verify collection of all logs from all hosts in"},{"line_number":33,"context_line":"the system"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"PASS: Create a log on the subcloud and then delete using"},{"line_number":36,"context_line":"collect --clean -sc subcloud1 from the controller"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"PASS: Change the prompt on the subcloud to its subcloud"},{"line_number":39,"context_line":"name and ensure that collect works"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"b8cfbe8b_f8c98b08","line":36,"range":{"start_line":35,"start_character":6,"end_line":36,"end_character":49},"updated":"2021-11-24 00:49:34.000000000","message":"nit: Suggest \u0027Verify subcloud and subclouds clean\u0027","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":35,"context_line":"PASS: Create a log on the subcloud and then delete using"},{"line_number":36,"context_line":"collect --clean -sc subcloud1 from the controller"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"PASS: Change the prompt on the subcloud to its subcloud"},{"line_number":39,"context_line":"name and ensure that collect works"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"PASS: Clean the longs on controller-0 by using"},{"line_number":42,"context_line":"collect --clean"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"f06bae4d_9e05d65a","line":39,"range":{"start_line":38,"start_character":6,"end_line":39,"end_character":34},"updated":"2021-11-24 00:49:34.000000000","message":"How is this different from the first test case ?","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bc7913e5ddf972554a076f0a4e0d656277e47bd","unresolved":true,"context_lines":[{"line_number":38,"context_line":"PASS: Change the prompt on the subcloud to its subcloud"},{"line_number":39,"context_line":"name and ensure that collect works"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"PASS: Clean the longs on controller-0 by using"},{"line_number":42,"context_line":"collect --clean"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Closes-Bug: 1948992"},{"line_number":45,"context_line":"Change-Id: I20523bce76bc3c15f003ff4924299b58513bc57f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fda9bec2_2dcaf792","line":42,"range":{"start_line":41,"start_character":6,"end_line":42,"end_character":15},"updated":"2021-11-24 00:49:34.000000000","message":"nit: Suggest \u0027Verify local host and hosts clean\u0027","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"a8ec26b4866980554070bc450e37f1987e3e2798","unresolved":true,"context_lines":[{"line_number":23,"context_line":"PASS: Verify that collect works after manually modifying"},{"line_number":24,"context_line":"      PS1 on the subcloud."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"PASS: Verify named subcloud collect (-sc -a -p -n \u003cname\u003e)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"PASS: Verify collect from all subclouds"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"0e0acc85_6feabb82","line":26,"range":{"start_line":26,"start_character":44,"end_line":26,"end_character":46},"updated":"2021-11-24 17:14:59.000000000","message":"nit: Sorry I didn\u0027t notice this before but -p is not a collect option.","commit_id":"47730a3a35e83b9656639d40c5e301bb2496b037"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a4688829472840c934a2730d20ae8c34f620eda3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"PASS: Verify that collect works after manually modifying"},{"line_number":24,"context_line":"      PS1 on the subcloud."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"PASS: Verify named subcloud collect (-sc -a -p -n \u003cname\u003e)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"PASS: Verify collect from all subclouds"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"091e6529_d8538179","line":26,"range":{"start_line":26,"start_character":44,"end_line":26,"end_character":46},"in_reply_to":"0e0acc85_6feabb82","updated":"2021-12-10 14:32:27.000000000","message":"Done","commit_id":"47730a3a35e83b9656639d40c5e301bb2496b037"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"bef830d3dc401f3a7457595c1b99e48ba85378dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb6227e2_5ff6da94","updated":"2021-10-27 20:56:48.000000000","message":"Changes for CGTS-29085.","commit_id":"7ec1cad14337d46ff8f3cb1f7d978d8cf340792e"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"7f9edf1e619fbb5f3a5fae5cb79dd6e43486cf23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"39be5093_91d9dc95","updated":"2021-11-15 14:36:43.000000000","message":"Looks good and I like all the tests you ran. \nI\u0027ll run a few tests on it today and hopefully we can get this change merged soon.","commit_id":"662548bbca0d7cf0efe0f06965bf2be29bcbef0c"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"62e2bc250f32469468b3f221bcf0f6bad0f6460e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"44d4d220_b96ec012","updated":"2021-11-24 00:36:27.000000000","message":"The second","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"d956740fd67d71f3085fa0f8390b28d9652d8ff6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8b19d2f0_7266cd81","updated":"2021-11-24 15:14:02.000000000","message":"There are still a number of commit message comments that could be addressed.\nOur policy is to reply to all comments with intended action even if you don\u0027t plan to make a change.","commit_id":"262f333cf5596248923781b3a103d7ab3af6d986"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"2fbb5b266ac95689bc930a7f699ae4929ad68494","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"40917282_16e04500","updated":"2021-11-25 00:48:15.000000000","message":"Changes seem fine to me.  I think once Eric tries it, and the -p is fixed, its probably ready","commit_id":"47730a3a35e83b9656639d40c5e301bb2496b037"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"a8ec26b4866980554070bc450e37f1987e3e2798","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b0791351_aba14a54","updated":"2021-11-24 17:14:59.000000000","message":"I\u0027ll take this version for a test drive.","commit_id":"47730a3a35e83b9656639d40c5e301bb2496b037"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"3b98c120d6fc32c008f195ad01b1202e5fc6274e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"189d35ec_a131e356","updated":"2021-11-25 14:23:25.000000000","message":"The recent patch update does work.\nHowever, unfortunately this update does not actually fix the reported issue\nwhich is to be able to collect from a subcloud if its configuration fails which could leave its hostname as its subcloud name.\n\nTesting this failure scenario reveals that the subcloud collect is rejected because the subcloud controller is not active (because it failed configuration).\n\n    Error: not active ; failed to collect from subcloud1 [remote] (reason:35)\n\nThe reason for this is that the collect command sent to the subcloud uses the -a (or --all) option which commands that host to collect all hosts. Unfortunately the --all option requires that controller to be active so that it can query system inventory for the list of provisioned hostnames.\n\nIn this case that fails cause the subcloud controller is not active.\n\nThis would also hold true if the customer on a normal system executes \u0027collect -a\u0027 on a system that is not active. Normally they would have to change the command to just do a local \u0027collect\u0027 with no -a option. This is not possible for the subcloud collect since the -a option is auto specified.\n\nThis update needs a further enhancement to print a warning rather than error out if an attempt is made to use the --all option on a host that is not active and then proceed to collect from self without the dependency of being active (and sysinv running).\n\nI have implemented a prototype of this change and will share that with the author once tested as a formal patch change.","commit_id":"47730a3a35e83b9656639d40c5e301bb2496b037"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"92700ba72c4da1d1d0a1579512a99117f6aa868c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9d59497e_b4495da5","in_reply_to":"189d35ec_a131e356","updated":"2021-12-10 14:24:36.000000000","message":"Is there a response to this comment?","commit_id":"47730a3a35e83b9656639d40c5e301bb2496b037"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"13b90b219b25f7d7e5e57d7d7681909c9317051d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"52e0ee02_b0aa2443","in_reply_to":"9d59497e_b4495da5","updated":"2022-01-06 16:40:34.000000000","message":"Changes from Eric were incorporated into the patch.","commit_id":"47730a3a35e83b9656639d40c5e301bb2496b037"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"00b646b15c13ead29ca1ee5ec9fb81059b5effe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"10528eb9_75cfac8a","updated":"2022-01-06 19:36:45.000000000","message":"This is ready to go.","commit_id":"f12e28755de94c18e7a7d8eef9ef5bf24afe6afd"}],"tools/collector/scripts/collect":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e3bbb09affdbe49aa662157cdbe9e31db37ebc79","unresolved":true,"context_lines":[{"line_number":1854,"context_line":"                \"${ac_error}\" { exit ${FAIL_PERMISSION_SKIP}}"},{"line_number":1855,"context_line":"                timeout       { exit ${FAIL_TIMEOUT3} }"},{"line_number":1856,"context_line":"                \"${SUBCLOUD_LOGIN_PROMPT}\" {}"},{"line_number":1857,"context_line":"                \"${subcloud} { }"},{"line_number":1858,"context_line":"            }"},{"line_number":1859,"context_line":"            set timeout ${TIMEOUT}"},{"line_number":1860,"context_line":"            send \"${collect} ${collect_cmd[@]}\\n\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a022f2c1_98309d3e","line":1857,"range":{"start_line":1857,"start_character":29,"end_line":1857,"end_character":32},"updated":"2021-10-27 23:20:12.000000000","message":"be consistent { } or {}","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a6cf04e9e5993ed307d4824548721f00e5968a7c","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"                \"${ac_error}\" { exit ${FAIL_PERMISSION_SKIP}}"},{"line_number":1855,"context_line":"                timeout       { exit ${FAIL_TIMEOUT3} }"},{"line_number":1856,"context_line":"                \"${SUBCLOUD_LOGIN_PROMPT}\" {}"},{"line_number":1857,"context_line":"                \"${subcloud} { }"},{"line_number":1858,"context_line":"            }"},{"line_number":1859,"context_line":"            set timeout ${TIMEOUT}"},{"line_number":1860,"context_line":"            send \"${collect} ${collect_cmd[@]}\\n\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"312460db_6cd9c5ee","line":1857,"range":{"start_line":1857,"start_character":29,"end_line":1857,"end_character":32},"in_reply_to":"a022f2c1_98309d3e","updated":"2021-11-09 20:29:57.000000000","message":"Done","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e3bbb09affdbe49aa662157cdbe9e31db37ebc79","unresolved":true,"context_lines":[{"line_number":2042,"context_line":"            # login to subclouds does not show the subcloud name"},{"line_number":2043,"context_line":"            # in the login prompt. It will always be one of the controllers"},{"line_number":2044,"context_line":"            # so set login prompt to SUBCLOUD_LOGIN_PROMPT"},{"line_number":2045,"context_line":"            delete_remote_dir_or_file \"${host}\" \"${COLLECT_BASE_DIR}/${tarname}*\" \"${SUBCLOUD_LOGIN_PROMPT}\" \"${subcloud}\""},{"line_number":2046,"context_line":"        else"},{"line_number":2047,"context_line":"            # hosts always login as host name, use that hostname as login prompt"},{"line_number":2048,"context_line":"            delete_remote_dir_or_file \"${host}\" \"${COLLECT_BASE_DIR}/${tarname}*\" \"${host}\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fbadd42a_fb857ea9","line":2045,"range":{"start_line":2045,"start_character":12,"end_line":2045,"end_character":37},"updated":"2021-10-27 23:20:12.000000000","message":"Where is the mod for the implementation of this proc ? I bet this fails to cleanup.","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a6cf04e9e5993ed307d4824548721f00e5968a7c","unresolved":false,"context_lines":[{"line_number":2042,"context_line":"            # login to subclouds does not show the subcloud name"},{"line_number":2043,"context_line":"            # in the login prompt. It will always be one of the controllers"},{"line_number":2044,"context_line":"            # so set login prompt to SUBCLOUD_LOGIN_PROMPT"},{"line_number":2045,"context_line":"            delete_remote_dir_or_file \"${host}\" \"${COLLECT_BASE_DIR}/${tarname}*\" \"${SUBCLOUD_LOGIN_PROMPT}\" \"${subcloud}\""},{"line_number":2046,"context_line":"        else"},{"line_number":2047,"context_line":"            # hosts always login as host name, use that hostname as login prompt"},{"line_number":2048,"context_line":"            delete_remote_dir_or_file \"${host}\" \"${COLLECT_BASE_DIR}/${tarname}*\" \"${host}\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"b7bd4a23_8a3951ed","line":2045,"range":{"start_line":2045,"start_character":12,"end_line":2045,"end_character":37},"in_reply_to":"fbadd42a_fb857ea9","updated":"2021-11-09 20:29:57.000000000","message":"Done","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e3bbb09affdbe49aa662157cdbe9e31db37ebc79","unresolved":true,"context_lines":[{"line_number":2335,"context_line":"        \"assword:\" {"},{"line_number":2336,"context_line":"            send \"${pw}\\r\""},{"line_number":2337,"context_line":"            expect {"},{"line_number":2338,"context_line":"                \"${SUBCLOUD_LOGIN_PROMPT}\" { }"},{"line_number":2339,"context_line":"                \"${pw_error}\" { exit ${FAIL_PASSWORD} }"},{"line_number":2340,"context_line":"                \"${ac_error}\" { exit ${FAIL_PERMISSION_SKIP}}"},{"line_number":2341,"context_line":"                timeout       { exit ${FAIL_TIMEOUT3} }"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"22fe4d7d_6bddad15","line":2338,"range":{"start_line":2338,"start_character":17,"end_line":2338,"end_character":46},"updated":"2021-10-27 23:20:12.000000000","message":"Where is the check for ${subcloud} ?","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"a6cf04e9e5993ed307d4824548721f00e5968a7c","unresolved":false,"context_lines":[{"line_number":2335,"context_line":"        \"assword:\" {"},{"line_number":2336,"context_line":"            send \"${pw}\\r\""},{"line_number":2337,"context_line":"            expect {"},{"line_number":2338,"context_line":"                \"${SUBCLOUD_LOGIN_PROMPT}\" { }"},{"line_number":2339,"context_line":"                \"${pw_error}\" { exit ${FAIL_PASSWORD} }"},{"line_number":2340,"context_line":"                \"${ac_error}\" { exit ${FAIL_PERMISSION_SKIP}}"},{"line_number":2341,"context_line":"                timeout       { exit ${FAIL_TIMEOUT3} }"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"48fdd835_2c0d7fe2","line":2338,"range":{"start_line":2338,"start_character":17,"end_line":2338,"end_character":46},"in_reply_to":"22fe4d7d_6bddad15","updated":"2021-11-09 20:29:57.000000000","message":"I have missed it. I\u0027ll add it.","commit_id":"80a93ca0b4afa522a86dcd23cac5905e78fb5aaf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"3e04fdd0589855d0a3efbeb6f0e82b2fecbf2b20","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"#"},{"line_number":1226,"context_line":"# Purpose   : Deletes a remote directory or file"},{"line_number":1227,"context_line":"#"},{"line_number":1228,"context_line":"# Parameters: $1 - remote hostname"},{"line_number":1229,"context_line":"#             $2 - dir or file with full path"},{"line_number":1230,"context_line":"#"},{"line_number":1231,"context_line":"###########################################################################"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"29b3130a_8801319d","line":1228,"range":{"start_line":1228,"start_character":2,"end_line":1228,"end_character":12},"updated":"2021-11-10 15:39:14.000000000","message":"Please update with parm info $3 and $4","commit_id":"84967c1a0149f4aa61d169fd5df1c2915fb17902"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"737a846d8e4b0c9983f366ce7b19491824832718","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"#"},{"line_number":1226,"context_line":"# Purpose   : Deletes a remote directory or file"},{"line_number":1227,"context_line":"#"},{"line_number":1228,"context_line":"# Parameters: $1 - remote hostname"},{"line_number":1229,"context_line":"#             $2 - dir or file with full path"},{"line_number":1230,"context_line":"#"},{"line_number":1231,"context_line":"###########################################################################"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3a82c038_1e24735b","line":1228,"range":{"start_line":1228,"start_character":2,"end_line":1228,"end_character":12},"in_reply_to":"29b3130a_8801319d","updated":"2021-11-11 16:19:51.000000000","message":"Done","commit_id":"84967c1a0149f4aa61d169fd5df1c2915fb17902"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"3e04fdd0589855d0a3efbeb6f0e82b2fecbf2b20","unresolved":true,"context_lines":[{"line_number":1235,"context_line":"    local remote_hostname\u003d${1}"},{"line_number":1236,"context_line":"    local dir_or_file\u003d${2}"},{"line_number":1237,"context_line":"    local login_prompt\u003d\"${3}\""},{"line_number":1238,"context_line":"    local alt_login_prompt\u003d\"${4}\""},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"/usr/bin/expect \u003c\u003c EOF"},{"line_number":1241,"context_line":"    log_user ${USER_LOG_MODE}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"a85c1248_75d30375","line":1238,"range":{"start_line":1238,"start_character":10,"end_line":1238,"end_character":33},"updated":"2021-11-10 15:39:14.000000000","message":"What happens when $4 is empty ?\n\nConsider setting it to $3 if empty to avoid expect interpreting an empty string and accepting it.\n\nNeed to make a comment in the heart that $4 is optional","commit_id":"84967c1a0149f4aa61d169fd5df1c2915fb17902"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"737a846d8e4b0c9983f366ce7b19491824832718","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"    local remote_hostname\u003d${1}"},{"line_number":1236,"context_line":"    local dir_or_file\u003d${2}"},{"line_number":1237,"context_line":"    local login_prompt\u003d\"${3}\""},{"line_number":1238,"context_line":"    local alt_login_prompt\u003d\"${4}\""},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"/usr/bin/expect \u003c\u003c EOF"},{"line_number":1241,"context_line":"    log_user ${USER_LOG_MODE}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"e3c59244_421d4dd8","line":1238,"range":{"start_line":1238,"start_character":10,"end_line":1238,"end_character":33},"in_reply_to":"a85c1248_75d30375","updated":"2021-11-11 16:19:51.000000000","message":"Done","commit_id":"84967c1a0149f4aa61d169fd5df1c2915fb17902"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"62e2bc250f32469468b3f221bcf0f6bad0f6460e","unresolved":true,"context_lines":[{"line_number":1865,"context_line":"                \"${ac_error}\" { exit ${FAIL_PERMISSION_SKIP}}"},{"line_number":1866,"context_line":"                timeout       { exit ${FAIL_TIMEOUT3} }"},{"line_number":1867,"context_line":"                \"${SUBCLOUD_LOGIN_PROMPT}\" {}"},{"line_number":1868,"context_line":"                \"${subcloud} {}"},{"line_number":1869,"context_line":"            }"},{"line_number":1870,"context_line":"            set timeout ${TIMEOUT}"},{"line_number":1871,"context_line":"            send \"${collect} ${collect_cmd[@]}\\n\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"10fdf640_a8258992","line":1868,"range":{"start_line":1868,"start_character":16,"end_line":1868,"end_character":28},"updated":"2021-11-24 00:36:27.000000000","message":"Issue #1: This is missing a \u0027\"\u0027 at the end of \"${subcloud}\n\nIssue #2: The subcloud check needs to add \u0027:\u0027 to subcloud match pattern because currently its matching on the login banner rather than the login prompt.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n         SYSTEM: subcloud1\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\ncontroller-0:~$\n\nSee expect tracing below ....\n\nexpect: does \" \\r\\nLast login: Wed Nov 24 00:13:16 2021 from 192.168.204.3\\r\\r\\n/etc/motd.d/00-header:\\r\\n\\r\\n\\u001b[H\\u001b[2J\\r\\nWARNING: Unauthorized access to this system is forbidden and will be\\r\\nprosecuted by law. By accessing this system, you agree that your\\r\\nactions may be monitored if unauthorized usage is suspected.\\r\\n\\r\\n/etc/motd.d/10-system:\\r\\n\\r\\n\\r\\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\\r\\n         SYSTEM: subcloud1\\r\\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\\r\\n\\r\\n\" (spawn_id exp6) match glob pattern \"controller-\"? no\n\"subcloud1\"? yes\nexpect: set expect_out(0,string) \"subcloud1\"\n\n\nThe above 3 lines represent the match.\n\nSuggest changing the match to ${subcloud}:\"","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"7054e5969eb5d6cb1ccb7e076b81a2016cd6d413","unresolved":false,"context_lines":[{"line_number":1865,"context_line":"                \"${ac_error}\" { exit ${FAIL_PERMISSION_SKIP}}"},{"line_number":1866,"context_line":"                timeout       { exit ${FAIL_TIMEOUT3} }"},{"line_number":1867,"context_line":"                \"${SUBCLOUD_LOGIN_PROMPT}\" {}"},{"line_number":1868,"context_line":"                \"${subcloud} {}"},{"line_number":1869,"context_line":"            }"},{"line_number":1870,"context_line":"            set timeout ${TIMEOUT}"},{"line_number":1871,"context_line":"            send \"${collect} ${collect_cmd[@]}\\n\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"cd846557_e12a9a70","line":1868,"range":{"start_line":1868,"start_character":16,"end_line":1868,"end_character":28},"in_reply_to":"10fdf640_a8258992","updated":"2021-11-24 15:34:01.000000000","message":"Done","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"62e2bc250f32469468b3f221bcf0f6bad0f6460e","unresolved":true,"context_lines":[{"line_number":2350,"context_line":"                \"${ac_error}\" { exit ${FAIL_PERMISSION_SKIP}}"},{"line_number":2351,"context_line":"                timeout       { exit ${FAIL_TIMEOUT3} }"},{"line_number":2352,"context_line":"                \"${SUBCLOUD_LOGIN_PROMPT}\" {}"},{"line_number":2353,"context_line":"                \"${subcloud}\" {}"},{"line_number":2354,"context_line":"            }"},{"line_number":2355,"context_line":"            send \"${collect} ${collect_cmd[@]}\\n\""},{"line_number":2356,"context_line":"            expect {"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"498f0bbf_d240d240","line":2353,"range":{"start_line":2353,"start_character":18,"end_line":2353,"end_character":28},"updated":"2021-11-24 00:36:27.000000000","message":"Same as above comment except in this case the end quote is there.","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9e20bc05c9f057fa6b9c65ebc39cc8c99e675f71","unresolved":false,"context_lines":[{"line_number":2350,"context_line":"                \"${ac_error}\" { exit ${FAIL_PERMISSION_SKIP}}"},{"line_number":2351,"context_line":"                timeout       { exit ${FAIL_TIMEOUT3} }"},{"line_number":2352,"context_line":"                \"${SUBCLOUD_LOGIN_PROMPT}\" {}"},{"line_number":2353,"context_line":"                \"${subcloud}\" {}"},{"line_number":2354,"context_line":"            }"},{"line_number":2355,"context_line":"            send \"${collect} ${collect_cmd[@]}\\n\""},{"line_number":2356,"context_line":"            expect {"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"6e507283_5d327aa9","line":2353,"range":{"start_line":2353,"start_character":18,"end_line":2353,"end_character":28},"in_reply_to":"498f0bbf_d240d240","updated":"2022-01-06 16:37:04.000000000","message":"Done","commit_id":"421e45aee81d4beac6462c930262e79d64fa682d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"1db660c7eed30ff3c6f09ecbc0122cf2be586ee2","unresolved":true,"context_lines":[{"line_number":2053,"context_line":"            # login to subclouds does not show the subcloud name"},{"line_number":2054,"context_line":"            # in the login prompt. It will always be one of the controllers"},{"line_number":2055,"context_line":"            # so set login prompt to SUBCLOUD_LOGIN_PROMPT"},{"line_number":2056,"context_line":"            delete_remote_dir_or_file \"${host}\" \"${COLLECT_BASE_DIR}/${tarname}*\" \"${SUBCLOUD_LOGIN_PROMPT}\" \"${host}\""},{"line_number":2057,"context_line":"        else"},{"line_number":2058,"context_line":"            # hosts always login as host name, use that hostname as login prompt"},{"line_number":2059,"context_line":"            delete_remote_dir_or_file \"${host}\" \"${COLLECT_BASE_DIR}/${tarname}*\" \"${host}\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"1d52e76e_b10b00f3","line":2056,"range":{"start_line":2056,"start_character":116,"end_line":2056,"end_character":117},"updated":"2021-11-24 15:12:05.000000000","message":"This should also have a \u0027:\u0027 \"${host}:\" otherwise there could be a race condition that leads to executing the rm command before being fully logged in. There can be login lag when a system is busy.","commit_id":"262f333cf5596248923781b3a103d7ab3af6d986"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"7054e5969eb5d6cb1ccb7e076b81a2016cd6d413","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"            # login to subclouds does not show the subcloud name"},{"line_number":2054,"context_line":"            # in the login prompt. It will always be one of the controllers"},{"line_number":2055,"context_line":"            # so set login prompt to SUBCLOUD_LOGIN_PROMPT"},{"line_number":2056,"context_line":"            delete_remote_dir_or_file \"${host}\" \"${COLLECT_BASE_DIR}/${tarname}*\" \"${SUBCLOUD_LOGIN_PROMPT}\" \"${host}\""},{"line_number":2057,"context_line":"        else"},{"line_number":2058,"context_line":"            # hosts always login as host name, use that hostname as login prompt"},{"line_number":2059,"context_line":"            delete_remote_dir_or_file \"${host}\" \"${COLLECT_BASE_DIR}/${tarname}*\" \"${host}\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"aa10df42_33107241","line":2056,"range":{"start_line":2056,"start_character":116,"end_line":2056,"end_character":117},"in_reply_to":"1d52e76e_b10b00f3","updated":"2021-11-24 15:34:01.000000000","message":"Done","commit_id":"262f333cf5596248923781b3a103d7ab3af6d986"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"20266534b487424c8d53dbb8ad425969b675ed42","unresolved":true,"context_lines":[{"line_number":3036,"context_line":"        log \"created ${COLLECT_TYPE} tarball ${TARBALL_NAME}\""},{"line_number":3037,"context_line":""},{"line_number":3038,"context_line":"        if [ \"${ORCHESTRATED_COLLECT}\" \u003d true ] ; then"},{"line_number":3039,"context_line":"            echo \"${collect_done}\""},{"line_number":3040,"context_line":"        fi"},{"line_number":3041,"context_line":"    else"},{"line_number":3042,"context_line":"        echo \"removing incomplete collect: ${TARBALL_NAME}\""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"eb224ce8_1f35123d","line":3039,"range":{"start_line":3039,"start_character":12,"end_line":3039,"end_character":34},"updated":"2021-11-26 03:16:43.000000000","message":"When the subcloud can\u0027t execute \u0027system\u0027 or \u0027dcmanager\u0027 commands (controller isn\u0027t active due to configuration or ansible error) the current code doesn\u0027t set ORCHESTRATED_COLLECT to true and as a result collect on the system controller times out because it never sees the \"collect done\" success path string even though the collect on the subcloud completes just fine.","commit_id":"6a7435c4cc75d786614da6825291031ef12243b3"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"13b90b219b25f7d7e5e57d7d7681909c9317051d","unresolved":false,"context_lines":[{"line_number":3036,"context_line":"        log \"created ${COLLECT_TYPE} tarball ${TARBALL_NAME}\""},{"line_number":3037,"context_line":""},{"line_number":3038,"context_line":"        if [ \"${ORCHESTRATED_COLLECT}\" \u003d true ] ; then"},{"line_number":3039,"context_line":"            echo \"${collect_done}\""},{"line_number":3040,"context_line":"        fi"},{"line_number":3041,"context_line":"    else"},{"line_number":3042,"context_line":"        echo \"removing incomplete collect: ${TARBALL_NAME}\""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9a2ef861_c79c57fc","line":3039,"range":{"start_line":3039,"start_character":12,"end_line":3039,"end_character":34},"in_reply_to":"eb224ce8_1f35123d","updated":"2022-01-06 16:40:34.000000000","message":"Done","commit_id":"6a7435c4cc75d786614da6825291031ef12243b3"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"d39143564cb33590047abf3ac96f96b8ee277938","unresolved":true,"context_lines":[{"line_number":982,"context_line":"    fi"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    if [ \"${DCROLE}\" \u003d\u003d \"\" -a \"${ACTIVE}\" \u003d\u003d false -a \"${pw}\" !\u003d \"\" ]; then"},{"line_number":985,"context_line":"        dlog \"Subcloud has not been properly configured.\""},{"line_number":986,"context_line":"        ERROR_DCROLE\u003d$(cat /etc/platform/platform.conf | grep distributed_cloud_role | cut -d \u0027\u003d\u0027 -f 2)"},{"line_number":987,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"},{"line_number":988,"context_line":"            dlog \"date override ${NOWDATE} to ${COLLECT_NAME: -15}\""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"45a8412c_3eb13dbe","line":985,"range":{"start_line":985,"start_character":8,"end_line":985,"end_character":57},"updated":"2021-12-20 16:14:47.000000000","message":"maybe make this a \u0027wlog\u0027","commit_id":"5fd7734542ae87e320c3772721c2572ed8b36a85"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"350e9e844356287ef83c8cf3469f97ada447d24d","unresolved":false,"context_lines":[{"line_number":982,"context_line":"    fi"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    if [ \"${DCROLE}\" \u003d\u003d \"\" -a \"${ACTIVE}\" \u003d\u003d false -a \"${pw}\" !\u003d \"\" ]; then"},{"line_number":985,"context_line":"        dlog \"Subcloud has not been properly configured.\""},{"line_number":986,"context_line":"        ERROR_DCROLE\u003d$(cat /etc/platform/platform.conf | grep distributed_cloud_role | cut -d \u0027\u003d\u0027 -f 2)"},{"line_number":987,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"},{"line_number":988,"context_line":"            dlog \"date override ${NOWDATE} to ${COLLECT_NAME: -15}\""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"07ae63e9_7b6b36b7","line":985,"range":{"start_line":985,"start_character":8,"end_line":985,"end_character":57},"in_reply_to":"45a8412c_3eb13dbe","updated":"2021-12-21 17:57:51.000000000","message":"I\u0027ll make this change shortly.","commit_id":"5fd7734542ae87e320c3772721c2572ed8b36a85"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"d39143564cb33590047abf3ac96f96b8ee277938","unresolved":true,"context_lines":[{"line_number":987,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"},{"line_number":988,"context_line":"            dlog \"date override ${NOWDATE} to ${COLLECT_NAME: -15}\""},{"line_number":989,"context_line":"            NOWDATE\u003d${COLLECT_NAME: -15}"},{"line_number":990,"context_line":"            ORCHESTRATED_COLLECT\u003dtrue"},{"line_number":991,"context_line":"        fi"},{"line_number":992,"context_line":"    fi"},{"line_number":993,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"6a64eb2d_4c36f34f","line":990,"range":{"start_line":990,"start_character":12,"end_line":990,"end_character":37},"updated":"2021-12-20 16:14:47.000000000","message":"maybe create a ilog \"orchestrated collect\" log where ever ORCHESTRATED_COLLECT is set true. Try to make them unique so that we can tell where in the code it was that logged it.","commit_id":"5fd7734542ae87e320c3772721c2572ed8b36a85"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"350e9e844356287ef83c8cf3469f97ada447d24d","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"},{"line_number":988,"context_line":"            dlog \"date override ${NOWDATE} to ${COLLECT_NAME: -15}\""},{"line_number":989,"context_line":"            NOWDATE\u003d${COLLECT_NAME: -15}"},{"line_number":990,"context_line":"            ORCHESTRATED_COLLECT\u003dtrue"},{"line_number":991,"context_line":"        fi"},{"line_number":992,"context_line":"    fi"},{"line_number":993,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5b539c3e_04b6180c","line":990,"range":{"start_line":990,"start_character":12,"end_line":990,"end_character":37},"in_reply_to":"6a64eb2d_4c36f34f","updated":"2021-12-21 17:57:51.000000000","message":"I\u0027ll create the ilog.","commit_id":"5fd7734542ae87e320c3772721c2572ed8b36a85"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"cbe62cf864e9bc8aa1df39d43996653ab9d24ad4","unresolved":true,"context_lines":[{"line_number":987,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"},{"line_number":988,"context_line":"            dlog \"date override ${NOWDATE} to ${COLLECT_NAME: -15}\""},{"line_number":989,"context_line":"            NOWDATE\u003d${COLLECT_NAME: -15}"},{"line_number":990,"context_line":"            ilog \"Setting ORCHESTRATED_COLLECT to true although DCROLE is nil and ACTIVE is false\""},{"line_number":991,"context_line":"            ORCHESTRATED_COLLECT\u003dtrue"},{"line_number":992,"context_line":"        fi"},{"line_number":993,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"02ba7efc_94d1761d","line":990,"range":{"start_line":990,"start_character":18,"end_line":990,"end_character":97},"updated":"2021-12-22 00:34:06.000000000","message":"Prefer not to include the guts of collect and its variable names in the logs. \"orchestrated collect\" is fine. We know where the log came from based on the warning log change you made above. Please add same log around log 981 as well.","commit_id":"51aed5957b5fac9176810bc723a778384e8f7c44"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"3e7e56a79e07001cc3feeb9dc6361cb0b652f8d9","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"},{"line_number":988,"context_line":"            dlog \"date override ${NOWDATE} to ${COLLECT_NAME: -15}\""},{"line_number":989,"context_line":"            NOWDATE\u003d${COLLECT_NAME: -15}"},{"line_number":990,"context_line":"            ilog \"Setting ORCHESTRATED_COLLECT to true although DCROLE is nil and ACTIVE is false\""},{"line_number":991,"context_line":"            ORCHESTRATED_COLLECT\u003dtrue"},{"line_number":992,"context_line":"        fi"},{"line_number":993,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"e45569ef_17d91621","line":990,"range":{"start_line":990,"start_character":18,"end_line":990,"end_character":97},"in_reply_to":"02ba7efc_94d1761d","updated":"2022-01-05 22:44:13.000000000","message":"Done","commit_id":"51aed5957b5fac9176810bc723a778384e8f7c44"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"1f0a3e3cbb3f1ec77583c91cf26a60fe372db245","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"},{"line_number":988,"context_line":"            dlog \"date override ${NOWDATE} to ${COLLECT_NAME: -15}\""},{"line_number":989,"context_line":"            NOWDATE\u003d${COLLECT_NAME: -15}"},{"line_number":990,"context_line":"            ilog \"Setting ORCHESTRATED_COLLECT to true although DCROLE is nil and ACTIVE is false\""},{"line_number":991,"context_line":"            ORCHESTRATED_COLLECT\u003dtrue"},{"line_number":992,"context_line":"        fi"},{"line_number":993,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"3f42d92c_439cb0c6","line":990,"range":{"start_line":990,"start_character":18,"end_line":990,"end_character":97},"in_reply_to":"e3bae538_2ed8a8f1","updated":"2022-01-06 16:34:33.000000000","message":"Changed message to Orchestrated Collect. Added same log around line 981 as well.","commit_id":"51aed5957b5fac9176810bc723a778384e8f7c44"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"f6dacca5824dea14cefc1066001b0135e8d811b4","unresolved":false,"context_lines":[{"line_number":987,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"},{"line_number":988,"context_line":"            dlog \"date override ${NOWDATE} to ${COLLECT_NAME: -15}\""},{"line_number":989,"context_line":"            NOWDATE\u003d${COLLECT_NAME: -15}"},{"line_number":990,"context_line":"            ilog \"Setting ORCHESTRATED_COLLECT to true although DCROLE is nil and ACTIVE is false\""},{"line_number":991,"context_line":"            ORCHESTRATED_COLLECT\u003dtrue"},{"line_number":992,"context_line":"        fi"},{"line_number":993,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"e3bae538_2ed8a8f1","line":990,"range":{"start_line":990,"start_character":18,"end_line":990,"end_character":97},"in_reply_to":"e45569ef_17d91621","updated":"2022-01-06 01:28:01.000000000","message":"What is the change ?","commit_id":"51aed5957b5fac9176810bc723a778384e8f7c44"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"386b8691abe40de32cdfd7954ef41bc0f3cf7661","unresolved":true,"context_lines":[{"line_number":982,"context_line":"        ORCHESTRATED_COLLECT\u003dtrue"},{"line_number":983,"context_line":"    fi"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"    if [ \"${DCROLE}\" \u003d\u003d \"\" -a \"${ACTIVE}\" \u003d\u003d false -a \"${pw}\" !\u003d \"\" ]; then"},{"line_number":986,"context_line":"        wlog \"Subcloud has not been properly configured.\""},{"line_number":987,"context_line":"        ERROR_DCROLE\u003d$(cat /etc/platform/platform.conf | grep distributed_cloud_role | cut -d \u0027\u003d\u0027 -f 2)"},{"line_number":988,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"ed77c285_a1e0322a","line":985,"range":{"start_line":985,"start_character":4,"end_line":985,"end_character":7},"updated":"2022-01-06 16:55:24.000000000","message":"Would prefer if this was an elif but willing to accept as is.","commit_id":"afa8d2c31910ee7a9cb1a8c3356d914908a774c6"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"f3196cfe8a9c3cc8bd937eae783f0b4685a0e959","unresolved":false,"context_lines":[{"line_number":982,"context_line":"        ORCHESTRATED_COLLECT\u003dtrue"},{"line_number":983,"context_line":"    fi"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"    if [ \"${DCROLE}\" \u003d\u003d \"\" -a \"${ACTIVE}\" \u003d\u003d false -a \"${pw}\" !\u003d \"\" ]; then"},{"line_number":986,"context_line":"        wlog \"Subcloud has not been properly configured.\""},{"line_number":987,"context_line":"        ERROR_DCROLE\u003d$(cat /etc/platform/platform.conf | grep distributed_cloud_role | cut -d \u0027\u003d\u0027 -f 2)"},{"line_number":988,"context_line":"        if [ \"${ERROR_DCROLE}\" \u003d \"subcloud\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"d9d3aedb_4840a64d","line":985,"range":{"start_line":985,"start_character":4,"end_line":985,"end_character":7},"in_reply_to":"ed77c285_a1e0322a","updated":"2022-01-06 19:34:51.000000000","message":"I have changed it to an elif.","commit_id":"afa8d2c31910ee7a9cb1a8c3356d914908a774c6"}]}