)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"ed76ce2c1a61fdbbcef36dfca4d5ebecfc733120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"95a8f6b9_2dd497fa","updated":"2022-01-05 14:32:51.000000000","message":"lgtm","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"678086953badda45d5836dcafaa81e556f8cc645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6d068a08_d306d722","updated":"2021-11-30 18:26:40.000000000","message":"recheck","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"6fbfa83f997ee351dd78b9a6071cdc7de6396dd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e690298_a75802b4","updated":"2022-01-10 19:55:21.000000000","message":"lgtm","commit_id":"5830faa08de969e52ebe9c72e6069b83563d663c"}],"utilities/namespace-utils/debian/deb_folder/compat":[{"author":{"_account_id":33631,"name":"Fabricio Henrique Ramos","email":"fabriciohenrique.ramos@windriver.com","username":"fhramos"},"change_message_id":"0c1dd67bffb239ad61a039b816a554c21b8af890","unresolved":true,"context_lines":[{"line_number":1,"context_line":"10"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"31ea01cc_a0a38396","line":1,"updated":"2022-01-12 21:18:21.000000000","message":"If I\u0027m not wrong, I believe this should be 13, but you can actually remove this file and replace with Build-Depends: debhelper-compat (\u003d 13) in control file. Please, refer to: https://www.debian.org/doc/manuals/debmake-doc/ch05.en.html#debianconf","commit_id":"5830faa08de969e52ebe9c72e6069b83563d663c"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"17fd5974fa2707c77c00ab52a6f14f5bce7b5aa9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"10"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"51d3c969_d3dcf137","line":1,"in_reply_to":"31ea01cc_a0a38396","updated":"2022-01-14 04:41:38.000000000","message":"Done","commit_id":"5830faa08de969e52ebe9c72e6069b83563d663c"}],"utilities/namespace-utils/debian/deb_folder/namespace-utils.install":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"502927dc97604e42cc23300228d7bfa3f1bf2212","unresolved":true,"context_lines":[{"line_number":1,"context_line":"usr/sbin/umount-in-namespace"},{"line_number":2,"context_line":"usr/sbin/bashns"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1f2a1b5f_031748d2","line":2,"updated":"2021-12-02 21:51:41.000000000","message":"not that it matters, but would be nice to have these alphabetized","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"0796478a6cb023f4b44b711e6f7d0a7bc9c7d808","unresolved":false,"context_lines":[{"line_number":1,"context_line":"usr/sbin/umount-in-namespace"},{"line_number":2,"context_line":"usr/sbin/bashns"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5f1b9a47_1fb4d210","line":2,"in_reply_to":"1f2a1b5f_031748d2","updated":"2022-01-06 15:20:40.000000000","message":"Ack","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"995437dd3797f812aa6ef84a2c4166d75e0e4593","unresolved":false,"context_lines":[{"line_number":1,"context_line":"usr/sbin/umount-in-namespace"},{"line_number":2,"context_line":"usr/sbin/bashns"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"48e28528_ca72c89a","line":2,"in_reply_to":"5f1b9a47_1fb4d210","updated":"2022-01-07 15:19:57.000000000","message":"Done","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"}],"utilities/namespace-utils/debian/deb_folder/rules":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"eff29ec1e87ea8c5642c4577e9215e1ebdccda5b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/make -f"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export ROOT \u003d $(CURDIR)/debian/tmp"},{"line_number":4,"context_line":"export SBINDIR \u003d usr/sbin"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"%:"},{"line_number":7,"context_line":"\tdh $@"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ea0757a8_0570b7e8","line":4,"updated":"2021-11-10 18:18:30.000000000","message":"I am wondering if this needs to change\nother debian rules files reference $(ROOT) for their SBINDIR.\nex:\nhttps://github.com/starlingx/metal/blob/master/mtce/debian/deb_folder/rules#L9","commit_id":"143a43adfa3b5aac2f1fae11fdc4960de9f4804f"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"3b8ddb1a8b3c1ba180139a5a7a1079a36d0a1c2b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/make -f"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export ROOT \u003d $(CURDIR)/debian/tmp"},{"line_number":4,"context_line":"export SBINDIR \u003d usr/sbin"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"%:"},{"line_number":7,"context_line":"\tdh $@"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ee995308_810a8f0a","line":4,"in_reply_to":"8757ff82_d9c3374b","updated":"2022-01-11 02:08:08.000000000","message":"Ack","commit_id":"143a43adfa3b5aac2f1fae11fdc4960de9f4804f"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"87a9cc4601ded44c486898f4826307851f145df4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/make -f"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export ROOT \u003d $(CURDIR)/debian/tmp"},{"line_number":4,"context_line":"export SBINDIR \u003d usr/sbin"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"%:"},{"line_number":7,"context_line":"\tdh $@"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8757ff82_d9c3374b","line":4,"in_reply_to":"ea0757a8_0570b7e8","updated":"2021-11-30 13:56:39.000000000","message":"It\u0027s mostly preference.\nThe reference to $ROOT for the purposes of dh_install is optional. \n\nAccording to https://man7.org/linux/man-pages/man1/dh_install.1.html: \"From debhelper compatibility level 7 on, dh_install will fall back to looking in debian/tmp for files, if it does not find them in the current directory (or wherever you\u0027ve told it to look using --sourcedir).\"","commit_id":"143a43adfa3b5aac2f1fae11fdc4960de9f4804f"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"5e24070be22aca5c08714562250df2b93f4e4337","unresolved":true,"context_lines":[{"line_number":6,"context_line":"%:"},{"line_number":7,"context_line":"\tdh $@"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"override_dh_auto_install:"},{"line_number":10,"context_line":"\tgcc -g -o bashns bashns.c"},{"line_number":11,"context_line":"\tdh_auto_install"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ff44c925_1598cdd5","line":9,"updated":"2022-01-07 14:48:58.000000000","message":"this probably be override_dh_auto_build:","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"995437dd3797f812aa6ef84a2c4166d75e0e4593","unresolved":false,"context_lines":[{"line_number":6,"context_line":"%:"},{"line_number":7,"context_line":"\tdh $@"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"override_dh_auto_install:"},{"line_number":10,"context_line":"\tgcc -g -o bashns bashns.c"},{"line_number":11,"context_line":"\tdh_auto_install"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"59f8fd9f_25079b02","line":9,"in_reply_to":"ff44c925_1598cdd5","updated":"2022-01-07 15:19:57.000000000","message":"Done","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"5e24070be22aca5c08714562250df2b93f4e4337","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"override_dh_auto_install:"},{"line_number":10,"context_line":"\tgcc -g -o bashns bashns.c"},{"line_number":11,"context_line":"\tdh_auto_install"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"override_dh_install:"},{"line_number":14,"context_line":"\tinstall -d -m 755 ${SBINDIR}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"90610e22_a7aa6953","line":11,"updated":"2022-01-07 14:48:58.000000000","message":"Remove this line since we are building here.","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"995437dd3797f812aa6ef84a2c4166d75e0e4593","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"override_dh_auto_install:"},{"line_number":10,"context_line":"\tgcc -g -o bashns bashns.c"},{"line_number":11,"context_line":"\tdh_auto_install"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"override_dh_install:"},{"line_number":14,"context_line":"\tinstall -d -m 755 ${SBINDIR}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"d13ca121_70d57295","line":11,"in_reply_to":"90610e22_a7aa6953","updated":"2022-01-07 15:19:57.000000000","message":"Done","commit_id":"f602ab3c35b98e6d515b03a8de91183a2838b54b"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"17fd5974fa2707c77c00ab52a6f14f5bce7b5aa9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\tdh $@"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"override_dh_auto_build:"},{"line_number":10,"context_line":"\tgcc -g -o bashns bashns.c"},{"line_number":11,"context_line":"\tdh_auto_build"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"override_dh_install:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"e1987238_73cf15ce","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":26},"updated":"2022-01-14 04:41:38.000000000","message":"Just for the record, getting this response:\n\n\"\nbashns.c: In function ‘main’:\nbashns.c:53:11: warning: implicit declaration of function ‘execvp’ [-Wimplicit-function-declaration]\n53 |      rc \u003d execvp(\"bash\", 0);\n\"\n\nWarnings are not set as errors, so the build process does finish successfully.","commit_id":"5830faa08de969e52ebe9c72e6069b83563d663c"}],"utilities/namespace-utils/debian/meta_data.yaml":[{"author":{"_account_id":33631,"name":"Fabricio Henrique Ramos","email":"fabriciohenrique.ramos@windriver.com","username":"fhramos"},"change_message_id":"0c1dd67bffb239ad61a039b816a554c21b8af890","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: namespace-utils"},{"line_number":3,"context_line":"debver: 1.0-1"},{"line_number":4,"context_line":"dl_hook: dl_hook"},{"line_number":5,"context_line":"revision:"},{"line_number":6,"context_line":"  dist: $STX_DIST"},{"line_number":7,"context_line":"  PKG_GITREVCOUNT: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"942976b0_bc0c631f","line":4,"updated":"2022-01-12 21:18:21.000000000","message":"remove the dl_hook and use the newer meta_data fields (such as src_files) to pull the files please\n\nrefer to: \n- https://review.opendev.org/c/starlingx/containers/+/818870/1/registry-token-server/debian/meta_data.yaml\n- https://wiki.openstack.org/wiki/StarlingX/DebianBuildStructure","commit_id":"5830faa08de969e52ebe9c72e6069b83563d663c"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"17fd5974fa2707c77c00ab52a6f14f5bce7b5aa9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: namespace-utils"},{"line_number":3,"context_line":"debver: 1.0-1"},{"line_number":4,"context_line":"dl_hook: dl_hook"},{"line_number":5,"context_line":"revision:"},{"line_number":6,"context_line":"  dist: $STX_DIST"},{"line_number":7,"context_line":"  PKG_GITREVCOUNT: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4e17b862_e9f79e3b","line":4,"in_reply_to":"942976b0_bc0c631f","updated":"2022-01-14 04:41:38.000000000","message":"Done","commit_id":"5830faa08de969e52ebe9c72e6069b83563d663c"}]}
