)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"dabdb17c7a19f9417f908d981af65163eca08739","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-10 09:43:39 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generate a list of RPMs and packages to download"},{"line_number":8,"context_line":"in a remote cloud installation"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is desirable to download only the rpms that are not common"},{"line_number":11,"context_line":"to the applied release and the one before it. To enable this,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"a3ea4447_414cd55e","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":30},"updated":"2022-02-10 15:03:25.000000000","message":"Commit title should be one-liner, 50 characters long (max)\n\nAdd script to prepare shared prestage packages","commit_id":"1b6429b489484fd46026d4d6f428b5cecfc4e635"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"4ef7cfef79d826f8173d68af2155b969c8acee82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrikumar Sharma \u003cshrikumar.sharma@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-10 09:43:39 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generate a list of RPMs and packages to download"},{"line_number":8,"context_line":"in a remote cloud installation"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is desirable to download only the rpms that are not common"},{"line_number":11,"context_line":"to the applied release and the one before it. To enable this,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"192c08e1_7097e7e3","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":30},"in_reply_to":"a3ea4447_414cd55e","updated":"2022-02-10 15:17:56.000000000","message":"Done","commit_id":"1b6429b489484fd46026d4d6f428b5cecfc4e635"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"9e7bb421c402c597d9b0aa75cab7c1e630047222","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is desirable to download only the rpms that are not common"},{"line_number":11,"context_line":"to the applied release and the one before it. To enable this,"},{"line_number":12,"context_line":"a download_packages.txt, Packages directory with all the rpms"},{"line_number":13,"context_line":"unique to the applied release and a comps.xml file to generate"},{"line_number":14,"context_line":"repodata are provided in"},{"line_number":15,"context_line":"/opt/platform/deploy/\u003crelease-id\u003e/prestage/shared."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1a2f664a_22100878","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":23},"updated":"2022-02-10 14:58:08.000000000","message":"did you mean a common_packages.txt? The playbook that prestage packages expects a file that contains the list of packages that have not changed between N and N+1 releases so it can copy these files locally.","commit_id":"1b6429b489484fd46026d4d6f428b5cecfc4e635"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"4ef7cfef79d826f8173d68af2155b969c8acee82","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is desirable to download only the rpms that are not common"},{"line_number":11,"context_line":"to the applied release and the one before it. To enable this,"},{"line_number":12,"context_line":"a download_packages.txt, Packages directory with all the rpms"},{"line_number":13,"context_line":"unique to the applied release and a comps.xml file to generate"},{"line_number":14,"context_line":"repodata are provided in"},{"line_number":15,"context_line":"/opt/platform/deploy/\u003crelease-id\u003e/prestage/shared."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"cc6a14f6_46eddaef","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":23},"in_reply_to":"1a2f664a_22100878","updated":"2022-02-10 15:17:56.000000000","message":"Done","commit_id":"1b6429b489484fd46026d4d6f428b5cecfc4e635"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"f8d31a746fdbbc838e513daee0fe8685c763a147","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is desirable to download only the rpms that are not common"},{"line_number":10,"context_line":"to the applied release and the one before it. To enable this,"},{"line_number":11,"context_line":"a common_packages.txt, Packages directory with all the rpms"},{"line_number":12,"context_line":"unique to the applied release and a comps.xml file to generate"},{"line_number":13,"context_line":"repodata are provided in"},{"line_number":14,"context_line":"/opt/platform/deploy/\u003crelease-id\u003e/prestage/shared."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"f2d2ee96_13f78d9e","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":31},"updated":"2022-02-17 14:19:22.000000000","message":"sentence reads as if conjunction missing","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"aa471b940158b34d6a2394f2552044ac1649ee09","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is desirable to download only the rpms that are not common"},{"line_number":10,"context_line":"to the applied release and the one before it. To enable this,"},{"line_number":11,"context_line":"a common_packages.txt, Packages directory with all the rpms"},{"line_number":12,"context_line":"unique to the applied release and a comps.xml file to generate"},{"line_number":13,"context_line":"repodata are provided in"},{"line_number":14,"context_line":"/opt/platform/deploy/\u003crelease-id\u003e/prestage/shared."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"158134d3_e47a63db","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":31},"in_reply_to":"f2d2ee96_13f78d9e","updated":"2022-02-17 20:09:15.000000000","message":"Done","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"ac2ff599a2a6e3e84aa773130fe962742faf34dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"80c023b6_56442f3b","updated":"2022-02-11 20:46:16.000000000","message":"Missing Story and Task fields in commit message","commit_id":"c8e59cce7a119d4e54fd5a8d451e4f7521a2ccf0"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"337cf9a1_d33c3edd","updated":"2022-02-15 00:29:10.000000000","message":"Based on the latest discussion with Matt and Scott, my understanding is the script will be accepting the \u003cN+1_release_id\u003e from the caller. Based on the provided release_id, it will search for the 2 files: \u003cN+1_release_id\u003e_package_list.txt and \u003cN_release_id\u003e_package_list.txt. If these files don\u0027t exist, the script will exit with an error.\n\nThe \u003cN+1_release_id\u003e_package_list.txt file should be available at some pre-defined location as part of the image.\n\nThe \u003cN_release_id\u003e_package_list.txt is retrieved from the subcloud by the caller and placed under:\n/opt/platform/deploy/\u003cN+1_release_id\u003e/prestage/shared\nbeforehand.\n \n\n\n","commit_id":"99510c320d7803b973098b7c9b990bbf18079e5a"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"c108bcf315e2796c7bc3aa838d2c1f6d54007646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"ec8a4e7d_9ea19509","updated":"2022-02-17 19:59:35.000000000","message":"Please include story and task in the commit msg.","commit_id":"169399ea3168b091d0c3342f7873e531c783ba55"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"348cb0369d3e8fd8646750afd3b8548900da5cf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"e5be7157_772ebd55","in_reply_to":"ec8a4e7d_9ea19509","updated":"2022-02-17 20:08:13.000000000","message":"Done","commit_id":"169399ea3168b091d0c3342f7873e531c783ba55"}],"utilities/platform-util/centos/platform-util.spec":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":70,"context_line":"install -m 555 %{_buildsubdir}/scripts/update_docker_registry_auth.sh %{buildroot}%{local_bindir}"},{"line_number":71,"context_line":"install -m 555 %{_buildsubdir}/scripts/change_system_private_registry.sh %{buildroot}%{local_bindir}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"install -D %{_buildsubdir}/scripts/current_package_checksums.txt %{buildroot}%{local_share_dir}/current_package_checksums.txt"},{"line_number":74,"context_line":"install -D %{_buildsubdir}/scripts/prev_package_checksums.txt %{buildroot}%{local_share_dir}/prev_package_checksums.txt"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"install -d %{buildroot}%{local_etc_initd}"},{"line_number":77,"context_line":"install %{_buildsubdir}/scripts/log_functions.sh %{buildroot}%{local_etc_initd}"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rpm-spec","patch_set":22,"id":"5549f814_515e4f3f","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":0},"updated":"2022-02-15 00:29:10.000000000","message":"Please make these conditional. If they exist then copy.","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"install -m 555 %{_buildsubdir}/scripts/update_docker_registry_auth.sh %{buildroot}%{local_bindir}"},{"line_number":71,"context_line":"install -m 555 %{_buildsubdir}/scripts/change_system_private_registry.sh %{buildroot}%{local_bindir}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"install -D %{_buildsubdir}/scripts/current_package_checksums.txt %{buildroot}%{local_share_dir}/current_package_checksums.txt"},{"line_number":74,"context_line":"install -D %{_buildsubdir}/scripts/prev_package_checksums.txt %{buildroot}%{local_share_dir}/prev_package_checksums.txt"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"install -d %{buildroot}%{local_etc_initd}"},{"line_number":77,"context_line":"install %{_buildsubdir}/scripts/log_functions.sh %{buildroot}%{local_etc_initd}"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rpm-spec","patch_set":22,"id":"614069ac_d72a19c5","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":0},"in_reply_to":"5549f814_515e4f3f","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"8bcba894b4ca231d65d427d8f9709d5597a7064a","unresolved":true,"context_lines":[{"line_number":113,"context_line":"%{pythonroot}/platform_util-%{version}.0-py2.7.egg-info/*"},{"line_number":114,"context_line":"%{local_etc_initd}/log_functions.sh"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"%files controller"},{"line_number":118,"context_line":"%defattr(-,root,root,-)"},{"line_number":119,"context_line":"%{local_bindir}/update-iso.sh"}],"source_content_type":"text/x-rpm-spec","patch_set":32,"id":"5facaf8f_d063ee8b","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":0},"updated":"2022-02-17 19:25:48.000000000","message":"Should not add empty lines for no reason","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"b05cceda319c805685424a835529c76dc8d7395c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"%{pythonroot}/platform_util-%{version}.0-py2.7.egg-info/*"},{"line_number":114,"context_line":"%{local_etc_initd}/log_functions.sh"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"%files controller"},{"line_number":118,"context_line":"%defattr(-,root,root,-)"},{"line_number":119,"context_line":"%{local_bindir}/update-iso.sh"}],"source_content_type":"text/x-rpm-spec","patch_set":32,"id":"53be90da_579f1fb0","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":0},"in_reply_to":"5facaf8f_d063ee8b","updated":"2022-02-17 19:30:24.000000000","message":"Done","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"}],"utilities/platform-util/scripts/common_packages":[{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"22e7f382cf13d7074da59e6b4a91a75e47e91dff","unresolved":true,"context_lines":[{"line_number":1,"context_line":"acl-2.2.51-14.el7.x86_64.rpm"},{"line_number":2,"context_line":"acpid-2.0.19-9.el7.x86_64.rpm"},{"line_number":3,"context_line":"alsa-lib-1.1.6-2.el7.x86_64.rpm"},{"line_number":4,"context_line":"ansible-2.7.5-1.el7.ans.noarch.rpm"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"8ea7500a_fc000d98","line":1,"updated":"2022-02-09 21:19:28.000000000","message":"How is this list of RPMs gathered? Should we be generating this somehow? Same comment for the package_list. Basically, I\u0027m wondering how we\u0027re going to maintain this list going forward.","commit_id":"41b6adc5f014c7af24a1af7f650e5f74fe25101d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"ddc3de47e67bf99134418c9e784121ccbee10b44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"acl-2.2.51-14.el7.x86_64.rpm"},{"line_number":2,"context_line":"acpid-2.0.19-9.el7.x86_64.rpm"},{"line_number":3,"context_line":"alsa-lib-1.1.6-2.el7.x86_64.rpm"},{"line_number":4,"context_line":"ansible-2.7.5-1.el7.ans.noarch.rpm"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"8d4628f4_9797325d","line":1,"in_reply_to":"8ea7500a_fc000d98","updated":"2022-02-09 22:03:19.000000000","message":"This needs to be generated by the build team. The package list will be generated internally in my next revision of the code.","commit_id":"41b6adc5f014c7af24a1af7f650e5f74fe25101d"}],"utilities/platform-util/scripts/current_package_checksums.txt":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"44f3e5c7_9e2d7128","updated":"2022-02-15 00:29:10.000000000","message":"Please remove","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"8a334f45_79e1633a","in_reply_to":"44f3e5c7_9e2d7128","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"}],"utilities/platform-util/scripts/package_list":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"9e7bb421c402c597d9b0aa75cab7c1e630047222","unresolved":true,"context_lines":[{"line_number":1,"context_line":"acl-2.2.51-14.el7.x86_64.rpm"},{"line_number":2,"context_line":"acpid-2.0.19-9.el7.x86_64.rpm"},{"line_number":3,"context_line":"alsa-lib-1.1.6-2.el7.x86_64.rpm"},{"line_number":4,"context_line":"ansible-2.7.5-1.el7.ans.noarch.rpm"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"58fabefc_5d7819e4","line":1,"updated":"2022-02-10 14:58:08.000000000","message":"why do we need to include this list? It can be generated from the release feed on the system controller e.g. /www/pages/feed/rel-\u003csw-version\u003e","commit_id":"1b6429b489484fd46026d4d6f428b5cecfc4e635"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"4ef7cfef79d826f8173d68af2155b969c8acee82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"acl-2.2.51-14.el7.x86_64.rpm"},{"line_number":2,"context_line":"acpid-2.0.19-9.el7.x86_64.rpm"},{"line_number":3,"context_line":"alsa-lib-1.1.6-2.el7.x86_64.rpm"},{"line_number":4,"context_line":"ansible-2.7.5-1.el7.ans.noarch.rpm"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"dd98bbbe_d08c5eff","line":1,"in_reply_to":"58fabefc_5d7819e4","updated":"2022-02-10 15:17:56.000000000","message":"We do not. I have modified the code so that it generates the list now.","commit_id":"1b6429b489484fd46026d4d6f428b5cecfc4e635"}],"utilities/platform-util/scripts/prepare-prestage-packages.sh":[{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"de9a3b0123761abdca865c46ad40030ca6758460","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    logger -i -s -t ${LOG_TAG} -- \"$@\""},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"declare NODE_ID\u003d"},{"line_number":22,"context_line":"declare PRESTAGE_DIR\u003d"},{"line_number":23,"context_line":"declare RPM_LIST\u003d\"package_list\""},{"line_number":24,"context_line":"declare RPM_COMMON_LIST\u003d\"common_packages\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"b99cc9ad_5c3c5beb","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":15},"updated":"2022-02-09 22:17:12.000000000","message":"Can you please rename this to RELEASE_ID, to correspond to the input parameter? I was confusing it with the subcloud name for some reason.","commit_id":"41b6adc5f014c7af24a1af7f650e5f74fe25101d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"30ea1d52733fa38e44e44faffa1b08d400579ab8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    logger -i -s -t ${LOG_TAG} -- \"$@\""},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"declare NODE_ID\u003d"},{"line_number":22,"context_line":"declare PRESTAGE_DIR\u003d"},{"line_number":23,"context_line":"declare RPM_LIST\u003d\"package_list\""},{"line_number":24,"context_line":"declare RPM_COMMON_LIST\u003d\"common_packages\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"20d55007_818f468f","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":15},"in_reply_to":"b99cc9ad_5c3c5beb","updated":"2022-02-10 14:44:53.000000000","message":"Done","commit_id":"41b6adc5f014c7af24a1af7f650e5f74fe25101d"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"22e7f382cf13d7074da59e6b4a91a75e47e91dff","unresolved":true,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# main script goes here."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"check_required_param \"--id\" \"${NODE_ID}\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"INPUT_ISO\u003d${ISO_DIR}/${NODE_ID}/bootimage.iso"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"304d30ce_4f0b2f5c","line":151,"range":{"start_line":151,"start_character":20,"end_line":151,"end_character":28},"updated":"2022-02-09 21:19:28.000000000","message":"Should be \"--release-id\"","commit_id":"41b6adc5f014c7af24a1af7f650e5f74fe25101d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"ddc3de47e67bf99134418c9e784121ccbee10b44","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# main script goes here."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"check_required_param \"--id\" \"${NODE_ID}\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"INPUT_ISO\u003d${ISO_DIR}/${NODE_ID}/bootimage.iso"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"51d60fac_1755bc48","line":151,"range":{"start_line":151,"start_character":20,"end_line":151,"end_character":28},"in_reply_to":"304d30ce_4f0b2f5c","updated":"2022-02-09 22:03:19.000000000","message":"Done","commit_id":"41b6adc5f014c7af24a1af7f650e5f74fe25101d"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"22e7f382cf13d7074da59e6b4a91a75e47e91dff","unresolved":true,"context_lines":[{"line_number":161,"context_line":"declare common_rpm_list\u003d()"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"mount_iso ${INPUT_ISO}"},{"line_number":164,"context_line":"RPM_DIR\u003d${MNTDIR}/Packages/"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# Create the shared directory"},{"line_number":167,"context_line":"create_prestage_shared_dir"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# create the download list. We only have the list of common rpms "},{"line_number":170,"context_line":"# and the list of all the rpms."},{"line_number":171,"context_line":"create_rpm_download_list"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"# copy the required items to the prestage shared directory"},{"line_number":174,"context_line":"populate_prestage_shared_dir"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"unmount_iso"},{"line_number":177,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3cd7a33b_5d5f02d9","line":174,"range":{"start_line":164,"start_character":0,"end_line":174,"end_character":28},"updated":"2022-02-09 21:19:28.000000000","message":"You will need to trap any errors across this section at a minimum in order to ensure that unmount_iso is called to cleanup the mount.","commit_id":"41b6adc5f014c7af24a1af7f650e5f74fe25101d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"ddc3de47e67bf99134418c9e784121ccbee10b44","unresolved":false,"context_lines":[{"line_number":161,"context_line":"declare common_rpm_list\u003d()"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"mount_iso ${INPUT_ISO}"},{"line_number":164,"context_line":"RPM_DIR\u003d${MNTDIR}/Packages/"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# Create the shared directory"},{"line_number":167,"context_line":"create_prestage_shared_dir"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# create the download list. We only have the list of common rpms "},{"line_number":170,"context_line":"# and the list of all the rpms."},{"line_number":171,"context_line":"create_rpm_download_list"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"# copy the required items to the prestage shared directory"},{"line_number":174,"context_line":"populate_prestage_shared_dir"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"unmount_iso"},{"line_number":177,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":11,"id":"0b44a3a4_96c907ea","line":174,"range":{"start_line":164,"start_character":0,"end_line":174,"end_character":28},"in_reply_to":"3cd7a33b_5d5f02d9","updated":"2022-02-09 22:03:19.000000000","message":"Done","commit_id":"41b6adc5f014c7af24a1af7f650e5f74fe25101d"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"1c130628b9fd87691311ac4ec4757391c06c77c7","unresolved":true,"context_lines":[{"line_number":21,"context_line":"declare RELEASE_ID\u003d"},{"line_number":22,"context_line":"declare PRESTAGE_DIR\u003d"},{"line_number":23,"context_line":"declare RPM_LIST\u003d"},{"line_number":24,"context_line":"declare RPM_COMMON_LIST\u003d\"common_packages.txt\""},{"line_number":25,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":26,"context_line":"declare RPM_DOWNLOAD_LIST\u003d\"download_packages.txt\""},{"line_number":27,"context_line":"declare RPM_PACKAGE_DIR\u003d"},{"line_number":28,"context_line":"declare RPM_DIR\u003d"}],"source_content_type":"text/x-sh","patch_set":18,"id":"504f6493_5cb86e72","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":56},"updated":"2022-02-10 17:59:14.000000000","message":"I would expect to find the two package lists with checksums in this directory,  representing the \u0027from\u0027 and \u0027to\u0027 releases.\n\ne.g.\n/usr/local/share/pkg-lists/${FROM_RELEASE_ID}_package_checksums\n/usr/local/share/pkg-lists/${TO_RELEASE_ID}_package_checksums\nor better....\n/usr/local/share/pkg-lists/${FROM_RELEASE_ID}/package_checksums\n/usr/local/share/pkg-lists/${TO_RELEASE_ID}/package_checksums\n\n\nThis script should compare them to derive the common_packages.txt, or populate your common_rpm_list directly.","commit_id":"3859dcc384252c8d827468f4ba3e86bd3826a2de"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"2cb5a6ac255a3cb50dce5a262a70c0e918825909","unresolved":false,"context_lines":[{"line_number":21,"context_line":"declare RELEASE_ID\u003d"},{"line_number":22,"context_line":"declare PRESTAGE_DIR\u003d"},{"line_number":23,"context_line":"declare RPM_LIST\u003d"},{"line_number":24,"context_line":"declare RPM_COMMON_LIST\u003d\"common_packages.txt\""},{"line_number":25,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":26,"context_line":"declare RPM_DOWNLOAD_LIST\u003d\"download_packages.txt\""},{"line_number":27,"context_line":"declare RPM_PACKAGE_DIR\u003d"},{"line_number":28,"context_line":"declare RPM_DIR\u003d"}],"source_content_type":"text/x-sh","patch_set":18,"id":"051e4ce1_9821c122","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":56},"in_reply_to":"47842058_22f6c8f5","updated":"2022-02-14 21:57:22.000000000","message":"Made changes as per your suggestions. Further changes based on matt\u0027s suggestions in next story. This is for 21.12.","commit_id":"3859dcc384252c8d827468f4ba3e86bd3826a2de"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"64c356a8b935b981be47216feaedd06035525e3f","unresolved":true,"context_lines":[{"line_number":21,"context_line":"declare RELEASE_ID\u003d"},{"line_number":22,"context_line":"declare PRESTAGE_DIR\u003d"},{"line_number":23,"context_line":"declare RPM_LIST\u003d"},{"line_number":24,"context_line":"declare RPM_COMMON_LIST\u003d\"common_packages.txt\""},{"line_number":25,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":26,"context_line":"declare RPM_DOWNLOAD_LIST\u003d\"download_packages.txt\""},{"line_number":27,"context_line":"declare RPM_PACKAGE_DIR\u003d"},{"line_number":28,"context_line":"declare RPM_DIR\u003d"}],"source_content_type":"text/x-sh","patch_set":18,"id":"867d9881_90f53bea","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":56},"in_reply_to":"504f6493_5cb86e72","updated":"2022-02-14 16:04:26.000000000","message":"Okay. I shall create a new story for this particular change and add it immediately following the completion of this story.","commit_id":"3859dcc384252c8d827468f4ba3e86bd3826a2de"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"326d06504111bcac571045d2371f682515e70555","unresolved":true,"context_lines":[{"line_number":21,"context_line":"declare RELEASE_ID\u003d"},{"line_number":22,"context_line":"declare PRESTAGE_DIR\u003d"},{"line_number":23,"context_line":"declare RPM_LIST\u003d"},{"line_number":24,"context_line":"declare RPM_COMMON_LIST\u003d\"common_packages.txt\""},{"line_number":25,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":26,"context_line":"declare RPM_DOWNLOAD_LIST\u003d\"download_packages.txt\""},{"line_number":27,"context_line":"declare RPM_PACKAGE_DIR\u003d"},{"line_number":28,"context_line":"declare RPM_DIR\u003d"}],"source_content_type":"text/x-sh","patch_set":18,"id":"47842058_22f6c8f5","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":56},"in_reply_to":"867d9881_90f53bea","updated":"2022-02-14 16:04:48.000000000","message":"Is this acceptable?","commit_id":"3859dcc384252c8d827468f4ba3e86bd3826a2de"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"8204baabecf6edbff9e2ec8fc67cc61201af8622","unresolved":true,"context_lines":[{"line_number":28,"context_line":"declare RPM_DIR\u003d"},{"line_number":29,"context_line":"declare INPUT_ISO\u003d"},{"line_number":30,"context_line":"declare ISO_DIR\u003d/opt/dc-vault/loads"},{"line_number":31,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy/\""},{"line_number":32,"context_line":"declare TEMPDIR\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function usage {"}],"source_content_type":"text/x-sh","patch_set":19,"id":"c290ac9b_1609865d","line":31,"range":{"start_line":31,"start_character":29,"end_line":31,"end_character":50},"updated":"2022-02-11 16:34:28.000000000","message":"should not have the trailing \u0027/\u0027\n\nFrom the log output:\nprepare-prestage-packages.sh[211383]: /opt/platform/deploy//22.02/prestage/shared does not exist; creating...","commit_id":"c8e59cce7a119d4e54fd5a8d451e4f7521a2ccf0"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"64c356a8b935b981be47216feaedd06035525e3f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"declare RPM_DIR\u003d"},{"line_number":29,"context_line":"declare INPUT_ISO\u003d"},{"line_number":30,"context_line":"declare ISO_DIR\u003d/opt/dc-vault/loads"},{"line_number":31,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy/\""},{"line_number":32,"context_line":"declare TEMPDIR\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function usage {"}],"source_content_type":"text/x-sh","patch_set":19,"id":"05988a55_ab9781a8","line":31,"range":{"start_line":31,"start_character":29,"end_line":31,"end_character":50},"in_reply_to":"c290ac9b_1609865d","updated":"2022-02-14 16:04:26.000000000","message":"Done","commit_id":"c8e59cce7a119d4e54fd5a8d451e4f7521a2ccf0"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"8204baabecf6edbff9e2ec8fc67cc61201af8622","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    exit -1"},{"line_number":198,"context_line":"fi"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# Create the shared directory"},{"line_number":201,"context_line":"create_prestage_shared_dir"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"# create the download list. We only have the list of common rpms "},{"line_number":204,"context_line":"# and the list of all the rpms."},{"line_number":205,"context_line":"create_rpm_download_list"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# copy the required items to the prestage shared directory"},{"line_number":208,"context_line":"populate_prestage_shared_dir"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"unmount_iso"},{"line_number":211,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":19,"id":"b547001b_fc82d00b","line":210,"range":{"start_line":200,"start_character":0,"end_line":210,"end_character":10},"updated":"2022-02-11 16:34:28.000000000","message":"It would be nice for troubleshooting to log the start of each of these steps, and also log when the script is finished.","commit_id":"c8e59cce7a119d4e54fd5a8d451e4f7521a2ccf0"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"64c356a8b935b981be47216feaedd06035525e3f","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    exit -1"},{"line_number":198,"context_line":"fi"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# Create the shared directory"},{"line_number":201,"context_line":"create_prestage_shared_dir"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"# create the download list. We only have the list of common rpms "},{"line_number":204,"context_line":"# and the list of all the rpms."},{"line_number":205,"context_line":"create_rpm_download_list"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# copy the required items to the prestage shared directory"},{"line_number":208,"context_line":"populate_prestage_shared_dir"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"unmount_iso"},{"line_number":211,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":19,"id":"b884ec40_6b2d0a27","line":210,"range":{"start_line":200,"start_character":0,"end_line":210,"end_character":10},"in_reply_to":"b547001b_fc82d00b","updated":"2022-02-14 16:04:26.000000000","message":"Done","commit_id":"c8e59cce7a119d4e54fd5a8d451e4f7521a2ccf0"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Bash utility to generate a prestage shared directory"},{"line_number":8,"context_line":"# that include a list of RPMs to download, and a list"},{"line_number":9,"context_line":"# containing the names of the rpms that must be"},{"line_number":10,"context_line":"# downloaded by the subcloud. This is used when there"},{"line_number":11,"context_line":"# is no prestage iso available at the subcloud."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"source $(dirname $0)/stx-iso-utils.sh"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-sh","patch_set":22,"id":"ec294903_64b558da","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":0},"updated":"2022-02-15 00:29:10.000000000","message":"generate a prestage shared directory containing the following:\n   - Packages directory containing a list of new RPMs to download\n   - File containing a list of unchanged RPMs to copy locally on the target\n   - Packages comps.xml file","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Bash utility to generate a prestage shared directory"},{"line_number":8,"context_line":"# that include a list of RPMs to download, and a list"},{"line_number":9,"context_line":"# containing the names of the rpms that must be"},{"line_number":10,"context_line":"# downloaded by the subcloud. This is used when there"},{"line_number":11,"context_line":"# is no prestage iso available at the subcloud."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"source $(dirname $0)/stx-iso-utils.sh"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-sh","patch_set":22,"id":"894ba954_8cb45b64","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":0},"in_reply_to":"ec294903_64b558da","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":42,"context_line":"declare TEMP_COMMON_PKGS_WITH_CHKSUM\u003dcommon_pkgs_with_chksum.txt"},{"line_number":43,"context_line":"function usage {"},{"line_number":44,"context_line":"    cat \u003c\u003cENDUSAGE"},{"line_number":45,"context_line":"Description: Sets up a prestage shared directory that includes a list of"},{"line_number":46,"context_line":"common RPMs, a list of RPMs to download, a directory (Packages) that has"},{"line_number":47,"context_line":"all the RPMs that need to be downloaded by the subcloud and the repodata."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Mandatory parameters for setup:"},{"line_number":50,"context_line":"    --release-id              Specify the release version"},{"line_number":51,"context_line":"    -h                        Print this help page"}],"source_content_type":"text/x-sh","patch_set":22,"id":"e23a0536_f08723dc","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":0},"updated":"2022-02-15 00:29:10.000000000","message":"See comment above","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"declare TEMP_COMMON_PKGS_WITH_CHKSUM\u003dcommon_pkgs_with_chksum.txt"},{"line_number":43,"context_line":"function usage {"},{"line_number":44,"context_line":"    cat \u003c\u003cENDUSAGE"},{"line_number":45,"context_line":"Description: Sets up a prestage shared directory that includes a list of"},{"line_number":46,"context_line":"common RPMs, a list of RPMs to download, a directory (Packages) that has"},{"line_number":47,"context_line":"all the RPMs that need to be downloaded by the subcloud and the repodata."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Mandatory parameters for setup:"},{"line_number":50,"context_line":"    --release-id              Specify the release version"},{"line_number":51,"context_line":"    -h                        Print this help page"}],"source_content_type":"text/x-sh","patch_set":22,"id":"5b2329bc_156ea1ac","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":0},"in_reply_to":"e23a0536_f08723dc","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":188,"context_line":"}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"function populate_prestage_shared_dir {"},{"line_number":191,"context_line":"    # copy all the rpms to be downloaded into the Packages "},{"line_number":192,"context_line":"    # directory in PRESTAGE_SHARED_DIR"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # copy the download list and the rpms themselves to the "}],"source_content_type":"text/x-sh","patch_set":22,"id":"b765a2d8_e0d1c9b5","line":191,"range":{"start_line":191,"start_character":58,"end_line":191,"end_character":59},"updated":"2022-02-15 00:29:10.000000000","message":"end of line extra space\n\nSame comment applies to other occurrences in this file.","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"function populate_prestage_shared_dir {"},{"line_number":191,"context_line":"    # copy all the rpms to be downloaded into the Packages "},{"line_number":192,"context_line":"    # directory in PRESTAGE_SHARED_DIR"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # copy the download list and the rpms themselves to the "}],"source_content_type":"text/x-sh","patch_set":22,"id":"3488f38e_eb082a98","line":191,"range":{"start_line":191,"start_character":58,"end_line":191,"end_character":59},"in_reply_to":"b765a2d8_e0d1c9b5","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"INPUT_ISO\u003d${ISO_DIR}/${RELEASE_ID}/bootimage.iso"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"trap cleanup EXIT"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"PRESTAGE_DIR\u003d\"${PRESTAGE_DIR_PREFIX}/${RELEASE_ID}/prestage\""},{"line_number":219,"context_line":"PRESTAGE_SHARED_DIR\u003d\"${PRESTAGE_DIR}/shared\""}],"source_content_type":"text/x-sh","patch_set":22,"id":"d45a33e7_40934231","line":216,"range":{"start_line":216,"start_character":13,"end_line":216,"end_character":17},"updated":"2022-02-15 00:29:10.000000000","message":"Works well with kill and ctrl-c as well?","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"INPUT_ISO\u003d${ISO_DIR}/${RELEASE_ID}/bootimage.iso"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"trap cleanup EXIT"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"PRESTAGE_DIR\u003d\"${PRESTAGE_DIR_PREFIX}/${RELEASE_ID}/prestage\""},{"line_number":219,"context_line":"PRESTAGE_SHARED_DIR\u003d\"${PRESTAGE_DIR}/shared\""}],"source_content_type":"text/x-sh","patch_set":22,"id":"289264a7_f9ffb2e2","line":216,"range":{"start_line":216,"start_character":13,"end_line":216,"end_character":17},"in_reply_to":"d45a33e7_40934231","updated":"2022-02-16 02:17:37.000000000","message":"appropriate handler has been added to handle a Ctrl-C.","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":219,"context_line":"PRESTAGE_SHARED_DIR\u003d\"${PRESTAGE_DIR}/shared\""},{"line_number":220,"context_line":"RPM_PACKAGE_DIR\u003d\"${PRESTAGE_SHARED_DIR}/Packages\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"TEMPDIR\u003d$(mktemp -d -p /scratch package_list_dir_XXXXXX)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# create the download list."},{"line_number":225,"context_line":"declare rpm_download_list\u003d()"}],"source_content_type":"text/x-sh","patch_set":22,"id":"16172d68_66e01f16","line":222,"range":{"start_line":222,"start_character":10,"end_line":222,"end_character":56},"updated":"2022-02-15 00:29:10.000000000","message":"Was this script tested with /scratch filled up beforehand?","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":219,"context_line":"PRESTAGE_SHARED_DIR\u003d\"${PRESTAGE_DIR}/shared\""},{"line_number":220,"context_line":"RPM_PACKAGE_DIR\u003d\"${PRESTAGE_SHARED_DIR}/Packages\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"TEMPDIR\u003d$(mktemp -d -p /scratch package_list_dir_XXXXXX)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# create the download list."},{"line_number":225,"context_line":"declare rpm_download_list\u003d()"}],"source_content_type":"text/x-sh","patch_set":22,"id":"6d72f793_054a4f86","line":222,"range":{"start_line":222,"start_character":10,"end_line":222,"end_character":56},"in_reply_to":"16172d68_66e01f16","updated":"2022-02-16 02:17:37.000000000","message":"Yes.","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":222,"context_line":"TEMPDIR\u003d$(mktemp -d -p /scratch package_list_dir_XXXXXX)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# create the download list."},{"line_number":225,"context_line":"declare rpm_download_list\u003d()"},{"line_number":226,"context_line":"declare common_rpm_list\u003d()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"mount_iso ${INPUT_ISO}"}],"source_content_type":"text/x-sh","patch_set":22,"id":"03d90139_8781919b","line":225,"range":{"start_line":225,"start_character":8,"end_line":225,"end_character":25},"updated":"2022-02-15 00:29:10.000000000","message":"download_rpm_list or new_rpm_list","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"TEMPDIR\u003d$(mktemp -d -p /scratch package_list_dir_XXXXXX)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"# create the download list."},{"line_number":225,"context_line":"declare rpm_download_list\u003d()"},{"line_number":226,"context_line":"declare common_rpm_list\u003d()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"mount_iso ${INPUT_ISO}"}],"source_content_type":"text/x-sh","patch_set":22,"id":"5a3d8d73_750cbf22","line":225,"range":{"start_line":225,"start_character":8,"end_line":225,"end_character":25},"in_reply_to":"03d90139_8781919b","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":225,"context_line":"declare rpm_download_list\u003d()"},{"line_number":226,"context_line":"declare common_rpm_list\u003d()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"mount_iso ${INPUT_ISO}"},{"line_number":229,"context_line":"RPM_DIR\u003d${MNTDIR}/Packages/"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"ls ${RPM_DIR} \u003e ${TEMPDIR}/package_list.txt"}],"source_content_type":"text/x-sh","patch_set":22,"id":"2db3873c_deb06019","line":228,"range":{"start_line":228,"start_character":0,"end_line":228,"end_character":22},"updated":"2022-02-15 00:29:10.000000000","message":"Is this required?","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":225,"context_line":"declare rpm_download_list\u003d()"},{"line_number":226,"context_line":"declare common_rpm_list\u003d()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"mount_iso ${INPUT_ISO}"},{"line_number":229,"context_line":"RPM_DIR\u003d${MNTDIR}/Packages/"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"ls ${RPM_DIR} \u003e ${TEMPDIR}/package_list.txt"}],"source_content_type":"text/x-sh","patch_set":22,"id":"058fdd89_80d670e6","line":228,"range":{"start_line":228,"start_character":0,"end_line":228,"end_character":22},"in_reply_to":"2db3873c_deb06019","updated":"2022-02-16 02:17:37.000000000","message":"Yes. We copy the Packages from the bootimage.iso on the system controller. We need to mount it first, so that we can copy the packages over to the shared directory.","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    log \"${RPM_LIST} not created. Abort\""},{"line_number":238,"context_line":"    exit -1"},{"line_number":239,"context_line":"fi"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"# create the common package list"},{"line_number":242,"context_line":"create_common_package_list"},{"line_number":243,"context_line":"log \"Created the common package list\""}],"source_content_type":"text/x-sh","patch_set":22,"id":"f01a81b8_980e1312","line":240,"updated":"2022-02-15 00:29:10.000000000","message":"Need to check if this script has been executed (successfully) before for the specified release-id and exit.","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    log \"${RPM_LIST} not created. Abort\""},{"line_number":238,"context_line":"    exit -1"},{"line_number":239,"context_line":"fi"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"# create the common package list"},{"line_number":242,"context_line":"create_common_package_list"},{"line_number":243,"context_line":"log \"Created the common package list\""}],"source_content_type":"text/x-sh","patch_set":22,"id":"96c7933a_eb612ff4","line":240,"in_reply_to":"f01a81b8_980e1312","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[{"line_number":256,"context_line":"log \"Prestage shared directory populated\""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"unmount_iso"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":22,"id":"9b87133a_d084c10d","line":259,"updated":"2022-02-15 00:29:10.000000000","message":"Should add step to mark the completion of prestage packages shared dir.","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"log \"Prestage shared directory populated\""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"unmount_iso"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":22,"id":"9d10099e_dec674f3","line":259,"in_reply_to":"9b87133a_d084c10d","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"declare RPM_COMMON_LIST_NAME\u003d\"common_packages.txt\""},{"line_number":29,"context_line":"declare RPM_COMMON_LIST\u003d"},{"line_number":30,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":31,"context_line":"declare RPM_DOWNLOAD_LIST\u003d\"download_packages.txt\""},{"line_number":32,"context_line":"declare CURRENT_PKGS_LIST\u003d\"current_package_checksums.txt\""},{"line_number":33,"context_line":"declare PREV_PKGS_LIST\u003d\"prev_package_checksums.txt\""},{"line_number":34,"context_line":"declare RPM_PACKAGE_DIR\u003d"}],"source_content_type":"text/x-sh","patch_set":24,"id":"7bb3b4a3_56af2364","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":49},"updated":"2022-02-16 01:03:17.000000000","message":"The consumer (prestage packages playbook) does not need this file. Only the file containing the list of unchanged packages (common_packages.txt), the comps.xml and the Packages directory which contains the new/updated packages.","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"declare RPM_COMMON_LIST_NAME\u003d\"common_packages.txt\""},{"line_number":29,"context_line":"declare RPM_COMMON_LIST\u003d"},{"line_number":30,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":31,"context_line":"declare RPM_DOWNLOAD_LIST\u003d\"download_packages.txt\""},{"line_number":32,"context_line":"declare CURRENT_PKGS_LIST\u003d\"current_package_checksums.txt\""},{"line_number":33,"context_line":"declare PREV_PKGS_LIST\u003d\"prev_package_checksums.txt\""},{"line_number":34,"context_line":"declare RPM_PACKAGE_DIR\u003d"}],"source_content_type":"text/x-sh","patch_set":24,"id":"5e046690_0464f938","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":49},"in_reply_to":"7bb3b4a3_56af2364","updated":"2022-02-16 17:27:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":29,"context_line":"declare RPM_COMMON_LIST\u003d"},{"line_number":30,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":31,"context_line":"declare RPM_DOWNLOAD_LIST\u003d\"download_packages.txt\""},{"line_number":32,"context_line":"declare CURRENT_PKGS_LIST\u003d\"current_package_checksums.txt\""},{"line_number":33,"context_line":"declare PREV_PKGS_LIST\u003d\"prev_package_checksums.txt\""},{"line_number":34,"context_line":"declare RPM_PACKAGE_DIR\u003d"},{"line_number":35,"context_line":"declare RPM_DIR\u003d"},{"line_number":36,"context_line":"declare INPUT_ISO\u003d"}],"source_content_type":"text/x-sh","patch_set":24,"id":"14b8b6d8_597064f8","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":51},"updated":"2022-02-16 01:03:17.000000000","message":"The naming convention likely is \"\u003crelease_id\u003e_package_list.txt","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"declare RPM_COMMON_LIST\u003d"},{"line_number":30,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":31,"context_line":"declare RPM_DOWNLOAD_LIST\u003d\"download_packages.txt\""},{"line_number":32,"context_line":"declare CURRENT_PKGS_LIST\u003d\"current_package_checksums.txt\""},{"line_number":33,"context_line":"declare PREV_PKGS_LIST\u003d\"prev_package_checksums.txt\""},{"line_number":34,"context_line":"declare RPM_PACKAGE_DIR\u003d"},{"line_number":35,"context_line":"declare RPM_DIR\u003d"},{"line_number":36,"context_line":"declare INPUT_ISO\u003d"}],"source_content_type":"text/x-sh","patch_set":24,"id":"859258ac_bd21d5df","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":51},"in_reply_to":"14b8b6d8_597064f8","updated":"2022-02-16 17:27:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    PREV_PKGS\u003d${RPM_COMMON_LIST_DIR}/${PREV_PKGS_LIST}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    if [ ! -f \"${CURRENT_PKGS}\" ]; then"},{"line_number":104,"context_line":"        log \"${CURRENT_PKGS} does not exist. Abort\""},{"line_number":105,"context_line":"        exit -1"},{"line_number":106,"context_line":"    fi"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"1afc628e_d3bfeb5d","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":50},"updated":"2022-02-16 01:03:17.000000000","message":"Package list for current release (${CURRENT_PKGS}) does not exist. Abort","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    PREV_PKGS\u003d${RPM_COMMON_LIST_DIR}/${PREV_PKGS_LIST}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    if [ ! -f \"${CURRENT_PKGS}\" ]; then"},{"line_number":104,"context_line":"        log \"${CURRENT_PKGS} does not exist. Abort\""},{"line_number":105,"context_line":"        exit -1"},{"line_number":106,"context_line":"    fi"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"57a9c6a6_cb12d6b0","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":50},"in_reply_to":"1afc628e_d3bfeb5d","updated":"2022-02-16 17:27:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    fi"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if [ ! -f \"${PREV_PKGS}\" ]; then"},{"line_number":109,"context_line":"        log \"${PREV_PKGS} does not exist. Abort\""},{"line_number":110,"context_line":"        exit -1"},{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"a39858e0_20700462","line":109,"range":{"start_line":109,"start_character":12,"end_line":109,"end_character":48},"updated":"2022-02-16 01:03:17.000000000","message":"Package list for previous release (${PREV_PKGS}) does not exist. Abort","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    fi"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if [ ! -f \"${PREV_PKGS}\" ]; then"},{"line_number":109,"context_line":"        log \"${PREV_PKGS} does not exist. Abort\""},{"line_number":110,"context_line":"        exit -1"},{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"618bb79c_cfde1f9c","line":109,"range":{"start_line":109,"start_character":12,"end_line":109,"end_character":48},"in_reply_to":"a39858e0_20700462","updated":"2022-02-16 17:27:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    comm -12 ${CURRENT_PKGS} ${PREV_PKGS} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    while read line; do"},{"line_number":119,"context_line":"        echo ${line} | cut -d \u0027 \u0027 -f 1 - \u003e\u003e ${RPM_COMMON_LIST}"},{"line_number":120,"context_line":"    done \u003c${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":123,"context_line":"        log \"Unable to create the common list of packages. Abort\""}],"source_content_type":"text/x-sh","patch_set":24,"id":"243c1dd8_0b4e63d4","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":51},"updated":"2022-02-16 01:03:17.000000000","message":"Wouldn\u0027t it be simpler with\ncat \u003cinput-file\u003e | awk \u0027{print $1}\u0027 \u003e \u003e\u003coutput-file\u003e","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"46e16191c951a996d794655de72dbc07926ce34f","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    comm -12 ${CURRENT_PKGS} ${PREV_PKGS} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    while read line; do"},{"line_number":119,"context_line":"        echo ${line} | cut -d \u0027 \u0027 -f 1 - \u003e\u003e ${RPM_COMMON_LIST}"},{"line_number":120,"context_line":"    done \u003c${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":123,"context_line":"        log \"Unable to create the common list of packages. Abort\""}],"source_content_type":"text/x-sh","patch_set":24,"id":"9a44b8f0_67c798fe","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":51},"in_reply_to":"243c1dd8_0b4e63d4","updated":"2022-02-16 17:31:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    fi"},{"line_number":126,"context_line":"}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"function create_rpm_download_list {"},{"line_number":129,"context_line":"    # load all the rpms in the common list into an array"},{"line_number":130,"context_line":"    local rpm_list\u003d()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"edf4e516_89f916ff","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":34},"updated":"2022-02-16 01:03:17.000000000","message":"This function is not required as the caller does not need the download list.","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"d0c4aa9749c2f062d67d352f10ca8f67792520de","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    fi"},{"line_number":126,"context_line":"}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"function create_rpm_download_list {"},{"line_number":129,"context_line":"    # load all the rpms in the common list into an array"},{"line_number":130,"context_line":"    local rpm_list\u003d()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"f93e5bd7_5993160f","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":34},"in_reply_to":"82d8ee5d_67cc5148","updated":"2022-02-16 17:47:23.000000000","message":"Removed","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    fi"},{"line_number":126,"context_line":"}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"function create_rpm_download_list {"},{"line_number":129,"context_line":"    # load all the rpms in the common list into an array"},{"line_number":130,"context_line":"    local rpm_list\u003d()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"82d8ee5d_67cc5148","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":34},"in_reply_to":"edf4e516_89f916ff","updated":"2022-02-16 17:27:59.000000000","message":"its part of the bigger picture. I generate the list of rpms to be downloaded here; this list is used to copy the appropriate packages to the shared Packages directory.","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":175,"context_line":"    cp ${PREV_PKGS} ${PRESTAGE_SHARED_DIR}"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"function create_prestage_shared_dir {"},{"line_number":179,"context_line":"    # Check if the PRESTAGE_DIR exists"},{"line_number":180,"context_line":"    if [ ! -d ${PRESTAGE_SHARED_DIR} ]; then"},{"line_number":181,"context_line":"        log \"${PRESTAGE_SHARED_DIR} does not exist; creating...\""}],"source_content_type":"text/x-sh","patch_set":24,"id":"a229056b_fcf4f428","line":178,"range":{"start_line":178,"start_character":0,"end_line":178,"end_character":37},"updated":"2022-02-16 01:03:17.000000000","message":"This function is not required. The caller of this script will ensure the prestage shared directory is created as the N_release_package_list.txt will be placed there.","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    cp ${PREV_PKGS} ${PRESTAGE_SHARED_DIR}"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"function create_prestage_shared_dir {"},{"line_number":179,"context_line":"    # Check if the PRESTAGE_DIR exists"},{"line_number":180,"context_line":"    if [ ! -d ${PRESTAGE_SHARED_DIR} ]; then"},{"line_number":181,"context_line":"        log \"${PRESTAGE_SHARED_DIR} does not exist; creating...\""}],"source_content_type":"text/x-sh","patch_set":24,"id":"afd1ec9a_aca9e165","line":178,"range":{"start_line":178,"start_character":0,"end_line":178,"end_character":37},"in_reply_to":"a229056b_fcf4f428","updated":"2022-02-16 17:27:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":187,"context_line":"    fi"},{"line_number":188,"context_line":"}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"function populate_prestage_shared_dir {"},{"line_number":191,"context_line":"    # copy all the rpms to be downloaded into the Packages "},{"line_number":192,"context_line":"    # directory in PRESTAGE_SHARED_DIR"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"65bc96a0_c8208396","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":37},"updated":"2022-02-16 01:03:17.000000000","message":"Check if rsync has the option to copy files from source to destination that are not  in the given list file. You can simplify the logic of this function.\n\nThe prestage packages playbook uses rsync to copy only files that are in the common_packages.txt from release feed dir to /opt/platform-backup.","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    fi"},{"line_number":188,"context_line":"}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"function populate_prestage_shared_dir {"},{"line_number":191,"context_line":"    # copy all the rpms to be downloaded into the Packages "},{"line_number":192,"context_line":"    # directory in PRESTAGE_SHARED_DIR"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"d9051194_aa7138fc","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":37},"in_reply_to":"65bc96a0_c8208396","updated":"2022-02-16 17:27:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"6c5e85e0e11c34cb54918d2bf68396df9f589d97","unresolved":true,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"check_required_param \"--release-id\" \"${RELEASE_ID}\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"INPUT_ISO\u003d${ISO_DIR}/${RELEASE_ID}/bootimage.iso"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"trap cleanup EXIT"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"896eda9b_2e2ff882","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":48},"updated":"2022-02-15 22:41:46.000000000","message":"I don\u0027t think you need this and all the mount/unmount business.\n\nAll the info you need is under\n/www/pages/feed/rel-sw-version/  (for 21.12 and below)\n/var/www/pages/feed/rel-sw-version/ (above 21.12)","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"check_required_param \"--release-id\" \"${RELEASE_ID}\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"INPUT_ISO\u003d${ISO_DIR}/${RELEASE_ID}/bootimage.iso"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"trap cleanup EXIT"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"ac706ac4_ae798407","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":48},"in_reply_to":"896eda9b_2e2ff882","updated":"2022-02-16 17:27:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"f20ad78de3b0e537b8494e4234e01bc31eeaf70b","unresolved":true,"context_lines":[{"line_number":231,"context_line":"ls ${RPM_DIR} \u003e ${TEMPDIR}/package_list.txt"},{"line_number":232,"context_line":"RPM_LIST\u003d${TEMPDIR}/package_list.txt"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"log \"${RPM_LIST}\""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"if [ ! -f \"${RPM_LIST}\" ]; then"},{"line_number":237,"context_line":"    log \"${RPM_LIST} not created. Abort\""}],"source_content_type":"text/x-sh","patch_set":24,"id":"4232da05_8fca18ac","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":17},"updated":"2022-02-16 01:03:17.000000000","message":"Is this log necessary?","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"70b18570f2218d8b3daac60e1f4559e82d66664e","unresolved":false,"context_lines":[{"line_number":231,"context_line":"ls ${RPM_DIR} \u003e ${TEMPDIR}/package_list.txt"},{"line_number":232,"context_line":"RPM_LIST\u003d${TEMPDIR}/package_list.txt"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"log \"${RPM_LIST}\""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"if [ ! -f \"${RPM_LIST}\" ]; then"},{"line_number":237,"context_line":"    log \"${RPM_LIST} not created. Abort\""}],"source_content_type":"text/x-sh","patch_set":24,"id":"06295e57_ef1d5c6a","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":17},"in_reply_to":"4232da05_8fca18ac","updated":"2022-02-16 17:27:59.000000000","message":"Done","commit_id":"a5035b54760ac8ff23cd19faed05b54c92a78d81"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"declare LOG_TAG\u003d$(basename $0)"},{"line_number":15,"context_line":"function log_error {"},{"line_number":16,"context_line":"    logger -i -s -t ${LOG_TAG} -- \"$@\""},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function log {"}],"source_content_type":"text/x-sh","patch_set":29,"id":"3f29fd7f_eaa8b87f","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":37},"updated":"2022-02-16 20:53:39.000000000","message":"perhaps \"ERROR: $@\"\nand exit -1 here?\n\nI don\u0027t see a difference between log and log_error","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"declare LOG_TAG\u003d$(basename $0)"},{"line_number":15,"context_line":"function log_error {"},{"line_number":16,"context_line":"    logger -i -s -t ${LOG_TAG} -- \"$@\""},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function log {"}],"source_content_type":"text/x-sh","patch_set":29,"id":"e4a8cd4f_98137a13","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":37},"in_reply_to":"3f29fd7f_eaa8b87f","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"16b1800d5fa7fee889f6ba8e96d937c3097146ca","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"declare LOG_TAG\u003d$(basename $0)"},{"line_number":15,"context_line":"function log_error {"},{"line_number":16,"context_line":"    logger -i -s -t ${LOG_TAG} -- \"$@\""},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function log {"}],"source_content_type":"text/x-sh","patch_set":29,"id":"aaedf379_eb878deb","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":37},"in_reply_to":"e4a8cd4f_98137a13","updated":"2022-02-16 22:56:06.000000000","message":"Added exit -1 to the log_error as well.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":24,"context_line":"declare RPM_LIST\u003d"},{"line_number":25,"context_line":"declare RPM_COMMON_LIST_NAME\u003d\"common_packages.txt\""},{"line_number":26,"context_line":"declare RPM_COMMON_LIST\u003d"},{"line_number":27,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":28,"context_line":"declare RPM_DIR\u003d"},{"line_number":29,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy\""},{"line_number":30,"context_line":"declare TEMPDIR\u003d"}],"source_content_type":"text/x-sh","patch_set":29,"id":"6e428760_a202d43b","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":27},"updated":"2022-02-16 20:53:39.000000000","message":"RPM_PACKAGE_LIST_DIR","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":24,"context_line":"declare RPM_LIST\u003d"},{"line_number":25,"context_line":"declare RPM_COMMON_LIST_NAME\u003d\"common_packages.txt\""},{"line_number":26,"context_line":"declare RPM_COMMON_LIST\u003d"},{"line_number":27,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":28,"context_line":"declare RPM_DIR\u003d"},{"line_number":29,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy\""},{"line_number":30,"context_line":"declare TEMPDIR\u003d"}],"source_content_type":"text/x-sh","patch_set":29,"id":"e7e86805_59f3355b","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":27},"in_reply_to":"6e428760_a202d43b","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    logger -i -s -t ${LOG_TAG} -- \"$@\""},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"declare RELEASE_ID\u003d"},{"line_number":24,"context_line":"declare RPM_LIST\u003d"},{"line_number":25,"context_line":"declare RPM_COMMON_LIST_NAME\u003d\"common_packages.txt\""},{"line_number":26,"context_line":"declare RPM_COMMON_LIST\u003d"},{"line_number":27,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":28,"context_line":"declare RPM_DIR\u003d"},{"line_number":29,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy\""},{"line_number":30,"context_line":"declare TEMPDIR\u003d"},{"line_number":31,"context_line":"declare CURRENT_PKGS\u003d"},{"line_number":32,"context_line":"declare PREV_PKGS\u003d"},{"line_number":33,"context_line":"declare FEED_DIR\u003d"},{"line_number":34,"context_line":"declare COMPS_FILE\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"function usage {"},{"line_number":37,"context_line":"    cat \u003c\u003cENDUSAGE"}],"source_content_type":"text/x-sh","patch_set":29,"id":"cf1a0b7d_24518042","line":34,"range":{"start_line":23,"start_character":0,"end_line":34,"end_character":19},"updated":"2022-02-16 20:53:39.000000000","message":"Not sure why you need to declare all of these upfront but either sort them alphabetically or group the ones with values together.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    logger -i -s -t ${LOG_TAG} -- \"$@\""},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"declare RELEASE_ID\u003d"},{"line_number":24,"context_line":"declare RPM_LIST\u003d"},{"line_number":25,"context_line":"declare RPM_COMMON_LIST_NAME\u003d\"common_packages.txt\""},{"line_number":26,"context_line":"declare RPM_COMMON_LIST\u003d"},{"line_number":27,"context_line":"declare RPM_COMMON_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":28,"context_line":"declare RPM_DIR\u003d"},{"line_number":29,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy\""},{"line_number":30,"context_line":"declare TEMPDIR\u003d"},{"line_number":31,"context_line":"declare CURRENT_PKGS\u003d"},{"line_number":32,"context_line":"declare PREV_PKGS\u003d"},{"line_number":33,"context_line":"declare FEED_DIR\u003d"},{"line_number":34,"context_line":"declare COMPS_FILE\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"function usage {"},{"line_number":37,"context_line":"    cat \u003c\u003cENDUSAGE"}],"source_content_type":"text/x-sh","patch_set":29,"id":"b45259c5_21429e02","line":34,"range":{"start_line":23,"start_character":0,"end_line":34,"end_character":19},"in_reply_to":"cf1a0b7d_24518042","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"function usage {"},{"line_number":37,"context_line":"    cat \u003c\u003cENDUSAGE"},{"line_number":38,"context_line":"Description: Sets up a prestage shared directory that:"},{"line_number":39,"context_line":"   - Packages directory containing a list of new RPMs to download"},{"line_number":40,"context_line":"   - File containing a list of unchanged RPMs to copy locally on the target"},{"line_number":41,"context_line":"   - Packages comps.xml file includes a list of all the RPMs that need to be"}],"source_content_type":"text/x-sh","patch_set":29,"id":"d7cbf52a_602d21e5","line":38,"range":{"start_line":38,"start_character":49,"end_line":38,"end_character":53},"updated":"2022-02-16 20:53:39.000000000","message":"that contains the following","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"function usage {"},{"line_number":37,"context_line":"    cat \u003c\u003cENDUSAGE"},{"line_number":38,"context_line":"Description: Sets up a prestage shared directory that:"},{"line_number":39,"context_line":"   - Packages directory containing a list of new RPMs to download"},{"line_number":40,"context_line":"   - File containing a list of unchanged RPMs to copy locally on the target"},{"line_number":41,"context_line":"   - Packages comps.xml file includes a list of all the RPMs that need to be"}],"source_content_type":"text/x-sh","patch_set":29,"id":"2c59ed40_ea71d9c1","line":38,"range":{"start_line":38,"start_character":49,"end_line":38,"end_character":53},"in_reply_to":"d7cbf52a_602d21e5","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":38,"context_line":"Description: Sets up a prestage shared directory that:"},{"line_number":39,"context_line":"   - Packages directory containing a list of new RPMs to download"},{"line_number":40,"context_line":"   - File containing a list of unchanged RPMs to copy locally on the target"},{"line_number":41,"context_line":"   - Packages comps.xml file includes a list of all the RPMs that need to be"},{"line_number":42,"context_line":"     downloaded by the subcloud and the repodata."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Mandatory parameters for setup:"},{"line_number":45,"context_line":"    --release-id              Specify the release version"}],"source_content_type":"text/x-sh","patch_set":29,"id":"c93847c6_5797fbef","line":42,"range":{"start_line":41,"start_character":5,"end_line":42,"end_character":48},"updated":"2022-02-16 20:53:39.000000000","message":"This is not an accurate description of the comps file. It defines how the packages are bundled and is used to generate repodata I think. Please check with Scott/Eric.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Description: Sets up a prestage shared directory that:"},{"line_number":39,"context_line":"   - Packages directory containing a list of new RPMs to download"},{"line_number":40,"context_line":"   - File containing a list of unchanged RPMs to copy locally on the target"},{"line_number":41,"context_line":"   - Packages comps.xml file includes a list of all the RPMs that need to be"},{"line_number":42,"context_line":"     downloaded by the subcloud and the repodata."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Mandatory parameters for setup:"},{"line_number":45,"context_line":"    --release-id              Specify the release version"}],"source_content_type":"text/x-sh","patch_set":29,"id":"4b9770eb_f3d33b9f","line":42,"range":{"start_line":41,"start_character":5,"end_line":42,"end_character":48},"in_reply_to":"c93847c6_5797fbef","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":100,"context_line":"        exit -1"},{"line_number":101,"context_line":"    fi"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # generate the list of common files"},{"line_number":104,"context_line":"    RPM_COMMON_LIST\u003d${PRESTAGE_SHARED_DIR}/${RPM_COMMON_LIST_NAME}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    comm -12 ${CURRENT_PKGS} ${PREV_PKGS} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"}],"source_content_type":"text/x-sh","patch_set":29,"id":"5d948eea_511d396c","line":103,"range":{"start_line":103,"start_character":27,"end_line":103,"end_character":39},"updated":"2022-02-16 20:53:39.000000000","message":"unchanged packages between previous and current releases.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        exit -1"},{"line_number":101,"context_line":"    fi"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # generate the list of common files"},{"line_number":104,"context_line":"    RPM_COMMON_LIST\u003d${PRESTAGE_SHARED_DIR}/${RPM_COMMON_LIST_NAME}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    comm -12 ${CURRENT_PKGS} ${PREV_PKGS} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"}],"source_content_type":"text/x-sh","patch_set":29,"id":"7241333d_e326e48a","line":103,"range":{"start_line":103,"start_character":27,"end_line":103,"end_character":39},"in_reply_to":"5d948eea_511d396c","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    comm -12 ${CURRENT_PKGS} ${PREV_PKGS} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    cat ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM} | awk \u0027{print $1}\u0027 \u003e\u003e ${RPM_COMMON_LIST}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":111,"context_line":"        log \"Unable to create the common list of packages. Abort\""}],"source_content_type":"text/x-sh","patch_set":29,"id":"843e792d_9e671455","line":108,"range":{"start_line":108,"start_character":70,"end_line":108,"end_character":72},"updated":"2022-02-16 20:53:39.000000000","message":"redirect (\u003e) not redirect and concatenate (\u003e\u003e)","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    comm -12 ${CURRENT_PKGS} ${PREV_PKGS} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    cat ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM} | awk \u0027{print $1}\u0027 \u003e\u003e ${RPM_COMMON_LIST}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":111,"context_line":"        log \"Unable to create the common list of packages. Abort\""}],"source_content_type":"text/x-sh","patch_set":29,"id":"9cc8e497_4b269fa1","line":108,"range":{"start_line":108,"start_character":70,"end_line":108,"end_character":72},"in_reply_to":"843e792d_9e671455","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    # copy the rpms to the Packages directory"},{"line_number":125,"context_line":"    rsync -a --filter\u003d\"merge ${EXCLUDE_LIST}\" ${RPM_DIR} ${PRESTAGE_SHARED_DIR}/"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":128,"context_line":"        log_error \"Unable to copy packages to ${PRESTAGE_SHARED_DIR}\""},{"line_number":129,"context_line":"    fi"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # copy over the comps.xml file"},{"line_number":132,"context_line":"    rsync ${COMPS_FILE} ${PRESTAGE_SHARED_DIR}"},{"line_number":133,"context_line":"    if [ $? -ne 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":29,"id":"97594fe8_47919a3e","line":130,"range":{"start_line":127,"start_character":0,"end_line":130,"end_character":0},"updated":"2022-02-16 20:53:39.000000000","message":"need to exit with error.\n\nConsider adding exit statement to the log_error function, not where you log as you may forget.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    # copy the rpms to the Packages directory"},{"line_number":125,"context_line":"    rsync -a --filter\u003d\"merge ${EXCLUDE_LIST}\" ${RPM_DIR} ${PRESTAGE_SHARED_DIR}/"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":128,"context_line":"        log_error \"Unable to copy packages to ${PRESTAGE_SHARED_DIR}\""},{"line_number":129,"context_line":"    fi"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # copy over the comps.xml file"},{"line_number":132,"context_line":"    rsync ${COMPS_FILE} ${PRESTAGE_SHARED_DIR}"},{"line_number":133,"context_line":"    if [ $? -ne 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":29,"id":"c4d66048_67be3dac","line":130,"range":{"start_line":127,"start_character":0,"end_line":130,"end_character":0},"in_reply_to":"97594fe8_47919a3e","updated":"2022-02-16 21:41:16.000000000","message":"having the exit outside of the error function is the norm in the some of the other bash files.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":129,"context_line":"    fi"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # copy over the comps.xml file"},{"line_number":132,"context_line":"    rsync ${COMPS_FILE} ${PRESTAGE_SHARED_DIR}"},{"line_number":133,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":134,"context_line":"        log_error \"Unable to copy ${COMPS_FILE} to ${PRESTAGE_SHARED_DIR}\""},{"line_number":135,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":29,"id":"b19b100d_1cb4b757","line":132,"range":{"start_line":132,"start_character":4,"end_line":132,"end_character":46},"updated":"2022-02-16 20:53:39.000000000","message":"Use cp","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    fi"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # copy over the comps.xml file"},{"line_number":132,"context_line":"    rsync ${COMPS_FILE} ${PRESTAGE_SHARED_DIR}"},{"line_number":133,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":134,"context_line":"        log_error \"Unable to copy ${COMPS_FILE} to ${PRESTAGE_SHARED_DIR}\""},{"line_number":135,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":29,"id":"9e8f82f5_d6e3091b","line":132,"range":{"start_line":132,"start_character":4,"end_line":132,"end_character":46},"in_reply_to":"b19b100d_1cb4b757","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # copy over the comps.xml file"},{"line_number":132,"context_line":"    rsync ${COMPS_FILE} ${PRESTAGE_SHARED_DIR}"},{"line_number":133,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":134,"context_line":"        log_error \"Unable to copy ${COMPS_FILE} to ${PRESTAGE_SHARED_DIR}\""},{"line_number":135,"context_line":"    fi"},{"line_number":136,"context_line":"}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# main script goes here."}],"source_content_type":"text/x-sh","patch_set":29,"id":"05a29d94_3eece4e9","line":135,"range":{"start_line":133,"start_character":4,"end_line":135,"end_character":6},"updated":"2022-02-16 20:53:39.000000000","message":"same here","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # copy over the comps.xml file"},{"line_number":132,"context_line":"    rsync ${COMPS_FILE} ${PRESTAGE_SHARED_DIR}"},{"line_number":133,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":134,"context_line":"        log_error \"Unable to copy ${COMPS_FILE} to ${PRESTAGE_SHARED_DIR}\""},{"line_number":135,"context_line":"    fi"},{"line_number":136,"context_line":"}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# main script goes here."}],"source_content_type":"text/x-sh","patch_set":29,"id":"6d8d372f_e54d4674","line":135,"range":{"start_line":133,"start_character":4,"end_line":135,"end_character":6},"in_reply_to":"05a29d94_3eece4e9","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"PRESTAGE_SHARED_DIR\u003d\"${PRESTAGE_DIR_PREFIX}/${RELEASE_ID}/prestage/shared\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -f \"${PRESTAGE_SHARED_DIR}/.${RELEASE_ID}\" ]; then"},{"line_number":149,"context_line":"    log_error \"The prestage shared content has already been created.\""},{"line_number":150,"context_line":"    exit 0"},{"line_number":151,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":29,"id":"d7d3041c_e425ccc8","line":148,"range":{"start_line":148,"start_character":33,"end_line":148,"end_character":46},"updated":"2022-02-16 20:53:39.000000000","message":".prestage_prepation_completed\n\nThe release_id is already part of the path","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"PRESTAGE_SHARED_DIR\u003d\"${PRESTAGE_DIR_PREFIX}/${RELEASE_ID}/prestage/shared\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -f \"${PRESTAGE_SHARED_DIR}/.${RELEASE_ID}\" ]; then"},{"line_number":149,"context_line":"    log_error \"The prestage shared content has already been created.\""},{"line_number":150,"context_line":"    exit 0"},{"line_number":151,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":29,"id":"a1cb1bb8_f8fb9519","line":148,"range":{"start_line":148,"start_character":33,"end_line":148,"end_character":46},"in_reply_to":"d7d3041c_e425ccc8","updated":"2022-02-16 21:41:16.000000000","message":"This is an addition in response to an earlier comment - to not do this activity if it has already been done before. Example: if N+1 is 21.12, we create a file .21.12 in the shared directory; if that file exists, then we just exit.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":146,"context_line":"PRESTAGE_SHARED_DIR\u003d\"${PRESTAGE_DIR_PREFIX}/${RELEASE_ID}/prestage/shared\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -f \"${PRESTAGE_SHARED_DIR}/.${RELEASE_ID}\" ]; then"},{"line_number":149,"context_line":"    log_error \"The prestage shared content has already been created.\""},{"line_number":150,"context_line":"    exit 0"},{"line_number":151,"context_line":"fi"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"c0d0ca04_34bbf25d","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":13},"updated":"2022-02-16 20:53:39.000000000","message":"This is not an error","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":146,"context_line":"PRESTAGE_SHARED_DIR\u003d\"${PRESTAGE_DIR_PREFIX}/${RELEASE_ID}/prestage/shared\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -f \"${PRESTAGE_SHARED_DIR}/.${RELEASE_ID}\" ]; then"},{"line_number":149,"context_line":"    log_error \"The prestage shared content has already been created.\""},{"line_number":150,"context_line":"    exit 0"},{"line_number":151,"context_line":"fi"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"61668653_bc9bb31c","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":13},"in_reply_to":"c0d0ca04_34bbf25d","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"RPM_DIR\u003d\"${FEED_DIR}/Packages\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"CURRENT_PKGS\u003d$(ls ${RPM_COMMON_LIST_DIR}/*packages_list.txt)"},{"line_number":159,"context_line":"PREV_PKGS\u003d$(ls ${PRESTAGE_SHARED_DIR}/*packages_list.txt)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"CURRENT_PKGS_COUNT\u003d$(echo ${CURRENT_PKGS} | wc -l)"}],"source_content_type":"text/x-sh","patch_set":29,"id":"e83e9bd1_b0c7ca97","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":12},"updated":"2022-02-16 20:53:39.000000000","message":"inaccurate name, CURRENT_PACKAGE_LIST_FILE","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"RPM_DIR\u003d\"${FEED_DIR}/Packages\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"CURRENT_PKGS\u003d$(ls ${RPM_COMMON_LIST_DIR}/*packages_list.txt)"},{"line_number":159,"context_line":"PREV_PKGS\u003d$(ls ${PRESTAGE_SHARED_DIR}/*packages_list.txt)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"CURRENT_PKGS_COUNT\u003d$(echo ${CURRENT_PKGS} | wc -l)"}],"source_content_type":"text/x-sh","patch_set":29,"id":"6e08b016_aa0ab00c","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":12},"in_reply_to":"e83e9bd1_b0c7ca97","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":156,"context_line":"RPM_DIR\u003d\"${FEED_DIR}/Packages\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"CURRENT_PKGS\u003d$(ls ${RPM_COMMON_LIST_DIR}/*packages_list.txt)"},{"line_number":159,"context_line":"PREV_PKGS\u003d$(ls ${PRESTAGE_SHARED_DIR}/*packages_list.txt)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"CURRENT_PKGS_COUNT\u003d$(echo ${CURRENT_PKGS} | wc -l)"},{"line_number":162,"context_line":"if [ ${CURRENT_PKGS_COUNT} -ne 1 ]; then"}],"source_content_type":"text/x-sh","patch_set":29,"id":"009e5712_77293c43","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":9},"updated":"2022-02-16 20:53:39.000000000","message":"PREVIOUS_PACKAGE_LIST_FILE","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":156,"context_line":"RPM_DIR\u003d\"${FEED_DIR}/Packages\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"CURRENT_PKGS\u003d$(ls ${RPM_COMMON_LIST_DIR}/*packages_list.txt)"},{"line_number":159,"context_line":"PREV_PKGS\u003d$(ls ${PRESTAGE_SHARED_DIR}/*packages_list.txt)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"CURRENT_PKGS_COUNT\u003d$(echo ${CURRENT_PKGS} | wc -l)"},{"line_number":162,"context_line":"if [ ${CURRENT_PKGS_COUNT} -ne 1 ]; then"}],"source_content_type":"text/x-sh","patch_set":29,"id":"756fd5a3_d06e43ef","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":9},"in_reply_to":"009e5712_77293c43","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"CURRENT_PKGS_COUNT\u003d$(echo ${CURRENT_PKGS} | wc -l)"},{"line_number":162,"context_line":"if [ ${CURRENT_PKGS_COUNT} -ne 1 ]; then"},{"line_number":163,"context_line":"    logger_error \"No Unique packages list found at ${RPM_COMMON_LIST_DIR}\""},{"line_number":164,"context_line":"    exit -1"},{"line_number":165,"context_line":"fi"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"c89cc0af_17ce6561","line":163,"range":{"start_line":163,"start_character":17,"end_line":163,"end_character":74},"updated":"2022-02-16 20:53:39.000000000","message":"Could just say the file is empty","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"CURRENT_PKGS_COUNT\u003d$(echo ${CURRENT_PKGS} | wc -l)"},{"line_number":162,"context_line":"if [ ${CURRENT_PKGS_COUNT} -ne 1 ]; then"},{"line_number":163,"context_line":"    logger_error \"No Unique packages list found at ${RPM_COMMON_LIST_DIR}\""},{"line_number":164,"context_line":"    exit -1"},{"line_number":165,"context_line":"fi"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"d96a4ccc_efb575f9","line":163,"range":{"start_line":163,"start_character":17,"end_line":163,"end_character":74},"in_reply_to":"c89cc0af_17ce6561","updated":"2022-02-16 21:41:16.000000000","message":"Either you have no files or more than one file.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"16b1800d5fa7fee889f6ba8e96d937c3097146ca","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"CURRENT_PKGS_COUNT\u003d$(echo ${CURRENT_PKGS} | wc -l)"},{"line_number":162,"context_line":"if [ ${CURRENT_PKGS_COUNT} -ne 1 ]; then"},{"line_number":163,"context_line":"    logger_error \"No Unique packages list found at ${RPM_COMMON_LIST_DIR}\""},{"line_number":164,"context_line":"    exit -1"},{"line_number":165,"context_line":"fi"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"e6d0a3c2_5232fd06","line":163,"range":{"start_line":163,"start_character":17,"end_line":163,"end_character":74},"in_reply_to":"d96a4ccc_efb575f9","updated":"2022-02-16 22:56:06.000000000","message":"Added check for empty file as well.","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"77f01b41993eef1e5ffcce0f27c31004fdf6b1b3","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"PREV_PKGS_COUNT\u003d$(echo ${PREV_PKGS} | wc -l)"},{"line_number":168,"context_line":"if [ ${PREV_PKGS_COUNT} -ne 1 ]; then"},{"line_number":169,"context_line":"    logger_error \"No Unique packages list found at ${PRESHARED_SHARED_DIR}\""},{"line_number":170,"context_line":"    exit -1"},{"line_number":171,"context_line":"fi"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"05410738_41b745ac","line":169,"range":{"start_line":169,"start_character":53,"end_line":169,"end_character":73},"updated":"2022-02-16 20:53:39.000000000","message":"undefined variable","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"9de821e5902c68b1eebf507e27c92a450dd4eb03","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"PREV_PKGS_COUNT\u003d$(echo ${PREV_PKGS} | wc -l)"},{"line_number":168,"context_line":"if [ ${PREV_PKGS_COUNT} -ne 1 ]; then"},{"line_number":169,"context_line":"    logger_error \"No Unique packages list found at ${PRESHARED_SHARED_DIR}\""},{"line_number":170,"context_line":"    exit -1"},{"line_number":171,"context_line":"fi"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"1be0fc7d_47ac9f9b","line":169,"range":{"start_line":169,"start_character":53,"end_line":169,"end_character":73},"in_reply_to":"05410738_41b745ac","updated":"2022-02-16 21:41:16.000000000","message":"Done","commit_id":"32fc298ee0ec406b6740dc6f6584f7ae905977e8"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"8bcba894b4ca231d65d427d8f9709d5597a7064a","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"declare RPM_COMMON_LIST_NAME\u003d\"common_packages.txt\""},{"line_number":37,"context_line":"declare RPM_PACKAGE_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":38,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"function usage {"},{"line_number":41,"context_line":"    cat \u003c\u003cENDUSAGE"}],"source_content_type":"text/x-sh","patch_set":32,"id":"a3bca8ef_d4878173","line":38,"range":{"start_line":38,"start_character":43,"end_line":38,"end_character":49},"updated":"2022-02-17 19:25:48.000000000","message":"What creates this directory ? I don\u0027t recall seeing this in the current release.\n\nif created elsewhere then please add a check for its presence and error out as that would indicate pre-requisite operations were not complete.","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"b05cceda319c805685424a835529c76dc8d7395c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"declare RPM_COMMON_LIST_NAME\u003d\"common_packages.txt\""},{"line_number":37,"context_line":"declare RPM_PACKAGE_LIST_DIR\u003d\"/usr/local/share/pkg-lists\""},{"line_number":38,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"function usage {"},{"line_number":41,"context_line":"    cat \u003c\u003cENDUSAGE"}],"source_content_type":"text/x-sh","patch_set":32,"id":"f36d7e69_877ab27e","line":38,"range":{"start_line":38,"start_character":43,"end_line":38,"end_character":49},"in_reply_to":"a3bca8ef_d4878173","updated":"2022-02-17 19:30:24.000000000","message":"It is created before this script is invoked.","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"f8d31a746fdbbc838e513daee0fe8685c763a147","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        log_error \"Package list for previous release (${PREVIOUS_PACKAGE_LIST_FILE}) does not exist. Abort\""},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    # generate the list unchanged packages between previous and current releases. "},{"line_number":105,"context_line":"    RPM_COMMON_LIST\u003d${PRESTAGE_SHARED_DIR}/${RPM_COMMON_LIST_NAME}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    comm -12 ${CURRENT_PACKAGE_LIST_FILE} ${PREVIOUS_PACKAGE_LIST_FILE} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"}],"source_content_type":"text/x-sh","patch_set":32,"id":"1d79c4e2_ed76b6db","line":104,"range":{"start_line":104,"start_character":81,"end_line":104,"end_character":82},"updated":"2022-02-17 14:19:22.000000000","message":"nit: extra space","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"b05cceda319c805685424a835529c76dc8d7395c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        log_error \"Package list for previous release (${PREVIOUS_PACKAGE_LIST_FILE}) does not exist. Abort\""},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    # generate the list unchanged packages between previous and current releases. "},{"line_number":105,"context_line":"    RPM_COMMON_LIST\u003d${PRESTAGE_SHARED_DIR}/${RPM_COMMON_LIST_NAME}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    comm -12 ${CURRENT_PACKAGE_LIST_FILE} ${PREVIOUS_PACKAGE_LIST_FILE} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"}],"source_content_type":"text/x-sh","patch_set":32,"id":"28ba4d08_ea0ace7b","line":104,"range":{"start_line":104,"start_character":81,"end_line":104,"end_character":82},"in_reply_to":"1d79c4e2_ed76b6db","updated":"2022-02-17 19:30:24.000000000","message":"Done","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"f8d31a746fdbbc838e513daee0fe8685c763a147","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    comm -12 ${CURRENT_PACKAGE_LIST_FILE} ${PREVIOUS_PACKAGE_LIST_FILE} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    cat ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM} | awk \u0027{print $1}\u0027 \u003e ${RPM_COMMON_LIST}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":112,"context_line":"        log_error \"Unable to create the common list of packages. Abort\""}],"source_content_type":"text/x-sh","patch_set":32,"id":"74c0aadf_82597c8b","line":109,"updated":"2022-02-17 14:19:22.000000000","message":"does this method need to be made reentrant ? In such case, it should ensure the temporary files are removed beforehand.","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3a95c8885f52e29cc28dfdee5affed5ce17baea7","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    comm -12 ${CURRENT_PACKAGE_LIST_FILE} ${PREVIOUS_PACKAGE_LIST_FILE} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    cat ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM} | awk \u0027{print $1}\u0027 \u003e ${RPM_COMMON_LIST}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":112,"context_line":"        log_error \"Unable to create the common list of packages. Abort\""}],"source_content_type":"text/x-sh","patch_set":32,"id":"6a9a51ad_307bb16e","line":109,"in_reply_to":"0ef09eb5_f6aad02b","updated":"2022-02-17 20:59:20.000000000","message":"ok, that\u0027s enforced by dcmanager also.","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"b05cceda319c805685424a835529c76dc8d7395c","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    comm -12 ${CURRENT_PACKAGE_LIST_FILE} ${PREVIOUS_PACKAGE_LIST_FILE} \u003e ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    cat ${TEMPDIR}/${TEMP_COMMON_PKGS_WITH_CHKSUM} | awk \u0027{print $1}\u0027 \u003e ${RPM_COMMON_LIST}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":112,"context_line":"        log_error \"Unable to create the common list of packages. Abort\""}],"source_content_type":"text/x-sh","patch_set":32,"id":"0ef09eb5_f6aad02b","line":109,"in_reply_to":"74c0aadf_82597c8b","updated":"2022-02-17 19:30:24.000000000","message":"No, its not re-entrant.","commit_id":"81ee81ebfc69b1955251a2ccf8302c8ee05a1810"}],"utilities/platform-util/scripts/prev_package_checksums.txt":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4bcbe4d582437614a6fbcc86175eef90f9626471","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"6ac04f8f_1c77d85d","updated":"2022-02-15 00:29:10.000000000","message":"Please remove","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5e0cff20a3e02fc1fe75a71753d1f5fb5be0d83b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1945fdb9_d31cf1f9","in_reply_to":"6ac04f8f_1c77d85d","updated":"2022-02-16 02:17:37.000000000","message":"Done","commit_id":"291f2f8f26059558d3b09d537144682791e7552c"}],"utilities/platform-util/scripts/rpm-list-creator.sh":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4cf243c9da784e269de5183276eb5bf309f61207","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":5,"id":"a7483c1e_a1db2c85","line":1,"updated":"2022-02-08 18:46:36.000000000","message":"This script should be renamed to prepare-prestage-packages.sh","commit_id":"4e7c355a21008f4a3c5564ea35c1f1b8e7af639d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"da3163cf0a912002c3fa40812de07d05da9f15e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":5,"id":"40fbba0c_38f68d8e","line":1,"in_reply_to":"a7483c1e_a1db2c85","updated":"2022-02-08 21:45:36.000000000","message":"Done","commit_id":"4e7c355a21008f4a3c5564ea35c1f1b8e7af639d"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4cf243c9da784e269de5183276eb5bf309f61207","unresolved":true,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Common bash utility functions for StarlingX "},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"source $(dirname $0)/stx-iso-utils.sh"}],"source_content_type":"text/x-sh","patch_set":5,"id":"b7c87f83_9ef2630c","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":46},"updated":"2022-02-08 18:46:36.000000000","message":"Need description","commit_id":"4e7c355a21008f4a3c5564ea35c1f1b8e7af639d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"29168d15afebafe25853406e6a6a12f68f6faa5d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Common bash utility functions for StarlingX "},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"source $(dirname $0)/stx-iso-utils.sh"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ed65d7c6_021bab1b","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":46},"in_reply_to":"b7c87f83_9ef2630c","updated":"2022-02-09 19:51:04.000000000","message":"Done","commit_id":"4e7c355a21008f4a3c5564ea35c1f1b8e7af639d"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"4cf243c9da784e269de5183276eb5bf309f61207","unresolved":true,"context_lines":[{"line_number":24,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy/\""},{"line_number":25,"context_line":"declare SHARED_COMMON_RPM_LIST\u003d\"unchanged_packages.txt\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function usage {"},{"line_number":28,"context_line":"    cat \u003c\u003cENDUSAGE"},{"line_number":29,"context_line":"Description: Sets up a prestage shared directory that includes a list of"},{"line_number":30,"context_line":"common RPMs, a list of RPMs to download, a directory (Packages) that has"},{"line_number":31,"context_line":"all the RPMs that need to be downloaded by the subcloud and the repodata."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Mandatory parameters for setup:"},{"line_number":34,"context_line":"    -i,--id                   Specify the release id for the current release"},{"line_number":35,"context_line":"    -d,--rpm-dir              Specify the location of the rpms for the new release"},{"line_number":36,"context_line":"    -c,--common-rpm-list      Specify the path for the list of common RPMs (full"},{"line_number":37,"context_line":"                              path including file name)"},{"line_number":38,"context_line":"    -r,--rpm-list             Specify the path for the list of all RPMs (full path"},{"line_number":39,"context_line":"                              including file name)"},{"line_number":40,"context_line":"    -l,--rpm-download-list    Specify the name of the download list (will be created"},{"line_number":41,"context_line":"                              in the prestaging directory)"},{"line_number":42,"context_line":"    -h                        Print this help page"},{"line_number":43,"context_line":"ENDUSAGE"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# Parse command line arguments"}],"source_content_type":"text/x-sh","patch_set":5,"id":"b1c442fd_46ec5016","line":44,"range":{"start_line":27,"start_character":0,"end_line":44,"end_character":1},"updated":"2022-02-08 18:46:36.000000000","message":"I don\u0027t think we need all of these parameters. The only user of this script (dcmanager) will provide the software version as the only input which is used to create and populate the shared prestage directory:\n\n/opt/platform/deploy/\u003csw-version\u003e/prestage/shared. \n\nThe consumer of the content in this shared directory is the prestage_sw_packages playbook. It expects 2 sub-directories Packages and repodata and one file common_packages.txt under shared.\n\nThe Packages directory should contain only RPMs that need to be downloaded from the system controller. The repodata need to be regenerated based on the new RPMs and the common RPMs. Perhaps gen-bootloader-iso.sh can be updated to generate the required content for prestage shared directory and this script calls gen-bootloader-iso.sh with --prestage-data (or --shared-data-only) option.","commit_id":"4e7c355a21008f4a3c5564ea35c1f1b8e7af639d"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"6b8a5c9fa0d95c3a1fd991f9ecf1f0d09c456409","unresolved":false,"context_lines":[{"line_number":24,"context_line":"declare PRESTAGE_DIR_PREFIX\u003d\"/opt/platform/deploy/\""},{"line_number":25,"context_line":"declare SHARED_COMMON_RPM_LIST\u003d\"unchanged_packages.txt\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function usage {"},{"line_number":28,"context_line":"    cat \u003c\u003cENDUSAGE"},{"line_number":29,"context_line":"Description: Sets up a prestage shared directory that includes a list of"},{"line_number":30,"context_line":"common RPMs, a list of RPMs to download, a directory (Packages) that has"},{"line_number":31,"context_line":"all the RPMs that need to be downloaded by the subcloud and the repodata."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Mandatory parameters for setup:"},{"line_number":34,"context_line":"    -i,--id                   Specify the release id for the current release"},{"line_number":35,"context_line":"    -d,--rpm-dir              Specify the location of the rpms for the new release"},{"line_number":36,"context_line":"    -c,--common-rpm-list      Specify the path for the list of common RPMs (full"},{"line_number":37,"context_line":"                              path including file name)"},{"line_number":38,"context_line":"    -r,--rpm-list             Specify the path for the list of all RPMs (full path"},{"line_number":39,"context_line":"                              including file name)"},{"line_number":40,"context_line":"    -l,--rpm-download-list    Specify the name of the download list (will be created"},{"line_number":41,"context_line":"                              in the prestaging directory)"},{"line_number":42,"context_line":"    -h                        Print this help page"},{"line_number":43,"context_line":"ENDUSAGE"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# Parse command line arguments"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f606050_076592f8","line":44,"range":{"start_line":27,"start_character":0,"end_line":44,"end_character":1},"in_reply_to":"b1c442fd_46ec5016","updated":"2022-02-09 00:14:54.000000000","message":"Removed a lot of the parameters. We are down to just two now. \nHowever, it is not easy to call gen-bootloader-iso.sh within this script - it is easier to use only the relevant functionality to achieve our purpose.","commit_id":"4e7c355a21008f4a3c5564ea35c1f1b8e7af639d"}]}