)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"9b2061248e84babdc9fe2537fd7b85064d0a79d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5c447a5_8ef4392b","updated":"2022-03-23 15:55:51.000000000","message":"Holding it back until the last two tests pass, but please go ahead and start reviewing it.","commit_id":"f863d183154b4eee474ad74f2f4233e9110c6db9"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"fed1ae8f11e3c958f47ee65502cac6e0cce17cdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2205aaa_4224f3bc","updated":"2022-04-29 18:15:24.000000000","message":"Holding it back until the last test pass, but please go ahead and start reviewing it.","commit_id":"9cae79793d6567e9cdfb424fab9ba744d42445c2"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"72df4443016dac639abed1a232c2cd323d5d68c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2dc603e2_be6e20c2","updated":"2022-05-04 21:21:29.000000000","message":"Added @Scott Little.\n","commit_id":"2838cd35bb183e220e8ec1aa06f5132da6d7f857"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"319ba419ba5b257a770d212cb08e2cb19a037d89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec4f4bac_9d2c936b","updated":"2022-05-03 16:25:38.000000000","message":"Added Davlet, as he will know if we need that line or not ","commit_id":"2838cd35bb183e220e8ec1aa06f5132da6d7f857"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"36e4da1566457053ef7fa5907c4b59ea6bb9c433","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cd84cc8e_e67aa9c1","updated":"2022-04-29 20:17:40.000000000","message":"LGTM","commit_id":"2838cd35bb183e220e8ec1aa06f5132da6d7f857"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"5f26104cac5b3e3daa0299e2a5eda1aa68d0a0cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e7e927b0_57c81dc7","updated":"2022-05-05 13:22:17.000000000","message":"removing vote while waiting for Scott to followup","commit_id":"2838cd35bb183e220e8ec1aa06f5132da6d7f857"}],"centos_pkg_dirs":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"3c0fb3f712c26fdf7076133c2ae860863ed82092","unresolved":true,"context_lines":[{"line_number":9,"context_line":"tools/engtools/hostdata-collectors"},{"line_number":10,"context_line":"utilities/build-info"},{"line_number":11,"context_line":"utilities/namespace-utils"},{"line_number":12,"context_line":"utilities/pci-irq-affinity-agent"},{"line_number":13,"context_line":"utilities/platform-util"},{"line_number":14,"context_line":"utilities/stx-extensions"},{"line_number":15,"context_line":"utilities/update-motd"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"8615e995_996a3b90","side":"PARENT","line":12,"updated":"2022-05-02 11:54:30.000000000","message":"Removing this line, removes the ability to build the centos package.\nHowever, later in this review, you are only editing the spec file rather than completely removing it.","commit_id":"4af5e3766d0c4b297bfbff7dd92634a719f02933"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"6c6f1d57ccd3f33b75489ae76082b809f38ae5fd","unresolved":true,"context_lines":[{"line_number":9,"context_line":"tools/engtools/hostdata-collectors"},{"line_number":10,"context_line":"utilities/build-info"},{"line_number":11,"context_line":"utilities/namespace-utils"},{"line_number":12,"context_line":"utilities/pci-irq-affinity-agent"},{"line_number":13,"context_line":"utilities/platform-util"},{"line_number":14,"context_line":"utilities/stx-extensions"},{"line_number":15,"context_line":"utilities/update-motd"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9ea15d62_88981a86","side":"PARENT","line":12,"in_reply_to":"1d8b510f_ff720603","updated":"2022-05-05 14:57:00.000000000","message":"I agree. The wheels are embedded within an rpm, and the rpm won\u0027t build unless named in a centos_pkg_dirs* file.  If it\u0027s containers only, it should go in centos_pkg_dirs_containers.","commit_id":"4af5e3766d0c4b297bfbff7dd92634a719f02933"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"c1d687fd9bfa2be9b05f855c5de7e645e3e6e76b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"tools/engtools/hostdata-collectors"},{"line_number":10,"context_line":"utilities/build-info"},{"line_number":11,"context_line":"utilities/namespace-utils"},{"line_number":12,"context_line":"utilities/pci-irq-affinity-agent"},{"line_number":13,"context_line":"utilities/platform-util"},{"line_number":14,"context_line":"utilities/stx-extensions"},{"line_number":15,"context_line":"utilities/update-motd"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bd6489d9_63210470","side":"PARENT","line":12,"in_reply_to":"1e7221ad_31b28ba5","updated":"2022-05-03 16:25:18.000000000","message":"OK, I will assume the code that finds the spec file to build the wheels used an alternative file to lookup the location, and does not also use this file","commit_id":"4af5e3766d0c4b297bfbff7dd92634a719f02933"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"1c995d913b39b13f0099793e689ea739c24389f7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"tools/engtools/hostdata-collectors"},{"line_number":10,"context_line":"utilities/build-info"},{"line_number":11,"context_line":"utilities/namespace-utils"},{"line_number":12,"context_line":"utilities/pci-irq-affinity-agent"},{"line_number":13,"context_line":"utilities/platform-util"},{"line_number":14,"context_line":"utilities/stx-extensions"},{"line_number":15,"context_line":"utilities/update-motd"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1e7221ad_31b28ba5","side":"PARENT","line":12,"in_reply_to":"8615e995_996a3b90","updated":"2022-05-02 19:31:12.000000000","message":"Thanks Al. Apparently this spec file is also used to build the wheels for the new container image. So I\u0027m afraid it can not be completely removed now (if we want to change only the necessary for removing the rpm/service from starlingx iso).\n\n@Heitor can provide more info if needed","commit_id":"4af5e3766d0c4b297bfbff7dd92634a719f02933"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"ae7d2e4711edf408ba60d8932394d9f81a5ed7f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"tools/engtools/hostdata-collectors"},{"line_number":10,"context_line":"utilities/build-info"},{"line_number":11,"context_line":"utilities/namespace-utils"},{"line_number":12,"context_line":"utilities/pci-irq-affinity-agent"},{"line_number":13,"context_line":"utilities/platform-util"},{"line_number":14,"context_line":"utilities/stx-extensions"},{"line_number":15,"context_line":"utilities/update-motd"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"17b27e57_fa05aced","side":"PARENT","line":12,"in_reply_to":"9ea15d62_88981a86","updated":"2022-05-09 11:00:21.000000000","message":"Reverted the removed line from pkg_dirs files as peer discussion with Scott. He pointed that moving it to the pkg_dirs_containers is not needed, as long as we keep the package here.\nThanks for pointing it out folks.","commit_id":"4af5e3766d0c4b297bfbff7dd92634a719f02933"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"c50735dc4cd02fbae4a96f66e36bb0ab2d980ba2","unresolved":true,"context_lines":[{"line_number":9,"context_line":"tools/engtools/hostdata-collectors"},{"line_number":10,"context_line":"utilities/build-info"},{"line_number":11,"context_line":"utilities/namespace-utils"},{"line_number":12,"context_line":"utilities/pci-irq-affinity-agent"},{"line_number":13,"context_line":"utilities/platform-util"},{"line_number":14,"context_line":"utilities/stx-extensions"},{"line_number":15,"context_line":"utilities/update-motd"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"d7ba52d2_c59129fa","side":"PARENT","line":12,"in_reply_to":"bd6489d9_63210470","updated":"2022-05-03 18:42:11.000000000","message":"I followed the procedure for building the wheels after removing this line and the build was successful. Also built a pci-irq-affinity-agent container image and tested it, all seemed to stay stable after the changes.","commit_id":"4af5e3766d0c4b297bfbff7dd92634a719f02933"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"8754581ca9a86085acff9c5cb11d477197581f80","unresolved":true,"context_lines":[{"line_number":9,"context_line":"tools/engtools/hostdata-collectors"},{"line_number":10,"context_line":"utilities/build-info"},{"line_number":11,"context_line":"utilities/namespace-utils"},{"line_number":12,"context_line":"utilities/pci-irq-affinity-agent"},{"line_number":13,"context_line":"utilities/platform-util"},{"line_number":14,"context_line":"utilities/stx-extensions"},{"line_number":15,"context_line":"utilities/update-motd"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1d8b510f_ff720603","side":"PARENT","line":12,"in_reply_to":"d7ba52d2_c59129fa","updated":"2022-05-04 21:22:37.000000000","message":"I\u0027m  not 100% sure, but I think the removed line should be added to a file named \"centos_pkg_dirs_containers\". Scott?","commit_id":"4af5e3766d0c4b297bfbff7dd92634a719f02933"}]}