)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"1559e2b18926a538e7da477da6268d1a33306f71","unresolved":true,"context_lines":[{"line_number":14,"context_line":"systemd-coredump[1496]: Not enough arguments passed by the kernel"},{"line_number":15,"context_line":"(6, expected 7)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit adds parameters as the code in src/coredump/coredump.c."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Test Plan:"},{"line_number":20,"context_line":"PASS: Build debian ISO and boot up with qemu."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e099483c_a3592c58","line":17,"updated":"2022-05-09 13:21:59.000000000","message":"Why make reviewers spend time to search for this reference? Please add the link to the code such as \n\n\u0027https://github.com/systemd/systemd/blob/main/src/coredump/coredump.c\u0027\n\n\nOr at least say which project the source code is in. Assuming reviewers know nothing and also have little time should motivate the writing on complete commit logs which will see your changes accepted more quickly and with less iterations.","commit_id":"c9f61ab258bd34d730bb08e397693a3f656ee03c"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"45ed3ad211fb124de40bb8be1a662c9c90abef9f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"systemd-coredump[1496]: Not enough arguments passed by the kernel"},{"line_number":15,"context_line":"(6, expected 7)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit adds parameters as the code in src/coredump/coredump.c."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Test Plan:"},{"line_number":20,"context_line":"PASS: Build debian ISO and boot up with qemu."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a0a6698_b50f1441","line":17,"in_reply_to":"e099483c_a3592c58","updated":"2022-05-10 06:30:53.000000000","message":"Thank you Mark,  I go to find the commit and add the link, also update the commit comments.","commit_id":"c9f61ab258bd34d730bb08e397693a3f656ee03c"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"d030da2a261c56c557ac9c63706a78c903607eea","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compares with v219 systemd(CentOS use this one), v247 systemd"},{"line_number":10,"context_line":"adds the parameter META_ARGV_HOSTNAME as the upstream commit:"},{"line_number":11,"context_line":"https://git.alternativebit.fr/NinjaTrappeur/Systemd/commit/f45b8015513d38ee5f7cc361db9c5b88c9aae704.patch"},{"line_number":12,"context_line":"which was integrated in the v238 systemd that need be 7 arguments."},{"line_number":13,"context_line":"But they are 6 arguments in our old config file, so there prints"},{"line_number":14,"context_line":"out the error information in kernel dmesg that caused coredump"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f0d1331_e51dbda2","line":11,"updated":"2022-05-10 15:47:21.000000000","message":"I would change this to the systemd main github repo commit link\n\nhttps://github.com/systemd/systemd/commit/f45b8015513d38ee5f7cc361db9c5b88c9aae704\n\n\nOtherwise, way more informative commit log. I can easily read this and know what failed, where you got the information to make you change and exactly what you change is. Thank you.\n\nPlease update the link then this will be an easy approval.","commit_id":"8c6efbef729eb58997babdcc10e231f9f0a1b3dc"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"5511df699ba4b2b67c9ae44a78fd2c58c66d451c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compares with v219 systemd(CentOS use this one), v247 systemd"},{"line_number":10,"context_line":"adds the parameter META_ARGV_HOSTNAME as the upstream commit:"},{"line_number":11,"context_line":"https://git.alternativebit.fr/NinjaTrappeur/Systemd/commit/f45b8015513d38ee5f7cc361db9c5b88c9aae704.patch"},{"line_number":12,"context_line":"which was integrated in the v238 systemd that need be 7 arguments."},{"line_number":13,"context_line":"But they are 6 arguments in our old config file, so there prints"},{"line_number":14,"context_line":"out the error information in kernel dmesg that caused coredump"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4a561380_c44f96fe","line":11,"in_reply_to":"3f0d1331_e51dbda2","updated":"2022-05-11 00:58:08.000000000","message":"Done","commit_id":"8c6efbef729eb58997babdcc10e231f9f0a1b3dc"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"bfeab6d01ea36f784baf111e1385412e999ce61b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"META_ARGV_RLIMIT,  /* %c: core file size soft resource limit */"},{"line_number":32,"context_line":"META_ARGV_HOSTNAME,/* %h: hostname */"},{"line_number":33,"context_line":"_META_ARGV_MAX,"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Test Plan:"},{"line_number":36,"context_line":"PASS: Build debian ISO and boot up with qemu."},{"line_number":37,"context_line":"PASS: Generate the coredump file after the fix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"88fed4d7_ff50e6f4","line":34,"updated":"2022-05-20 14:04:48.000000000","message":"You updated the text to indicate that you are including a coredump-sysctl-debian.conf which is good. But you should also add a line about the other settings. Something like.\n---\nThe coredump-sysctl-debian.conf also includes default settings for enabling coredumps by default, as expected by StarlingX.\n---","commit_id":"bd074a5a13c82c5d1c1921aea0ed338dc44c2b0e"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"92e901e1586f37406918700b5890e68b1eed1a92","unresolved":false,"context_lines":[{"line_number":31,"context_line":"META_ARGV_RLIMIT,  /* %c: core file size soft resource limit */"},{"line_number":32,"context_line":"META_ARGV_HOSTNAME,/* %h: hostname */"},{"line_number":33,"context_line":"_META_ARGV_MAX,"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Test Plan:"},{"line_number":36,"context_line":"PASS: Build debian ISO and boot up with qemu."},{"line_number":37,"context_line":"PASS: Generate the coredump file after the fix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"c34323f5_2fadc40d","line":34,"in_reply_to":"88fed4d7_ff50e6f4","updated":"2022-05-21 16:10:32.000000000","message":"Done","commit_id":"bd074a5a13c82c5d1c1921aea0ed338dc44c2b0e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34038,"name":"Waldo Acioli Falcão de Alencar","email":"WaldoAcioli.FalcaodeAlencar@windriver.com"},"change_message_id":"f455129fcb9eff835450044e66955d6db2d5c939","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8d014341_968dc1ff","updated":"2022-05-13 20:59:42.000000000","message":"Adding TCPG-510 Developers as CC","commit_id":"5cd8a445b964bfda50d31e29ae56e6972455d4f0"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"c913437db085ea6680aa323d3f5a41390d7d9116","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d926beb6_b93d6d15","updated":"2022-05-17 01:29:34.000000000","message":"Also, the core dump should produce a .xz compressed file.","commit_id":"5cd8a445b964bfda50d31e29ae56e6972455d4f0"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e5a044b652b0f9f53651c0ccb523d9deca87cc5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"86b393ff_448226b0","updated":"2022-05-16 13:01:51.000000000","message":"Change to +1 while I build a load wit this change. Need to to help debug a mtcAgent crash issue anyway.","commit_id":"5cd8a445b964bfda50d31e29ae56e6972455d4f0"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"6057d08dd6993d4d7fe9e9c9affece54a42db973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"79399cd2_30689e18","updated":"2022-05-17 01:26:57.000000000","message":"I took this update for a ride and with the author\u0027s I\u0027ve learned that the \u0027ulimit -c unlimited\u0027 command needs to run before a core dump will be generated. Once that commandis executed I got the expected coredump.\n\n[sysadmin@controller-0 sysadmin(keystone_admin)]$ ls /var/lib/systemd/coredump/\ncore.mtcAgent.0.c71b48bdb3cb42c6b4664153c150f83d.2007655.1652750224000000.zst\n\nHowever, core dumps need to be generated by default.\n\nPlease also provide the necessary change(s) required so that core dumps of segfaulted processes get produced automatically.\n\nI don\u0027t know if that change is required in this update or other so I won\u0027t -1 this update, I\u0027ll just remove my +1 for now. ","commit_id":"5cd8a445b964bfda50d31e29ae56e6972455d4f0"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"f0b65d2799a901d137c6ec781c0299d95b388e16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b9e319dd_ed940246","in_reply_to":"3b1f9cf7_a06ab54b","updated":"2022-05-18 13:49:40.000000000","message":"Thanks Jiping. My comment was directed to you as much as Eric. I will add my +1 here given your comments that the remaining work to ensure coredumps are enabled and using the right compression type are underway. Thanks.","commit_id":"5cd8a445b964bfda50d31e29ae56e6972455d4f0"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"be052beee7f1e9702af44d648a44004a6786ffd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3b1f9cf7_a06ab54b","in_reply_to":"6c81fdb4_53b31e8c","updated":"2022-05-18 06:58:15.000000000","message":"Hi, Mark\n\nThere is a epic for the compression type\nhttps://jira.wrs.com/browse/TCPG-882\n\nI do the test. Adds the following two lines in /etc/security/limits.conf.  (it is in libpam-modules deb package.)\n* soft core unlimited\n* hard core unlimited\nit can enable core dump by default.\n\nbut I did not get clear why it is enable even without run \"ulimit  -c unlimited\" in centos.","commit_id":"5cd8a445b964bfda50d31e29ae56e6972455d4f0"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"033b53f88c9a28db18f7f29794574f2f6a7fa2f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b2b6a96f_ca6b1b3d","in_reply_to":"8d014341_968dc1ff","updated":"2022-05-16 12:08:20.000000000","message":"Done","commit_id":"5cd8a445b964bfda50d31e29ae56e6972455d4f0"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"1dccef7f31ab1f65888c9e9bfc4d02499769e993","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6c81fdb4_53b31e8c","in_reply_to":"d926beb6_b93d6d15","updated":"2022-05-17 13:49:01.000000000","message":"My initial reaction was to maintain focus of the change to address the bug. Going back and reviewing the bug though I agree that this is an incomplete fix. Selection of the compression type seems to be configured in the Debian rules for systemd (the changelog mentions switching to LZ4). As for adjusting \"ulimit  -c unlimited\", should this be done as part of packaging, or better done and accounted for in the puppet/ansible realm? So I do agree the fix is incomplete but it might take changes in several places to cover the issue completely.","commit_id":"5cd8a445b964bfda50d31e29ae56e6972455d4f0"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"42a9c9d3f3eddb32e76f2c33b5741110fc18549c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2a4d2322_93d91e0f","updated":"2022-05-20 13:50:44.000000000","message":"Hi, Mark and Eric\n\nNow it enables coredump by default. please help to review it again.","commit_id":"bd074a5a13c82c5d1c1921aea0ed338dc44c2b0e"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"bfeab6d01ea36f784baf111e1385412e999ce61b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"01e51e3c_0ba04435","updated":"2022-05-20 14:04:48.000000000","message":"Sorry, one more minor change to the commit log.","commit_id":"bd074a5a13c82c5d1c1921aea0ed338dc44c2b0e"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"46e4f62cc866c48cb58619682783243d1953561d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"752b08e5_c6ebfb47","updated":"2022-05-26 07:57:50.000000000","message":"Hi, Eric\nCould you also help to review and add+2， workflow+1?","commit_id":"7d71d83678c58dcff63e6f02ce67647b67cbd3ab"}]}