)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5de10e2577344244c1da141971deb8a9fd9188e8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Girish Subramanya \u003cgirish.subramanya@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-21 18:04:25 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Error reported as Timeout from collect utility provided with a lengthy name"},{"line_number":8,"context_line":"Reject the provided name with option --n when name length exceeds 255-16"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Reported Error: operation timeout ; failed to get file from controller-1"},{"line_number":11,"context_line":"On standalone system, the result is an Error in creating empty \u003cname\u003e.tar file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"74358b24_6c67e7bb","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":72},"updated":"2022-09-22 10:43:07.000000000","message":"Commit title is too long.","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"d84668a91d1d9bbf86bb48395ffbc1d06eed2d11","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Girish Subramanya \u003cgirish.subramanya@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-21 18:04:25 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Error reported as Timeout from collect utility provided with a lengthy name"},{"line_number":8,"context_line":"Reject the provided name with option --n when name length exceeds 255-16"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Reported Error: operation timeout ; failed to get file from controller-1"},{"line_number":11,"context_line":"On standalone system, the result is an Error in creating empty \u003cname\u003e.tar file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b2977682_df2ce98a","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":72},"in_reply_to":"74358b24_6c67e7bb","updated":"2022-09-22 13:12:54.000000000","message":"Done","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5de10e2577344244c1da141971deb8a9fd9188e8","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix Error reported as Timeout from collect utility provided with a lengthy name"},{"line_number":8,"context_line":"Reject the provided name with option --n when name length exceeds 255-16"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Reported Error: operation timeout ; failed to get file from controller-1"},{"line_number":11,"context_line":"On standalone system, the result is an Error in creating empty \u003cname\u003e.tar file"},{"line_number":12,"context_line":"Test plan:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - Tested on AIO-DX"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0d82dc83_e8cf202d","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":78},"updated":"2022-09-22 10:43:07.000000000","message":"Just describe the issue from a third party impersonal perspective. For instance.\n\nIf the user specified a collect bundle name, using the --name option, that is too long \u003cdescribe what happens\u003e.\n\nThis update \u003cdescribe how this update fixes the issue\u003e","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"d84668a91d1d9bbf86bb48395ffbc1d06eed2d11","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Error reported as Timeout from collect utility provided with a lengthy name"},{"line_number":8,"context_line":"Reject the provided name with option --n when name length exceeds 255-16"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Reported Error: operation timeout ; failed to get file from controller-1"},{"line_number":11,"context_line":"On standalone system, the result is an Error in creating empty \u003cname\u003e.tar file"},{"line_number":12,"context_line":"Test plan:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - Tested on AIO-DX"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c2910869_d2f4ca41","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":78},"in_reply_to":"0d82dc83_e8cf202d","updated":"2022-09-22 13:12:54.000000000","message":"Done","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5de10e2577344244c1da141971deb8a9fd9188e8","unresolved":true,"context_lines":[{"line_number":11,"context_line":"On standalone system, the result is an Error in creating empty \u003cname\u003e.tar file"},{"line_number":12,"context_line":"Test plan:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - Tested on AIO-DX"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Jira: CGTS-27822"},{"line_number":17,"context_line":"Change-Id: Iee8f918e19ed431a19209e19dc73fc28b9624027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4a351155_b9e37a37","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":19},"updated":"2022-09-22 10:43:07.000000000","message":"Should have issue targeted test cases\n\neg:\n\nTest Plan:\n\nVerify collector package build in Debian and CentOS\nVerify log name is rejected (failure path)\nVerify in range size is accepted and named collect bundle is created\nVerify size boundary condition ; 1 over and 1 under (fail and pass)\n\nRegression:\n\nVerify named collect bundle extract and content\n\nNote: This is a patchable change so maybe you would test as a patch and add that test case. Otherwise test as an iso install and the existing test case you have suffices.","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"d84668a91d1d9bbf86bb48395ffbc1d06eed2d11","unresolved":false,"context_lines":[{"line_number":11,"context_line":"On standalone system, the result is an Error in creating empty \u003cname\u003e.tar file"},{"line_number":12,"context_line":"Test plan:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - Tested on AIO-DX"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Jira: CGTS-27822"},{"line_number":17,"context_line":"Change-Id: Iee8f918e19ed431a19209e19dc73fc28b9624027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"30659306_5a33b85d","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":19},"in_reply_to":"4a351155_b9e37a37","updated":"2022-09-22 13:12:54.000000000","message":"Done","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5de10e2577344244c1da141971deb8a9fd9188e8","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - Tested on AIO-DX"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Jira: CGTS-27822"},{"line_number":17,"context_line":"Change-Id: Iee8f918e19ed431a19209e19dc73fc28b9624027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7d6afe02_b28d4b02","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":16},"updated":"2022-09-22 10:43:07.000000000","message":"Internal references should not be included. You need to create a launchpad at https://bugs.launchpad.net/starlingx . You can use the info in the internal Jira to avoid re-writing the issue in the launchpad case you create.\n\nOnce created, you need to add that launchpad link to the Jira at Edit -\u003e External (tab) -\u003e External Issue URL\n\nThe in place of this line put\nCloses-Bug: \u003cthe launchpad 7 digit number\u003e\n\nOnce the update is merged then the tools will automatically transition the state of the LP accordingly.","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"d84668a91d1d9bbf86bb48395ffbc1d06eed2d11","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - Tested on AIO-DX"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Jira: CGTS-27822"},{"line_number":17,"context_line":"Change-Id: Iee8f918e19ed431a19209e19dc73fc28b9624027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e8e7a9e9_43aed159","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":16},"in_reply_to":"7d6afe02_b28d4b02","updated":"2022-09-22 13:12:54.000000000","message":"Ack","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"a229ae6c7b5402793083f68b175b36186e2b1172","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reject input name with collect utility when name length exceeds 239"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using the collect utility and where the user provides a bundle name with"},{"line_number":10,"context_line":" --name that is 240 characters or longer:"},{"line_number":11,"context_line":"An inappropriate error \"operation timeout\" is reported;"},{"line_number":12,"context_line":"On a standalone system, the Error reported is \"creating empty \u003cname\u003e.tar file\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This update validates the name length provided and fixes the reported Error."},{"line_number":15,"context_line":"A suggestion is provided on the maximum allowed length for the bundle name."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7cd8815d_17593d7c","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":75},"updated":"2022-09-23 11:33:48.000000000","message":"long line: lines need to be limited to 72 characters","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"146788ed6b0d3309371875bbf60acff0864e4ba0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reject input name with collect utility when name length exceeds 239"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using the collect utility and where the user provides a bundle name with"},{"line_number":10,"context_line":" --name that is 240 characters or longer:"},{"line_number":11,"context_line":"An inappropriate error \"operation timeout\" is reported;"},{"line_number":12,"context_line":"On a standalone system, the Error reported is \"creating empty \u003cname\u003e.tar file\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This update validates the name length provided and fixes the reported Error."},{"line_number":15,"context_line":"A suggestion is provided on the maximum allowed length for the bundle name."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f28e6c04_f006efb2","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":75},"in_reply_to":"7cd8815d_17593d7c","updated":"2022-09-23 13:00:19.000000000","message":"Ack","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"a229ae6c7b5402793083f68b175b36186e2b1172","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Verify collector package build with iso build in CentOS"},{"line_number":20,"context_line":"Verify log name within limit is accepted and named collect bundle is created"},{"line_number":21,"context_line":"Verify log name is rejected with the appropriate error code 55"},{"line_number":22,"context_line":"Verify boundary condition with name length equal to max-length succeeds"},{"line_number":23,"context_line":"Verify name length 1 over max-length fails"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5dfae376_ad5e9c24","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":76},"updated":"2022-09-23 11:33:48.000000000","message":"long line","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"146788ed6b0d3309371875bbf60acff0864e4ba0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Verify collector package build with iso build in CentOS"},{"line_number":20,"context_line":"Verify log name within limit is accepted and named collect bundle is created"},{"line_number":21,"context_line":"Verify log name is rejected with the appropriate error code 55"},{"line_number":22,"context_line":"Verify boundary condition with name length equal to max-length succeeds"},{"line_number":23,"context_line":"Verify name length 1 over max-length fails"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"07dd0f66_2645af96","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":76},"in_reply_to":"5dfae376_ad5e9c24","updated":"2022-09-23 13:00:19.000000000","message":"Done","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"a229ae6c7b5402793083f68b175b36186e2b1172","unresolved":true,"context_lines":[{"line_number":25,"context_line":"Regression:"},{"line_number":26,"context_line":"Verify named collect bundle tar under scratch."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Bug #1990533"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: Iee8f918e19ed431a19209e19dc73fc28b9624027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8d96bee8_cfbdb76e","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":12},"updated":"2022-09-23 11:33:48.000000000","message":"Use\n\nCloses-Bug: 1990533","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"146788ed6b0d3309371875bbf60acff0864e4ba0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Regression:"},{"line_number":26,"context_line":"Verify named collect bundle tar under scratch."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Bug #1990533"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: Iee8f918e19ed431a19209e19dc73fc28b9624027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fe41719b_9fb0bdca","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":12},"in_reply_to":"8d96bee8_cfbdb76e","updated":"2022-09-23 13:00:19.000000000","message":"Ack","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"a229ae6c7b5402793083f68b175b36186e2b1172","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56810b77_3bea6555","line":31,"updated":"2022-09-23 11:33:48.000000000","message":"Need to use -s option on the git review command line to add the Signed-off-by: line to the commit message.","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"146788ed6b0d3309371875bbf60acff0864e4ba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ebf3520a_4d07e676","line":31,"in_reply_to":"56810b77_3bea6555","updated":"2022-09-23 13:00:19.000000000","message":"Ack","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"dd3934a9efec35e6dca60cb3a0f909d8620a0b79","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Girish Subramanya \u003cGirish.Subramanya@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-26 12:03:52 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reject input name with collect utility when name length exceeds 239"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using the collect utility and where the user provides a bundle"},{"line_number":10,"context_line":"name with --name that is 240 characters or longer:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dc7ba8ca_d35a0cdb","line":7,"range":{"start_line":7,"start_character":64,"end_line":7,"end_character":67},"updated":"2022-09-27 13:03:33.000000000","message":"Needs to be updated to 235","commit_id":"98784453f96234f99cb5a53cd38660c37af9e702"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"66219ab932c165564bc34e4751a4319fdf3b799b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Girish Subramanya \u003cGirish.Subramanya@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-26 12:03:52 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reject input name with collect utility when name length exceeds 239"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using the collect utility and where the user provides a bundle"},{"line_number":10,"context_line":"name with --name that is 240 characters or longer:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"73d507b6_b2f10f46","line":7,"range":{"start_line":7,"start_character":64,"end_line":7,"end_character":67},"in_reply_to":"dc7ba8ca_d35a0cdb","updated":"2022-09-27 22:39:32.000000000","message":"Ack","commit_id":"98784453f96234f99cb5a53cd38660c37af9e702"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"dd3934a9efec35e6dca60cb3a0f909d8620a0b79","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Reject input name with collect utility when name length exceeds 239"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using the collect utility and where the user provides a bundle"},{"line_number":10,"context_line":"name with --name that is 240 characters or longer:"},{"line_number":11,"context_line":"An inappropriate error \"operation timeout\" is reported;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On a standalone system, the Error reported i:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"79db82b1_4e887c09","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":29},"updated":"2022-09-27 13:03:33.000000000","message":"236","commit_id":"98784453f96234f99cb5a53cd38660c37af9e702"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"66219ab932c165564bc34e4751a4319fdf3b799b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reject input name with collect utility when name length exceeds 239"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using the collect utility and where the user provides a bundle"},{"line_number":10,"context_line":"name with --name that is 240 characters or longer:"},{"line_number":11,"context_line":"An inappropriate error \"operation timeout\" is reported;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On a standalone system, the Error reported i:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d4a13336_0dc74d2a","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":29},"in_reply_to":"79db82b1_4e887c09","updated":"2022-09-27 22:39:32.000000000","message":"Done","commit_id":"98784453f96234f99cb5a53cd38660c37af9e702"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"dd3934a9efec35e6dca60cb3a0f909d8620a0b79","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using the collect utility and where the user provides a bundle"},{"line_number":10,"context_line":"name with --name that is 240 characters or longer:"},{"line_number":11,"context_line":"An inappropriate error \"operation timeout\" is reported;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On a standalone system, the Error reported i:"},{"line_number":14,"context_line":"\"creating empty \u003cname\u003e.tar file\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4f57b81d_a61adedc","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":43},"updated":"2022-09-27 13:03:33.000000000","message":"I think it is a \"No space left on device\" error","commit_id":"98784453f96234f99cb5a53cd38660c37af9e702"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"66219ab932c165564bc34e4751a4319fdf3b799b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using the collect utility and where the user provides a bundle"},{"line_number":10,"context_line":"name with --name that is 240 characters or longer:"},{"line_number":11,"context_line":"An inappropriate error \"operation timeout\" is reported;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On a standalone system, the Error reported i:"},{"line_number":14,"context_line":"\"creating empty \u003cname\u003e.tar file\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c9d411f0_d299a1b9","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":43},"in_reply_to":"4f57b81d_a61adedc","updated":"2022-09-27 22:39:32.000000000","message":"Both error are seen in different cases.\noperation timeout is reported as no pre-tar \u003cname\u003e file is found, when size is 140.\n\"No space left on device\" when size is 136, due to creation of .tar when pre-tar bundle is present.","commit_id":"98784453f96234f99cb5a53cd38660c37af9e702"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"dd3934a9efec35e6dca60cb3a0f909d8620a0b79","unresolved":true,"context_lines":[{"line_number":10,"context_line":"name with --name that is 240 characters or longer:"},{"line_number":11,"context_line":"An inappropriate error \"operation timeout\" is reported;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On a standalone system, the Error reported i:"},{"line_number":14,"context_line":"\"creating empty \u003cname\u003e.tar file\"."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This update validates the name length and fixes the reported Error,"},{"line_number":17,"context_line":"indicating the maximum allowed length for the bundle name."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bce7191a_1e6bdd99","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":0},"updated":"2022-09-27 13:03:33.000000000","message":"is this accurate ?","commit_id":"98784453f96234f99cb5a53cd38660c37af9e702"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"66219ab932c165564bc34e4751a4319fdf3b799b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"name with --name that is 240 characters or longer:"},{"line_number":11,"context_line":"An inappropriate error \"operation timeout\" is reported;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On a standalone system, the Error reported i:"},{"line_number":14,"context_line":"\"creating empty \u003cname\u003e.tar file\"."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This update validates the name length and fixes the reported Error,"},{"line_number":17,"context_line":"indicating the maximum allowed length for the bundle name."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4df1aa2f_ee0b2547","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"bce7191a_1e6bdd99","updated":"2022-09-27 22:39:32.000000000","message":"Error message shown on Standalone is:\n\u003cname\u003e not present ; refusing to create empty \u003cname\u003e.tar","commit_id":"98784453f96234f99cb5a53cd38660c37af9e702"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"10a414cceb2b96276e601b3ae9a8aa2faf9690cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6927ca20_4120dee0","updated":"2022-09-21 22:33:18.000000000","message":"Please take a look at the changes to check input filename parameter for collect utility","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"d84668a91d1d9bbf86bb48395ffbc1d06eed2d11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"72c0592f_e65ab1a0","updated":"2022-09-22 13:12:54.000000000","message":"Thank you for looking into the changes for Bug #1990533","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"306ad015cf670ef1f5b11c8318513dddab3793c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4fe2b7d_3a587db0","updated":"2022-09-22 16:04:35.000000000","message":"Uploaded patch with resolution","commit_id":"018aa6e69bdc5604d98a37c6b82297bbe9432c66"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"146788ed6b0d3309371875bbf60acff0864e4ba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31b3d633_03d35626","updated":"2022-09-23 13:00:19.000000000","message":"Thank you for your review and specifying use of the options.","commit_id":"d7f291bbaecd492124db3af973b5480f70bb0e7d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"a460155cb0c61a4dcad85d6e0b0cbef5f2541b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8617f523_d09f403f","updated":"2022-09-26 11:48:08.000000000","message":"I\u0027m seeing an unexpected error using this update. I expected collect to work with long name that does not exceed the suggested 239 characters but instead I\u0027m seeing an out of space error.\n\nIncrease available space in controller-0:/scratch and retry operation.\n\nLets hold off on this merge till this is bottomed out.","commit_id":"1fa666b1f14bf5035d84885200c53cef621e38bf"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"86342b5ccc1b6aabe6ae30761a5f1fff706c194d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e56a7a8f_99a72ebc","updated":"2022-09-26 16:17:36.000000000","message":"New upload handles the Worklflow identified \"no space left on device\"","commit_id":"1fa666b1f14bf5035d84885200c53cef621e38bf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"b7e6fc7bf891b193ac59004de902c3868e577bfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"280d4f01_f3cc0532","updated":"2022-09-23 15:40:33.000000000","message":"Testing update, will boost to +2 once done.","commit_id":"1fa666b1f14bf5035d84885200c53cef621e38bf"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"86342b5ccc1b6aabe6ae30761a5f1fff706c194d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c2585867_084b3c11","in_reply_to":"8617f523_d09f403f","updated":"2022-09-26 16:17:36.000000000","message":"The error message \"No space left on device\" was generated due to a colect step moving the final log file with \".tar\" padding, different from the timeout error. Handled with the uploaded patch.","commit_id":"1fa666b1f14bf5035d84885200c53cef621e38bf"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"92e0ef850832c5836ead566a2b176a4ee6d249a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad9d3b92_b984fd8b","in_reply_to":"e56a7a8f_99a72ebc","updated":"2022-09-27 13:05:56.000000000","message":"The new upload prevents collect from trying to create a tar file longer than 255 characters that would otherwise misleadingly error out with the \u0027no space left on device\u0027 string","commit_id":"1fa666b1f14bf5035d84885200c53cef621e38bf"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"66219ab932c165564bc34e4751a4319fdf3b799b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"df2ef6ca_9bb0e894","updated":"2022-09-27 22:39:32.000000000","message":"Comment amended based on max name-length of 235 characters","commit_id":"2d92fcea17411d8e53e4e2967e37f0f190e9124b"}],"tools/collector/scripts/collect":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5de10e2577344244c1da141971deb8a9fd9188e8","unresolved":true,"context_lines":[{"line_number":602,"context_line":"while [[ ${#} -gt 0 ]] ; do"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    key\u003d\"${1}\""},{"line_number":605,"context_line":"    name\u003d\"${2}\""},{"line_number":606,"context_line":"    len\u003d${#name}"},{"line_number":607,"context_line":"    max_length\u003d$(expr 255 - 16)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    case $key in"},{"line_number":610,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"674634c7_846e94e8","line":607,"range":{"start_line":605,"start_character":1,"end_line":607,"end_character":31},"updated":"2022-09-22 10:43:07.000000000","message":"Scope these to the --name option. So move down. I would recommend using an else followed by these commands and then the if check block.","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"306ad015cf670ef1f5b11c8318513dddab3793c0","unresolved":false,"context_lines":[{"line_number":602,"context_line":"while [[ ${#} -gt 0 ]] ; do"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    key\u003d\"${1}\""},{"line_number":605,"context_line":"    name\u003d\"${2}\""},{"line_number":606,"context_line":"    len\u003d${#name}"},{"line_number":607,"context_line":"    max_length\u003d$(expr 255 - 16)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    case $key in"},{"line_number":610,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0c0aa017_26613b7b","line":607,"range":{"start_line":605,"start_character":1,"end_line":607,"end_character":31},"in_reply_to":"674634c7_846e94e8","updated":"2022-09-22 16:04:35.000000000","message":"Done","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5de10e2577344244c1da141971deb8a9fd9188e8","unresolved":true,"context_lines":[{"line_number":617,"context_line":"        if [ \"${2}\" \u003d\u003d \"\" ] ; then"},{"line_number":618,"context_line":"            report_error \"need to specify a name with the --name option\" ${FAIL_MISSING_PARAMETER}"},{"line_number":619,"context_line":"            collect_exit ${FAIL_MISSING_PARAMETER}"},{"line_number":620,"context_line":"        elif [ $len -gt ${max_length} ] ; then"},{"line_number":621,"context_line":"            report_error \"provided name must be less than 240 character long\" ${FAIL_NAME_TOO_LONG}"},{"line_number":622,"context_line":"            collect_exit ${FAIL_NAME_TOO_LONG}"},{"line_number":623,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f26aa5e_725d90c9","line":620,"range":{"start_line":620,"start_character":16,"end_line":620,"end_character":20},"updated":"2022-09-22 10:43:07.000000000","message":"be consistent with use of backets {}. Collect uses them.","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"306ad015cf670ef1f5b11c8318513dddab3793c0","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        if [ \"${2}\" \u003d\u003d \"\" ] ; then"},{"line_number":618,"context_line":"            report_error \"need to specify a name with the --name option\" ${FAIL_MISSING_PARAMETER}"},{"line_number":619,"context_line":"            collect_exit ${FAIL_MISSING_PARAMETER}"},{"line_number":620,"context_line":"        elif [ $len -gt ${max_length} ] ; then"},{"line_number":621,"context_line":"            report_error \"provided name must be less than 240 character long\" ${FAIL_NAME_TOO_LONG}"},{"line_number":622,"context_line":"            collect_exit ${FAIL_NAME_TOO_LONG}"},{"line_number":623,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"75fb73c0_ba63c6f1","line":620,"range":{"start_line":620,"start_character":16,"end_line":620,"end_character":20},"in_reply_to":"9f26aa5e_725d90c9","updated":"2022-09-22 16:04:35.000000000","message":"Done","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5de10e2577344244c1da141971deb8a9fd9188e8","unresolved":true,"context_lines":[{"line_number":618,"context_line":"            report_error \"need to specify a name with the --name option\" ${FAIL_MISSING_PARAMETER}"},{"line_number":619,"context_line":"            collect_exit ${FAIL_MISSING_PARAMETER}"},{"line_number":620,"context_line":"        elif [ $len -gt ${max_length} ] ; then"},{"line_number":621,"context_line":"            report_error \"provided name must be less than 240 character long\" ${FAIL_NAME_TOO_LONG}"},{"line_number":622,"context_line":"            collect_exit ${FAIL_NAME_TOO_LONG}"},{"line_number":623,"context_line":"        fi"},{"line_number":624,"context_line":"        COLLECT_NAME\u003d\"${2}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a9c1497_055866dd","line":621,"range":{"start_line":621,"start_character":58,"end_line":621,"end_character":62},"updated":"2022-09-22 10:43:07.000000000","message":"Should use the ${max_length} instead.\n\n... must not be longer than ${max_length} characters ...","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5de10e2577344244c1da141971deb8a9fd9188e8","unresolved":true,"context_lines":[{"line_number":618,"context_line":"            report_error \"need to specify a name with the --name option\" ${FAIL_MISSING_PARAMETER}"},{"line_number":619,"context_line":"            collect_exit ${FAIL_MISSING_PARAMETER}"},{"line_number":620,"context_line":"        elif [ $len -gt ${max_length} ] ; then"},{"line_number":621,"context_line":"            report_error \"provided name must be less than 240 character long\" ${FAIL_NAME_TOO_LONG}"},{"line_number":622,"context_line":"            collect_exit ${FAIL_NAME_TOO_LONG}"},{"line_number":623,"context_line":"        fi"},{"line_number":624,"context_line":"        COLLECT_NAME\u003d\"${2}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0c9c15dc_e9add339","line":621,"range":{"start_line":621,"start_character":62,"end_line":621,"end_character":72},"updated":"2022-09-22 10:43:07.000000000","message":"characters (plural)","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"d84668a91d1d9bbf86bb48395ffbc1d06eed2d11","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            report_error \"need to specify a name with the --name option\" ${FAIL_MISSING_PARAMETER}"},{"line_number":619,"context_line":"            collect_exit ${FAIL_MISSING_PARAMETER}"},{"line_number":620,"context_line":"        elif [ $len -gt ${max_length} ] ; then"},{"line_number":621,"context_line":"            report_error \"provided name must be less than 240 character long\" ${FAIL_NAME_TOO_LONG}"},{"line_number":622,"context_line":"            collect_exit ${FAIL_NAME_TOO_LONG}"},{"line_number":623,"context_line":"        fi"},{"line_number":624,"context_line":"        COLLECT_NAME\u003d\"${2}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7505f715_163cfab7","line":621,"range":{"start_line":621,"start_character":62,"end_line":621,"end_character":72},"in_reply_to":"0c9c15dc_e9add339","updated":"2022-09-22 13:12:54.000000000","message":"Ack","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"d84668a91d1d9bbf86bb48395ffbc1d06eed2d11","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            report_error \"need to specify a name with the --name option\" ${FAIL_MISSING_PARAMETER}"},{"line_number":619,"context_line":"            collect_exit ${FAIL_MISSING_PARAMETER}"},{"line_number":620,"context_line":"        elif [ $len -gt ${max_length} ] ; then"},{"line_number":621,"context_line":"            report_error \"provided name must be less than 240 character long\" ${FAIL_NAME_TOO_LONG}"},{"line_number":622,"context_line":"            collect_exit ${FAIL_NAME_TOO_LONG}"},{"line_number":623,"context_line":"        fi"},{"line_number":624,"context_line":"        COLLECT_NAME\u003d\"${2}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fd679e56_7549f1c5","line":621,"range":{"start_line":621,"start_character":58,"end_line":621,"end_character":62},"in_reply_to":"7a9c1497_055866dd","updated":"2022-09-22 13:12:54.000000000","message":"Ack","commit_id":"38415453209f7dbb7db9939b8f6bb1f59fe7e130"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"68a02b3181a0d41813db1bd258941032bd4ffc7e","unresolved":true,"context_lines":[{"line_number":620,"context_line":"            max_length\u003d$(expr 255 - 16 - 4) # Padding of timestamp and .tar"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"            if [ ${len} -gt ${max_length} ] ; then"},{"line_number":623,"context_line":"                report_error \"name must not be longer than ${$max_length} characters\" ${FAIL_NAME_TOO_LONG}"},{"line_number":624,"context_line":"                collect_exit ${FAIL_NAME_TOO_LONG}"},{"line_number":625,"context_line":"            fi"},{"line_number":626,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ae3d33dc_a5faea4c","line":623,"range":{"start_line":623,"start_character":62,"end_line":623,"end_character":72},"updated":"2022-09-28 16:45:24.000000000","message":"Should be max_length","commit_id":"2d92fcea17411d8e53e4e2967e37f0f190e9124b"},{"author":{"_account_id":35237,"name":"Girish Subramanya","email":"girish.subramanya@windriver.com","username":"gisubram"},"change_message_id":"75565838303200ed63842401483fab42c8b41f27","unresolved":false,"context_lines":[{"line_number":620,"context_line":"            max_length\u003d$(expr 255 - 16 - 4) # Padding of timestamp and .tar"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"            if [ ${len} -gt ${max_length} ] ; then"},{"line_number":623,"context_line":"                report_error \"name must not be longer than ${$max_length} characters\" ${FAIL_NAME_TOO_LONG}"},{"line_number":624,"context_line":"                collect_exit ${FAIL_NAME_TOO_LONG}"},{"line_number":625,"context_line":"            fi"},{"line_number":626,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"8095fc1f_07a7b657","line":623,"range":{"start_line":623,"start_character":62,"end_line":623,"end_character":72},"in_reply_to":"ae3d33dc_a5faea4c","updated":"2022-09-29 13:09:54.000000000","message":"follow on update done with https://review.opendev.org/c/starlingx/utilities/+/859727","commit_id":"2d92fcea17411d8e53e4e2967e37f0f190e9124b"}]}