)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Upgrade qemu to 7.2.0."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As we add kata container support for StarlingX"},{"line_number":10,"context_line":"with the latest kata containers stable version 3.1.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We need to upgrade qemu to 7.2.0 version to make them"},{"line_number":13,"context_line":"compatible."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"0cfaa3ef_5ad1c11d","line":10,"updated":"2023-06-26 19:58:11.000000000","message":"Was this kata containers version a community decision?\nI wonder if the latest version is the correct one here, specially because it requires a QEMU major upgrade to a release that is not even the officially supported on debian/bullseye (5.2) [1]\n\nOf course we could upversion QEMU to 7.2.0, just would like to see more information on the rationale behind it on this commit message.\n\n[1] https://packages.debian.org/bullseye/qemu-system-common","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Upgrade qemu to 7.2.0."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As we add kata container support for StarlingX"},{"line_number":10,"context_line":"with the latest kata containers stable version 3.1.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We need to upgrade qemu to 7.2.0 version to make them"},{"line_number":13,"context_line":"compatible."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"65fe3a4c_e754a3a3","line":10,"in_reply_to":"0cfaa3ef_5ad1c11d","updated":"2023-06-27 05:28:17.000000000","message":"This is as per discussion with Bruce.\n\nYes, according to the kata release page, they upgraded qemu to 7.2 with the 3.1.* releases, https://github.com/kata-containers/kata-containers/releases/tag/3.1.0","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":9,"context_line":"As we add kata container support for StarlingX"},{"line_number":10,"context_line":"with the latest kata containers stable version 3.1.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We need to upgrade qemu to 7.2.0 version to make them"},{"line_number":13,"context_line":"compatible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test plan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"c7e47a53_d6e2d90f","line":12,"updated":"2023-06-26 19:58:11.000000000","message":"We have to keep in mind that the QEMU on the host is shared with the stx-openstack application. The app currently is based on openstack services from Ussuri release, but those services are being ported to the Antelope release [1].\nI reckon that for the Antelope release, the version 7.2.0 would not be a problem [2] but could not find a major constraint on the QEMU version for the Ussuri release [3] [4].\n\nAnother point to keep in mind is the libvirt compatibility. \nThis same repo is delivering libvirt on its officially supported on debian/bullseye (7.0.0) [5], this needs to still be compatible with the upversioned QEMU.\n\n[1] https://storyboard.openstack.org/#!/story/2010715\n[2] https://github.com/openstack/nova/blob/stable/2023.1/nova/virt/libvirt/driver.py#L220\n[3] https://docs.openstack.org/nova/latest/reference/libvirt-distro-support-matrix.html#libvirt-minimum-version-change-policy\n[4] https://github.com/openstack/nova/blob/stable/ussuri/nova/virt/libvirt/driver.py#L226\n[5] https://packages.debian.org/bullseye/libvirt-daemon","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As we add kata container support for StarlingX"},{"line_number":10,"context_line":"with the latest kata containers stable version 3.1.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We need to upgrade qemu to 7.2.0 version to make them"},{"line_number":13,"context_line":"compatible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test plan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"a65edc21_512b62fc","line":12,"in_reply_to":"99516ccc_99cc44f1","updated":"2023-06-27 05:28:17.000000000","message":"Yes, I\u0027ll update test plan according to your comments.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"6a2d77d034840a06d62b8c4c6d0659fb7af7cf58","unresolved":true,"context_lines":[{"line_number":9,"context_line":"As we add kata container support for StarlingX"},{"line_number":10,"context_line":"with the latest kata containers stable version 3.1.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We need to upgrade qemu to 7.2.0 version to make them"},{"line_number":13,"context_line":"compatible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test plan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"99516ccc_99cc44f1","line":12,"in_reply_to":"b2008b0b_711f68f8","updated":"2023-06-26 20:14:14.000000000","message":"That would be necessary, I\u0027m afraid. \nLike I commented before, we can arrange help from the stx-openstack team to test it thoroughly. Just would not like to merge the upversion before being sure that what works now is not broken.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35757,"name":"Bruce Jones","email":"bruce.jones@windriver.com","username":"bejones"},"change_message_id":"8d17c01cd97312a48cc7c536a477752957483871","unresolved":true,"context_lines":[{"line_number":9,"context_line":"As we add kata container support for StarlingX"},{"line_number":10,"context_line":"with the latest kata containers stable version 3.1.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We need to upgrade qemu to 7.2.0 version to make them"},{"line_number":13,"context_line":"compatible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test plan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"b2008b0b_711f68f8","line":12,"in_reply_to":"c7e47a53_d6e2d90f","updated":"2023-06-26 20:09:40.000000000","message":"SHould we add \"Verify that stx-openstack works correctly\" to the test plan for the QEMU upgrade?","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2cde6feab868ba56c623ab9edc051b9f8d55751b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"We need to upgrade qemu to 7.2.0 version to make them"},{"line_number":13,"context_line":"compatible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test plan:"},{"line_number":16,"context_line":"PASS - Build qemu package."},{"line_number":17,"context_line":"PASS - Build /install image on AIO-SX."},{"line_number":18,"context_line":"PASS - Verify the package is installed in the system."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"7c8f70b6_daf60663","line":15,"updated":"2023-06-26 20:07:32.000000000","message":"Due to the shared nature of the QEMU package, I would like to see at least a couple of mentions to tests including the stx-openstack application on the platform. Not only applying it though, but also simple VM operations.\n\nI can arrange with my team to get help on testing a custom ISO with upversioned QEMU and stx-openstack.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"We need to upgrade qemu to 7.2.0 version to make them"},{"line_number":13,"context_line":"compatible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test plan:"},{"line_number":16,"context_line":"PASS - Build qemu package."},{"line_number":17,"context_line":"PASS - Build /install image on AIO-SX."},{"line_number":18,"context_line":"PASS - Verify the package is installed in the system."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"105a2003_2e62a8de","line":15,"in_reply_to":"7c8f70b6_daf60663","updated":"2023-06-27 05:28:17.000000000","message":"Yes, Thales, thank you for your review and help on this.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":20,"context_line":"       running qemi-image -V"},{"line_number":21,"context_line":"PASS - Verify the qemu x86_64 correctly installed by"},{"line_number":22,"context_line":"       running qemu-system-x86_64 --version"},{"line_number":23,"context_line":"PASS - Verify stx-openstack works correctly with sanity"},{"line_number":24,"context_line":"       and regression tests."},{"line_number":25,"context_line":"PASS - Verify that the kata-runtime check command print"},{"line_number":26,"context_line":"       system is capable of running kata containers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"db03113f_a2c8bea3","line":23,"updated":"2023-06-27 12:15:34.000000000","message":"How, when and where was this tested?\nWhich stx-openstack? Which system configuration and which test cases were executed covering VM handling scenarios?\n\nDo you have the test logs output to add here via link?","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"       running qemi-image -V"},{"line_number":21,"context_line":"PASS - Verify the qemu x86_64 correctly installed by"},{"line_number":22,"context_line":"       running qemu-system-x86_64 --version"},{"line_number":23,"context_line":"PASS - Verify stx-openstack works correctly with sanity"},{"line_number":24,"context_line":"       and regression tests."},{"line_number":25,"context_line":"PASS - Verify that the kata-runtime check command print"},{"line_number":26,"context_line":"       system is capable of running kata containers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"e07975d8_7e6e074e","line":23,"in_reply_to":"4a3afbe0_f5068861","updated":"2023-06-28 02:03:43.000000000","message":"My fault, I just updated the test plan, so need to set this review to WIP.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"bc2ae13b99d0bcb38ade08fbad0f8e17c0d42870","unresolved":true,"context_lines":[{"line_number":20,"context_line":"       running qemi-image -V"},{"line_number":21,"context_line":"PASS - Verify the qemu x86_64 correctly installed by"},{"line_number":22,"context_line":"       running qemu-system-x86_64 --version"},{"line_number":23,"context_line":"PASS - Verify stx-openstack works correctly with sanity"},{"line_number":24,"context_line":"       and regression tests."},{"line_number":25,"context_line":"PASS - Verify that the kata-runtime check command print"},{"line_number":26,"context_line":"       system is capable of running kata containers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"4a3afbe0_f5068861","line":23,"in_reply_to":"db03113f_a2c8bea3","updated":"2023-06-27 14:43:33.000000000","message":"Just to be clear here: on my previous comments I said that we (stx-openstack team) COULD arrange to help with sanity and regression on top of a custom ISO containing qemu7.2.0.\nBut we DID NOT DO it yet.\n\nIf you need help on this test, please reach me out and I will organize how we can help with this testing.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2b5d44d12934779603a14a0ff467c39b7fa200d1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"       running qemi-image -V"},{"line_number":21,"context_line":"PASS - Verify the qemu x86_64 correctly installed by"},{"line_number":22,"context_line":"       running qemu-system-x86_64 --version"},{"line_number":23,"context_line":"PASS - Verify stx-openstack works correctly with sanity"},{"line_number":24,"context_line":"       and regression tests."},{"line_number":25,"context_line":"PASS - Verify that the kata-runtime check command print"},{"line_number":26,"context_line":"       system is capable of running kata containers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":43,"id":"22279147_e5994121","line":23,"updated":"2023-12-21 14:17:44.000000000","message":"stx-openstack team helped with executing the automated tests pipelines and the results follows:\n\nList of Test Cases:\n------------------------------------------------------\n\nPASS\t20231221 00:23:26\ttest_ssh_to_hosts\nPASS\t20231221 00:24:43\ttest_lock_unlock_host\nPASS\t20231221 00:41:26\ttest_openstack_services_healthy\nPASS\t20231221 00:42:25\ttest_reapply_stx_openstack_no_change[controller-0]\nPASS\t20231221 00:44:21\ttest_horizon_create_delete_instance\nPASS\t20231221 00:47:32\ttest_ping_between_two_vms[tis-centos-guest-virtio-virtio]\nPASS\t20231221 00:52:56\ttest_migrate_vm[tis-centos-guest-live-None]\nPASS\t20231221 00:56:50\ttest_nova_actions[tis-centos-guest-dedicated-pause-unpause]\nPASS\t20231221 01:00:35\ttest_nova_actions[tis-centos-guest-dedicated-suspend-resume]\nPASS\t20231221 01:04:01\ttest_evacuate_vms\nPASS\t20231221 01:40:03\ttest_system_coredumps_and_crashes[core_dumps]\nPASS\t20231221 01:40:19\ttest_system_coredumps_and_crashes[crash_reports]\nPASS\t20231221 01:40:25\ttest_system_alarms\nPASS\t20231220 22:39:03\ttest_multiports_on_same_network_vm_actions[virtio_x4]\nPASS\t20231220 23:00:03\ttest_cpu_pol_vm_actions[2-dedicated-image-volume]\nPASS\t20231220 23:11:24\ttest_vm_mem_pool_default_config[2048]\nPASS\t20231220 23:14:37\ttest_vm_mem_pool_default_config[1048576]\nPASS\t20231220 23:19:20\ttest_resize_vm_positive[local_image-4_1_512-5_2_1024-image]\nPASS\t20231220 23:25:50\ttest_server_group_boot_vms[affinity-2]\nPASS\t20231220 23:30:51\ttest_server_group_boot_vms[anti_affinity-2]\nPASS\t20231220 23:36:18\ttest_vm_with_config_drive\nPASS\t20231220 23:55:40\ttest_lock_with_vms","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"154e9b69b9a400632ddc0e3e945ac236404a6533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5e19a8ba_716957d7","updated":"2023-06-13 10:25:45.000000000","message":"Hello,\n\nPlease help review this one which https://review.opendev.org/c/starlingx/integ/+/883893 depends on.\n\nThank you,\nDavid","commit_id":"5b26dd9fb0d894745b88a28d65e91fc0df9df63e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5245a3ffbd646a9881994653c2d3718c2ad0d6eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c2d20521_0c13fa52","updated":"2023-06-26 19:08:58.000000000","message":"I see you\u0027re missing some of the previous patches under qemu/debian/patches, what\u0027s the story on those?","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"9b5e6105f157ef639caab90121126e660a34ba31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"5db26fd7_16c7bb64","updated":"2023-06-26 19:13:35.000000000","message":"Please check all the patches for hard tabs instead of spaces.  Your code changes need to match the formatting of the surrounding code.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35757,"name":"Bruce Jones","email":"bruce.jones@windriver.com","username":"bejones"},"change_message_id":"8d17c01cd97312a48cc7c536a477752957483871","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ad086059_206aba33","updated":"2023-06-26 20:09:40.000000000","message":"The more I think about this, the more I want to be very careful with the QEMU upgrade.  At the very least we need to test it against all use cases.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"6216f24efab30baa06f2a5879d65b8e4b806b970","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ad1c8764_75f6adce","updated":"2023-06-26 17:56:00.000000000","message":"This may have implications for existing usage of qemu.  Would like Thales Elero Cervi to take a look.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"26a3be9c_adce4937","in_reply_to":"5db26fd7_16c7bb64","updated":"2023-06-27 05:28:17.000000000","message":"Correct, thanks.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35467,"name":"Luan Utimura","display_name":"Luan Utimura","email":"luan.utimura@luizalabs.com","username":"lutimura"},"change_message_id":"cd79ed52d5a21d32a1d0f23aa043a6b89fb3dab5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ff838730_803028a5","in_reply_to":"ad086059_206aba33","updated":"2023-06-26 20:22:40.000000000","message":"I agree. In my (and Thales\u0027) experience, it can be quite tricky to ensure that QEMU and Libvirt are working properly, even when all pods are -- apparently -- \"healthy\".\n\nIn the last upversion we did for QEMU and Libvirt, it took us several sanity/regression tests to guarantee that all VM operations were working as expected. So if we decide to continue with this new upversion, I would recommend that we include these types of tests in the test plan.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ea1967e8_e02fe195","in_reply_to":"c2d20521_0c13fa52","updated":"2023-06-27 05:28:17.000000000","message":"Yes, patch 0010-STX-Modify-live-migration-auto-converge-threshold.patch and\n0011-STX-virtio-serial-don-t-touch-virtqueue-if-vm-is-sto.patch not modified.\nseries file either.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"c5c3966e_db64080f","updated":"2023-06-27 05:28:17.000000000","message":"Thank you, folks, for helping review, really appreciate it.","commit_id":"139f65ec40308c18eade05dda52390dfa686d46f"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"df242afa_2b4df98e","updated":"2023-06-28 02:03:43.000000000","message":"Thank you Thales, set it to WIP.","commit_id":"5f532c89ed9a944f60cdcdc8e47167b0f399622b"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"4e00cdfd28383e9a24d54654139e8a0a6fb5a6b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"09881e47_fcd534e9","updated":"2023-11-29 19:39:37.000000000","message":"Still waiting on proper test with stx-openstack","commit_id":"e53f5ea42a27d9f044cba39afc638492a58c65ae"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"73f5f7040ef622fd0920ee6fb54705412496f84e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"ede5ea91_f98c7c33","updated":"2023-12-01 17:18:27.000000000","message":"Still waiting on proper test with stx-openstack","commit_id":"bbf6b1b80c5fb5f00f1806a4a785a8ca78f3d122"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2b5d44d12934779603a14a0ff467c39b7fa200d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"2afd29ed_f89efe6e","updated":"2023-12-21 14:17:44.000000000","message":"Looks good and is tested against the most important/common features of stx-opesntasck now.\n\nJust left some comments before bumping my CR+2","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"1e311d6d2aa653fb24a7e6620de981ee61323cd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"8f80ef69_e2f34582","updated":"2023-12-04 12:43:23.000000000","message":"Still waiting on proper test with stx-openstack and confirmation that this package builds on a clean build environment","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"}],"qemu/debian/deb_patches/0001-Customize-Debian-build-files-for-STX.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 49bf1475ba61e7ea8d3f596ec9701189205330d2 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 6 Jun 2023 19:25:22 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] Customize Debian build files for STX"}],"source_content_type":"text/x-diff","patch_set":20,"id":"884d8546_f5e85043","line":1,"updated":"2023-06-26 19:58:11.000000000","message":"We usually do not change the patch original header like this.\nThe updates are tracked on the \"Signed-off-by\" section, in which you can add a shortlog before your signature (and after the previous one).\n\nSame applies to all other patches that were modified bellow.\n\nExample:\n[trimmed the commit shortlog]\nSigned-off-by: david.liu \u003cdavid.liu@windriver.com\u003e","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 49bf1475ba61e7ea8d3f596ec9701189205330d2 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 6 Jun 2023 19:25:22 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] Customize Debian build files for STX"}],"source_content_type":"text/x-diff","patch_set":20,"id":"7288611d_04563399","line":1,"in_reply_to":"884d8546_f5e85043","updated":"2023-06-27 05:28:17.000000000","message":"Thanks for helping review.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 49bf1475ba61e7ea8d3f596ec9701189205330d2 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 6 Jun 2023 19:25:22 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] Customize Debian build files for STX"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"a0c9356a_793fab20","line":2,"updated":"2023-06-27 12:15:34.000000000","message":"I think you missed this header yet.\nLike I said before, the original header should be kept and ONLY your addition to the end of this section should be new.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 49bf1475ba61e7ea8d3f596ec9701189205330d2 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 6 Jun 2023 19:25:22 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] Customize Debian build files for STX"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"4175be2c_57d4416a","line":2,"in_reply_to":"a0c9356a_793fab20","updated":"2023-06-28 02:03:43.000000000","message":"Ok, keep the original header.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":24,"context_line":"* qemu-user-binftmt"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Signed-off-by: Thales Elero Cervi \u003cthaleselero.cervi@windriver.com\u003e"},{"line_number":27,"context_line":"Rebased original changes to the qemu 7.2 version."},{"line_number":28,"context_line":"Signed-off-by: david.liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":29,"context_line":"---"},{"line_number":30,"context_line":" debian/control | 232 +++----------------------------------------------"}],"source_content_type":"text/x-diff","patch_set":27,"id":"92814873_d154f566","line":27,"updated":"2023-06-27 12:15:34.000000000","message":"Correct, this is the way. Thanks!\n\nnit: Just please put you message between [ ], as peer examples on other patches.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"* qemu-user-binftmt"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Signed-off-by: Thales Elero Cervi \u003cthaleselero.cervi@windriver.com\u003e"},{"line_number":27,"context_line":"Rebased original changes to the qemu 7.2 version."},{"line_number":28,"context_line":"Signed-off-by: david.liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":29,"context_line":"---"},{"line_number":30,"context_line":" debian/control | 232 +++----------------------------------------------"}],"source_content_type":"text/x-diff","patch_set":27,"id":"ecd73c4f_03e93097","line":27,"in_reply_to":"92814873_d154f566","updated":"2023-06-28 02:03:43.000000000","message":"Ok.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"}],"qemu/debian/deb_patches/0007-workaround-for-libvirt-breaks.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2b5d44d12934779603a14a0ff467c39b7fa200d1","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Date: Thu, 15 Jun 2023 02:27:25 -0700"},{"line_number":4,"context_line":"Subject: [PATCH] workaround for libvirt breaks"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"qemu 6.0+ breaks libvirt \u003c7.2(issue with hotplug on attach-device):"},{"line_number":7,"context_line":"https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1932264"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can be removed if libvirt is upgraded to 7.2+"}],"source_content_type":"text/x-diff","patch_set":43,"id":"5d7b09ec_25d60fe3","line":6,"updated":"2023-12-21 14:17:44.000000000","message":"This will require a LP or story/task so we can uprev libvirt later in a follow-up step.","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":34769,"name":"Davi Frossard","email":"dbarrosf@windriver.com","username":"dbarrosf"},"change_message_id":"65d79a3819948ed79740b6ced017c70abb5296af","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Date: Thu, 15 Jun 2023 02:27:25 -0700"},{"line_number":4,"context_line":"Subject: [PATCH] workaround for libvirt breaks"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"qemu 6.0+ breaks libvirt \u003c7.2(issue with hotplug on attach-device):"},{"line_number":7,"context_line":"https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1932264"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can be removed if libvirt is upgraded to 7.2+"}],"source_content_type":"text/x-diff","patch_set":43,"id":"850de5e9_b3a2c0d7","line":6,"in_reply_to":"5d7b09ec_25d60fe3","updated":"2023-12-22 12:03:13.000000000","message":"Acknowledged","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"5d3608769146e78ca42035002fa173170737c6e5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Date: Thu, 15 Jun 2023 02:27:25 -0700"},{"line_number":4,"context_line":"Subject: [PATCH] workaround for libvirt breaks"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"qemu 6.0+ breaks libvirt \u003c7.2(issue with hotplug on attach-device):"},{"line_number":7,"context_line":"https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1932264"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can be removed if libvirt is upgraded to 7.2+"}],"source_content_type":"text/x-diff","patch_set":43,"id":"7ea871a6_b352f80c","line":6,"in_reply_to":"850de5e9_b3a2c0d7","updated":"2023-12-22 12:19:49.000000000","message":"Done: https://storyboard.openstack.org/#!/story/2010995","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"}],"qemu/debian/meta_data.yaml":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"10909830dacbf779e8744ef44d71def1dccb66d1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: qemu"},{"line_number":3,"context_line":"debver: 5.2+dfsg-11+deb11u3"},{"line_number":4,"context_line":"archive: https://snapshot.debian.org/archive/debian/20231021T030056Z/pool/main/q/qemu/"},{"line_number":5,"context_line":"revision:"},{"line_number":6,"context_line":"  dist: $STX_DIST"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"31e73fc0_e758a764","side":"PARENT","line":3,"updated":"2023-12-01 17:28:27.000000000","message":"For this version change to take effect is it required that the new source base version is listed in debian-mirror-tools/config/debian/common/base-bullseye.lst?\nIf so, both changes need to be merged together.\n\nI also see other changes related to QEMU upversion to 7.2 on this topic: https://review.opendev.org/q/topic:%22upgrade_qemu_to_7.2%22\nIs there any dependency chain between all changes that require merges to happen together to avoid breaking a master build?\nMight be a good idea to group all the changes on same topic to help core reviewers to organize the merges when the time comes...","commit_id":"1739c97f2f7f96396fa2e4b5f67bd60b81f7a6a5"},{"author":{"_account_id":34769,"name":"Davi Frossard","email":"dbarrosf@windriver.com","username":"dbarrosf"},"change_message_id":"ffe829bcb19bc94ebc43ba5071c547047e34f68b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: qemu"},{"line_number":3,"context_line":"debver: 5.2+dfsg-11+deb11u3"},{"line_number":4,"context_line":"archive: https://snapshot.debian.org/archive/debian/20231021T030056Z/pool/main/q/qemu/"},{"line_number":5,"context_line":"revision:"},{"line_number":6,"context_line":"  dist: $STX_DIST"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"a3b85786_15e6731f","side":"PARENT","line":3,"in_reply_to":"31e73fc0_e758a764","updated":"2023-12-04 12:20:24.000000000","message":"Done","commit_id":"1739c97f2f7f96396fa2e4b5f67bd60b81f7a6a5"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"1e311d6d2aa653fb24a7e6620de981ee61323cd2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: qemu"},{"line_number":3,"context_line":"debver: 5.2+dfsg-11+deb11u3"},{"line_number":4,"context_line":"archive: https://snapshot.debian.org/archive/debian/20231021T030056Z/pool/main/q/qemu/"},{"line_number":5,"context_line":"revision:"},{"line_number":6,"context_line":"  dist: $STX_DIST"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"0cedc88d_280b8e8a","side":"PARENT","line":3,"in_reply_to":"a3b85786_15e6731f","updated":"2023-12-04 12:43:23.000000000","message":"Was the solution simply removing qemu from debian_iso_image.inc?\nHow does this solve the downloader dependency chain?\nHave you tried this package build in an environment without any cached .debs (i.e., clean environment)?\n\nAlso, doesn\u0027t this change need any \"Depends-On\" pointing to other stx/tools or stx/root changes?","commit_id":"1739c97f2f7f96396fa2e4b5f67bd60b81f7a6a5"}],"qemu/debian/patches/0001-STX-Add-support-statement-to-help-output.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 29b89423b833d5407a186539cfbd0e6868180938 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 6 Jun 2023 20:19:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: Add support statement to -help output"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"c73d960a_437ca0a8","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 29b89423b833d5407a186539cfbd0e6868180938 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 6 Jun 2023 20:19:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: Add support statement to -help output"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"fb4b2e63_bad3748d","line":2,"in_reply_to":"c73d960a_437ca0a8","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 29b89423b833d5407a186539cfbd0e6868180938 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 6 Jun 2023 20:19:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: Add support statement to -help output"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"c657f9cc_e8032cb4","line":2,"updated":"2023-06-27 12:15:34.000000000","message":"I think you missed this header yet.\nLike I said before, the original header should be kept and ONLY your addition to the end of this section should be new.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 29b89423b833d5407a186539cfbd0e6868180938 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 6 Jun 2023 20:19:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: Add support statement to -help output"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"0eda241a_3923e78b","line":2,"in_reply_to":"c657f9cc_e8032cb4","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":25,"context_line":"Signed-off-by: Eduardo Habkost \u003cehabkost@redhat.com\u003e"},{"line_number":26,"context_line":"Signed-off-by: Jim Somerville \u003cJim.Somerville@windriver.com\u003e"},{"line_number":27,"context_line":"Signed-off-by: Rafael Falcao \u003cRafael.VieiraFalcao@windriver.com\u003e"},{"line_number":28,"context_line":"Rebased original changes to the qemu 7.2 version."},{"line_number":29,"context_line":"Signed-off-by: david.liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":30,"context_line":"---"},{"line_number":31,"context_line":" softmmu/vl.c | 9 +++++++++"}],"source_content_type":"text/x-diff","patch_set":27,"id":"748e99a5_9374aacc","line":28,"updated":"2023-06-27 12:15:34.000000000","message":"Correct, this is the way. Thanks!\n\nnit: Just please put you message between [ ], as peer examples on other patches.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Signed-off-by: Eduardo Habkost \u003cehabkost@redhat.com\u003e"},{"line_number":26,"context_line":"Signed-off-by: Jim Somerville \u003cJim.Somerville@windriver.com\u003e"},{"line_number":27,"context_line":"Signed-off-by: Rafael Falcao \u003cRafael.VieiraFalcao@windriver.com\u003e"},{"line_number":28,"context_line":"Rebased original changes to the qemu 7.2 version."},{"line_number":29,"context_line":"Signed-off-by: david.liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":30,"context_line":"---"},{"line_number":31,"context_line":" softmmu/vl.c | 9 +++++++++"}],"source_content_type":"text/x-diff","patch_set":27,"id":"4ffed5f6_f6550676","line":28,"in_reply_to":"748e99a5_9374aacc","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"}],"qemu/debian/patches/0002-STX-migration-thread-affinity-and-priority-qmp.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 8baa149e364133a5d4489b3b296662b04ed5a3ee Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 17:18:19 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: migration thread affinity and priority qmp"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"d952a472_82a5cebf","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 8baa149e364133a5d4489b3b296662b04ed5a3ee Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 17:18:19 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: migration thread affinity and priority qmp"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"72aefea6_8f802272","line":2,"in_reply_to":"d952a472_82a5cebf","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"9b5e6105f157ef639caab90121126e660a34ba31","unresolved":true,"context_lines":[{"line_number":27,"context_line":"@@ -39,6 +39,36 @@ SRST"},{"line_number":28,"context_line":"   completes."},{"line_number":29,"context_line":" ERST"},{"line_number":30,"context_line":" "},{"line_number":31,"context_line":"+    {"},{"line_number":32,"context_line":"+        .name       \u003d \"migrate-set-thread-cpumask\","},{"line_number":33,"context_line":"+        .args_type  \u003d \"value:o\","},{"line_number":34,"context_line":"+        .params     \u003d \"value\","},{"line_number":35,"context_line":"+        .help       \u003d \"Set CPU mask for the migration thread.\""},{"line_number":36,"context_line":"+                      \"Defaults to CPU 0 if no mask is specified\","},{"line_number":37,"context_line":"+        .cmd        \u003d hmp_migrate_set_thread_cpumask,"},{"line_number":38,"context_line":"+   },"},{"line_number":39,"context_line":"+"},{"line_number":40,"context_line":"+SRST"},{"line_number":41,"context_line":"+``migrate_set_thread_cpumask`` *value*"},{"line_number":42,"context_line":"+  Set CPU mask for the migration thread"},{"line_number":43,"context_line":"+ERST"},{"line_number":44,"context_line":"+"},{"line_number":45,"context_line":"+    {"},{"line_number":46,"context_line":"+        .name       \u003d \"migrate-set-thread-priority\","},{"line_number":47,"context_line":"+        .args_type  \u003d \"value:o\","},{"line_number":48,"context_line":"+        .params     \u003d \"value\","},{"line_number":49,"context_line":"+        .help       \u003d \"Set real time priority for the the migration thread.\""},{"line_number":50,"context_line":"+                      \"Defaults to no change migration thread priority if not\""}],"source_content_type":"text/x-diff","patch_set":20,"id":"5060b9a0_f82932c4","line":47,"range":{"start_line":30,"start_character":1,"end_line":47,"end_character":33},"updated":"2023-06-26 19:13:35.000000000","message":"do we still need to change these names?","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"@@ -39,6 +39,36 @@ SRST"},{"line_number":28,"context_line":"   completes."},{"line_number":29,"context_line":" ERST"},{"line_number":30,"context_line":" "},{"line_number":31,"context_line":"+    {"},{"line_number":32,"context_line":"+        .name       \u003d \"migrate-set-thread-cpumask\","},{"line_number":33,"context_line":"+        .args_type  \u003d \"value:o\","},{"line_number":34,"context_line":"+        .params     \u003d \"value\","},{"line_number":35,"context_line":"+        .help       \u003d \"Set CPU mask for the migration thread.\""},{"line_number":36,"context_line":"+                      \"Defaults to CPU 0 if no mask is specified\","},{"line_number":37,"context_line":"+        .cmd        \u003d hmp_migrate_set_thread_cpumask,"},{"line_number":38,"context_line":"+   },"},{"line_number":39,"context_line":"+"},{"line_number":40,"context_line":"+SRST"},{"line_number":41,"context_line":"+``migrate_set_thread_cpumask`` *value*"},{"line_number":42,"context_line":"+  Set CPU mask for the migration thread"},{"line_number":43,"context_line":"+ERST"},{"line_number":44,"context_line":"+"},{"line_number":45,"context_line":"+    {"},{"line_number":46,"context_line":"+        .name       \u003d \"migrate-set-thread-priority\","},{"line_number":47,"context_line":"+        .args_type  \u003d \"value:o\","},{"line_number":48,"context_line":"+        .params     \u003d \"value\","},{"line_number":49,"context_line":"+        .help       \u003d \"Set real time priority for the the migration thread.\""},{"line_number":50,"context_line":"+                      \"Defaults to no change migration thread priority if not\""}],"source_content_type":"text/x-diff","patch_set":20,"id":"62007b1a_de95ffd7","line":47,"range":{"start_line":30,"start_character":1,"end_line":47,"end_character":33},"in_reply_to":"5060b9a0_f82932c4","updated":"2023-06-27 05:28:17.000000000","message":"To support the upgrade, we also upgraded the build tool.\nhttps://review.opendev.org/c/starlingx/tools/+/885946\n\nSo have to change the name or the build will fail.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"9b5e6105f157ef639caab90121126e660a34ba31","unresolved":true,"context_lines":[{"line_number":122,"context_line":"+{"},{"line_number":123,"context_line":"+    /* Check for truncation */"},{"line_number":124,"context_line":"+    if (value !\u003d (size_t)value) {"},{"line_number":125,"context_line":"+\terror_setg(errp, \"Migration thread CPU Mask exceeding address space\");"},{"line_number":126,"context_line":"+\treturn;"},{"line_number":127,"context_line":"+    }"},{"line_number":128,"context_line":"+    /*resize the value */"},{"line_number":129,"context_line":"+    value \u003e\u003e\u003d 20; /*Magic */"}],"source_content_type":"text/x-diff","patch_set":20,"id":"3b1334b1_e1d6296b","line":126,"range":{"start_line":125,"start_character":2,"end_line":126,"end_character":9},"updated":"2023-06-26 19:13:35.000000000","message":"this looks like you\u0027re using hard tabs while the surrounding code uses spaces.  Please check all the patches for this.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"+{"},{"line_number":123,"context_line":"+    /* Check for truncation */"},{"line_number":124,"context_line":"+    if (value !\u003d (size_t)value) {"},{"line_number":125,"context_line":"+\terror_setg(errp, \"Migration thread CPU Mask exceeding address space\");"},{"line_number":126,"context_line":"+\treturn;"},{"line_number":127,"context_line":"+    }"},{"line_number":128,"context_line":"+    /*resize the value */"},{"line_number":129,"context_line":"+    value \u003e\u003e\u003d 20; /*Magic */"}],"source_content_type":"text/x-diff","patch_set":20,"id":"c124b251_d76b9b37","line":126,"range":{"start_line":125,"start_character":2,"end_line":126,"end_character":9},"in_reply_to":"3b1334b1_e1d6296b","updated":"2023-06-27 05:28:17.000000000","message":"Yes, thanks.","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"9b5e6105f157ef639caab90121126e660a34ba31","unresolved":true,"context_lines":[{"line_number":136,"context_line":"+    if (value !\u003d (size_t)value) {"},{"line_number":137,"context_line":"+\terror_setg(errp, \"Migration thread Priority exceeding address space\");"},{"line_number":138,"context_line":"+\treturn;"},{"line_number":139,"context_line":"+\t}"},{"line_number":140,"context_line":"+    /*resize the value */"},{"line_number":141,"context_line":"+    value \u003e\u003e\u003d 20;"},{"line_number":142,"context_line":"+    migrate_thread_priority \u003d value;"}],"source_content_type":"text/x-diff","patch_set":20,"id":"be6a7951_52bc42e4","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":3},"updated":"2023-06-26 19:13:35.000000000","message":"you\u0027ve changed the indent level here due to using hard tabs","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"+    if (value !\u003d (size_t)value) {"},{"line_number":137,"context_line":"+\terror_setg(errp, \"Migration thread Priority exceeding address space\");"},{"line_number":138,"context_line":"+\treturn;"},{"line_number":139,"context_line":"+\t}"},{"line_number":140,"context_line":"+    /*resize the value */"},{"line_number":141,"context_line":"+    value \u003e\u003e\u003d 20;"},{"line_number":142,"context_line":"+    migrate_thread_priority \u003d value;"}],"source_content_type":"text/x-diff","patch_set":20,"id":"d2487c83_c177fdb0","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":3},"in_reply_to":"be6a7951_52bc42e4","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 8baa149e364133a5d4489b3b296662b04ed5a3ee Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 17:18:19 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: migration thread affinity and priority qmp"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"0da9e4f4_489bfb1b","line":2,"updated":"2023-06-27 12:15:34.000000000","message":"ditto","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 8baa149e364133a5d4489b3b296662b04ed5a3ee Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 17:18:19 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: migration thread affinity and priority qmp"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"54ec9d21_cd850229","line":2,"in_reply_to":"0da9e4f4_489bfb1b","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Signed-off-by: Jim Somerville \u003cJim.Somerville@windriver.com\u003e"},{"line_number":10,"context_line":"[ Update hmp-commands struc ]"},{"line_number":11,"context_line":"Signed-off-by: Rafael Falcao \u003cRafael.VieiraFalcao@windriver.com\u003e"},{"line_number":12,"context_line":"Rebased original changes to the qemu 7.2 version"},{"line_number":13,"context_line":"Signed-off-by: david.liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":14,"context_line":"---"},{"line_number":15,"context_line":" hmp-commands.hx        | 30 ++++++++++++++++++++++++"}],"source_content_type":"text/x-diff","patch_set":27,"id":"edaff160_33509958","line":12,"updated":"2023-06-27 12:15:34.000000000","message":"nit: Please put you message between [ ], as peer examples on other patches.\nSee on line 10 an example.","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Signed-off-by: Jim Somerville \u003cJim.Somerville@windriver.com\u003e"},{"line_number":10,"context_line":"[ Update hmp-commands struc ]"},{"line_number":11,"context_line":"Signed-off-by: Rafael Falcao \u003cRafael.VieiraFalcao@windriver.com\u003e"},{"line_number":12,"context_line":"Rebased original changes to the qemu 7.2 version"},{"line_number":13,"context_line":"Signed-off-by: david.liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":14,"context_line":"---"},{"line_number":15,"context_line":" hmp-commands.hx        | 30 ++++++++++++++++++++++++"}],"source_content_type":"text/x-diff","patch_set":27,"id":"02a300c1_7a400e4e","line":12,"in_reply_to":"edaff160_33509958","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2b5d44d12934779603a14a0ff467c39b7fa200d1","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Signed-off-by: Jim Somerville \u003cJim.Somerville@windriver.com\u003e"},{"line_number":10,"context_line":"[ Update hmp-commands struc ]"},{"line_number":11,"context_line":"Signed-off-by: Rafael Falcao \u003cRafael.VieiraFalcao@windriver.com\u003e"},{"line_number":12,"context_line":"[Rebased original changes to the qemu 7.2 version]"},{"line_number":13,"context_line":"Signed-off-by: david.liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":14,"context_line":"---"},{"line_number":15,"context_line":" hmp-commands.hx        | 30 ++++++++++++++++++++++++"}],"source_content_type":"text/x-diff","patch_set":43,"id":"dc84c29f_e37338f5","line":12,"updated":"2023-12-21 14:17:44.000000000","message":"nit: there was more than a straight-forward rebase here, commands naming convention was changed too.","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":34769,"name":"Davi Frossard","email":"dbarrosf@windriver.com","username":"dbarrosf"},"change_message_id":"65d79a3819948ed79740b6ced017c70abb5296af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Signed-off-by: Jim Somerville \u003cJim.Somerville@windriver.com\u003e"},{"line_number":10,"context_line":"[ Update hmp-commands struc ]"},{"line_number":11,"context_line":"Signed-off-by: Rafael Falcao \u003cRafael.VieiraFalcao@windriver.com\u003e"},{"line_number":12,"context_line":"[Rebased original changes to the qemu 7.2 version]"},{"line_number":13,"context_line":"Signed-off-by: david.liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":14,"context_line":"---"},{"line_number":15,"context_line":" hmp-commands.hx        | 30 ++++++++++++++++++++++++"}],"source_content_type":"text/x-diff","patch_set":43,"id":"65f5fbcc_2e7e8cae","line":12,"in_reply_to":"dc84c29f_e37338f5","updated":"2023-12-22 12:03:13.000000000","message":"Acknowledged","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2b5d44d12934779603a14a0ff467c39b7fa200d1","unresolved":false,"context_lines":[{"line_number":30,"context_line":" ERST"},{"line_number":31,"context_line":" "},{"line_number":32,"context_line":"+    {"},{"line_number":33,"context_line":"+        .name       \u003d \"migrate-set-thread-cpumask\","},{"line_number":34,"context_line":"+        .args_type  \u003d \"value:o\","},{"line_number":35,"context_line":"+        .params     \u003d \"value\","},{"line_number":36,"context_line":"+        .help       \u003d \"Set CPU mask for the migration thread.\""}],"source_content_type":"text/x-diff","patch_set":43,"id":"dc0b83e0_90f0b43e","line":33,"updated":"2023-12-21 14:17:44.000000000","message":"Should be safe. Name is changed but command is not (refer to lines 38 and 54 in comparison with lines 73 and 74)","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2b5d44d12934779603a14a0ff467c39b7fa200d1","unresolved":true,"context_lines":[{"line_number":223,"context_line":"+#"},{"line_number":224,"context_line":"+# Since: 0.14.0"},{"line_number":225,"context_line":"+##"},{"line_number":226,"context_line":"+{ \u0027command\u0027: \u0027migrate-set-thread-cpumask\u0027, \u0027data\u0027: {\u0027value\u0027: \u0027int\u0027} }"},{"line_number":227,"context_line":"+"},{"line_number":228,"context_line":"+##"},{"line_number":229,"context_line":"+# @migrate-set-thread-priority:"}],"source_content_type":"text/x-diff","patch_set":43,"id":"ac7fe92f_b1d35004","line":226,"updated":"2023-12-21 14:17:44.000000000","message":"shouldn\u0027t the command keep the \"_\" naming convention here?\n(only the names were updated to use \"-\" instead: L33-54)","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":34769,"name":"Davi Frossard","email":"dbarrosf@windriver.com","username":"dbarrosf"},"change_message_id":"65d79a3819948ed79740b6ced017c70abb5296af","unresolved":false,"context_lines":[{"line_number":223,"context_line":"+#"},{"line_number":224,"context_line":"+# Since: 0.14.0"},{"line_number":225,"context_line":"+##"},{"line_number":226,"context_line":"+{ \u0027command\u0027: \u0027migrate-set-thread-cpumask\u0027, \u0027data\u0027: {\u0027value\u0027: \u0027int\u0027} }"},{"line_number":227,"context_line":"+"},{"line_number":228,"context_line":"+##"},{"line_number":229,"context_line":"+# @migrate-set-thread-priority:"}],"source_content_type":"text/x-diff","patch_set":43,"id":"98e5a9e2_f3242f45","line":226,"in_reply_to":"ac7fe92f_b1d35004","updated":"2023-12-22 12:03:13.000000000","message":"No. If we use \"_\" build breaks:\n../../qapi/misc.json: In command \u0027migrate_set_thread_cpumask\u0027:\n../../qapi/misc.json:262: name of command must not use uppercase or \u0027_\u0027","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2b5d44d12934779603a14a0ff467c39b7fa200d1","unresolved":true,"context_lines":[{"line_number":238,"context_line":"+#"},{"line_number":239,"context_line":"+# Since: 0.14.0"},{"line_number":240,"context_line":"+##"},{"line_number":241,"context_line":"+{ \u0027command\u0027: \u0027migrate-set-thread-priority\u0027, \u0027data\u0027: {\u0027value\u0027: \u0027int\u0027} }"},{"line_number":242,"context_line":"+"},{"line_number":243,"context_line":" ##"},{"line_number":244,"context_line":" # @getfd:"}],"source_content_type":"text/x-diff","patch_set":43,"id":"1f68112c_f128adca","line":241,"updated":"2023-12-21 14:17:44.000000000","message":"shouldn\u0027t the command keep the \"_\" naming convention here?\n(only the names were updated to use \"-\" instead: L33-54)","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":34769,"name":"Davi Frossard","email":"dbarrosf@windriver.com","username":"dbarrosf"},"change_message_id":"65d79a3819948ed79740b6ced017c70abb5296af","unresolved":false,"context_lines":[{"line_number":238,"context_line":"+#"},{"line_number":239,"context_line":"+# Since: 0.14.0"},{"line_number":240,"context_line":"+##"},{"line_number":241,"context_line":"+{ \u0027command\u0027: \u0027migrate-set-thread-priority\u0027, \u0027data\u0027: {\u0027value\u0027: \u0027int\u0027} }"},{"line_number":242,"context_line":"+"},{"line_number":243,"context_line":" ##"},{"line_number":244,"context_line":" # @getfd:"}],"source_content_type":"text/x-diff","patch_set":43,"id":"c56da9ad_0c347a2b","line":241,"in_reply_to":"1f68112c_f128adca","updated":"2023-12-22 12:03:13.000000000","message":"No. If we use \"_\" build breaks:\n../../qapi/misc.json: In command \u0027migrate_set_thread_cpumask\u0027:\n../../qapi/misc.json:262: name of command must not use uppercase or \u0027_\u0027","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"}],"qemu/debian/patches/0003-STX-qemu-dpdk-changes-for-openvswitch-dpdk.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From ecf23086aab67938fc3567a7baaba90f23e23416 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 19:13:56 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu dpdk changes for openvswitch dpdk"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"8102b0fc_29837658","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From ecf23086aab67938fc3567a7baaba90f23e23416 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 19:13:56 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu dpdk changes for openvswitch dpdk"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"432ae863_3fd71959","line":2,"in_reply_to":"8102b0fc_29837658","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From ecf23086aab67938fc3567a7baaba90f23e23416 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 19:13:56 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu dpdk changes for openvswitch dpdk"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"0b01e245_925f8ac8","line":2,"updated":"2023-06-27 12:15:34.000000000","message":"ditto","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From ecf23086aab67938fc3567a7baaba90f23e23416 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 19:13:56 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu dpdk changes for openvswitch dpdk"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"d0d68ebd_1c9208d1","line":2,"in_reply_to":"0b01e245_925f8ac8","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"}],"qemu/debian/patches/0004-STX-qemu-add-enable-dpdk-runtime-flag.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 50195f5e45af58ff983cb5c53fd79ddabcb3a281 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 19:41:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu: add -enable-dpdk runtime flag"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"02e928cb_9c07e98f","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 50195f5e45af58ff983cb5c53fd79ddabcb3a281 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 19:41:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu: add -enable-dpdk runtime flag"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"33b74d6c_0f39c030","line":2,"in_reply_to":"02e928cb_9c07e98f","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 50195f5e45af58ff983cb5c53fd79ddabcb3a281 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 19:41:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu: add -enable-dpdk runtime flag"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"For Intel\u0027s dpdk openvswitch support, qemu takes a set of dpdk"}],"source_content_type":"text/x-diff","patch_set":27,"id":"ad70f8dc_1079f8b6","line":3,"updated":"2023-06-27 12:15:34.000000000","message":"ditto","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 50195f5e45af58ff983cb5c53fd79ddabcb3a281 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Wed, 7 Jun 2023 19:41:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu: add -enable-dpdk runtime flag"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"For Intel\u0027s dpdk openvswitch support, qemu takes a set of dpdk"}],"source_content_type":"text/x-diff","patch_set":27,"id":"5c10dbe0_acf3e6e1","line":3,"in_reply_to":"ad70f8dc_1079f8b6","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"2b5d44d12934779603a14a0ff467c39b7fa200d1","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                 qsp_enable();"},{"line_number":48,"context_line":"                 break;"},{"line_number":49,"context_line":"             case QEMU_OPTION_nouserconfig:"},{"line_number":50,"context_line":"+            case QEMU_OPTION_enable_dpdk:\t\t"},{"line_number":51,"context_line":"                 /* Nothing to be parsed here. Especially, do not error out below. */"},{"line_number":52,"context_line":"                 break;"},{"line_number":53,"context_line":"             default:"}],"source_content_type":"text/x-diff","patch_set":43,"id":"3da6dd44_4b89421b","line":50,"updated":"2023-12-21 14:17:44.000000000","message":"nit: extra tabs here","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"},{"author":{"_account_id":34769,"name":"Davi Frossard","email":"dbarrosf@windriver.com","username":"dbarrosf"},"change_message_id":"65d79a3819948ed79740b6ced017c70abb5296af","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                 qsp_enable();"},{"line_number":48,"context_line":"                 break;"},{"line_number":49,"context_line":"             case QEMU_OPTION_nouserconfig:"},{"line_number":50,"context_line":"+            case QEMU_OPTION_enable_dpdk:\t\t"},{"line_number":51,"context_line":"                 /* Nothing to be parsed here. Especially, do not error out below. */"},{"line_number":52,"context_line":"                 break;"},{"line_number":53,"context_line":"             default:"}],"source_content_type":"text/x-diff","patch_set":43,"id":"c06ff956_6b481edf","line":50,"in_reply_to":"3da6dd44_4b89421b","updated":"2023-12-22 12:03:13.000000000","message":"Done","commit_id":"b9893d145b78fb79afcc34ba61b36979d2b447bd"}],"qemu/debian/patches/0005-STX-qemu-add-compile-define-for-CONFIG_DPDK.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From a1a64c8e2dac1634fbe06786830a411ae1f45074 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 12:44:52 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu: add compile define for CONFIG_DPDK"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"01150bb5_c88a79b1","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From a1a64c8e2dac1634fbe06786830a411ae1f45074 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 12:44:52 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu: add compile define for CONFIG_DPDK"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"31a34841_5617749c","line":2,"in_reply_to":"01150bb5_c88a79b1","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From a1a64c8e2dac1634fbe06786830a411ae1f45074 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 12:44:52 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu: add compile define for CONFIG_DPDK"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"df9827f3_2109be4a","line":2,"updated":"2023-06-27 12:15:34.000000000","message":"ditto","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From a1a64c8e2dac1634fbe06786830a411ae1f45074 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 12:44:52 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu: add compile define for CONFIG_DPDK"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"bc30fd63_305a3c7c","line":2,"in_reply_to":"df9827f3_2109be4a","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"}],"qemu/debian/patches/0006-STX-add-libdl.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 383528e7c770357c5bf227ae907d5e01b58f1aa6 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 12:20:38 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: add libdl"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"7c319f08_91c294a6","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 383528e7c770357c5bf227ae907d5e01b58f1aa6 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 12:20:38 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: add libdl"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"c3ccc742_0dd36c5b","line":2,"in_reply_to":"7c319f08_91c294a6","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 383528e7c770357c5bf227ae907d5e01b58f1aa6 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 12:20:38 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: add libdl"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"e48bd6ca_c74d0c2b","line":2,"updated":"2023-06-27 12:15:34.000000000","message":"ditto","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 383528e7c770357c5bf227ae907d5e01b58f1aa6 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 12:20:38 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: add libdl"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"ac2f1fb5_4d3a35df","line":2,"in_reply_to":"e48bd6ca_c74d0c2b","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"}],"qemu/debian/patches/0007-STX-qemu-dpdk-custom-config.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 886c338755d446928a04140319b3db95af2c861c Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 13:06:14 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu dpdk custom config"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"496b972d_dd1bdc51","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 886c338755d446928a04140319b3db95af2c861c Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 13:06:14 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu dpdk custom config"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"90342576_940372f5","line":2,"in_reply_to":"496b972d_dd1bdc51","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 886c338755d446928a04140319b3db95af2c861c Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 13:06:14 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu dpdk custom config"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"28d67545_1bae64a8","line":2,"updated":"2023-06-27 12:15:34.000000000","message":"ditto","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 886c338755d446928a04140319b3db95af2c861c Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 13:06:14 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: qemu dpdk custom config"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"1876df2f_abe6bdcb","line":2,"in_reply_to":"28d67545_1bae64a8","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"}],"qemu/debian/patches/0008-STX-realtime-uses-mlock-instead-of-mlockall.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From ae058c760a61d40ca21bbb5d6a062e6775ab4737 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 13:57:13 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: realtime uses mlock instead of mlockall"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"75a51146_35069ea7","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From ae058c760a61d40ca21bbb5d6a062e6775ab4737 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 13:57:13 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: realtime uses mlock instead of mlockall"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"c561c480_9f118d07","line":2,"in_reply_to":"75a51146_35069ea7","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From ae058c760a61d40ca21bbb5d6a062e6775ab4737 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 13:57:13 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: realtime uses mlock instead of mlockall"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"54aeef7e_9ddcbabf","line":2,"updated":"2023-06-27 12:15:34.000000000","message":"ditto","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From ae058c760a61d40ca21bbb5d6a062e6775ab4737 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 13:57:13 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: realtime uses mlock instead of mlockall"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":27,"id":"dea77df1_1c22e1d2","line":2,"in_reply_to":"54aeef7e_9ddcbabf","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"}],"qemu/debian/patches/0009-STX-Suspend-Resume-for-VMs-with-PCIPT-Virtio.patch":[{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"eea08e9efea799c1f7797e6c7b95e90e4209e1f2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 38413c82e753109a1b1fb7bd3dc32b6d1978f78c Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 15:28:21 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: Suspend/Resume for VMs with PCIPT+Virtio"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"fc4fc0e0_dc71c675","line":2,"updated":"2023-06-26 19:58:11.000000000","message":"ditto","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"16000c109144c4856132dd6af1028689460ccc2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 38413c82e753109a1b1fb7bd3dc32b6d1978f78c Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 15:28:21 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: Suspend/Resume for VMs with PCIPT+Virtio"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":20,"id":"16766465_f83f6c90","line":2,"in_reply_to":"fc4fc0e0_dc71c675","updated":"2023-06-27 05:28:17.000000000","message":"Ack","commit_id":"188d2fd4c28f3affd5cb47a1e683da0d66844efb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"523e40f008391ca504f3c05dfe9e1e4dbcc1bbce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 38413c82e753109a1b1fb7bd3dc32b6d1978f78c Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 15:28:21 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: Suspend/Resume for VMs with PCIPT+Virtio"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"When we have a Passthrough or a SR-IOV device, the plug/unplug of these"}],"source_content_type":"text/x-diff","patch_set":27,"id":"0b8a7bd3_856c30cd","line":3,"updated":"2023-06-27 12:15:34.000000000","message":"ditto","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"45667b93ce9b65ea28f7b4d43f9ae8c6caf4b4cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 38413c82e753109a1b1fb7bd3dc32b6d1978f78c Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: \"david.liu\" \u003cdavid.liu@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Thu, 8 Jun 2023 15:28:21 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] STX: Suspend/Resume for VMs with PCIPT+Virtio"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"When we have a Passthrough or a SR-IOV device, the plug/unplug of these"}],"source_content_type":"text/x-diff","patch_set":27,"id":"ab8b71ce_ea48770e","line":3,"in_reply_to":"0b8a7bd3_856c30cd","updated":"2023-06-28 02:03:43.000000000","message":"Ack","commit_id":"eec524863f3d1d2c7d4684208a69d5bc467c3a53"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"8068c711bb9db83aa137f3ec4858e5087cb452cd","unresolved":true,"context_lines":[{"line_number":26,"context_line":"memory map."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Signed-off-by: Jim Somerville \u003cJim.Somerville@windriver.com\u003e"},{"line_number":29,"context_line":"[ Trimmed the shortlog ]"},{"line_number":30,"context_line":"Signed-off-by: Rafael Falcao \u003cRafael.VieiraFalcao@windriver.com\u003e"},{"line_number":31,"context_line":"---"},{"line_number":32,"context_line":" hw/virtio/vhost.c | 26 +++++++++++++++++++++++++-"}],"source_content_type":"text/x-diff","patch_set":38,"id":"5137518a_c2e9e685","side":"PARENT","line":29,"updated":"2023-06-28 11:43:20.000000000","message":"why was this line removed?","commit_id":"e5c284bb0d1373d1a644a885237a72d1d52fde6f"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"7b05f0f1ce506b20be3456f7f75cd0faf51af45a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"memory map."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Signed-off-by: Jim Somerville \u003cJim.Somerville@windriver.com\u003e"},{"line_number":29,"context_line":"[ Trimmed the shortlog ]"},{"line_number":30,"context_line":"Signed-off-by: Rafael Falcao \u003cRafael.VieiraFalcao@windriver.com\u003e"},{"line_number":31,"context_line":"---"},{"line_number":32,"context_line":" hw/virtio/vhost.c | 26 +++++++++++++++++++++++++-"}],"source_content_type":"text/x-diff","patch_set":38,"id":"3e54ea9e_28eed99e","side":"PARENT","line":29,"in_reply_to":"5137518a_c2e9e685","updated":"2023-06-29 01:38:23.000000000","message":"Yes, mistake, put it back.","commit_id":"e5c284bb0d1373d1a644a885237a72d1d52fde6f"}]}