)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e6bcc3ceb7c10fc78b4cdbdddd07ba4ce8edd4e6","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The QEMU base version on 7.2+dfsg-7+deb12u5 was still causing"},{"line_number":10,"context_line":"incompatibilities other than the ones fixed in [1]."},{"line_number":11,"context_line":"Whe hot-plugging devices to instances, the error was still occuring and"},{"line_number":12,"context_line":"extra cherry-picks were required to be brought from master in order to"},{"line_number":13,"context_line":"fix bug/2083929."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"92ef7420_a7ac81ac","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":3},"updated":"2024-10-17 20:47:03.000000000","message":"typo","commit_id":"fcf652f887c9c7db26c69207f223fb9b8351db73"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"dce6e3e886bd608538abf86dfaad8accd4640512","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The QEMU base version on 7.2+dfsg-7+deb12u5 was still causing"},{"line_number":10,"context_line":"incompatibilities other than the ones fixed in [1]."},{"line_number":11,"context_line":"Whe hot-plugging devices to instances, the error was still occuring and"},{"line_number":12,"context_line":"extra cherry-picks were required to be brought from master in order to"},{"line_number":13,"context_line":"fix bug/2083929."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"64f5a90a_67986819","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":3},"in_reply_to":"92ef7420_a7ac81ac","updated":"2024-10-17 21:33:02.000000000","message":"Done","commit_id":"fcf652f887c9c7db26c69207f223fb9b8351db73"},{"author":{"_account_id":35166,"name":"Romulo Jose Lyra Leite","email":"romulo.leite@windriver.com","username":"rlyra"},"change_message_id":"31ce45bd127f54e147d803840652cefab6d139cc","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The QEMU base version on 7.2+dfsg-7+deb12u5 was still causing"},{"line_number":10,"context_line":"incompatibilities other than the ones fixed in [1]."},{"line_number":11,"context_line":"When hot-plugging devices to instances, the error was still occuring and"},{"line_number":12,"context_line":"extra cherry-picks were required to be brought from master in order to"},{"line_number":13,"context_line":"fix bug/2083929."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7d811b_03d3d6e8","line":11,"updated":"2024-10-18 11:26:54.000000000","message":"typo in occurring","commit_id":"bf804058f633cd980df11b77ff553fc5db6f7187"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"15610bbc3e443e2bcdc7abb49cf36b23bf9ce70c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The QEMU base version on 7.2+dfsg-7+deb12u5 was still causing"},{"line_number":10,"context_line":"incompatibilities other than the ones fixed in [1]."},{"line_number":11,"context_line":"When hot-plugging devices to instances, the error was still occuring and"},{"line_number":12,"context_line":"extra cherry-picks were required to be brought from master in order to"},{"line_number":13,"context_line":"fix bug/2083929."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"795fb2e5_ff476f7e","line":11,"in_reply_to":"fa7d811b_03d3d6e8","updated":"2024-10-18 11:40:30.000000000","message":"Done","commit_id":"bf804058f633cd980df11b77ff553fc5db6f7187"},{"author":{"_account_id":35166,"name":"Romulo Jose Lyra Leite","email":"romulo.leite@windriver.com","username":"rlyra"},"change_message_id":"31ce45bd127f54e147d803840652cefab6d139cc","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Test Plan:"},{"line_number":24,"context_line":"PASS - build-pkgs -c -p libvirt"},{"line_number":25,"context_line":"PASS - build-stx-images.sh --only stx-libvirt"},{"line_number":26,"context_line":"PASS - Re-apply STX-O with new stx-libvirt image"},{"line_number":27,"context_line":"PASS - Launch VM with 1 bootable volume"},{"line_number":28,"context_line":"PASS - Attach 1 extra volume to the VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"00b89302_6d2e21f0","line":25,"updated":"2024-10-18 11:26:54.000000000","message":"just to be sure, did you also built all other images in the manifest to make sure no","commit_id":"bf804058f633cd980df11b77ff553fc5db6f7187"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"bc5cc2288ead374e2466c8d8396bd4df1ec4b979","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Test Plan:"},{"line_number":24,"context_line":"PASS - build-pkgs -c -p libvirt"},{"line_number":25,"context_line":"PASS - build-stx-images.sh --only stx-libvirt"},{"line_number":26,"context_line":"PASS - Re-apply STX-O with new stx-libvirt image"},{"line_number":27,"context_line":"PASS - Launch VM with 1 bootable volume"},{"line_number":28,"context_line":"PASS - Attach 1 extra volume to the VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c0c17e15_5fab3c49","line":25,"in_reply_to":"00b89302_6d2e21f0","updated":"2024-10-18 15:48:43.000000000","message":"Sure thing. I tested the following images:\n\nstx-placement\nstx-openstackclients\nstx-nova\nstx-neutron\nstx-keystone\nstx-horizon\nstx-heat\nstx-glance\nstx-cinder\nstx-ceilometer\nstx-barbican\nstx-ironic\nstx-aodh\nstx-ovs\nstx-mariadb\nstx-fm-rest-api\nstx-libvirt\n\nThanks for raising this concern, Romulo","commit_id":"bf804058f633cd980df11b77ff553fc5db6f7187"},{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"f604ec69e3fefc4ba6658e6c07bb683ac519a3bb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"incompatibilities other than the ones fixed in [1]."},{"line_number":11,"context_line":"When hot-plugging devices to instances, the error was still occurring"},{"line_number":12,"context_line":"and extra cherry-picks [2-4] were required to be brought from master"},{"line_number":13,"context_line":"in order to fix bug/2083929."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Patch 0014-qemu-remove-support-for-generating-yes-no-boolean-op.patch"},{"line_number":16,"context_line":"was not strictly necessary for this fix, but it helped to smooth the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e3b94713_5bdc9023","line":13,"updated":"2024-10-18 12:08:15.000000000","message":"Just out of curiosity, how did you find this? Is there any upstream libvirt bug or conversation that we could check?","commit_id":"7a7256da11a0d4e293d443e956eb525baee929cb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"b9cacb0bb285c911def7125a2a078bccce631612","unresolved":false,"context_lines":[{"line_number":10,"context_line":"incompatibilities other than the ones fixed in [1]."},{"line_number":11,"context_line":"When hot-plugging devices to instances, the error was still occurring"},{"line_number":12,"context_line":"and extra cherry-picks [2-4] were required to be brought from master"},{"line_number":13,"context_line":"in order to fix bug/2083929."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Patch 0014-qemu-remove-support-for-generating-yes-no-boolean-op.patch"},{"line_number":16,"context_line":"was not strictly necessary for this fix, but it helped to smooth the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"47f18814_fe96982c","line":13,"in_reply_to":"e3b94713_5bdc9023","updated":"2024-10-18 12:34:29.000000000","message":"In the first commit to stx/virt there were some upstream bugs listed:\n[1] https://bugs.launchpad.net/starlingx/+bug/2078857\n[2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1958302\n[3] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1944985\n\nAt the time we were focusing on fixing the reported live-migration issue and tried to bring as little as possible upstream patches on top of 7.0.0.\nThe community fixed it on 7.1.0 or 7.2.0, would have to check the tags, and since all the commits were there I\u0027m not sure if there is an upstream bug reported for this hot-plug issue.","commit_id":"7a7256da11a0d4e293d443e956eb525baee929cb"},{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"f604ec69e3fefc4ba6658e6c07bb683ac519a3bb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"was not strictly necessary for this fix, but it helped to smooth the"},{"line_number":17,"context_line":"package build with the other two patches in place."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"When we decide to uprev libvirt, this change will no longer be needed."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://opendev.org/starlingx/virt/commit/a4fad169adb97d5d7d6fd1ae6510db8c24fd6f3"},{"line_number":22,"context_line":"[2] libvirt/libvirt/-/commit/29318399667114b3dd8a054f7ef898b3ba74828d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6ea9eacb_07e04ca0","line":19,"range":{"start_line":19,"start_character":18,"end_line":19,"end_character":31},"updated":"2024-10-18 12:08:15.000000000","message":"If/when an uprev happens, what\u0027s the minimum version that we can drop this?","commit_id":"7a7256da11a0d4e293d443e956eb525baee929cb"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"b9cacb0bb285c911def7125a2a078bccce631612","unresolved":false,"context_lines":[{"line_number":16,"context_line":"was not strictly necessary for this fix, but it helped to smooth the"},{"line_number":17,"context_line":"package build with the other two patches in place."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"When we decide to uprev libvirt, this change will no longer be needed."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://opendev.org/starlingx/virt/commit/a4fad169adb97d5d7d6fd1ae6510db8c24fd6f3"},{"line_number":22,"context_line":"[2] libvirt/libvirt/-/commit/29318399667114b3dd8a054f7ef898b3ba74828d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3691a250_2b40a592","line":19,"range":{"start_line":19,"start_character":18,"end_line":19,"end_character":31},"in_reply_to":"6ea9eacb_07e04ca0","updated":"2024-10-18 12:34:29.000000000","message":"The community fixed it on 7.1.0 or 7.2.0, would have to check the tags.\nAnyhow, libvirt Debian packages goes from 7.0.0 directly to 7.6.0 checking the salsa.debian repo tags [1]. This uprev would require was updating build dependencies on the STX shared list of dependencies... it is a risky move, specially because the required versions are listed as bookworm LTS versions. We should wait on STX distro update to do it.\n\nThe patches while we wait on stx-debian base image update were the best solution found.\n\n[1] https://salsa.debian.org/libvirt-team/libvirt/-/tags?search\u003ddebian%2F7.\u0026sort\u003dupdated_desc","commit_id":"7a7256da11a0d4e293d443e956eb525baee929cb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37173,"name":"Alex Fernandes Figueirêdo","display_name":"Alex Figueiredo","email":"alex.fernandesfigueiredo@windriver.com","username":"afernand"},"change_message_id":"e6bcc3ceb7c10fc78b4cdbdddd07ba4ce8edd4e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17070374_196315dc","updated":"2024-10-17 20:47:03.000000000","message":"Great job @thaleselero.cervi@windriver.com and @DanielMarques.Caires@windriver.com \n\nI have just added a comment about a typo in the commit message. If you can, please take a look.","commit_id":"fcf652f887c9c7db26c69207f223fb9b8351db73"},{"author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"change_message_id":"f604ec69e3fefc4ba6658e6c07bb683ac519a3bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6803f72f_d6de3185","updated":"2024-10-18 12:08:15.000000000","message":"Thanks Thales and Daniel. My comments are just questions to ease future references","commit_id":"7a7256da11a0d4e293d443e956eb525baee929cb"}]}