)]}'
{"conf/templates/packaging/specs/openstack-nova.spec":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"315bd01d1786dedf3261cd037cdcf8cb546ed539","unresolved":false,"context_lines":[{"line_number":57,"context_line":"BuildRequires:    python-devel"},{"line_number":58,"context_line":"BuildRequires:    python-setuptools"},{"line_number":59,"context_line":"# TODO(mmorais): no pbr for scl builds, figure out how to make conditional"},{"line_number":60,"context_line":"#BuildRequires:    python-pbr"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Requires:         %{name}-compute \u003d %{epoch}:%{version}-%{release}"},{"line_number":63,"context_line":"Requires:         %{name}-cert \u003d %{epoch}:%{version}-%{release}"}],"source_content_type":"text/x-rpm-spec","patch_set":1,"id":"fa98f980_5a591b5a","line":60,"updated":"2014-09-10 17:05:03.000000000","message":"Hmmmm, how\u0027s this gonna work, pbr is very heavily used for all of openstack during build time.","commit_id":"3f1a7af8bca66f9bd38ce3e9aa92caaf622a1688"},{"author":{"_account_id":10165,"name":"Marco Morais","email":"mmorais@yahoo-inc.com","username":"mmorais"},"change_message_id":"d5472d343a184e8e2a735948d6566bb20c8f8640","unresolved":false,"context_lines":[{"line_number":57,"context_line":"BuildRequires:    python-devel"},{"line_number":58,"context_line":"BuildRequires:    python-setuptools"},{"line_number":59,"context_line":"# TODO(mmorais): no pbr for scl builds, figure out how to make conditional"},{"line_number":60,"context_line":"#BuildRequires:    python-pbr"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Requires:         %{name}-compute \u003d %{epoch}:%{version}-%{release}"},{"line_number":63,"context_line":"Requires:         %{name}-cert \u003d %{epoch}:%{version}-%{release}"}],"source_content_type":"text/x-rpm-spec","patch_set":1,"id":"fa98f980_c24bae5d","line":60,"in_reply_to":"fa98f980_5a591b5a","updated":"2014-09-17 10:25:05.000000000","message":"in the most recent patchset I added a standalone tool named build-pbr-for-scl-python27.py which builds a scl rpm for pbr and installs it during the scl bootstrap phase of smithy, as a result I removed the commenting which was added in this earlier patchset","commit_id":"3f1a7af8bca66f9bd38ce3e9aa92caaf622a1688"}],"smithy":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"dc37f4a41a78dae7010338929cd7abd1ab3a02fa","unresolved":false,"context_lines":[{"line_number":296,"context_line":"{"},{"line_number":297,"context_line":"    # Downloads an rpm from a url and then installs it (if it\u0027s not already"},{"line_number":298,"context_line":"    # installed)."},{"line_number":299,"context_line":"    echo \"cache and install function called\""},{"line_number":300,"context_line":"    url\u003d${1:?\"Error: rpm url is undefined!\"}"},{"line_number":301,"context_line":"    cachedir\u003d${RPM_CACHEDIR:-\u0027/tmp\u0027}"},{"line_number":302,"context_line":"    rpm\u003d$(basename \"$url\")"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_5a154d3e","line":299,"updated":"2014-09-12 18:41:46.000000000","message":"This line seems out of place, no other functions currently log when they are called, so probably shouldn\u0027t just add it for this one.","commit_id":"900455ecd03f9f5da146fd4cf7db2fecf0eda772"},{"author":{"_account_id":10165,"name":"Marco Morais","email":"mmorais@yahoo-inc.com","username":"mmorais"},"change_message_id":"89162e167b70f69e0ede5a712703356bbe95b3dc","unresolved":false,"context_lines":[{"line_number":296,"context_line":"{"},{"line_number":297,"context_line":"    # Downloads an rpm from a url and then installs it (if it\u0027s not already"},{"line_number":298,"context_line":"    # installed)."},{"line_number":299,"context_line":"    echo \"cache and install function called\""},{"line_number":300,"context_line":"    url\u003d${1:?\"Error: rpm url is undefined!\"}"},{"line_number":301,"context_line":"    cachedir\u003d${RPM_CACHEDIR:-\u0027/tmp\u0027}"},{"line_number":302,"context_line":"    rpm\u003d$(basename \"$url\")"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_c0422aaa","line":299,"in_reply_to":"fa98f980_5a154d3e","updated":"2014-09-17 10:25:44.000000000","message":"it appeared in the changeset that I pulled down from Pranesh, will remove it in next commit","commit_id":"900455ecd03f9f5da146fd4cf7db2fecf0eda772"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"dc37f4a41a78dae7010338929cd7abd1ab3a02fa","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    cachedir\u003d${RPM_CACHEDIR:-\u0027/tmp\u0027}"},{"line_number":302,"context_line":"    rpm\u003d$(basename \"$url\")"},{"line_number":303,"context_line":"    if rpm_is_installed \"$rpm\"; then"},{"line_number":304,"context_line":"        echo \"already installed $rpm\""},{"line_number":305,"context_line":"        return 0"},{"line_number":306,"context_line":"    fi"},{"line_number":307,"context_line":"    echo $rpm \"not already installed\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_9a1b3572","line":304,"updated":"2014-09-12 18:41:46.000000000","message":"Are these just leftover debug statements?","commit_id":"900455ecd03f9f5da146fd4cf7db2fecf0eda772"},{"author":{"_account_id":10165,"name":"Marco Morais","email":"mmorais@yahoo-inc.com","username":"mmorais"},"change_message_id":"89162e167b70f69e0ede5a712703356bbe95b3dc","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    cachedir\u003d${RPM_CACHEDIR:-\u0027/tmp\u0027}"},{"line_number":302,"context_line":"    rpm\u003d$(basename \"$url\")"},{"line_number":303,"context_line":"    if rpm_is_installed \"$rpm\"; then"},{"line_number":304,"context_line":"        echo \"already installed $rpm\""},{"line_number":305,"context_line":"        return 0"},{"line_number":306,"context_line":"    fi"},{"line_number":307,"context_line":"    echo $rpm \"not already installed\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_e07baef2","line":304,"in_reply_to":"fa98f980_9a1b3572","updated":"2014-09-17 10:25:44.000000000","message":"same as above, I will remove","commit_id":"900455ecd03f9f5da146fd4cf7db2fecf0eda772"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"741b73edb4f4e726dd23373dc6109e44c2e7a713","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    fi"},{"line_number":141,"context_line":"    # Install the repo gpg key if it doesn\u0027t already exist."},{"line_number":142,"context_line":"    if [ ! -s $SCL_REPO_GPG_KEY_FN ] ; then"},{"line_number":143,"context_line":"        wget $SCL_REPO_GPG_KEY_URL --output-document $SCL_REPO_GPG_KEY_FN"},{"line_number":144,"context_line":"        if [ $? -ne 0 ] ; then"},{"line_number":145,"context_line":"            echo \"Fail from $SCL_REPO_GPG_KEY_URL to $SCL_REPO_GPG_KEY_FN\""},{"line_number":146,"context_line":"            return 1"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa98f980_2299cc1f","line":143,"updated":"2014-09-18 01:02:48.000000000","message":"Can we also make this quiet, unless verbose mode (aka when VERBOSE is set) is on so we don\u0027t see the whole verbose wget output. Thanks.","commit_id":"9b0b47094c7473186fe8550cdf6e0f0cec8b5f97"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3743e72574509e758a756db763f2ce6224046371","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        echo \"Fail to build pbr rpm for bootstrap.\""},{"line_number":178,"context_line":"        return 1"},{"line_number":179,"context_line":"    fi"},{"line_number":180,"context_line":"    yum install $YUM_OPTS $SCL_PBR_RPM "},{"line_number":181,"context_line":"    if [ $? -ne 0 ] ; then"},{"line_number":182,"context_line":"        echo \"Fail to install pbr rpm for bootstrap.\""},{"line_number":183,"context_line":"        return 1"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa98f980_ba988a1c","line":180,"updated":"2014-09-17 17:32:47.000000000","message":"Can we remove this whitespace?\n\nProbably in the future should look into using bashate to prevent this stuff from passing code-review.","commit_id":"9b0b47094c7473186fe8550cdf6e0f0cec8b5f97"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3743e72574509e758a756db763f2ce6224046371","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    if rpm_is_installed \"$rpm\"; then"},{"line_number":330,"context_line":"        return 0"},{"line_number":331,"context_line":"    fi"},{"line_number":332,"context_line":"    echo $rpm \"not already installed\""},{"line_number":333,"context_line":"    if [ ! -f \"$cachedir/$rpm\" ]; then"},{"line_number":334,"context_line":"        echo -e \"Downloading ${rpm} to ${cachedir}\""},{"line_number":335,"context_line":"        curl $CURL_OPTS \"$url\" -o \"$cachedir/$rpm\" || return 1"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa98f980_3a849ab0","line":332,"updated":"2014-09-17 17:32:47.000000000","message":"Isn\u0027t this still another debug statement, or did u mean to keep this?","commit_id":"9b0b47094c7473186fe8550cdf6e0f0cec8b5f97"}],"tools/build-pbr-for-scl-python27.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3743e72574509e758a756db763f2ce6224046371","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"\"\"\""},{"line_number":3,"context_line":"This script bootstraps anvil with a pbr rpm for scl python27."},{"line_number":4,"context_line":"\"\"\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_9abae66f","line":3,"updated":"2014-09-17 17:32:47.000000000","message":"Damn, all this was needed just for pbr :-/","commit_id":"9b0b47094c7473186fe8550cdf6e0f0cec8b5f97"}]}