)]}'
{"ansible/install/roles/workloads/templates/pbench-fio-user.file":[{"author":{"_account_id":21143,"name":"Alex Krzos","email":"akrzos@redhat.com","username":"akrzos"},"change_message_id":"cda8e2ae7ff3a36a653262f97d90ccb481d181cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"sudo echo \"nameserver {{ dns_server }}\" \u003e /etc/resolv.conf"},{"line_number":3,"context_line":"sudo wget -O /etc/yum.repos.d/pbench.repo \"{{ pbench_internal_url }}\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"sudo cat \u003c\u003c EOF \u003e\u003e /etc/yum.repos.d/pbench.repo"},{"line_number":6,"context_line":"# Template file to be used with ansible playbook \"pbench-repo.yml\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7f515b1d_799e0c64","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":13},"updated":"2017-10-06 12:36:59.000000000","message":"Lets change this to curl since wget may not be available","commit_id":"0e3e5e2c5424bfdcf693bd95eecc11e60cfcd28f"},{"author":{"_account_id":21143,"name":"Alex Krzos","email":"akrzos@redhat.com","username":"akrzos"},"change_message_id":"cda8e2ae7ff3a36a653262f97d90ccb481d181cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"sudo yum install -y pbench-fio"},{"line_number":26,"context_line":"sudo sed -i \u0027s/disable_root: 1/disable_root: 0/g\u0027 /etc/cloud/cloud.cfg"},{"line_number":27,"context_line":"cat /etc/cloud/cloud.cfg | grep disable_root"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"echo \"Browbeat workload installed\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7f515b1d_f9831c03","line":28,"updated":"2017-10-06 12:36:59.000000000","message":"If root is required we need the same sed command as pbench-uperf user file","commit_id":"0e3e5e2c5424bfdcf693bd95eecc11e60cfcd28f"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":17,"context_line":"enabled_metadata\u003d1"},{"line_number":18,"context_line":"skip_if_unavailable\u003d1"},{"line_number":19,"context_line":"EOF"},{"line_number":20,"context_line":"cat /etc/yum.repos.d/pbench.repo"},{"line_number":21,"context_line":"sudo yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm"},{"line_number":22,"context_line":"sudo yum clean all"},{"line_number":23,"context_line":"sudo yum install -y python-pandas"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_71bc08dc","line":20,"updated":"2018-08-08 14:30:37.000000000","message":"Not sure why you are downloading the repo then overwriting it?","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"be5ef3663aaabafeae410ed1d4d8890e35b84f51","unresolved":false,"context_lines":[{"line_number":17,"context_line":"enabled_metadata\u003d1"},{"line_number":18,"context_line":"skip_if_unavailable\u003d1"},{"line_number":19,"context_line":"EOF"},{"line_number":20,"context_line":"cat /etc/yum.repos.d/pbench.repo"},{"line_number":21,"context_line":"sudo yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm"},{"line_number":22,"context_line":"sudo yum clean all"},{"line_number":23,"context_line":"sudo yum install -y python-pandas"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_34abde89","line":20,"in_reply_to":"3f79a3b5_71bc08dc","updated":"2018-11-30 18:28:50.000000000","message":"Good catch. The prior should be pbench-internal.repo","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":20,"context_line":"cat /etc/yum.repos.d/pbench.repo"},{"line_number":21,"context_line":"sudo yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm"},{"line_number":22,"context_line":"sudo yum clean all"},{"line_number":23,"context_line":"sudo yum install -y python-pandas"},{"line_number":24,"context_line":"sudo yum install -y pbench-agent"},{"line_number":25,"context_line":"sudo yum install -y pbench-agent-internal"},{"line_number":26,"context_line":"sudo yum install -y pbench-sysstat"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_9163e4b1","line":23,"updated":"2018-08-08 14:30:37.000000000","message":"The yum installs can all be done on one line.","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"be5ef3663aaabafeae410ed1d4d8890e35b84f51","unresolved":false,"context_lines":[{"line_number":20,"context_line":"cat /etc/yum.repos.d/pbench.repo"},{"line_number":21,"context_line":"sudo yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm"},{"line_number":22,"context_line":"sudo yum clean all"},{"line_number":23,"context_line":"sudo yum install -y python-pandas"},{"line_number":24,"context_line":"sudo yum install -y pbench-agent"},{"line_number":25,"context_line":"sudo yum install -y pbench-agent-internal"},{"line_number":26,"context_line":"sudo yum install -y pbench-sysstat"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_94bf52cf","line":23,"in_reply_to":"3f79a3b5_9163e4b1","updated":"2018-11-30 18:28:50.000000000","message":"Right - They were broken up for simply debuggability. I run this, and check via the nova console-log to see if anything breaks up.","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":26,"context_line":"sudo yum install -y pbench-sysstat"},{"line_number":27,"context_line":"sudo yum install -y pbench-fio"},{"line_number":28,"context_line":"sudo sed -i \u0027s/disable_root: 1/disable_root: 0/g\u0027 /etc/cloud/cloud.cfg"},{"line_number":29,"context_line":"cat /etc/cloud/cloud.cfg | grep disable_root"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"echo \"Browbeat workload installed\""}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_b177003b","line":29,"updated":"2018-08-08 14:30:37.000000000","message":"Probably can just check the return value of grep here.","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c4e4b0eb3c45a269c2cd7b6e34848c702eba6574","unresolved":false,"context_lines":[{"line_number":17,"context_line":"enabled_metadata\u003d1"},{"line_number":18,"context_line":"skip_if_unavailable\u003d1"},{"line_number":19,"context_line":"EOF"},{"line_number":20,"context_line":"sudo yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm"},{"line_number":21,"context_line":"sudo yum clean all"},{"line_number":22,"context_line":"sudo yum install -y python-pandas"},{"line_number":23,"context_line":"sudo yum install -y pbench-agent"}],"source_content_type":"application/x-shellscript","patch_set":29,"id":"3f79a3b5_5528d132","line":20,"updated":"2018-08-08 19:50:37.000000000","message":"nit: New line for readability?","commit_id":"da27ab3b23513704a9fbc1d2fbb54fc40ce584e6"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c4e4b0eb3c45a269c2cd7b6e34848c702eba6574","unresolved":false,"context_lines":[{"line_number":24,"context_line":"sudo yum install -y pbench-agent-internal"},{"line_number":25,"context_line":"sudo yum install -y pbench-sysstat"},{"line_number":26,"context_line":"sudo yum install -y pbench-fio"},{"line_number":27,"context_line":"sudo sed -i \u0027s/disable_root: 1/disable_root: 0/g\u0027 /etc/cloud/cloud.cfg"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"echo \"Browbeat workload installed\""}],"source_content_type":"application/x-shellscript","patch_set":29,"id":"3f79a3b5_752b8d2f","line":27,"updated":"2018-08-08 19:50:37.000000000","message":"ditto","commit_id":"da27ab3b23513704a9fbc1d2fbb54fc40ce584e6"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"05b895ed1e70e5cf88027e6a32a06f5c68689a27","unresolved":false,"context_lines":[{"line_number":19,"context_line":"EOF"},{"line_number":20,"context_line":"sudo yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm"},{"line_number":21,"context_line":"sudo yum clean all"},{"line_number":22,"context_line":"sudo yum install -y python-pandas"},{"line_number":23,"context_line":"sudo yum install -y pbench-agent"},{"line_number":24,"context_line":"sudo yum install -y pbench-agent-internal"},{"line_number":25,"context_line":"sudo yum install -y pbench-sysstat"}],"source_content_type":"application/x-shellscript","patch_set":37,"id":"3f79a3b5_95b429f6","line":22,"updated":"2018-11-19 14:30:38.000000000","message":"line 22 to 26 can be combined into one command, so you are not calling yum multiple times","commit_id":"720292de3c6fc72d0d1c5866e380a5bfa2657225"}],"browbeat-config.yaml":[{"author":{"_account_id":21143,"name":"Alex Krzos","email":"akrzos@redhat.com","username":"akrzos"},"change_message_id":"22d7429bff287bcfae81724f1d14062c22e12774","unresolved":false,"context_lines":[{"line_number":266,"context_line":"          elastic_host:"},{"line_number":267,"context_line":"          elastic_port: 9200"},{"line_number":268,"context_line":"          file: rally/rally-plugins/workloads/pbench-uperf.yml"},{"line_number":269,"context_line":"          send_results: True"},{"line_number":270,"context_line":"          test_name: \"browbeat-rally\""},{"line_number":271,"context_line":"          file: rally/rally-plugins/nova-create-pbench-uperf/pbench-uperf.yml"},{"line_number":272,"context_line":"        - name: browbeat-pbench-fio"},{"line_number":273,"context_line":"          enabled: true"},{"line_number":274,"context_line":"          user: root"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1f485f77_72425840","line":271,"range":{"start_line":269,"start_character":1,"end_line":271,"end_character":77},"updated":"2017-11-16 20:58:10.000000000","message":"These three lines are duplicated in this yaml dict","commit_id":"6f77ee423b96bdcbb3e08ace90d011016638197b"},{"author":{"_account_id":28477,"name":"Valli Annamalai","email":"valli.annamalai1994@gmail.com","username":"vannama"},"change_message_id":"f3b3d6ba67447181ce71b977daeca25565057b2c","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        image_name: browbeat-fio"},{"line_number":298,"context_line":"        flavor_name: m1.small"},{"line_number":299,"context_line":"        external_network: public"},{"line_number":300,"context_line":"        network_id: 960a41c2-15c8-4291-a2b9-f8c809ffde40"},{"line_number":301,"context_line":"        num_clients: 1"},{"line_number":302,"context_line":"        samples: 1"},{"line_number":303,"context_line":"        attach_volume: true"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_37ea0075","line":300,"range":{"start_line":300,"start_character":1,"end_line":300,"end_character":56},"updated":"2018-08-08 15:25:40.000000000","message":"network_id to be left empty.","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":26109,"name":"Aakarsh","email":"aakarsh.g2012@gmail.com","username":"agopi"},"change_message_id":"e2aa1a209703f3cd7c29578f6ae73b7361e56c02","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        test_name: browbeat-pbench-fio"},{"line_number":307,"context_line":"        send_results: true"},{"line_number":308,"context_line":"        cloudname: test-fio"},{"line_number":309,"context_line":"        elastic_host: elastic.test.com"},{"line_number":310,"context_line":"        elastic_port: 9200"},{"line_number":311,"context_line":"        file: rally/rally-plugins/workloads/pbench-fio.yml"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_fe7815f9","line":310,"range":{"start_line":309,"start_character":0,"end_line":310,"end_character":26},"updated":"2018-08-06 18:01:47.000000000","message":"why use a separate elastic host? can\u0027t we use elasticsearch defined at a higher level?","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"}],"doc/source/plugins.rst":[{"author":{"_account_id":21143,"name":"Alex Krzos","email":"akrzos@redhat.com","username":"akrzos"},"change_message_id":"22d7429bff287bcfae81724f1d14062c22e12774","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Scenario - pbench-fio"},{"line_number":44,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Stnad up"},{"line_number":47,"context_line":"--------"},{"line_number":48,"context_line":"With the Browbeat Install the user must enable workloads,"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_925cb4ed","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":5},"updated":"2017-11-16 20:58:10.000000000","message":"Stand","commit_id":"6f77ee423b96bdcbb3e08ace90d011016638197b"},{"author":{"_account_id":26109,"name":"Aakarsh","email":"aakarsh.g2012@gmail.com","username":"agopi"},"change_message_id":"a20a4c650d485c96e40411e28388a1a6a595a165","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Scenario - pbench-fio"},{"line_number":49,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Stnad up"},{"line_number":52,"context_line":"--------"},{"line_number":53,"context_line":"With the Browbeat Install the user must enable workloads,"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f79a3b5_ec6401b7","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":6},"updated":"2018-11-13 19:14:28.000000000","message":"stand","commit_id":"0b2111ce860ccb7341d4c50356cb87df0ed57884"}],"elastic/templates/browbeat-pbench-fio-.json":[{"author":{"_account_id":26109,"name":"Aakarsh","email":"aakarsh.g2012@gmail.com","username":"agopi"},"change_message_id":"1b803ad672785a406a6179395aa52144231d2e8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    template: \"browbeat-pbench-fio-*\","},{"line_number":3,"context_line":"    mappings: {"},{"line_number":4,"context_line":"        result: {"},{"line_number":5,"context_line":"            properties: {"},{"line_number":6,"context_line":"                browbeat_config: {"},{"line_number":7,"context_line":"                    properties: {"},{"line_number":8,"context_line":"                        browbeat: {"},{"line_number":9,"context_line":"                            properties: {"},{"line_number":10,"context_line":"                                attach_volume: {"},{"line_number":11,"context_line":"                                    type: \"boolean\""},{"line_number":12,"context_line":"                                },"},{"line_number":13,"context_line":"                                cloud_name: {"},{"line_number":14,"context_line":"                                    index: \"not_analyzed\","},{"line_number":15,"context_line":"                                    type: \"string\""},{"line_number":16,"context_line":"                                },"},{"line_number":17,"context_line":"                                num_clients: {"},{"line_number":18,"context_line":"                                    type: \"long\""},{"line_number":19,"context_line":"                                },"},{"line_number":20,"context_line":"                                preallocate: {"},{"line_number":21,"context_line":"                                    type: \"boolean\""},{"line_number":22,"context_line":"                                },"},{"line_number":23,"context_line":"                                test_name: {"},{"line_number":24,"context_line":"                                    index: \"not_analyzed\","},{"line_number":25,"context_line":"                                    type: \"string\""},{"line_number":26,"context_line":"                                }"},{"line_number":27,"context_line":"                            }"},{"line_number":28,"context_line":"                        }"},{"line_number":29,"context_line":"                    }"},{"line_number":30,"context_line":"                },"},{"line_number":31,"context_line":"                action: {"},{"line_number":32,"context_line":"                    index: \"not_analyzed\","},{"line_number":33,"context_line":"                    type: \"string\""},{"line_number":34,"context_line":"                },"},{"line_number":35,"context_line":"                browbeat_uuid: {"},{"line_number":36,"context_line":"                    index: \"not_analyzed\","},{"line_number":37,"context_line":"                    type: \"string\""},{"line_number":38,"context_line":"                },"},{"line_number":39,"context_line":"                cloud_name: {"},{"line_number":40,"context_line":"                    index: \"not_analyzed\","},{"line_number":41,"context_line":"                    type: \"string\""},{"line_number":42,"context_line":"                },"},{"line_number":43,"context_line":"                grafana_url: {"},{"line_number":44,"context_line":"                    properties: {"},{"line_number":45,"context_line":"                        openstack-general-system-performance: {"},{"line_number":46,"context_line":"                            index: \"not_analyzed\","},{"line_number":47,"context_line":"                            type: \"string\""},{"line_number":48,"context_line":"                        }"},{"line_number":49,"context_line":"                    }"},{"line_number":50,"context_line":"                },"},{"line_number":51,"context_line":"                result: {"},{"line_number":52,"context_line":"                    type: \"string\""},{"line_number":53,"context_line":"                },"},{"line_number":54,"context_line":"                scenario: {"},{"line_number":55,"context_line":"                    index: \"not_analyzed\","},{"line_number":56,"context_line":"                    type: \"string\""},{"line_number":57,"context_line":"                },"},{"line_number":58,"context_line":"                timestamp: {"},{"line_number":59,"context_line":"                    type: \"date\","},{"line_number":60,"context_line":"                    format: \"strict_date_optional_time||epoch_millis\""},{"line_number":61,"context_line":"                }"},{"line_number":62,"context_line":"            }"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":"}"}],"source_content_type":"application/json","patch_set":29,"id":"3f79a3b5_ba0c7eec","line":65,"range":{"start_line":1,"start_character":0,"end_line":65,"end_character":1},"updated":"2018-08-10 15:07:56.000000000","message":"Can you please make it elasticsearch v6 friendly \n\nhttps://www.elastic.co/blog/strings-are-dead-long-live-strings \n\nwould be helpful","commit_id":"da27ab3b23513704a9fbc1d2fbb54fc40ce584e6"}],"rally/rally-plugins/workloads/pbench-fio.py":[{"author":{"_account_id":28477,"name":"Valli Annamalai","email":"valli.annamalai1994@gmail.com","username":"vannama"},"change_message_id":"1629276e547477375ebc8a3d7e1168d933b7feda","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"#   limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from rally.plugins.openstack.scenarios.vm import utils as vm_utils"},{"line_number":14,"context_line":"from rally.plugins.openstack.scenarios.neutron import utils as neutron_utils"},{"line_number":15,"context_line":"from rally.common import sshutils"},{"line_number":16,"context_line":"from rally.task import scenario"},{"line_number":17,"context_line":"from rally.task import types"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f79a3b5_9d63f5dc","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":76},"updated":"2018-08-08 16:52:38.000000000","message":"needs to be rally_openstack.scenarios.vm import ..\nand rally_openstack.scenarios.neutron import ..","commit_id":"0dcc7aeea47b98b44e0befc1e2d605a900aa3f1d"},{"author":{"_account_id":26109,"name":"Aakarsh","email":"aakarsh.g2012@gmail.com","username":"agopi"},"change_message_id":"0f1f1a74d3dde34d31201e529f97d407cb58f696","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from rally.task import scenario"},{"line_number":17,"context_line":"from rally.task import types"},{"line_number":18,"context_line":"from rally.task import validation"},{"line_number":19,"context_line":"from rally import consts"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"import StringIO"},{"line_number":22,"context_line":"import csv"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f79a3b5_5ba83b1e","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":11},"updated":"2018-08-06 17:16:39.000000000","message":"needs to be rally_openstack","commit_id":"0dcc7aeea47b98b44e0befc1e2d605a900aa3f1d"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.task import types"},{"line_number":18,"context_line":"from rally.task import validation"},{"line_number":19,"context_line":"from rally_openstack import consts"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"import StringIO"},{"line_number":22,"context_line":"import csv"},{"line_number":23,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_b192a0f5","line":20,"updated":"2018-08-08 14:30:37.000000000","message":"the imports of the standard libraries should be before the rally imports","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                        vm_utils.VMScenario):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def build_jump_host("},{"line_number":49,"context_line":"            self,"},{"line_number":50,"context_line":"            external,"},{"line_number":51,"context_line":"            image,"},{"line_number":52,"context_line":"            flavor,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_7163a81b","line":49,"updated":"2018-08-08 14:30:37.000000000","message":"Should be on line 48","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        return jump_ssh, jump_host_ip, jump_host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def create_guests("},{"line_number":85,"context_line":"            self,"},{"line_number":86,"context_line":"            jump_ssh,"},{"line_number":87,"context_line":"            num_of_guests,"},{"line_number":88,"context_line":"            image,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_316d3004","line":85,"updated":"2018-08-08 14:30:37.000000000","message":"Should be on line 84","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                #    flavor,"},{"line_number":137,"context_line":"                #    requests\u003d1,"},{"line_number":138,"context_line":"                #    instances_amount\u003dreq,"},{"line_number":139,"context_line":"                #    **kwargs)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"                server \u003d self._boot_server("},{"line_number":142,"context_line":"                    image,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_91f3e473","line":139,"updated":"2018-08-08 14:30:37.000000000","message":"Can remove this comment for now, the note is good enough we can debug it later?","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        return _servers, _server_obj"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def run("},{"line_number":180,"context_line":"            self,"},{"line_number":181,"context_line":"            image,"},{"line_number":182,"context_line":"            flavor,"},{"line_number":183,"context_line":"            user,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_117274e4","line":180,"updated":"2018-08-08 14:30:37.000000000","message":"Should be on line 179","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        jump_ssh.put_file(jobfile, \u0027/root/fio.job\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        # Disable Pandas :"},{"line_number":244,"context_line":"        # https://github.com/distributed-system-analysis/pbench/issues/716"},{"line_number":245,"context_line":"        cmd \u003d \"sed -i s/pandas_install$/true/g\""},{"line_number":246,"context_line":"        cmd \u003d \"{} {}/bench-scripts/pbench-fio\".format(cmd, pbench_path)"},{"line_number":247,"context_line":"        exitcode, stdout, stderr \u003d jump_ssh.execute(cmd, timeout\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_513eacda","line":244,"updated":"2018-08-08 14:30:37.000000000","message":"Is this still needed according to the bug report you filed says its fixed?","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"be5ef3663aaabafeae410ed1d4d8890e35b84f51","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        jump_ssh.put_file(jobfile, \u0027/root/fio.job\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        # Disable Pandas :"},{"line_number":244,"context_line":"        # https://github.com/distributed-system-analysis/pbench/issues/716"},{"line_number":245,"context_line":"        cmd \u003d \"sed -i s/pandas_install$/true/g\""},{"line_number":246,"context_line":"        cmd \u003d \"{} {}/bench-scripts/pbench-fio\".format(cmd, pbench_path)"},{"line_number":247,"context_line":"        exitcode, stdout, stderr \u003d jump_ssh.execute(cmd, timeout\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_a376d205","line":244,"in_reply_to":"3f79a3b5_513eacda","updated":"2018-11-30 18:28:50.000000000","message":"Done","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":28477,"name":"Valli Annamalai","email":"valli.annamalai1994@gmail.com","username":"vannama"},"change_message_id":"1629276e547477375ebc8a3d7e1168d933b7feda","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            for server in server_obj:"},{"line_number":252,"context_line":"                # Create and attach volume to guest"},{"line_number":253,"context_line":"                volume \u003d self._attach_volume("},{"line_number":254,"context_line":"                    server, self._create_volume(vol_size))"},{"line_number":255,"context_line":"                LOG.info(\"Volume attached at: {}\".format(volume.device))"},{"line_number":256,"context_line":"                sip \u003d None"},{"line_number":257,"context_line":"                if create_network:"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_dd4acd25","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":58},"updated":"2018-08-08 16:52:38.000000000","message":"you might have to import cinder utils else this throws error: no attribute _create_volume.","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c4e4b0eb3c45a269c2cd7b6e34848c702eba6574","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":"import ConfigParser"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"from rally.plugins.openstack.scenarios.cinder import utils as cinder_utils"},{"line_number":22,"context_line":"from rally.plugins.openstack.scenarios.vm import utils as vm_utils"},{"line_number":23,"context_line":"from rally.plugins.openstack.scenarios.neutron import utils as neutron_utils"},{"line_number":24,"context_line":"from rally.common import sshutils"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f79a3b5_75b94de7","line":21,"updated":"2018-08-08 19:50:37.000000000","message":"nit: newline","commit_id":"da27ab3b23513704a9fbc1d2fbb54fc40ce584e6"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c4e4b0eb3c45a269c2cd7b6e34848c702eba6574","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from rally.task import types"},{"line_number":27,"context_line":"from rally.task import validation"},{"line_number":28,"context_line":"from rally_openstack import consts"},{"line_number":29,"context_line":"import browbeat.elastic"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f79a3b5_35cbd572","line":29,"updated":"2018-08-08 19:50:37.000000000","message":"nit: newline","commit_id":"da27ab3b23513704a9fbc1d2fbb54fc40ce584e6"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c4e4b0eb3c45a269c2cd7b6e34848c702eba6574","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                elastic.index_result(result_json, test_name, \u0027results/\u0027)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        # Prepare results"},{"line_number":358,"context_line":"        # exitcode, stdout, stderr \u003d jump_ssh.execute("},{"line_number":359,"context_line":"        #    \"cat {}/fio_{}*/generate-benchmark-summary.cmd\".format(pbench_results, test_name))"},{"line_number":360,"context_line":"        exitcode, stdout, stderr \u003d jump_ssh.execute("},{"line_number":361,"context_line":"            \"cat {}/fio_{}*/result.csv\".format(pbench_results, test_name))"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f79a3b5_9562e93d","line":358,"updated":"2018-08-08 19:50:37.000000000","message":"nit: remove this line","commit_id":"da27ab3b23513704a9fbc1d2fbb54fc40ce584e6"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"05b895ed1e70e5cf88027e6a32a06f5c68689a27","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                        vm_utils.VMScenario,"},{"line_number":47,"context_line":"                        cinder_utils.CinderScenario):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def build_jump_host(self,"},{"line_number":50,"context_line":"                        external,"},{"line_number":51,"context_line":"                        image,"},{"line_number":52,"context_line":"                        flavor,"}],"source_content_type":"text/x-python","patch_set":37,"id":"3f79a3b5_75a62dc2","line":49,"updated":"2018-11-19 14:30:38.000000000","message":"nit: line wrap","commit_id":"720292de3c6fc72d0d1c5866e380a5bfa2657225"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"05b895ed1e70e5cf88027e6a32a06f5c68689a27","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        jump_ssh.execute(\"chmod 0600 ~/.ssh/id_rsa\")"},{"line_number":82,"context_line":"        return jump_ssh, jump_host_ip, jump_host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def create_guests(self,"},{"line_number":85,"context_line":"                      jump_ssh,"},{"line_number":86,"context_line":"                      num_of_guests,"},{"line_number":87,"context_line":"                      image,"}],"source_content_type":"text/x-python","patch_set":37,"id":"3f79a3b5_f591dd51","line":84,"updated":"2018-11-19 14:30:38.000000000","message":"nit: ditto","commit_id":"720292de3c6fc72d0d1c5866e380a5bfa2657225"}],"rally/rally-plugins/workloads/pbench-uperf.py":[{"author":{"_account_id":21143,"name":"Alex Krzos","email":"akrzos@redhat.com","username":"akrzos"},"change_message_id":"22d7429bff287bcfae81724f1d14062c22e12774","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"#   you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"#   You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f485f77_9286f412","line":1,"updated":"2017-11-16 20:58:10.000000000","message":"I think this is the incorrect file, I would venture to guess the fio one would be pbench-fio.py.","commit_id":"6f77ee423b96bdcbb3e08ace90d011016638197b"},{"author":{"_account_id":21143,"name":"Alex Krzos","email":"akrzos@redhat.com","username":"akrzos"},"change_message_id":"22d7429bff287bcfae81724f1d14062c22e12774","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            \"neutron\"],"},{"line_number":44,"context_line":"        \"keypair\": {},"},{"line_number":45,"context_line":"        \"allow_ssh\": None},"},{"line_number":46,"context_line":"    name\u003d\"BrowbeatPlugin.pbench_uperf\")"},{"line_number":47,"context_line":"class BrowbeatPluginUPerf(neutron_utils.NeutronScenario,"},{"line_number":48,"context_line":"                     vm_utils.VMScenario,"},{"line_number":49,"context_line":"                     scenario.Scenario):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f485f77_5293dc5b","line":46,"range":{"start_line":46,"start_character":10,"end_line":46,"end_character":37},"updated":"2017-11-16 20:58:10.000000000","message":"Shouldn\u0027t this be BrowbeatPlugin.pbench_fio or are we missing the fio python file for this commit?","commit_id":"6f77ee423b96bdcbb3e08ace90d011016638197b"},{"author":{"_account_id":26109,"name":"Aakarsh","email":"aakarsh.g2012@gmail.com","username":"agopi"},"change_message_id":"0f1f1a74d3dde34d31201e529f97d407cb58f696","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from rally.task import scenario"},{"line_number":19,"context_line":"from rally.task import types"},{"line_number":20,"context_line":"from rally.task import validation"},{"line_number":21,"context_line":"from rally import consts"},{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":"import StringIO"},{"line_number":24,"context_line":"import csv"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f79a3b5_fb30270a","line":21,"range":{"start_line":21,"start_character":5,"end_line":21,"end_character":11},"updated":"2018-08-06 17:16:39.000000000","message":"Is not needed as we already did it in L15","commit_id":"0dcc7aeea47b98b44e0befc1e2d605a900aa3f1d"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"5259e0e261d5402b3c6757e1fc01b6f12504fe23","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from rally.task import scenario"},{"line_number":19,"context_line":"from rally.task import types"},{"line_number":20,"context_line":"from rally.task import validation"},{"line_number":21,"context_line":"from rally import consts"},{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":"import StringIO"},{"line_number":24,"context_line":"import csv"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f79a3b5_b262d315","line":21,"updated":"2018-08-06 16:04:10.000000000","message":"consts not used anywhere.","commit_id":"0dcc7aeea47b98b44e0befc1e2d605a900aa3f1d"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return jump_ssh, jump_host_ip, jump_host"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def create_guests("},{"line_number":73,"context_line":"            self,"},{"line_number":74,"context_line":"            jump_ssh,"},{"line_number":75,"context_line":"            num_of_guests,"},{"line_number":76,"context_line":"            image,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_b435aedc","line":73,"updated":"2018-08-08 14:30:37.000000000","message":"Should be on line 72","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"3207b3bcfd0605338ec1304ed6509f591fdd6785","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return _servers, _server_obj"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def create_guest_pairs("},{"line_number":147,"context_line":"            self,"},{"line_number":148,"context_line":"            jump_ssh,"},{"line_number":149,"context_line":"            num_pairs,"},{"line_number":150,"context_line":"            image,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f79a3b5_3470bea5","line":147,"updated":"2018-08-08 14:30:37.000000000","message":"Should be on line 147","commit_id":"bda75d25a0d8e9cf881153011bad1cdf65cb695a"},{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"0cba6e7347dff3f9ff682d1f2722508514ea7a4b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            _servers.append("},{"line_number":101,"context_line":"                str(server.addresses[network_name][0][\"addr\"]))"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            for i in range(num_of_guests):"},{"line_number":104,"context_line":"                if zones[\u0027server\u0027] !\u003d \u0027None\u0027:"},{"line_number":105,"context_line":"                    kwargs[\u0027availability_zone\u0027] \u003d zones[\u0027server\u0027]"},{"line_number":106,"context_line":"                server \u003d self._boot_server("}],"source_content_type":"text/x-python","patch_set":35,"id":"3f79a3b5_35e54308","line":103,"updated":"2018-11-15 01:34:34.000000000","message":"If \"i\" is not being used anywhere else, best to use \"_\" to iterate.\n\nfor _ in range(num_of_guests)","commit_id":"204eb83d6f8cc1e21ded747bd7ec72f7f5c2daa7"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"05b895ed1e70e5cf88027e6a32a06f5c68689a27","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return jump_ssh, jump_host_ip, jump_host"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def create_guests("},{"line_number":73,"context_line":"            self,"},{"line_number":74,"context_line":"            jump_ssh,"},{"line_number":75,"context_line":"            num_of_guests,"},{"line_number":76,"context_line":"            image,"}],"source_content_type":"text/x-python","patch_set":37,"id":"3f79a3b5_151a5918","line":73,"updated":"2018-11-19 14:30:38.000000000","message":"nit: seems to be line wrapped weird","commit_id":"720292de3c6fc72d0d1c5866e380a5bfa2657225"}]}