)]}'
{"ansible/install/browbeat-inventory.yml":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"2b3cb40f5f57803d0c421689cabde14ff40a8653","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- hosts: all"},{"line_number":3,"context_line":"  name: Create browbeat inventory and ssh-config"},{"line_number":4,"context_line":"  roles:"},{"line_number":5,"context_line":"    - browbeat-inventory"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_cb2acae5","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":12},"updated":"2019-06-24 15:45:36.000000000","message":"Why is this hosts all? The command eventually seems to run on undercloud only. Shouldn\u0027t this run on the undercloud ?","commit_id":"222ee8192004ef0ecb28293dda916c7a9062c529"}],"ansible/install/roles/browbeat-inventory/defaults/main.yml":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"6db975acf3d66748b0683ae413daba1dd4f688dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# undercloud hostname"},{"line_number":3,"context_line":"host: localhost"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_9a31795c","line":3,"updated":"2019-06-24 17:48:25.000000000","message":"Needs to be undercloud_host","commit_id":"222ee8192004ef0ecb28293dda916c7a9062c529"}],"ansible/install/roles/browbeat-inventory/tasks/openstack.yml":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"2b3cb40f5f57803d0c421689cabde14ff40a8653","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Query the tripleo ansible inventory"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    source /home/stack/stackrc"},{"line_number":5,"context_line":"    tripleo-ansible-inventory --list"},{"line_number":6,"context_line":"  register: browbeat_nodes_output"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: set fact for filtered openstack inventory nodes"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_6b395e3d","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":36},"updated":"2019-06-24 15:45:36.000000000","message":"I think we should check if the command exists first, since this patch has not been tested against OSP 10 or 13. Can we please have this tested on those versions? The hosts file generation is the barrier of entry for rest of browbeat and would be important to ensure this does not fail.","commit_id":"222ee8192004ef0ecb28293dda916c7a9062c529"}],"ansible/install/roles/browbeat-inventory/templates/ssh-config.j2":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"51f647f6e08200947f4b97883c9bb82e570c93f0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"{% endfor %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Host undercloud-root"},{"line_number":14,"context_line":"  Hostname localhost"},{"line_number":15,"context_line":"  User root"},{"line_number":16,"context_line":"  IdentityFile ~/.ssh/id_rsa"},{"line_number":17,"context_line":"  StrictHostKeyChecking no"},{"line_number":18,"context_line":"  UserKnownHostsFile\u003d/dev/null"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Host undercloud"},{"line_number":21,"context_line":"  HostName localhost"},{"line_number":22,"context_line":"  User stack"},{"line_number":23,"context_line":"  IdentityFile ~/.ssh/id_rsa"},{"line_number":24,"context_line":"  StrictHostKeyChecking no"},{"line_number":25,"context_line":"  UserKnownHostsFile\u003d/dev/null"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fb8cfa7_daeff684","line":25,"range":{"start_line":13,"start_character":0,"end_line":25,"end_character":30},"updated":"2019-06-24 13:32:33.000000000","message":"How are we assuming that undercloud is localhost? In the earlier bash script there was an option to specify undercloud inventory. Browbeat should not depend on being run from undercloud, it should be able to run from a jump host.","commit_id":"a85f8d67cd4a0b60fa265499fa524802902097be"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"5c47fd4ab68d4d687b6913f50832b59c950f3dc6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"{% endfor %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Host undercloud-root"},{"line_number":14,"context_line":"  Hostname localhost"},{"line_number":15,"context_line":"  User root"},{"line_number":16,"context_line":"  IdentityFile ~/.ssh/id_rsa"},{"line_number":17,"context_line":"  StrictHostKeyChecking no"},{"line_number":18,"context_line":"  UserKnownHostsFile\u003d/dev/null"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Host undercloud"},{"line_number":21,"context_line":"  HostName localhost"},{"line_number":22,"context_line":"  User stack"},{"line_number":23,"context_line":"  IdentityFile ~/.ssh/id_rsa"},{"line_number":24,"context_line":"  StrictHostKeyChecking no"},{"line_number":25,"context_line":"  UserKnownHostsFile\u003d/dev/null"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fb8cfa7_90b71f87","line":25,"range":{"start_line":13,"start_character":0,"end_line":25,"end_character":30},"in_reply_to":"9fb8cfa7_daeff684","updated":"2019-06-24 15:14:56.000000000","message":"Fixed","commit_id":"a85f8d67cd4a0b60fa265499fa524802902097be"}]}