)]}'
{"ansible/install/group_vars/all.yml":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"83aac1ab4d511a301246c1632727e67d4c5c4039","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"home_dir: \"/home/{{browbeat_user}}\""},{"line_number":19,"context_line":"browbeat_path: \"{{home_dir}}/browbeat\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"rally_undercloud_enabled: true"},{"line_number":22,"context_line":"rally_overcloud_enabled: true"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_782449b2","line":20,"updated":"2020-02-17 14:50:46.000000000","message":"Please add some comments about what each option does.","commit_id":"2d8bd10a3ab4f4d47992d54754aea34e2043155f"},{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"ff7127a0b2e971bc80bc61073e06f9b4c2bb4b29","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The Undercloud RC file"},{"line_number":28,"context_line":"stackrc: \"{{home_dir}}/stackrc\""},{"line_number":29,"context_line":"undercloudrc: \"{{home_dir}}/undercloudrc\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# The Overcloud RC file"},{"line_number":32,"context_line":"overcloudrc: \"{{home_dir}}/overcloudrc\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_5aed978b","line":29,"updated":"2020-02-27 14:46:55.000000000","message":"Don\u0027t need this right?","commit_id":"3dd07fca88c4490ac5afc8be1d0ce5f0c3bc81e6"}],"ansible/install/roles/rally/tasks/main.yml":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"b8636db55610a3780a7f928237e95378b9839baf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      shell: cat undercloudrc | grep OS_AUTH_URL\u003d"},{"line_number":50,"context_line":"      register: os_auth_url"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    - name: Add v3 to OS_AUTH_URL in stackrc"},{"line_number":53,"context_line":"      replace:"},{"line_number":54,"context_line":"        path: \"{{ undercloudrc }}\""},{"line_number":55,"context_line":"        regexp: \"{{ os_auth_url.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_7cb79623","line":52,"updated":"2020-02-12 18:41:14.000000000","message":"Is this only for TLS everywhere enabled UC?","commit_id":"dc7e28d6bd3f0e1e89c4ab01115c68fbfd71d1b2"},{"author":{"_account_id":30421,"name":"Asma Syed Hameed","email":"asyedham@redhat.com","username":"asyedham"},"change_message_id":"e8f31cd03952a7c498af16810c9ade018b863c6e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      shell: cat undercloudrc | grep OS_AUTH_URL\u003d"},{"line_number":50,"context_line":"      register: os_auth_url"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    - name: Add v3 to OS_AUTH_URL in stackrc"},{"line_number":53,"context_line":"      replace:"},{"line_number":54,"context_line":"        path: \"{{ undercloudrc }}\""},{"line_number":55,"context_line":"        regexp: \"{{ os_auth_url.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d47d3ae5","line":52,"in_reply_to":"3fa7e38b_7cb79623","updated":"2020-02-13 05:14:24.000000000","message":"No, this is needed to authenticate against an identity Server API v3 as the OS_IDENTITY_API_VERSION\u003d3 from queen onwards. So we need to update the OS_AUTH_URL in the undercloud.\ne.g, OS_AUTH_URL\u003dhttp://192.168.24.1:500/v3 as without adding v3 the authentication fails http://paste.openstack.org/show/789492/. Because if the version is not included it considers it to be 2","commit_id":"dc7e28d6bd3f0e1e89c4ab01115c68fbfd71d1b2"},{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"ff7127a0b2e971bc80bc61073e06f9b4c2bb4b29","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    - name: copy of stackrc"},{"line_number":44,"context_line":"      copy:"},{"line_number":45,"context_line":"        src: \"{{ stackrc }}\""},{"line_number":46,"context_line":"        dest: \"{{ undercloudrc }}\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    - name: Get the OS_AUTH_URL value in stackrc"},{"line_number":49,"context_line":"      shell: cat undercloudrc | grep OS_AUTH_URL\u003d"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_1ae71fae","line":46,"range":{"start_line":46,"start_character":14,"end_line":46,"end_character":34},"updated":"2020-02-27 14:46:55.000000000","message":"you can directly use path here","commit_id":"3dd07fca88c4490ac5afc8be1d0ce5f0c3bc81e6"}],"browbeat-config-uc.yaml":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"b8636db55610a3780a7f928237e95378b9839baf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Basic set of initial stress tests to test overcloud before running complete set of benchmarks."},{"line_number":2,"context_line":"browbeat:"},{"line_number":3,"context_line":"  cloud_name: openstack"},{"line_number":4,"context_line":"  rerun: 1"},{"line_number":5,"context_line":"  # Two types of rerun:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9cd93282","line":2,"updated":"2020-02-12 18:41:14.000000000","message":"Why is this config filed needed?","commit_id":"dc7e28d6bd3f0e1e89c4ab01115c68fbfd71d1b2"}],"browbeat-config.yaml":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"83aac1ab4d511a301246c1632727e67d4c5c4039","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    scenarios:"},{"line_number":88,"context_line":"      - name: authentic-keystone"},{"line_number":89,"context_line":"        enabled: true"},{"line_number":90,"context_line":"        rally_benchmark: overcloud"},{"line_number":91,"context_line":"        file: rally/authenticate/keystone-cc.yml"},{"line_number":92,"context_line":"      - name: authentic-neutron"},{"line_number":93,"context_line":"        enabled: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_4d70b110","line":90,"updated":"2020-02-17 14:50:46.000000000","message":"Please change to rally_deployment.","commit_id":"2d8bd10a3ab4f4d47992d54754aea34e2043155f"}],"browbeat/schema/rally.yml":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"ff7127a0b2e971bc80bc61073e06f9b4c2bb4b29","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    enum: [\"rally\"]"},{"line_number":24,"context_line":"  rally_deployment:"},{"line_number":25,"context_line":"    type: str"},{"line_number":26,"context_line":"    required: True"},{"line_number":27,"context_line":"  scenarios:"},{"line_number":28,"context_line":"    type: seq"},{"line_number":29,"context_line":"    sequence:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_fd679deb","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":18},"updated":"2020-02-27 14:46:55.000000000","message":"Don\u0027t make it required","commit_id":"3dd07fca88c4490ac5afc8be1d0ce5f0c3bc81e6"}],"browbeat/workloads/rally.py":[{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"83aac1ab4d511a301246c1632727e67d4c5c4039","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            scenario_name \u003d scenario[\"name\"]"},{"line_number":218,"context_line":"            scenario_file \u003d scenario[\"file\"]"},{"line_number":219,"context_line":"            scenario_rally_benchmark \u003d scenario[\"rally_benchmark\"]"},{"line_number":220,"context_line":"            _rally_benchmark \u003d [\u0027undercloud\u0027, \u0027overcloud\u0027]"},{"line_number":221,"context_line":"            if scenario_rally_benchmark in _rally_benchmark:"},{"line_number":222,"context_line":"                cmd \u003d \"source {}; \".format(get_workload_venv(\u0027rally\u0027, True))"},{"line_number":223,"context_line":"                cmd +\u003d \"rally deployment use {}\".format(scenario_rally_benchmark)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_582e2d5c","line":220,"updated":"2020-02-17 14:50:46.000000000","message":"What if the user wants to benchmark the undercloud in browbeat-config.yaml but the udnercloud deployment was not created in the browbeat install playbook. How does your code handle that?","commit_id":"2d8bd10a3ab4f4d47992d54754aea34e2043155f"},{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"83aac1ab4d511a301246c1632727e67d4c5c4039","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            del scenario[\"enabled\"]"},{"line_number":230,"context_line":"            del scenario[\"file\"]"},{"line_number":231,"context_line":"            del scenario[\"name\"]"},{"line_number":232,"context_line":"            del scenario[\"rally_benchmark\"]"},{"line_number":233,"context_line":"            if len(scenario) \u003e 0:"},{"line_number":234,"context_line":"                self.logger.debug(\"Overriding Scenario Args: {}\".format(scenario))"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_7880c949","line":232,"updated":"2020-02-17 14:50:46.000000000","message":"Instead of this, why don\u0027t you give the user the flexibility to define the rally_deployment at the workload level/scenario level. See how concurreny and times are possible to be defined at the workload level or the scenario level on lines 246-252","commit_id":"2d8bd10a3ab4f4d47992d54754aea34e2043155f"},{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"ff7127a0b2e971bc80bc61073e06f9b4c2bb4b29","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            else:"},{"line_number":241,"context_line":"                concurrencies \u003d def_concurrencies"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            if \"rally_deployment\" not in scenario and \"times\" not in scenario:"},{"line_number":244,"context_line":"                scenario[\"times\"] \u003d def_times"},{"line_number":245,"context_line":"                scenario[\"rally_deployment\"] \u003d def_rally_dep"},{"line_number":246,"context_line":"                _rally_deployment \u003d [\u0027undercloud\u0027, \u0027overcloud\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_1ab5df7d","line":243,"range":{"start_line":243,"start_character":49,"end_line":243,"end_character":53},"updated":"2020-02-27 14:46:55.000000000","message":"Why do you need and here?","commit_id":"3dd07fca88c4490ac5afc8be1d0ce5f0c3bc81e6"},{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"ff7127a0b2e971bc80bc61073e06f9b4c2bb4b29","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                    cmd +\u003d \"rally deployment use {}\".format(def_rally_dep)"},{"line_number":250,"context_line":"                    cmd_stdout \u003d self.tools.run_cmd(cmd)[\u0027stdout\u0027]"},{"line_number":251,"context_line":"                    if cmd_stdout \u003d\u003d \"Deployment {} is not found.\".format(def_rally_dep):"},{"line_number":252,"context_line":"                        exit(1)"},{"line_number":253,"context_line":"                    else:"},{"line_number":254,"context_line":"                        self.logger.info(\" Rally deployment {} is used.\".format(def_rally_dep))"},{"line_number":255,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_5dfcb10a","line":252,"range":{"start_line":252,"start_character":23,"end_line":252,"end_character":31},"updated":"2020-02-27 14:46:55.000000000","message":"Exit with a browbeat logger message","commit_id":"3dd07fca88c4490ac5afc8be1d0ce5f0c3bc81e6"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"2792dc8a576fb4cc065707e16fbd519365cda5ad","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"            if \"rally_deployment\" in scenario:"},{"line_number":246,"context_line":"                _rally_deployment \u003d scenario[\"rally_deployment\"]"},{"line_number":247,"context_line":"            elif \"rally_deployment\" not in scenario and \"rally_deployment\" in workload:"},{"line_number":248,"context_line":"                _rally_deployment \u003d workload[\"rally_deployment\"]"},{"line_number":249,"context_line":"            else:"},{"line_number":250,"context_line":"                _rally_deployment \u003d \u0027overcloud\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_1eeb0bdc","line":247,"range":{"start_line":247,"start_character":17,"end_line":247,"end_character":55},"updated":"2020-03-05 17:00:28.000000000","message":"elif will run only the if fails, so no need to test this here.","commit_id":"98a685b7435d492c4971b684a14b581282bb68e7"},{"author":{"_account_id":30421,"name":"Asma Syed Hameed","email":"asyedham@redhat.com","username":"asyedham"},"change_message_id":"a3f633fa6bc4619f5563b19badb0cb596be977df","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"            if \"rally_deployment\" in scenario:"},{"line_number":246,"context_line":"                _rally_deployment \u003d scenario[\"rally_deployment\"]"},{"line_number":247,"context_line":"            elif \"rally_deployment\" not in scenario and \"rally_deployment\" in workload:"},{"line_number":248,"context_line":"                _rally_deployment \u003d workload[\"rally_deployment\"]"},{"line_number":249,"context_line":"            else:"},{"line_number":250,"context_line":"                _rally_deployment \u003d \u0027overcloud\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_db125b62","line":247,"range":{"start_line":247,"start_character":17,"end_line":247,"end_character":55},"in_reply_to":"1fa4df85_1eeb0bdc","updated":"2020-03-06 07:42:55.000000000","message":"We need to because if \u0027rally_deployment\u0027 is not set at both scenario  and workload level then it should consider overcloud as default rally deployment","commit_id":"98a685b7435d492c4971b684a14b581282bb68e7"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"0ed8d22045c3195c5cc6ee3ec8f0ba5a48f9689d","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"            if \"rally_deployment\" in scenario:"},{"line_number":246,"context_line":"                _rally_deployment \u003d scenario[\"rally_deployment\"]"},{"line_number":247,"context_line":"            elif \"rally_deployment\" not in scenario and \"rally_deployment\" in workload:"},{"line_number":248,"context_line":"                _rally_deployment \u003d workload[\"rally_deployment\"]"},{"line_number":249,"context_line":"            else:"},{"line_number":250,"context_line":"                _rally_deployment \u003d \u0027overcloud\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_9e3e11bf","line":247,"range":{"start_line":247,"start_character":17,"end_line":247,"end_character":55},"in_reply_to":"1fa4df85_db125b62","updated":"2020-03-06 07:50:33.000000000","message":"i am saying this condition `\"rally_deployment\" not in scenario and` is no need. you can write like this `elif \"rally_deployment\" in workload:","commit_id":"98a685b7435d492c4971b684a14b581282bb68e7"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"2792dc8a576fb4cc065707e16fbd519365cda5ad","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                cmd +\u003d \"rally deployment use {}\".format(_rally_deployment)"},{"line_number":257,"context_line":"                cmd_stdout \u003d self.tools.run_cmd(cmd)[\u0027stdout\u0027]"},{"line_number":258,"context_line":"                if cmd_stdout \u003d\u003d \"Deployment {} is not found.\".format(_rally_deployment):"},{"line_number":259,"context_line":"                    self.logger.info(\" Rally deployment {} is not found.\".format(_rally_deployment))"},{"line_number":260,"context_line":"                    exit(1)"},{"line_number":261,"context_line":"            else:"},{"line_number":262,"context_line":"                self.logger.error(\"Wrong rally benchmark name specified.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_3e96074e","line":259,"range":{"start_line":259,"start_character":32,"end_line":259,"end_character":36},"updated":"2020-03-05 17:00:28.000000000","message":"this can be error right?","commit_id":"98a685b7435d492c4971b684a14b581282bb68e7"}]}