)]}'
{"browbeat/prescribe.py":[{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b688179b43d94d50bee1a746f9e66dfae3bb40d8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"       version \u003d {}"},{"line_number":85,"context_line":"       for item, dictionary in six.iteritems(sys_data):"},{"line_number":86,"context_line":"           if sys_data[item][\u0027group_names\u0027] \u003d\u003d \u0027undercloud\u0027:"},{"line_number":87,"context_line":"                for key, value in six.iteritems(sys_data[item]):"},{"line_number":88,"context_line":"                    if key \u003d\u003d \u0027stockpile_rhosp_version\u0027:"},{"line_number":89,"context_line":"                        version[\u0027rhosp_version\u0027] \u003d output"},{"line_number":90,"context_line":"                    if key \u003d\u003d \u0027stockpile_rhosp_major\u0027:"},{"line_number":91,"context_line":"                        version[\u0027rhosp_major\u0027] \u003d output"},{"line_number":92,"context_line":"                    if key \u003d\u003d \u0027stockpile_rhosp_puddle\u0027:"},{"line_number":93,"context_line":"                        version[\u0027rhosp_puddle\u0027] \u003d output"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def get_software_metadata(self, sys_data):"},{"line_number":96,"context_line":"        soft_all_dict \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_df9b5e63","line":93,"range":{"start_line":87,"start_character":16,"end_line":93,"end_character":56},"updated":"2020-03-03 13:50:05.000000000","message":"if \u0027stockpile_rhosp_version\u0027 in dictionary:\n  version[\u0027rhosp_version\u0027] \u003d dictionary[\u0027stockpile_rhosp_version\u0027]\nif \u0027stockpile_rhosp_major\u0027 in dictionary:\n  version[\u0027rhosp_major\u0027] \u003d dictionary[\u0027stockpile_rhosp_major\u0027]\n//same for puddle\n\nnot sure about the length of the dict and all the three if have to run for all the values. so just proposing the above method.","commit_id":"29f2051e24ca37300567e2f32961a53a557ce8ab"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"e9b0f74bca2092406f1a40bf111d70cbba8e52bc","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def get_version_metadata(self, sys_data):"},{"line_number":84,"context_line":"        version \u003d {}"},{"line_number":85,"context_line":"        for item, dictionary in six.iteritems(sys_data):"},{"line_number":86,"context_line":"            if sys_data[item][\u0027group_names\u0027] \u003d\u003d \u0027undercloud\u0027:"},{"line_number":87,"context_line":"                if \u0027stockpile_rhosp_version\u0027 in dictionary:"},{"line_number":88,"context_line":"                    version[\u0027rhosp_version\u0027] \u003d dictionary[\u0027stockpile_rhosp_version\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_0691af47","line":85,"updated":"2020-03-03 17:37:24.000000000","message":"can we break this loop once we found the undercloud group?","commit_id":"d1eb58d0bf21503ef5f0109300c9e199862e093e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"57a03def4f3e9793a5f2aeaa8df7f74bb88603dd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def get_version_metadata(self, sys_data):"},{"line_number":84,"context_line":"        version \u003d {}"},{"line_number":85,"context_line":"        for item, dictionary in six.iteritems(sys_data):"},{"line_number":86,"context_line":"            if sys_data[item][\u0027group_names\u0027] \u003d\u003d \u0027undercloud\u0027:"},{"line_number":87,"context_line":"                if \u0027stockpile_rhosp_version\u0027 in dictionary:"},{"line_number":88,"context_line":"                    version[\u0027rhosp_version\u0027] \u003d dictionary[\u0027stockpile_rhosp_version\u0027]"},{"line_number":89,"context_line":"                if \u0027stockpile_rhosp_major\u0027 in dictionary:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_c1c34e88","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":61},"updated":"2020-03-06 09:25:39.000000000","message":"group_names is a list object, so we have to check using the in keyword, if \u0027undercloud\u0027 in sys_data[item][\u0027grorp_names\u0027]:","commit_id":"d1eb58d0bf21503ef5f0109300c9e199862e093e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"57a03def4f3e9793a5f2aeaa8df7f74bb88603dd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                if \u0027stockpile_rhosp_major\u0027 in dictionary:"},{"line_number":90,"context_line":"                    version[\u0027rhosp_major\u0027] \u003d dictionary[\u0027stockpile_rhosp_major\u0027]"},{"line_number":91,"context_line":"                if \u0027stockpile_rhosp_puddle\u0027 in dictionary:"},{"line_number":92,"context_line":"                    version[\u0027rhosp_puddle\u0027] \u003d dictionary[\u0027stockpile_rhosp_puddle\u0027]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_software_metadata(self, sys_data):"},{"line_number":95,"context_line":"        soft_all_dict \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_61be1a00","line":92,"updated":"2020-03-06 09:25:39.000000000","message":"after this line we have to return the \u0027version\u0027","commit_id":"d1eb58d0bf21503ef5f0109300c9e199862e093e"}]}