)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33735,"name":"Sanjay Chari","display_name":"Sanjay Chari","email":"schari@redhat.com","username":"schari"},"change_message_id":"407d0e52e585c56d4b34f995d24b923a2831af86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17da58d1_280a63b8","updated":"2023-02-24 08:20:56.000000000","message":"Hi Yatin,\n\nFirst of all, thanks for the patch. I was facing a similar issue with passing the \u0027availability-zone\u0027 kwarg to nova create(). Your patch helped me figure out the issue there 😊.\nThe breaking changes in python-novaclient seem to have been introduced in version 18.3.0. rally-openstack has an upper constraint of 17.6.0[1] for python-novaclient. I think the better approach to fix this issue is for Browbeat to follow the upper constraints set by rally-openstack. I created a patch[2] for it.\n\n[1] https://github.com/openstack/rally-openstack/blob/master/upper-constraints.txt#L94\n[2] https://review.opendev.org/c/x/browbeat/+/874987","commit_id":"f047972744367b5e29d8a22ecdca9cbf51c23e59"},{"author":{"_account_id":33735,"name":"Sanjay Chari","display_name":"Sanjay Chari","email":"schari@redhat.com","username":"schari"},"change_message_id":"7ac4fe43fdabe3ec5e7e6cbb0775ca54f35beb13","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d66ba21_ce2a8c75","in_reply_to":"0887eb3e_406d7dc8","updated":"2023-02-27 07:52:21.000000000","message":"Hi yatin,\n\nThanks. Sorry, I missed the next task. I tried installing Browbeat by adding the lines below after https://opendev.org/x/browbeat/src/branch/master/ansible/install/roles/rally/tasks/main.yml#L55.\n\n- name: Ensure python-novaclient\u003c\u003d17.6.0\n  pip:\n    name: \u0027python-novaclient\u003c\u003d17.6.0\u0027\n    virtualenv: \"{{ rally_venv }}\"\n\nWith these changes, python-novaclient version 17.6.0 was installed into rally-venv instead of 18.3.0. I think this approach is better than removing the floating kwarg as there might be other kwargs used in other scenarios which might also be affected by the breaking changes in python-novaclient 18.3.0. What do you think?\n\nIf this change sounds ok to you, could you edit this patch to add a check for python-novaclient\u003c\u003d17.6.0 inside rally-venv, similar to the SQLAlchemy\u003c2.0.0 check?","commit_id":"f047972744367b5e29d8a22ecdca9cbf51c23e59"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6ed8e9bbdd8faf2f79b15a703a40cd05530f3f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0887eb3e_406d7dc8","in_reply_to":"17da58d1_280a63b8","updated":"2023-02-27 06:58:45.000000000","message":"Thanks Sanjay but i see jobs still failing with [2] included as it\u0027s getting upgraded to latest 18.30 again as part of the next task https://opendev.org/x/browbeat/src/branch/master/ansible/install/roles/rally/tasks/main.yml#L38-L42.\nI tested with 874928 patch and atleast worked but if plans is to fix other way i am totally ok.","commit_id":"f047972744367b5e29d8a22ecdca9cbf51c23e59"},{"author":{"_account_id":33735,"name":"Sanjay Chari","display_name":"Sanjay Chari","email":"schari@redhat.com","username":"schari"},"change_message_id":"83ea2e196f31b837eba87fdfca3171a734f8a413","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"967a6c39_2edaf66d","in_reply_to":"1d66ba21_ce2a8c75","updated":"2023-02-27 07:55:18.000000000","message":"It looks like the formatting of the code block got messed up in the above reply. This line \"- name: Ensure python-novaclient\u003c\u003d17.6.0\" is supposed to be inside the code block. Sorry about that.","commit_id":"f047972744367b5e29d8a22ecdca9cbf51c23e59"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b7d8707ebfcce75f212f93a0ae6ab457f881838c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6afa4da_616e0818","in_reply_to":"967a6c39_2edaf66d","updated":"2023-02-27 07:59:43.000000000","message":"Ok sure updating patch, floating keyword removal part can be done later.","commit_id":"f047972744367b5e29d8a22ecdca9cbf51c23e59"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1bf1123990511ba06581be7a9cb346dbd7cffe0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68d0d78b_9e17d440","in_reply_to":"c6afa4da_616e0818","updated":"2023-02-27 08:06:32.000000000","message":"Done","commit_id":"f047972744367b5e29d8a22ecdca9cbf51c23e59"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6d410bdb9c995b1c46e96c501290dcb5fa894214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de2c8ce6_22939fe2","updated":"2023-02-27 15:38:29.000000000","message":"With this not working as requirements conflict based on previous tests versions before 18.3.0 works fine so i think better to pin that for now, will push a patch for that:-\n2023-02-27 05:31:40.411 149952 WARNING rally.common.plugin.discover [-]          Failed to load plugins from module \u0027rally_openstack\u0027 (package: \u0027rally-openstack 2.2.0\u0027): (python-novaclient 17.6.0 (/home/stack/browbeat/.rally-venv/lib/python3.9/site-packages), Requirement.parse(\u0027python-novaclient\u003e\u003d18.1.0\u0027), {\u0027python-openstackclient\u0027}): pkg_resources.ContextualVersionConflict: (python-novaclient 17.6.0 (/home/stack/browbeat/.rally-venv/lib/python3.9/site-packages), Requirement.parse(\u0027python-novaclient\u003e\u003d18.1.0\u0027), {\u0027python-openstackclient\u0027})^[[00m","commit_id":"ba485b728dc5cd70529290f64ef17d0f42414f08"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"262148c30bd922ce32db8e394affdacf50446d73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ddf4f764_dd16b3be","in_reply_to":"de2c8ce6_22939fe2","updated":"2023-02-27 15:42:43.000000000","message":"pushed https://review.opendev.org/c/x/browbeat/+/875509","commit_id":"ba485b728dc5cd70529290f64ef17d0f42414f08"}]}