)]}'
{"cloudbaseinit/utils/windows/vfat.py":[{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"081ebc28c311e5a2b96abe7c639786b8c68657f8","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cloudbaseinit_conf.CONF"},{"line_number":25,"context_line":"CONFIG_DRIVE_LABELS \u003d [\u0027config-2\u0027, \u0027CONFIG-2\u0027]"},{"line_number":26,"context_line":"LOG \u003d oslo_logging.getLogger(__name__)"},{"line_number":27,"context_line":"VOLUME_LABEL_REGEX \u003d re.compile(\"Volume label is (.*?)$\", re.IGNORECASE)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_b44502b6","line":25,"updated":"2018-02-26 15:05:52.000000000","message":"Is this still needed given the re.IGNORECASE below?","commit_id":"916d3f35b067561a7824a5884c3be8c41860877b"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8536ab58a6ae1d264926cbf71d197f2332c2f2cf","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cloudbaseinit_conf.CONF"},{"line_number":25,"context_line":"CONFIG_DRIVE_LABELS \u003d [\u0027config-2\u0027, \u0027CONFIG-2\u0027]"},{"line_number":26,"context_line":"LOG \u003d oslo_logging.getLogger(__name__)"},{"line_number":27,"context_line":"VOLUME_LABEL_REGEX \u003d re.compile(\"Volume label is (.*?)$\", re.IGNORECASE)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_3f430316","line":25,"in_reply_to":"3fa0c359_55d35560","updated":"2018-02-27 08:23:07.000000000","message":"Yep, that re.IGNORECASE is indeed superfluous. Sending a quick amend on the patch, no need to hold it any longer.","commit_id":"916d3f35b067561a7824a5884c3be8c41860877b"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"4b3d5a69dd07e9ae79a9abe9a607b63c8680be34","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cloudbaseinit_conf.CONF"},{"line_number":25,"context_line":"CONFIG_DRIVE_LABELS \u003d [\u0027config-2\u0027, \u0027CONFIG-2\u0027]"},{"line_number":26,"context_line":"LOG \u003d oslo_logging.getLogger(__name__)"},{"line_number":27,"context_line":"VOLUME_LABEL_REGEX \u003d re.compile(\"Volume label is (.*?)$\", re.IGNORECASE)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_55d35560","line":25,"in_reply_to":"3fa0c359_9a56ec29","updated":"2018-02-26 22:43:04.000000000","message":"My bad, I should have put the opposite question and commented on line 27: is the re.IGNORECASE needed? Given the regex, unless the \"Volume label is \" text needs to be matched in a case insensitive way, I don\u0027t see what it should be needed for.\n\nAs a side note, the corresponding cloud-init patch matches as well on (\u0027config-2\u0027, \u0027CONFIG-2\u0027), so we\u0027re consistent with Linux in allowing only all lowercase or all uppercase.","commit_id":"916d3f35b067561a7824a5884c3be8c41860877b"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"a9db0fe87e0364fe30b990167d980dff42958cea","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cloudbaseinit_conf.CONF"},{"line_number":25,"context_line":"CONFIG_DRIVE_LABELS \u003d [\u0027config-2\u0027, \u0027CONFIG-2\u0027]"},{"line_number":26,"context_line":"LOG \u003d oslo_logging.getLogger(__name__)"},{"line_number":27,"context_line":"VOLUME_LABEL_REGEX \u003d re.compile(\"Volume label is (.*?)$\", re.IGNORECASE)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_9a56ec29","line":25,"in_reply_to":"3fa0c359_b44502b6","updated":"2018-02-26 21:54:59.000000000","message":"It is, unless you change the check at line 53 to something like: match.group(1).lower() \u003d\u003d CONFIG_DRIVE_LABEL.lower().","commit_id":"916d3f35b067561a7824a5884c3be8c41860877b"}]}
