)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"5f5eabece632a4cdfe1ffefe05908be8deb48220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12991fa7_3274e64c","updated":"2023-02-01 15:04:52.000000000","message":"Hello and thank you for the contribution.\nThere is a small pep8 issue and, as a new method is added, can you please add a basic unit test to cover the two code paths?\n\nReusing a class from nocloudservice.py directly might be a little problematic in the future, but we can leave the refactoring for another commit if needed.\n\nThank you.","commit_id":"ee15277ac8099d12089321d4b54c9d2db9c025bc"},{"author":{"_account_id":35747,"name":"Sion Dafydd","display_name":"sidaf","email":"sion.dafydd@gmail.com","username":"sidaf"},"change_message_id":"8859ca6d46f6c71b4b79148402d2547ff837fe29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f77aa55_db8f1d1e","updated":"2023-02-01 13:08:20.000000000","message":"Submitted second patch set with fixes for \"pep8: H306: imports not in alphabetical order\" and \"pep8: W292 no newline at end of file\".","commit_id":"ee15277ac8099d12089321d4b54c9d2db9c025bc"},{"author":{"_account_id":35747,"name":"Sion Dafydd","display_name":"sidaf","email":"sion.dafydd@gmail.com","username":"sidaf"},"change_message_id":"648214b83b264f65f355b1397bc66d34807a36ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b8a04f0e_227f9716","updated":"2023-02-03 11:36:09.000000000","message":"As per code review comments, I\u0027ve have added test cases and the build now completes successfully without any errors.","commit_id":"740a33b8f8b787984cb3742ef2fd1591db29eef1"},{"author":{"_account_id":36484,"name":"David Elliott","email":"blitztide@hackthebox.eu"},"change_message_id":"b6f192339659c3f9156b1829ae3860b4454891e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"63b88b96_d7e1de9e","updated":"2023-10-25 20:56:58.000000000","message":"Is there anything else needed to merge these changes?","commit_id":"740a33b8f8b787984cb3742ef2fd1591db29eef1"},{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"e59470e6c8e57d171698a7949a5782a75a25aa24","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"639b5f6a_e387b1d5","updated":"2023-06-19 10:02:46.000000000","message":"recheck","commit_id":"740a33b8f8b787984cb3742ef2fd1591db29eef1"},{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"3b52ea90ac62da8e3c48331805f29ba1064ca03a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b48cade1_8c94ac6a","updated":"2023-11-13 14:00:35.000000000","message":"recheck","commit_id":"740a33b8f8b787984cb3742ef2fd1591db29eef1"},{"author":{"_account_id":36484,"name":"David Elliott","email":"blitztide@hackthebox.eu"},"change_message_id":"e696659e8c1bbcaf1ff16adb8c7d0b02b38a80c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7c608752_deefdade","in_reply_to":"639b5f6a_e387b1d5","updated":"2023-10-25 21:01:48.000000000","message":"Done","commit_id":"740a33b8f8b787984cb3742ef2fd1591db29eef1"},{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"66e46a63f055e04f960e1c87b8bae204a143527e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d51f5c23_75aca84f","updated":"2024-02-20 13:57:21.000000000","message":"recheck","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":36901,"name":"Zhongcheng Lao","display_name":"laozc","email":"zhongcheng.lao@broadcom.com","username":"laozc","status":"github.com/laozc\nVMware by Broadcom"},"change_message_id":"5184ac6c7cd60d21cb181897bcc454759ad15e1a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75907b63_5b311bea","in_reply_to":"1cc22f1a_dd377248","updated":"2024-05-14 13:51:28.000000000","message":"Hi Adrian/Florian,\nWe would like to take the initiate for VMware Datasource from VMware perspective as this feature on our roadmap to support network configuration for cloudbase-init to gain feature parity with cloud-init nowadays.\nWe have \nhttps://review.opendev.org/c/x/cloudbase-init/+/913734\nto support both NetworkConfig V1 and V2.\nI can build a compiled MSI if you would like to test the feature.","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":37028,"name":"Florian LAUNAY","display_name":"Florian LAUNAY","email":"florian@ucantfind.me","username":"florianlaunay"},"change_message_id":"6e7d6bb6ce0057caea8fb7056162e9a542ce809e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a4d4d9f5_92f30f7a","in_reply_to":"1ce4e9d4_6357aa57","updated":"2024-05-17 15:23:28.000000000","message":"Feture is now followed on https://review.opendev.org/c/x/cloudbase-init/+/913734. We can maybe close this one?","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"c89ea19f0169198274b23309d6fd35ce414044ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6f1ec21d_e89d54b7","in_reply_to":"2921368b_68582283","updated":"2024-05-13 10:35:54.000000000","message":"hello and thanks. we can merge this feature. Can you confirm it works (as currently I do not have an env to test it out) and maybe take care of the feature maintainence if need be?","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":37028,"name":"Florian LAUNAY","display_name":"Florian LAUNAY","email":"florian@ucantfind.me","username":"florianlaunay"},"change_message_id":"ef3ad827be72ffdbbe1bb6d5068ab09dc5caf6ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c87c7c4d_6cdd5aac","in_reply_to":"6f1ec21d_e89d54b7","updated":"2024-05-13 11:49:42.000000000","message":"To be honest I am just a simple user of cloudbase-init and I did not take any interest in your development workflow yet because I am already involved in some professional projects that keep me busy all the day 😊.\n\nSo I do not have any test environment either and in cannot confirm if it works 😞.\n\nMaybe @sidaf can?\n\nAren\u0027t these kind of tests already covered by your Zuul pipeline?","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":37028,"name":"Florian LAUNAY","display_name":"Florian LAUNAY","email":"florian@ucantfind.me","username":"florianlaunay"},"change_message_id":"0477d2327c40aff5f59b97cf8744de801a5fc594","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1ce4e9d4_6357aa57","in_reply_to":"75907b63_5b311bea","updated":"2024-05-15 11:39:00.000000000","message":"Hi Lao,\nI will be happy to test your feature. Particularly if it has support for the NetworkConfig v2 format 😊.\nShould we continue this conversation in https://review.opendev.org/c/x/cloudbase-init/+/913734 ?","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":37028,"name":"Florian LAUNAY","display_name":"Florian LAUNAY","email":"florian@ucantfind.me","username":"florianlaunay"},"change_message_id":"5e7ac898c0c50fbd1cc67f6d0e0df0aef5e31ec4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1cc22f1a_dd377248","in_reply_to":"bd12e1e0_756df7c1","updated":"2024-05-13 16:08:36.000000000","message":"If you could provide me with a compiled version incorporating this change, I could test it by quickly creating a Windows image with Packer.","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"631a3d0980d716132ee14ce4307c8c08c03d6444","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bd12e1e0_756df7c1","in_reply_to":"c87c7c4d_6cdd5aac","updated":"2024-05-13 12:16:13.000000000","message":"The units tests should be covering the implementation, but would be nice to confirm that an actual deployment works.","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":37028,"name":"Florian LAUNAY","display_name":"Florian LAUNAY","email":"florian@ucantfind.me","username":"florianlaunay"},"change_message_id":"662832eb7ea03f5d387a9f060d3556a13c196d30","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2921368b_68582283","in_reply_to":"d51f5c23_75aca84f","updated":"2024-05-13 08:05:50.000000000","message":"Hi Adrian. Thank you for all your work on cloudbase-init. What a great tool. This feature will be awesome and it will finally bring VMware datasource to its expected level! Does it needs more work to be merged?","commit_id":"2659ef71c19ca587c1a580033f40126bce632374"},{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"a8eda68558d34841b5baad5728992caae2d1b6f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7c60506c_793c8b58","updated":"2024-05-14 13:51:07.000000000","message":"hello, you can find the cloudbaseinit msi as zipped artifact here, built by github actions: https://github.com/ader1990/cloudbase-init-installer-1/actions/runs/9080270202","commit_id":"ee8402f040a36a22f14f44e728ed2aee16386dfc"},{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"6ce84bdb26cc641ca91b1bd3ecd1a02adef451d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36d606cd_2de759b9","updated":"2024-05-13 10:33:42.000000000","message":"recheck","commit_id":"ee8402f040a36a22f14f44e728ed2aee16386dfc"}]}