)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36950,"name":"Brett Holman","display_name":"Brett Holman","email":"bpholman5@gmail.com","username":"holmanb"},"change_message_id":"dc99a9fccae044cc7c810592730efe1078acbc12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e2559ad_fd7da1e7","updated":"2024-04-03 22:28:03.000000000","message":"Fixes https://github.com/cloudbase/cloudbase-init/issues/135","commit_id":"3c0760a89fefcc007bbd8711a4b5ef5a32678805"},{"author":{"_account_id":9649,"name":"Adrian Vladu","email":"avladu@cloudbasesolutions.com","username":"avladu"},"change_message_id":"99ba7966a7a4f32eab5d43706fbb7959e17c26ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf45347b_ba9c6967","updated":"2024-04-04 07:19:27.000000000","message":"Hello,\n\ncan you please give more details on why this change is required?\n\nhttps://cloudbase-init.readthedocs.io/en/latest/services.html#openstack-configuration-drive cloudbaseinit.metadata.services.configdrive.ConfigDriveService is the implementation for the OpenStack config drive.\n\nThe nocloud implementation is using the cidata https://github.com/cloudbase/cloudbase-init/blob/4bb6895f115c8cb20ee9be37d5facc84243d0113/cloudbaseinit/metadata/services/nocloudservice.py#L279 \n\nSee: https://cloudbase-init.readthedocs.io/en/latest/services.html#nocloud-configuration-drive\n\nThus, it is not necessary to make this change on the configdrive, as you can use nocloud. I know the terminology is confusing, there are historical reasons, when cloudbase-init was primarly used for OpenStack.","commit_id":"3c0760a89fefcc007bbd8711a4b5ef5a32678805"},{"author":{"_account_id":36950,"name":"Brett Holman","display_name":"Brett Holman","email":"bpholman5@gmail.com","username":"holmanb"},"change_message_id":"fe41529f404f352c681883fc73c3031d623f8ba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b53e265_bef02674","in_reply_to":"cf45347b_ba9c6967","updated":"2024-04-04 14:01:55.000000000","message":"Hi Adrian,\n\nThanks for the review.\n\nI\u0027m familiar with the terminology (I contribute to cloud-init and occasionally cloud-utils), but I am unfamiliar with the cloudbase codebase. The user claimed that config-2 was required for nocloud[1], and pointed me to the configdrive.py file in the codebase.  I incorrectly came to the conclusion that they had the same implementation in configdrive.\n\nWe can close this proposal, since it probably doesn\u0027t make sense.\n\n[1] https://github.com/canonical/cloud-utils/pull/56","commit_id":"3c0760a89fefcc007bbd8711a4b5ef5a32678805"}]}
