)]}'
{"devstack/gluster-functions.sh":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2877f836d78eb8e434dfed01352fbe5eab52e9a7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# Setting up glusterfs"},{"line_number":144,"context_line":"function _create_glusterfs_disk {"},{"line_number":145,"context_line":"    # create a backing file disk"},{"line_number":146,"context_line":"    local disk_image_directory\u003d$(dirname \"${GLUSTERFS_DISK_IMAGE}\")"},{"line_number":147,"context_line":"    mkdir -p $disk_image_directory"},{"line_number":148,"context_line":"    create_disk ${GLUSTERFS_DISK_IMAGE} ${GLUSTERFS_DATA_DIR} ${GLUSTERFS_LOOPBACK_DISK_SIZE}"},{"line_number":149,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f621f24_5de0a126","line":146,"updated":"2020-11-13 06:13:02.000000000","message":"bashate: E042 local declaration hides errors","commit_id":"634b3fcf11a7b72eff6c84788668865fed9ba5f6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b27f7fa42e9341bfc58da3ba9c80972ade89bbff","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# Setting up glusterfs"},{"line_number":144,"context_line":"function _create_glusterfs_disk {"},{"line_number":145,"context_line":"    # create a backing file disk"},{"line_number":146,"context_line":"    local disk_image_directory\u003d$(dirname \"${GLUSTERFS_DISK_IMAGE}\")"},{"line_number":147,"context_line":"    mkdir -p $disk_image_directory"},{"line_number":148,"context_line":"    create_disk ${GLUSTERFS_DISK_IMAGE} ${GLUSTERFS_DATA_DIR} ${GLUSTERFS_LOOPBACK_DISK_SIZE}"},{"line_number":149,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f621f24_e6d2bed0","line":146,"in_reply_to":"1f621f24_5de0a126","updated":"2020-11-13 12:49:25.000000000","message":"Probably we should just remove the \u0027local\u0027.","commit_id":"634b3fcf11a7b72eff6c84788668865fed9ba5f6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d22cee3bb8c9a369eb7ffbd1d02fbcf19943526a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# Setting up glusterfs"},{"line_number":144,"context_line":"function _create_glusterfs_disk {"},{"line_number":145,"context_line":"    # create a backing file disk"},{"line_number":146,"context_line":"    local disk_image_directory\u003d$(dirname \"${GLUSTERFS_DISK_IMAGE}\")"},{"line_number":147,"context_line":"    mkdir -p $disk_image_directory"},{"line_number":148,"context_line":"    create_disk ${GLUSTERFS_DISK_IMAGE} ${GLUSTERFS_DATA_DIR} ${GLUSTERFS_LOOPBACK_DISK_SIZE}"},{"line_number":149,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f621f24_92518039","line":146,"in_reply_to":"1f621f24_9294e038","updated":"2020-11-13 18:11:51.000000000","message":"Separate patch is fine.  None of the other local variables use command output to get their value.","commit_id":"634b3fcf11a7b72eff6c84788668865fed9ba5f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ce3ba05f66c843ce38e38af6dec02b3ff9a0417","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# Setting up glusterfs"},{"line_number":144,"context_line":"function _create_glusterfs_disk {"},{"line_number":145,"context_line":"    # create a backing file disk"},{"line_number":146,"context_line":"    local disk_image_directory\u003d$(dirname \"${GLUSTERFS_DISK_IMAGE}\")"},{"line_number":147,"context_line":"    mkdir -p $disk_image_directory"},{"line_number":148,"context_line":"    create_disk ${GLUSTERFS_DISK_IMAGE} ${GLUSTERFS_DATA_DIR} ${GLUSTERFS_LOOPBACK_DISK_SIZE}"},{"line_number":149,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f621f24_9294e038","line":146,"in_reply_to":"1f621f24_e6d2bed0","updated":"2020-11-13 17:33:58.000000000","message":"I\u0027ll make a separate patch for this Tom - i don\u0027t really understand the error here; given there\u0027s a lot of use of \"local\" all over this file?","commit_id":"634b3fcf11a7b72eff6c84788668865fed9ba5f6"}]}