)]}'
{"deployment_scripts/puppet/modules/nagios/files/process-service-checks.wsgi":[{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9cd2dbb852f928f9e2fdda3afff75ed668a444ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"#    Copyright 2015 Mirantis, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_1d6dd6cc","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":19},"updated":"2016-05-12 10:10:00.000000000","message":"6","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9cd2dbb852f928f9e2fdda3afff75ed668a444ae","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        output\u003dp[\u0027plugin_output\u0027][0]"},{"line_number":92,"context_line":"    )"},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        f \u003d os.open(cmd_file, os.O_WRONLY)"},{"line_number":95,"context_line":"        os.write(f, cmd + \"\\n\")"},{"line_number":96,"context_line":"        os.close(f)"},{"line_number":97,"context_line":"    except Exception as e:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_9d2ee6a3","line":94,"updated":"2016-05-12 10:10:00.000000000","message":"(nit) a more Pythonic way would be use io.open with a context manager:\n\n with open(cmd_file, \"w\") as f:\n   f.write(cmd + \"\\n\")\n\nUnless there\u0027s a strong reason to use os.open()?","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"3ef41dada9ee01a578f0c31ccee0c0dc3751d136","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        output\u003dp[\u0027plugin_output\u0027][0]"},{"line_number":92,"context_line":"    )"},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        f \u003d os.open(cmd_file, os.O_WRONLY)"},{"line_number":95,"context_line":"        os.write(f, cmd + \"\\n\")"},{"line_number":96,"context_line":"        os.close(f)"},{"line_number":97,"context_line":"    except Exception as e:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_ced3925e","line":94,"in_reply_to":"dab17558_9d2ee6a3","updated":"2016-05-12 10:36:43.000000000","message":"obviously there is no specific reason","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9cd2dbb852f928f9e2fdda3afff75ed668a444ae","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        status \u003d \u0027400 Bad Request\u0027"},{"line_number":114,"context_line":"        return http_response(response, status, str(e))"},{"line_number":115,"context_line":"    valid \u003d validate_params(params)"},{"line_number":116,"context_line":"    if valid is not True:"},{"line_number":117,"context_line":"        return http_response(response, \u0027400 Bad Request\u0027, valid)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    cmd_file \u003d environ.get(\u0027NAGIOS_CMD_FILE\u0027, \u0027/var/lib/nagios3/rw/nagios.cmd\u0027)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_90b88d2c","line":116,"updated":"2016-05-12 10:10:00.000000000","message":"same remark as L121","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"3ef41dada9ee01a578f0c31ccee0c0dc3751d136","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        status \u003d \u0027400 Bad Request\u0027"},{"line_number":114,"context_line":"        return http_response(response, status, str(e))"},{"line_number":115,"context_line":"    valid \u003d validate_params(params)"},{"line_number":116,"context_line":"    if valid is not True:"},{"line_number":117,"context_line":"        return http_response(response, \u0027400 Bad Request\u0027, valid)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    cmd_file \u003d environ.get(\u0027NAGIOS_CMD_FILE\u0027, \u0027/var/lib/nagios3/rw/nagios.cmd\u0027)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_6ea2669c","line":116,"in_reply_to":"dab17558_90b88d2c","updated":"2016-05-12 10:36:43.000000000","message":"Done","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9cd2dbb852f928f9e2fdda3afff75ed668a444ae","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    cmd_file \u003d environ.get(\u0027NAGIOS_CMD_FILE\u0027, \u0027/var/lib/nagios3/rw/nagios.cmd\u0027)"},{"line_number":120,"context_line":"    written \u003d write_command(cmd_file, params, timestamp)"},{"line_number":121,"context_line":"    if written is not True:"},{"line_number":122,"context_line":"        return http_response(response, \u0027500 Internal Server Error\u0027, written)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    return http_response(response, \u0027200 OK\u0027)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_9061add6","line":121,"updated":"2016-05-12 10:10:00.000000000","message":"this feels a bit strange. You could as well let write_command() raise the exception and catch it here:\n\n  try:\n    write_command(...)\n  except e:\n    return http_response(response, \u0027500 Internal Server Error, str(e))\n\n  return http_response(response, \u0027204 No Content\u0027)","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"3ef41dada9ee01a578f0c31ccee0c0dc3751d136","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    cmd_file \u003d environ.get(\u0027NAGIOS_CMD_FILE\u0027, \u0027/var/lib/nagios3/rw/nagios.cmd\u0027)"},{"line_number":120,"context_line":"    written \u003d write_command(cmd_file, params, timestamp)"},{"line_number":121,"context_line":"    if written is not True:"},{"line_number":122,"context_line":"        return http_response(response, \u0027500 Internal Server Error\u0027, written)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    return http_response(response, \u0027200 OK\u0027)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_6ec3868b","line":121,"in_reply_to":"dab17558_9061add6","updated":"2016-05-12 10:36:43.000000000","message":"Done","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9cd2dbb852f928f9e2fdda3afff75ed668a444ae","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if written is not True:"},{"line_number":122,"context_line":"        return http_response(response, \u0027500 Internal Server Error\u0027, written)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    return http_response(response, \u0027200 OK\u0027)"},{"line_number":125,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_dd350ea9","line":124,"range":{"start_line":124,"start_character":36,"end_line":124,"end_character":42},"updated":"2016-05-12 10:10:00.000000000","message":"(nit) 204 No Content would be even more appropriate","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"3ef41dada9ee01a578f0c31ccee0c0dc3751d136","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if written is not True:"},{"line_number":122,"context_line":"        return http_response(response, \u0027500 Internal Server Error\u0027, written)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    return http_response(response, \u0027200 OK\u0027)"},{"line_number":125,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dab17558_0e459a16","line":124,"range":{"start_line":124,"start_character":36,"end_line":124,"end_character":42},"in_reply_to":"dab17558_dd350ea9","updated":"2016-05-12 10:36:43.000000000","message":"Done","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"757fecc7a5db9698698759f42bbe516face6a83b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def validate_params(params):"},{"line_number":38,"context_line":"    cmd_mod \u003d params.get(\u0027cmd_mod\u0027)"},{"line_number":39,"context_line":"    if not cmd_mod or not len(cmd_mod) or len(cmd_mod[0]) \u003d\u003d 0:"},{"line_number":40,"context_line":"        raise Exception(\u0027cmd_mod parameter is required\u0027)"},{"line_number":41,"context_line":"    try:"},{"line_number":42,"context_line":"        cmd_mod \u003d int(cmd_mod[0])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dab17558_147124e1","line":39,"updated":"2016-05-12 13:43:13.000000000","message":"For consistency reasons and sake of explicitness I\u0027d rewrite this to:\n\n    if not cmd_mod or len(cmd_mod) \u003d\u003d 0 or len(cmd_mod[0]) \u003d\u003d 0:","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"a8eb42674e884b5615ed704f8bcbfba584c58898","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def validate_params(params):"},{"line_number":38,"context_line":"    cmd_mod \u003d params.get(\u0027cmd_mod\u0027)"},{"line_number":39,"context_line":"    if not cmd_mod or not len(cmd_mod) or len(cmd_mod[0]) \u003d\u003d 0:"},{"line_number":40,"context_line":"        raise Exception(\u0027cmd_mod parameter is required\u0027)"},{"line_number":41,"context_line":"    try:"},{"line_number":42,"context_line":"        cmd_mod \u003d int(cmd_mod[0])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dab17558_4b24a6ae","line":39,"in_reply_to":"dab17558_147124e1","updated":"2016-05-12 14:00:49.000000000","message":"this is really to make you happy","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"ddf732addd825360e4b29152559a581d81f707e5","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def validate_params(params):"},{"line_number":38,"context_line":"    cmd_mod \u003d params.get(\u0027cmd_mod\u0027)"},{"line_number":39,"context_line":"    if not cmd_mod or not len(cmd_mod) or len(cmd_mod[0]) \u003d\u003d 0:"},{"line_number":40,"context_line":"        raise Exception(\u0027cmd_mod parameter is required\u0027)"},{"line_number":41,"context_line":"    try:"},{"line_number":42,"context_line":"        cmd_mod \u003d int(cmd_mod[0])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dab17558_cb2b7693","line":39,"in_reply_to":"dab17558_4b24a6ae","updated":"2016-05-12 14:18:21.000000000","message":"Thank you!","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"757fecc7a5db9698698759f42bbe516face6a83b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        raise Exception(\u0027cmd_mod is invalid, cmd_mod must be set to 2\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cmd_typ \u003d params.get(\u0027cmd_typ\u0027)"},{"line_number":49,"context_line":"    if not cmd_typ or not len(cmd_typ) or len(cmd_typ[0]) \u003d\u003d 0:"},{"line_number":50,"context_line":"        raise Exception(\u0027cmd_typ parameter is required\u0027)"},{"line_number":51,"context_line":"    try:"},{"line_number":52,"context_line":"        cmd_typ \u003d int(cmd_typ[0])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dab17558_5473ace7","line":49,"updated":"2016-05-12 13:43:13.000000000","message":"Ditto.","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"757fecc7a5db9698698759f42bbe516face6a83b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        raise Exception(\u0027only cmd_typ\u003d30 is supported (PROCESS_SERVICE_CHECK_RESULT)\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    state \u003d params.get(\u0027plugin_state\u0027)"},{"line_number":59,"context_line":"    if not state or not len(state) or len(state[0]) \u003d\u003d 0:"},{"line_number":60,"context_line":"        raise Exception(\u0027plugin_state parameter is required\u0027)"},{"line_number":61,"context_line":"    try:"},{"line_number":62,"context_line":"        state \u003d int(state[0])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dab17558_f448e08c","line":59,"updated":"2016-05-12 13:43:13.000000000","message":"Ditto.","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"e2858dd78460a8274300c7a4fd28b6ecdda69163","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    )"},{"line_number":90,"context_line":"    with open(cmd_file, \"w\") as f:"},{"line_number":91,"context_line":"        f.write(cmd + \"\\n\")"},{"line_number":92,"context_line":"        f.close()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def application(environ, response):"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dab17558_2194e3e6","line":92,"updated":"2016-05-12 14:47:32.000000000","message":"you don\u0027t need f.close() here, the context manager will take care of it.","commit_id":"e10fb4b1609ea8c11c871d6ef4aa855c8bb5d246"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"470371b551f9fb4bc5ebb91c7d6c509b06de5c3d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    )"},{"line_number":90,"context_line":"    with open(cmd_file, \"w\") as f:"},{"line_number":91,"context_line":"        f.write(cmd + \"\\n\")"},{"line_number":92,"context_line":"        f.close()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def application(environ, response):"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dab17558_dc1fbeb5","line":92,"in_reply_to":"dab17558_2194e3e6","updated":"2016-05-12 15:03:37.000000000","message":"right","commit_id":"e10fb4b1609ea8c11c871d6ef4aa855c8bb5d246"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"e2858dd78460a8274300c7a4fd28b6ecdda69163","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    cmd_file \u003d environ.get(\u0027NAGIOS_CMD_FILE\u0027, \u0027/var/lib/nagios3/rw/nagios.cmd\u0027)"},{"line_number":114,"context_line":"    try:"},{"line_number":115,"context_line":"        write_command(cmd_file, params, timestamp)"},{"line_number":116,"context_line":"    except e:"},{"line_number":117,"context_line":"        return http_response(response, \u0027500 Internal Server Error\u0027, str(e))"},{"line_number":118,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dab17558_619eeb08","line":115,"updated":"2016-05-12 14:47:32.000000000","message":"one could argue that you don\u0027t even need the write_command() function.","commit_id":"e10fb4b1609ea8c11c871d6ef4aa855c8bb5d246"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"470371b551f9fb4bc5ebb91c7d6c509b06de5c3d","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    cmd_file \u003d environ.get(\u0027NAGIOS_CMD_FILE\u0027, \u0027/var/lib/nagios3/rw/nagios.cmd\u0027)"},{"line_number":114,"context_line":"    try:"},{"line_number":115,"context_line":"        write_command(cmd_file, params, timestamp)"},{"line_number":116,"context_line":"    except e:"},{"line_number":117,"context_line":"        return http_response(response, \u0027500 Internal Server Error\u0027, str(e))"},{"line_number":118,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dab17558_9cda56e8","line":115,"in_reply_to":"dab17558_619eeb08","updated":"2016-05-12 15:03:37.000000000","message":"you are a perfectionist ..","commit_id":"e10fb4b1609ea8c11c871d6ef4aa855c8bb5d246"}],"deployment_scripts/puppet/modules/nagios/manifests/cgi.pp":[{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9cd2dbb852f928f9e2fdda3afff75ed668a444ae","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $htpasswd_file \u003d $nagios::params::cgi_htpasswd_file,"},{"line_number":23,"context_line":"  $http_port \u003d $nagios::params::cgi_http_port,"},{"line_number":24,"context_line":"  $vhost_listen_ip \u003d \u0027*\u0027,"},{"line_number":25,"context_line":"  $nagios_command_file \u003d $nagios::params::command_file,"},{"line_number":26,"context_line":"  $wsgi_process_service_checks_location \u003d \u0027/status\u0027,"},{"line_number":27,"context_line":"  $wsgi_process_service_checks_script \u003d \u0027/usr/local/bin/nagios-process-service-checks.wsgi\u0027,"},{"line_number":28,"context_line":"  $wsgi_processes \u003d 3,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_90c36d38","line":25,"updated":"2016-05-12 10:10:00.000000000","message":"it doesn\u0027t need to be exposed IMO.","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"3ef41dada9ee01a578f0c31ccee0c0dc3751d136","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $htpasswd_file \u003d $nagios::params::cgi_htpasswd_file,"},{"line_number":23,"context_line":"  $http_port \u003d $nagios::params::cgi_http_port,"},{"line_number":24,"context_line":"  $vhost_listen_ip \u003d \u0027*\u0027,"},{"line_number":25,"context_line":"  $nagios_command_file \u003d $nagios::params::command_file,"},{"line_number":26,"context_line":"  $wsgi_process_service_checks_location \u003d \u0027/status\u0027,"},{"line_number":27,"context_line":"  $wsgi_process_service_checks_script \u003d \u0027/usr/local/bin/nagios-process-service-checks.wsgi\u0027,"},{"line_number":28,"context_line":"  $wsgi_processes \u003d 3,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_ce639240","line":25,"in_reply_to":"dab17558_90c36d38","updated":"2016-05-12 10:36:43.000000000","message":"Done","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9cd2dbb852f928f9e2fdda3afff75ed668a444ae","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  apache::listen { $http_port: }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  # Template uses these variables: http_port, vhost_listen_ip, cgi_htpasswd_file"},{"line_number":53,"context_line":"  #"},{"line_number":54,"context_line":"  apache::custom_config { \u0027nagios\u0027:"},{"line_number":55,"context_line":"    content \u003d\u003e template(\"nagios/${nagios::params::apache_vhost_config_tpl}\"),"},{"line_number":56,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_d0ba1571","line":53,"updated":"2016-05-12 10:10:00.000000000","message":"nagios_command_file too","commit_id":"dc852c8bd7418dcc809bbe59d02df74321b1e3aa"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"757fecc7a5db9698698759f42bbe516face6a83b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $wsgi_process_service_checks_location \u003d \u0027/status\u0027,"},{"line_number":26,"context_line":"  $wsgi_process_service_checks_script \u003d \u0027/usr/local/bin/nagios-process-service-checks.wsgi\u0027,"},{"line_number":27,"context_line":"  $wsgi_processes \u003d 3,"},{"line_number":28,"context_line":"  $wsgi_threads \u003d 15,"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":") inherits nagios::params {"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_485caced","line":28,"updated":"2016-05-12 13:43:13.000000000","message":"Out of curiosity how did you choose these values?","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"a8eb42674e884b5615ed704f8bcbfba584c58898","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $wsgi_process_service_checks_location \u003d \u0027/status\u0027,"},{"line_number":26,"context_line":"  $wsgi_process_service_checks_script \u003d \u0027/usr/local/bin/nagios-process-service-checks.wsgi\u0027,"},{"line_number":27,"context_line":"  $wsgi_processes \u003d 3,"},{"line_number":28,"context_line":"  $wsgi_threads \u003d 15,"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":") inherits nagios::params {"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_e8576024","line":28,"in_reply_to":"dab17558_485caced","updated":"2016-05-12 14:00:49.000000000","message":"nope, we probably need only 1 process in fact ... lets reduce to 2","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"d9c9c26e2496eef194f0fea4f94386c9849afb85","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    default_vhost       \u003d\u003e false,"},{"line_number":40,"context_line":"    # prerequists for Nagios CGI"},{"line_number":41,"context_line":"    mpm_module          \u003d\u003e \u0027prefork\u0027,"},{"line_number":42,"context_line":"    default_mods        \u003d\u003e [\u0027php\u0027, \u0027cgi\u0027, \u0027authn_file\u0027, \u0027auth_basic\u0027, \u0027authz_user\u0027, \u0027wsgi\u0027],"},{"line_number":43,"context_line":"    # allow to use the Puppet user resource later in the manifest"},{"line_number":44,"context_line":"    manage_group        \u003d\u003e false,"},{"line_number":45,"context_line":"    manage_user         \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_c8fffca8","line":42,"updated":"2016-05-12 13:43:55.000000000","message":"Are we guaranteed that the mod_wsgi package is installed on the target machine?","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"ddf732addd825360e4b29152559a581d81f707e5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    default_vhost       \u003d\u003e false,"},{"line_number":40,"context_line":"    # prerequists for Nagios CGI"},{"line_number":41,"context_line":"    mpm_module          \u003d\u003e \u0027prefork\u0027,"},{"line_number":42,"context_line":"    default_mods        \u003d\u003e [\u0027php\u0027, \u0027cgi\u0027, \u0027authn_file\u0027, \u0027auth_basic\u0027, \u0027authz_user\u0027, \u0027wsgi\u0027],"},{"line_number":43,"context_line":"    # allow to use the Puppet user resource later in the manifest"},{"line_number":44,"context_line":"    manage_group        \u003d\u003e false,"},{"line_number":45,"context_line":"    manage_user         \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_bee3d232","line":42,"in_reply_to":"dab17558_a876f8d5","updated":"2016-05-12 14:18:21.000000000","message":"I was not sure that adding \"wsgi\" here would make ensure the installation of the actual Ubuntu package.","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"a8eb42674e884b5615ed704f8bcbfba584c58898","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    default_vhost       \u003d\u003e false,"},{"line_number":40,"context_line":"    # prerequists for Nagios CGI"},{"line_number":41,"context_line":"    mpm_module          \u003d\u003e \u0027prefork\u0027,"},{"line_number":42,"context_line":"    default_mods        \u003d\u003e [\u0027php\u0027, \u0027cgi\u0027, \u0027authn_file\u0027, \u0027auth_basic\u0027, \u0027authz_user\u0027, \u0027wsgi\u0027],"},{"line_number":43,"context_line":"    # allow to use the Puppet user resource later in the manifest"},{"line_number":44,"context_line":"    manage_group        \u003d\u003e false,"},{"line_number":45,"context_line":"    manage_user         \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_a876f8d5","line":42,"in_reply_to":"dab17558_c8fffca8","updated":"2016-05-12 14:00:49.000000000","message":"This is the purpose of this configuration .. don\u0027t see your point?","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"}],"deployment_scripts/puppet/modules/nagios/templates/apache_vhost_centos.conf.erb":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"757fecc7a5db9698698759f42bbe516face6a83b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  # WSGI implementation for the process_service_check command"},{"line_number":11,"context_line":"  SetEnv NAGIOS_CMD_FILE \u003c%\u003d @nagios_command_file %\u003e"},{"line_number":12,"context_line":"  WSGIScriptAlias \u003c%\u003d @wsgi_process_service_checks_location %\u003e \u003c%\u003d @wsgi_process_service_checks_script %\u003e"},{"line_number":13,"context_line":"  WSGIDaemonProcess nagios_process_service_checks user\u003dnagios group\u003dnagios processes\u003d\u003c%\u003d @wsgi_processes %\u003e threads\u003d\u003c%\u003d @wsgi_threads %\u003e display-name\u003d\u0027%{GROUP}\u0027 maximum-requests\u003d10000"},{"line_number":14,"context_line":"  WSGIProcessGroup nagios_process_service_checks"},{"line_number":15,"context_line":"  \u003cLocation \u003c%\u003d @wsgi_process_service_checks_location %\u003e\u003e"},{"line_number":16,"context_line":"     AuthName \"Nagios Access\""}],"source_content_type":"application/x-erb","patch_set":3,"id":"dab17558_c88c1c82","line":13,"updated":"2016-05-12 13:43:13.000000000","message":"Don\u0027t you want to use \"user\u003d\u003c%\u003d @user %\u003e\" here?","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"4fbd854e01bf2beac7ef06f806ff94b297584515","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  # WSGI implementation for the process_service_check command"},{"line_number":11,"context_line":"  SetEnv NAGIOS_CMD_FILE \u003c%\u003d @nagios_command_file %\u003e"},{"line_number":12,"context_line":"  WSGIScriptAlias \u003c%\u003d @wsgi_process_service_checks_location %\u003e \u003c%\u003d @wsgi_process_service_checks_script %\u003e"},{"line_number":13,"context_line":"  WSGIDaemonProcess nagios_process_service_checks user\u003dnagios group\u003dnagios processes\u003d\u003c%\u003d @wsgi_processes %\u003e threads\u003d\u003c%\u003d @wsgi_threads %\u003e display-name\u003d\u0027%{GROUP}\u0027 maximum-requests\u003d10000"},{"line_number":14,"context_line":"  WSGIProcessGroup nagios_process_service_checks"},{"line_number":15,"context_line":"  \u003cLocation \u003c%\u003d @wsgi_process_service_checks_location %\u003e\u003e"},{"line_number":16,"context_line":"     AuthName \"Nagios Access\""}],"source_content_type":"application/x-erb","patch_set":3,"id":"dab17558_3e024270","line":13,"in_reply_to":"dab17558_683a50e9","updated":"2016-05-12 14:23:21.000000000","message":"Go confused by the $nagios::params::cgi_user variable, which actually defines the UI user.","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"a8eb42674e884b5615ed704f8bcbfba584c58898","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  # WSGI implementation for the process_service_check command"},{"line_number":11,"context_line":"  SetEnv NAGIOS_CMD_FILE \u003c%\u003d @nagios_command_file %\u003e"},{"line_number":12,"context_line":"  WSGIScriptAlias \u003c%\u003d @wsgi_process_service_checks_location %\u003e \u003c%\u003d @wsgi_process_service_checks_script %\u003e"},{"line_number":13,"context_line":"  WSGIDaemonProcess nagios_process_service_checks user\u003dnagios group\u003dnagios processes\u003d\u003c%\u003d @wsgi_processes %\u003e threads\u003d\u003c%\u003d @wsgi_threads %\u003e display-name\u003d\u0027%{GROUP}\u0027 maximum-requests\u003d10000"},{"line_number":14,"context_line":"  WSGIProcessGroup nagios_process_service_checks"},{"line_number":15,"context_line":"  \u003cLocation \u003c%\u003d @wsgi_process_service_checks_location %\u003e\u003e"},{"line_number":16,"context_line":"     AuthName \"Nagios Access\""}],"source_content_type":"application/x-erb","patch_set":3,"id":"dab17558_683a50e9","line":13,"in_reply_to":"dab17558_c88c1c82","updated":"2016-05-12 14:00:49.000000000","message":"no, this is quite static value IMO .. there is approximately zero chance that the package will change the user","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"}],"deployment_scripts/puppet/modules/nagios/templates/apache_vhost_ubuntu.conf.erb":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"757fecc7a5db9698698759f42bbe516face6a83b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  # WSGI implementation for the process_service_check command"},{"line_number":11,"context_line":"  SetEnv NAGIOS_CMD_FILE \u003c%\u003d @nagios_command_file %\u003e"},{"line_number":12,"context_line":"  WSGIScriptAlias \u003c%\u003d @wsgi_process_service_checks_location %\u003e \u003c%\u003d @wsgi_process_service_checks_script %\u003e"},{"line_number":13,"context_line":"  WSGIDaemonProcess nagios_process_service_checks user\u003dnagios group\u003dnagios processes\u003d\u003c%\u003d @wsgi_processes %\u003e threads\u003d\u003c%\u003d @wsgi_threads %\u003e display-name\u003d\u0027%{GROUP}\u0027 maximum-requests\u003d10000"},{"line_number":14,"context_line":"  WSGIProcessGroup nagios_process_service_checks"},{"line_number":15,"context_line":"  \u003cLocation \u003c%\u003d @wsgi_process_service_checks_location %\u003e\u003e"},{"line_number":16,"context_line":"     AuthName \"Nagios Access\""}],"source_content_type":"application/x-erb","patch_set":3,"id":"dab17558_083bc49d","line":13,"updated":"2016-05-12 13:43:13.000000000","message":"Ditto regarding the \"user\" variable.","commit_id":"2c12cfd77d74c2f7ec3bec2b22aeec2457dedbd9"}]}