)]}'
{".zuul.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ddb9b8a1c28d50f1132a37113a0c6b9aeb68593b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    name: x/gearman-plugin"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - legacy-gearman-plugin-maven-build-ubuntu-trusty"},{"line_number":6,"context_line":"    gate:"},{"line_number":7,"context_line":"      jobs:"},{"line_number":8,"context_line":"        - legacy-gearman-plugin-maven-build-ubuntu-trusty"},{"line_number":9,"context_line":"    post:"},{"line_number":10,"context_line":"      jobs:"},{"line_number":11,"context_line":"        - legacy-gearman-plugin-hpi-artifact"},{"line_number":12,"context_line":"    release:"},{"line_number":13,"context_line":"      jobs:"},{"line_number":14,"context_line":"        - legacy-gearman-plugin-jenkinsci-upload:"},{"line_number":15,"context_line":"            dependencies:"},{"line_number":16,"context_line":"              - legacy-gearman-plugin-hpi-artifact"},{"line_number":17,"context_line":"        - legacy-gearman-plugin-hpi-artifact"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfb3d3c7_b8b809e5","line":17,"range":{"start_line":1,"start_character":0,"end_line":17,"end_character":44},"updated":"2019-05-24 06:32:56.000000000","message":"you don\u0027t need this - unless you import everything from project-config as well.\n\nAnd then you should rename the jobs and import them as well..","commit_id":"96237336f2882d355685c39aa7a4656a2ff286cc"}],"bindep.txt":[{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"bc010d6dbe2a60157a4e550b147556ef5df94410","unresolved":false,"context_lines":[{"line_number":1,"context_line":"maven [test]"},{"line_number":2,"context_line":"# Javac Compiler in lib/tools.jar"},{"line_number":3,"context_line":"openjdk-7-jdk [test platform:dpkg]"}],"source_content_type":"text/plain","patch_set":11,"id":"3fa7e38b_5b1c64c0","line":3,"updated":"2019-09-24 09:20:40.000000000","message":"I think Jenkins now requires Java 8, but it is not available in Ubuntu Trusty iirc.\n\nA few years ago I tried:\n\n* add bindep for java8 https://review.opendev.org/#/c/518284/\n* change the CI jobs to Xenial:\n** https://review.opendev.org/#/c/518287/\n** https://review.opendev.org/#/c/518333/\n\nAnd eventually gave up since I got lost with all the various dependencies/repositories involved.\n\nThen if the job pass fine just by adding openjdk-7-jdk, yeah I guess that is fine.","commit_id":"70b579cc6af5d82f533a7855c702c99ac94cf5a8"}],"src/main/java/hudson/plugins/gearman/StartJobWorker.java":[{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"bc010d6dbe2a60157a4e550b147556ef5df94410","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                       result.add(def.getDefaultParameterValue());"},{"line_number":172,"context_line":"                       buildParams.add(def.getDefaultParameterValue());"},{"line_number":173,"context_line":"                   }"},{"line_number":174,"context_line":"             }"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"            String offline \u003d inParams.get(\"OFFLINE_NODE_WHEN_COMPLETE\");"},{"line_number":177,"context_line":"            if (offline !\u003d null) {"}],"source_content_type":"text/x-java","patch_set":11,"id":"3fa7e38b_bbceb82a","line":174,"updated":"2019-09-24 09:20:40.000000000","message":"This block might need some comment to explain what is going?\n\nMy guess is that it adds the default values defined in the Jenkins job. But that seems to override the parameters that have been passed by the Gearman client?\n\nOr to say it otherwise, shouldn\u0027t the block you add be moved above the comment \"// decode the data from client\"?","commit_id":"70b579cc6af5d82f533a7855c702c99ac94cf5a8"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"c7b2bd66787d9796b12bb0824be32048a48d5399","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                       result.add(def.getDefaultParameterValue());"},{"line_number":172,"context_line":"                       buildParams.add(def.getDefaultParameterValue());"},{"line_number":173,"context_line":"                   }"},{"line_number":174,"context_line":"             }"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"            String offline \u003d inParams.get(\"OFFLINE_NODE_WHEN_COMPLETE\");"},{"line_number":177,"context_line":"            if (offline !\u003d null) {"}],"source_content_type":"text/x-java","patch_set":11,"id":"3fa7e38b_9005c716","line":174,"in_reply_to":"3fa7e38b_bbceb82a","updated":"2019-09-25 01:14:42.000000000","message":"Not override, just merge the parameters.","commit_id":"70b579cc6af5d82f533a7855c702c99ac94cf5a8"}]}