)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18031,"name":"Thomas Bachman","email":"tbachman@yahoo.com","username":"bachmantech"},"change_message_id":"f24f213ca33c7173a58698e080feef6eaac216d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed3b9a20_2be54fab","updated":"2026-06-04 11:43:15.000000000","message":"There is some code that may not be needed, but I\u0027ll approve this for now so that we can verify with functional testing whether or not to keep it. If it\u0027s not needed, we can remove it in a follow-on patch.","commit_id":"8730c5aa0b824d1c2b7621f275f508edc744b5b2"}],"gbpservice/neutron/plugins/ml2plus/drivers/apic_aim/exceptions.py":[{"author":{"_account_id":18031,"name":"Thomas Bachman","email":"tbachman@yahoo.com","username":"bachmantech"},"change_message_id":"f24f213ca33c7173a58698e080feef6eaac216d6","unresolved":true,"context_lines":[{"line_number":164,"context_line":"                \"when it is an external VLAN provider network.\")"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"class ServiceNetworkEnableUpdateNotSupported(exceptions.BadRequest):"},{"line_number":168,"context_line":"    message \u003d _(\"apic:service_network_enable can only be set during network \""},{"line_number":169,"context_line":"                \"creation.\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class ServiceNetworkInUse(exceptions.BadRequest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd780c08_c0070972","line":169,"range":{"start_line":167,"start_character":0,"end_line":169,"end_character":28},"updated":"2026-06-04 11:43:15.000000000","message":"This one may not be needed - I think that the NET_ATTRIBUTES updates in cisco_apic.py in this patch may prevent the REST PUT calls from happening on this attribute (although we should verify that with testing).","commit_id":"8730c5aa0b824d1c2b7621f275f508edc744b5b2"},{"author":{"_account_id":35928,"name":"Mohd Nisar Khan","email":"nisarkhancsengg@gmail.com","username":"nisarkhan"},"change_message_id":"72cf57ce31afa22a1d31ebbb9aba6fa424649183","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                \"when it is an external VLAN provider network.\")"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"class ServiceNetworkEnableUpdateNotSupported(exceptions.BadRequest):"},{"line_number":168,"context_line":"    message \u003d _(\"apic:service_network_enable can only be set during network \""},{"line_number":169,"context_line":"                \"creation.\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class ServiceNetworkInUse(exceptions.BadRequest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"63ee57ed_f02380c6","line":169,"range":{"start_line":167,"start_character":0,"end_line":169,"end_character":28},"in_reply_to":"fd780c08_c0070972","updated":"2026-06-04 12:11:49.000000000","message":"The API schema enforcement(allow_put: False) is sufficient. The mechanism driver check was never reached in practice, so removing it simplifies the code without losing any protection.","commit_id":"8730c5aa0b824d1c2b7621f275f508edc744b5b2"}],"gbpservice/neutron/plugins/ml2plus/drivers/apic_aim/mechanism_driver.py":[{"author":{"_account_id":18031,"name":"Thomas Bachman","email":"tbachman@yahoo.com","username":"bachmantech"},"change_message_id":"f24f213ca33c7173a58698e080feef6eaac216d6","unresolved":true,"context_lines":[{"line_number":992,"context_line":"        is_ext \u003d self._is_external(current)"},{"line_number":993,"context_line":"        is_svi \u003d self._is_svi(current)"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"        if (current.get(cisco_apic.SERVICE_NETWORK_ENABLE) !\u003d"},{"line_number":996,"context_line":"                original.get(cisco_apic.SERVICE_NETWORK_ENABLE)):"},{"line_number":997,"context_line":"            raise exceptions.ServiceNetworkEnableUpdateNotSupported()"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"        if (current.get(qos_consts.QOS_POLICY_ID) and (is_ext or is_svi)):"},{"line_number":1000,"context_line":"            raise exceptions.InvalidNetworkForQos()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fb1841ae_c85f2432","line":997,"range":{"start_line":995,"start_character":0,"end_line":997,"end_character":69},"updated":"2026-06-04 11:43:15.000000000","message":"This may not be needed (i.e. based on NET_ATTRIBUTES in cisco_apic.py).","commit_id":"8730c5aa0b824d1c2b7621f275f508edc744b5b2"},{"author":{"_account_id":35928,"name":"Mohd Nisar Khan","email":"nisarkhancsengg@gmail.com","username":"nisarkhan"},"change_message_id":"72cf57ce31afa22a1d31ebbb9aba6fa424649183","unresolved":false,"context_lines":[{"line_number":992,"context_line":"        is_ext \u003d self._is_external(current)"},{"line_number":993,"context_line":"        is_svi \u003d self._is_svi(current)"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"        if (current.get(cisco_apic.SERVICE_NETWORK_ENABLE) !\u003d"},{"line_number":996,"context_line":"                original.get(cisco_apic.SERVICE_NETWORK_ENABLE)):"},{"line_number":997,"context_line":"            raise exceptions.ServiceNetworkEnableUpdateNotSupported()"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"        if (current.get(qos_consts.QOS_POLICY_ID) and (is_ext or is_svi)):"},{"line_number":1000,"context_line":"            raise exceptions.InvalidNetworkForQos()"}],"source_content_type":"text/x-python","patch_set":3,"id":"b03c45a8_8341d4c5","line":997,"range":{"start_line":995,"start_character":0,"end_line":997,"end_character":69},"in_reply_to":"fb1841ae_c85f2432","updated":"2026-06-04 12:11:49.000000000","message":"Done","commit_id":"8730c5aa0b824d1c2b7621f275f508edc744b5b2"}]}