)]}'
{"ironic_staging_drivers/ovirt/ovirt.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ab0619662ef434cbdc845ad92c92e90d2cc62ae","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            # pycurl.Curl.setopt doesn\u0027t support unicode strings,"},{"line_number":142,"context_line":"            # attempt to turn variables into an all-ASCII string;"},{"line_number":143,"context_line":"            # in Python 3.x setopt accepts bytes as it should."},{"line_number":144,"context_line":"            str.encode(string, encoding\u003d\u0027ascii\u0027, errors\u003d\u0027strict\u0027)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        except UnicodeEncodeError:"},{"line_number":147,"context_line":"            LOG.warning(\"oVirt SDK does not accept non-ascii \""}],"source_content_type":"text/x-python","patch_set":2,"id":"e970fe4e_a23b2e2d","line":144,"updated":"2021-04-07 02:42:26.000000000","message":"url and name need to be assigned to the encoded url and name, I\u0027d just repeat the existing url encode block with another one for name.\n\nThis is probably why unit test test_getvm_nounicode failed","commit_id":"0bb36230c787fdd65b2d02000e76118c4dbb61f6"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"886a8f7e83d196dabf9746f6464556603b684dd1","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        # pycurl.Curl.setopt doesn\u0027t support unicode strings,"},{"line_number":141,"context_line":"        # attempt to turn variables into an all-ASCII string;"},{"line_number":142,"context_line":"        # in Python 3.x setopt accepts bytes as it should."},{"line_number":143,"context_line":"        str.encode(url, encoding\u003d\u0027ascii\u0027, errors\u003d\u0027strict\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    except UnicodeEncodeError:"},{"line_number":146,"context_line":"        LOG.exception(\"oVirt SDK does not accept non-ascii \""}],"source_content_type":"text/x-python","patch_set":4,"id":"3bfc72a3_b64625c5","line":143,"updated":"2021-04-08 02:09:19.000000000","message":"ah, so the purpose of the encode is to validate that it is ascii, so it shouldn\u0027t be assigned back to the url variable because then it will be a binary not a string.","commit_id":"a94fc0ac23c207f3d012b3b1ad313f46dd55bd68"}]}
