)]}'
{"networking_bigswitch/plugins/bigswitch/l3_router_plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0dda3a11a5610e17305b3598cfedfa64514ca5dd","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        self._send_floatingip_update(context)"},{"line_number":501,"context_line":"        return router_ids"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def get_external_network_id(self, context):"},{"line_number":504,"context_line":"        nets \u003d self.get_networks(context, {extnet_apidef.EXTERNAL: [True]})"},{"line_number":505,"context_line":"        if len(nets) \u003e 1:"},{"line_number":506,"context_line":"            raise TooManyExternalNetworks()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_263c21be","line":503,"updated":"2020-02-28 10:58:07.000000000","message":"Just in case, because the original method definition has kwargs, if the method is called with something else than the context, let\u0027s read those extra parameters.","commit_id":"5947e0b21a98b82af9be8e6d3a67f3d6cf387956"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3bf96e70a6ea0362e237802419c1929f20574d71","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        self._send_floatingip_update(context)"},{"line_number":501,"context_line":"        return router_ids"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def get_external_network_id(self, context):"},{"line_number":504,"context_line":"        nets \u003d self.get_networks(context, {extnet_apidef.EXTERNAL: [True]})"},{"line_number":505,"context_line":"        if len(nets) \u003e 1:"},{"line_number":506,"context_line":"            raise TooManyExternalNetworks()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_268421b1","line":503,"in_reply_to":"1fa4df85_263c21be","updated":"2020-02-28 11:52:47.000000000","message":"Are You sure You checked correct method? IMO method used in this class was the one from https://review.opendev.org/#/c/690908/3/neutron/db/external_net_db.py which don\u0027t accepts kwargs","commit_id":"5947e0b21a98b82af9be8e6d3a67f3d6cf387956"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a90ff9d10b9415f189fcc2200c833465398eb4e5","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        self._send_floatingip_update(context)"},{"line_number":501,"context_line":"        return router_ids"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def get_external_network_id(self, context):"},{"line_number":504,"context_line":"        nets \u003d self.get_networks(context, {extnet_apidef.EXTERNAL: [True]})"},{"line_number":505,"context_line":"        if len(nets) \u003e 1:"},{"line_number":506,"context_line":"            raise TooManyExternalNetworks()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_c9b8be2b","line":503,"in_reply_to":"1fa4df85_268421b1","updated":"2020-02-28 12:22:46.000000000","message":"You are right. The DB mixin is from where this class is inheriting this method, not the RPC one.","commit_id":"5947e0b21a98b82af9be8e6d3a67f3d6cf387956"}]}