)]}'
{"ocf/NovaEvacuate":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"058b69342c2b5c853fed7bb70a7f4d63b67ac221","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    fi"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    handle_evacuations $("},{"line_number":223,"context_line":"        attrd_updater -n evacute -A |"},{"line_number":224,"context_line":"            sed \u0027s/ value\u003d\"\"/ value\u003d\"no\"/\u0027 |"},{"line_number":225,"context_line":"            tr \u0027\u003d\"\u0027 \u0027  \u0027 |"},{"line_number":226,"context_line":"            awk \u0027{print $4\" \"$6}\u0027"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba8a016a_7234addd","line":223,"updated":"2015-11-23 10:29:37.000000000","message":"The key -A looks not documented http://clusterlabs.org/man/pacemaker/attrd_updater.8.html\n\nWhat do you think about http://clusterlabs.org/man/pacemaker/crm_attribute.8.html ? Usages example for rabbit cluster OCF https://github.com/rabbitmq/rabbitmq-server/blob/stable/packaging/common/rabbitmq-server-ha.ocf#L375","commit_id":"3c7ec2d8650502d879676a108741222f28850ace"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"eab92a120c6247c34ecec5a85c560548544dcd81","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    fi"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    handle_evacuations $("},{"line_number":223,"context_line":"        attrd_updater -n evacute -A |"},{"line_number":224,"context_line":"            sed \u0027s/ value\u003d\"\"/ value\u003d\"no\"/\u0027 |"},{"line_number":225,"context_line":"            tr \u0027\u003d\"\u0027 \u0027  \u0027 |"},{"line_number":226,"context_line":"            awk \u0027{print $4\" \"$6}\u0027"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba8a016a_88fec4ac","line":223,"in_reply_to":"ba8a016a_7234addd","updated":"2015-11-23 11:06:55.000000000","message":"@Bogdan the -A option was already in use, and this review does not change the way it was used. So while I agree with you that -A should be documented, that is a bug in Pacemaker and IMHO not relevant to this review which is simply fixing the case where attributes are empty strings.  So please can you reconsider your -1?\n\nYes I did wonder why beekhof chose attrd_updater instead of crm_attribute, I guess he has a good reason but we can ask him ...","commit_id":"3c7ec2d8650502d879676a108741222f28850ace"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"439e6f72ba3d32fe22ffe34b8a880e2eedc82b5b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    fi"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    handle_evacuations $("},{"line_number":223,"context_line":"        attrd_updater -n evacute -A |"},{"line_number":224,"context_line":"            sed \u0027s/ value\u003d\"\"/ value\u003d\"no\"/\u0027 |"},{"line_number":225,"context_line":"            tr \u0027\u003d\"\u0027 \u0027  \u0027 |"},{"line_number":226,"context_line":"            awk \u0027{print $4\" \"$6}\u0027"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba8a016a_a38ba967","line":223,"in_reply_to":"ba8a016a_88fec4ac","updated":"2015-11-23 11:26:27.000000000","message":"Also it is not correct that -A is undocumented:\n\nhttps://github.com/ClusterLabs/pacemaker/blob/master/tools/attrd_updater.c#L57\n\nI think the problem is simply that the man pages for the website are out of date.  I have submitted http://bugs.clusterlabs.org/show_bug.cgi?id\u003d5256 for this.","commit_id":"3c7ec2d8650502d879676a108741222f28850ace"}]}