)]}'
{"ocf/NovaCompute":[{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"d145d744e0278cbb80cba4ee5826b72b85205545","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        else"},{"line_number":332,"context_line":"            NOVA_HOST\u003d$(uname -n)"},{"line_number":333,"context_line":"        fi"},{"line_number":334,"context_line":"        validate_host\u003d0"},{"line_number":335,"context_line":"    else"},{"line_number":336,"context_line":"        validate_host\u003d1"},{"line_number":337,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a461143_55ae9081","line":334,"updated":"2017-01-30 17:05:12.000000000","message":"The change looks essentially fine to me but there\u0027s a nitpick which makes me pause before giving a +1: I\u0027m not too keen on how far the local variable declaration is split from its usage - that impacts readability and maintainability.  You could instead put\n\n    local validate_host\u003d1\n\njust before this if clause, and then just drop the else part.  Declaring variables at the start of a function is usually just an unnecessary throwback to the ancient era of C programming before C99 :-)\n\nOf course, that wouldn\u0027t be a concern if this function wasn\u0027t already horribly overgrown, but even prior to any \"extract function\" refactoring, it makes sense to keep related code in the same part of the function.","commit_id":"ccc7435cb16fb451fc8131a7b6abfc375e3a7f13"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"515c7467bea2110102ee8b1bb0b42915a420075c","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        else"},{"line_number":332,"context_line":"            NOVA_HOST\u003d$(uname -n)"},{"line_number":333,"context_line":"        fi"},{"line_number":334,"context_line":"        validate_host\u003d0"},{"line_number":335,"context_line":"    else"},{"line_number":336,"context_line":"        validate_host\u003d1"},{"line_number":337,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a461143_75a2ac4c","line":334,"in_reply_to":"3a461143_55ae9081","updated":"2017-01-30 17:10:23.000000000","message":"Done","commit_id":"ccc7435cb16fb451fc8131a7b6abfc375e3a7f13"}]}
