)]}'
{"ocf/NovaCompute":[{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"eaf7c05eda5e159e80cefec27c7eb48b343fd3fe","unresolved":false,"context_lines":[{"line_number":249,"context_line":"nova_validate() {"},{"line_number":250,"context_line":"    rc\u003d$OCF_SUCCESS"},{"line_number":251,"context_line":"    fence_options\u003d\"\""},{"line_number":252,"context_line":"    local conf_file"},{"line_number":253,"context_line":"    local validate_host"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    check_binary crudini"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a461143_f51bfcc7","line":252,"updated":"2017-01-30 17:08:29.000000000","message":"Same comment as in previous review - there\u0027s no good reason to separate the declaration from its usage, and this makes the code worse given the horribly long function.","commit_id":"0d4666fb5c8b4939c02559e2f87fbcc7e208d086"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"65d21f5133a9419559aaff899d122a593a43e4bf","unresolved":false,"context_lines":[{"line_number":249,"context_line":"nova_validate() {"},{"line_number":250,"context_line":"    rc\u003d$OCF_SUCCESS"},{"line_number":251,"context_line":"    fence_options\u003d\"\""},{"line_number":252,"context_line":"    local conf_file"},{"line_number":253,"context_line":"    local validate_host"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    check_binary crudini"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a461143_b50b3429","line":252,"in_reply_to":"3a461143_f51bfcc7","updated":"2017-01-30 17:13:38.000000000","message":"Done","commit_id":"0d4666fb5c8b4939c02559e2f87fbcc7e208d086"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"eaf7c05eda5e159e80cefec27c7eb48b343fd3fe","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        parsed_value\u003d$(crudini --get \"$conf_file\" DEFAULT host 2\u003e/dev/null)"},{"line_number":337,"context_line":"        if [ $? \u003d 0 ]; then"},{"line_number":338,"context_line":"            NOVA_HOST\u003d\"$parsed_value\""},{"line_number":339,"context_line":"        fi"},{"line_number":340,"context_line":"    done"},{"line_number":341,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a461143_f5493cb8","line":338,"updated":"2017-01-30 17:08:29.000000000","message":"I\u0027m not sure of nova\u0027s precedence rules but I assume you consciously decided not to put a break here, to match nova\u0027s behaviour in case of overlapping config parameters?","commit_id":"0d4666fb5c8b4939c02559e2f87fbcc7e208d086"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"65d21f5133a9419559aaff899d122a593a43e4bf","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        parsed_value\u003d$(crudini --get \"$conf_file\" DEFAULT host 2\u003e/dev/null)"},{"line_number":337,"context_line":"        if [ $? \u003d 0 ]; then"},{"line_number":338,"context_line":"            NOVA_HOST\u003d\"$parsed_value\""},{"line_number":339,"context_line":"        fi"},{"line_number":340,"context_line":"    done"},{"line_number":341,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a461143_18019f05","line":338,"in_reply_to":"3a461143_f5493cb8","updated":"2017-01-30 17:13:38.000000000","message":"Yes, exactly.","commit_id":"0d4666fb5c8b4939c02559e2f87fbcc7e208d086"}]}
