)]}'
{"packstack/plugins/nova_300.py":[{"author":{"_account_id":6807,"name":"Sandro Mathys","email":"sandro@midokura.com","username":"red-trela"},"change_message_id":"bafcdddc6acc40b791a9dd99c328fb6f5175d359","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    Raises ScriptRuntimeError if given host does not have give device."},{"line_number":232,"context_line":"    \"\"\""},{"line_number":233,"context_line":"    server \u003d utils.ScriptRunner(host)"},{"line_number":234,"context_line":"    cmd \u003d \"ifconfig %s || ( echo Device %s does not exist \u0026\u0026 exit 1 )\""},{"line_number":235,"context_line":"    server.append(cmd % (device, device))"},{"line_number":236,"context_line":"    server.execute()"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BvSM%3D","line":234,"updated":"2013-02-20 07:48:27.000000000","message":"Maybe this should be changed to ip instead of ifconfig, too. ifconfig is sorta deprecated and ip is used below.","commit_id":"71496f0ab1334f8428cb9cfae685d4795093558b"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"cd77227ab6ad4325e1f3a781cd09db1969f62813","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    Raises ScriptRuntimeError if given host does not have give device."},{"line_number":232,"context_line":"    \"\"\""},{"line_number":233,"context_line":"    server \u003d utils.ScriptRunner(host)"},{"line_number":234,"context_line":"    cmd \u003d \"ifconfig %s || ( echo Device %s does not exist \u0026\u0026 exit 1 )\""},{"line_number":235,"context_line":"    server.append(cmd % (device, device))"},{"line_number":236,"context_line":"    server.execute()"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BscA%3D","line":234,"in_reply_to":"AAAAM3%2F%2BvSM%3D","updated":"2013-02-21 12:07:42.000000000","message":"I agree here, but this commit is addressing another issue, so it can be handled in another commit.","commit_id":"71496f0ab1334f8428cb9cfae685d4795093558b"},{"author":{"_account_id":6807,"name":"Sandro Mathys","email":"sandro@midokura.com","username":"red-trela"},"change_message_id":"bafcdddc6acc40b791a9dd99c328fb6f5175d359","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    server.execute()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"def bring_up_ifcfg(host, device):"},{"line_number":240,"context_line":"    \"\"\""},{"line_number":241,"context_line":"    Brings given device up if it\u0027s down. Raises ScriptRuntimeError in case"},{"line_number":242,"context_line":"    of failure."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BvSQ%3D","line":239,"updated":"2013-02-20 07:48:27.000000000","message":"Why ifcfg? You seem to bring up the if, not the cfg.","commit_id":"71496f0ab1334f8428cb9cfae685d4795093558b"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"cd77227ab6ad4325e1f3a781cd09db1969f62813","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    server.execute()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"def bring_up_ifcfg(host, device):"},{"line_number":240,"context_line":"    \"\"\""},{"line_number":241,"context_line":"    Brings given device up if it\u0027s down. Raises ScriptRuntimeError in case"},{"line_number":242,"context_line":"    of failure."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bsb0%3D","line":239,"in_reply_to":"AAAAM3%2F%2BvSQ%3D","updated":"2013-02-21 12:07:42.000000000","message":"gonna let this through anyways I don\u0027t think its too confusing","commit_id":"71496f0ab1334f8428cb9cfae685d4795093558b"}]}