)]}'
{"packstack/puppet/modules/packstack/manifests/apache.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    apache::listen { \u00275000\u0027: }"},{"line_number":14,"context_line":"    apache::listen { \u002735357\u0027: }"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    if hiera(\u0027CONFIG_CEILOMETER_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"},{"line_number":17,"context_line":"      if hiera(\u0027CONFIG_CEILOMETER_SERVICE_NAME\u0027) \u003d\u003d \u0027httpd\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_e67ad476","line":14,"updated":"2016-06-16 03:34:17.000000000","message":"is it appropiate to add a comment for each apache::listen class so users that don\u0027t know the ports from memory can understand the code faster?","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"7d1426545b25a6820a8b9d31eb5d41d16d5653f6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      Package[\u0027mod_ssl\u0027] -\u003e Class[\u0027::apache\u0027]"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"    if hiera(\u0027CONFIG_HORIZON_SSL\u0027)  \u003d\u003d \u0027y\u0027 {"},{"line_number":10,"context_line":"      apache::listen { \u0027443\u0027: }"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    "},{"line_number":13,"context_line":"    # Keystone port"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5a9d85d2_eb5bb652","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":31},"updated":"2016-06-21 15:41:41.000000000","message":"is there a reason for having this extra if statement instead of:\n\n\n    if hiera(\u0027CONFIG_HORIZON_SSL\u0027)  \u003d\u003d \u0027y\u0027 {\n      ensure_packages([\u0027mod_ssl\u0027], {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})\n      Package[\u0027mod_ssl\u0027] -\u003e Class[\u0027::apache\u0027]\n      apache::listen { \u0027443\u0027: }\n    }","commit_id":"78ce94ffcd5fa59b061f93e1e179b78a9d679042"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"1953cb950f6f344cc6777028eb0f11466d5a2510","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      Package[\u0027mod_ssl\u0027] -\u003e Class[\u0027::apache\u0027]"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"    if hiera(\u0027CONFIG_HORIZON_SSL\u0027)  \u003d\u003d \u0027y\u0027 {"},{"line_number":10,"context_line":"      apache::listen { \u0027443\u0027: }"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    "},{"line_number":13,"context_line":"    # Keystone port"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5a9d85d2_724e6d70","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":31},"in_reply_to":"5a9d85d2_eb5bb652","updated":"2016-06-21 15:46:03.000000000","message":"Mmm not really, just not paying enough attention during copy/paste. I\u0027ll fix it right away :).","commit_id":"78ce94ffcd5fa59b061f93e1e179b78a9d679042"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"7d1426545b25a6820a8b9d31eb5d41d16d5653f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    if hiera(\u0027CONFIG_HORIZON_SSL\u0027)  \u003d\u003d \u0027y\u0027 {"},{"line_number":10,"context_line":"      apache::listen { \u0027443\u0027: }"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    "},{"line_number":13,"context_line":"    # Keystone port"},{"line_number":14,"context_line":"    apache::listen { \u00275000\u0027: }"},{"line_number":15,"context_line":"    # Keystone admin port"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5a9d85d2_eb51f663","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"updated":"2016-06-21 15:41:41.000000000","message":"whitespace","commit_id":"78ce94ffcd5fa59b061f93e1e179b78a9d679042"}],"packstack/puppet/modules/packstack/manifests/ceilometer.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      $redis_port \u003d hiera(\u0027CONFIG_REDIS_PORT\u0027)"},{"line_number":16,"context_line":"      $coordination_url \u003d \"redis://${redis_host}:${redis_port}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"      ensure_packages([\u0027python-redis\u0027], {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})    "},{"line_number":19,"context_line":"    } else {"},{"line_number":20,"context_line":"      $coordination_url \u003d \u0027\u0027"},{"line_number":21,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_468c887f","line":18,"updated":"2016-06-16 03:34:17.000000000","message":"whitespaces","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/cinder/backend/netapp.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":22,"context_line":"          nfs_shares                \u003d\u003e hiera_array(\u0027CONFIG_CINDER_NETAPP_NFS_SHARES\u0027),"},{"line_number":23,"context_line":"          nfs_shares_config         \u003d\u003e hiera(\u0027CONFIG_CINDER_NETAPP_NFS_SHARES_CONFIG\u0027),"},{"line_number":24,"context_line":"        }"},{"line_number":25,"context_line":"        ensure_packages([\u0027nfs-utils\u0027], {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})    "},{"line_number":26,"context_line":"      }"},{"line_number":27,"context_line":"      elsif $netapp_storage_protocol \u003d\u003d \u0027iscsi\u0027 {"},{"line_number":28,"context_line":"        cinder::backend::netapp { $netapp_backend_name:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_e6a93492","line":25,"range":{"start_line":25,"start_character":63,"end_line":25,"end_character":67},"updated":"2016-06-16 03:34:17.000000000","message":"whitespaces","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":71,"context_line":"          nfs_shares_config         \u003d\u003e hiera(\u0027CONFIG_CINDER_NETAPP_NFS_SHARES_CONFIG\u0027),"},{"line_number":72,"context_line":"        }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        ensure_packages([\u0027nfs-utils\u0027], {\u0027ensure\u0027 \u003d\u003e \u0027present\u0027})    "},{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":"      elsif $netapp_storage_protocol \u003d\u003d \u0027iscsi\u0027 {"},{"line_number":77,"context_line":"        cinder::backend::netapp { $netapp_backend_name:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_c6aeb897","line":74,"range":{"start_line":74,"start_character":63,"end_line":74,"end_character":67},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/glance.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::glance () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    create_resources(packstack::firewall, hiera(\u0027FIREWALL_GLANCE_RULES\u0027, {}))"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_069f2051","line":1,"range":{"start_line":1,"start_character":26,"end_line":1,"end_character":27},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/glance/backend/file.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::glance::backend::file () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    # TO-DO: Make this configurable"},{"line_number":4,"context_line":"    class { \u0027::glance::backend::file\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_46a9287b","line":1,"range":{"start_line":1,"start_character":41,"end_line":1,"end_character":42},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/glance/backend/swift.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::glance::backend::swift () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    class { \u0027::glance::backend::swift\u0027:"},{"line_number":4,"context_line":"      swift_store_user                    \u003d\u003e \u0027services:glance\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_26d05cf7","line":1,"range":{"start_line":1,"start_character":42,"end_line":1,"end_character":43},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/glance/ceilometer.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::glance::ceilometer () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $kombu_ssl_ca_certs \u003d hiera(\u0027CONFIG_AMQP_SSL_CACERT_FILE\u0027, undef)"},{"line_number":4,"context_line":"    $kombu_ssl_keyfile \u003d hiera(\u0027CONFIG_GLANCE_SSL_KEY\u0027, undef)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_86079080","line":1,"range":{"start_line":1,"start_character":38,"end_line":1,"end_character":39},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/aodh.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::aodh () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $keystone_host_url \u003d hiera(\u0027CONFIG_KEYSTONE_HOST_URL\u0027)"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_693357f7","line":1,"range":{"start_line":1,"start_character":34,"end_line":1,"end_character":35},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/ceilometer.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::ceilometer () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $ceilometer_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $ceilometer_port \u003d \u00278777\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_29402f35","line":1,"range":{"start_line":1,"start_character":40,"end_line":1,"end_character":41},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/cinder.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::cinder () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $cinder_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $cinder_host \u003d hiera(\u0027CONFIG_STORAGE_HOST_URL\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_c971abaa","line":1,"range":{"start_line":1,"start_character":36,"end_line":1,"end_character":37},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/glance.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::glance () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $glance_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $glance_port \u003d \u00279292\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_29678feb","line":1,"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/gnocchi.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::gnocchi () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $gnocchi_keystone_host_url \u003d hiera(\u0027CONFIG_KEYSTONE_HOST_URL\u0027)"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_e9a3c7fe","line":1,"range":{"start_line":1,"start_character":37,"end_line":1,"end_character":38},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/heat.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::heat () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $heat_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $heat_port \u003d \u00278004\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_c9a88bde","line":1,"range":{"start_line":1,"start_character":34,"end_line":1,"end_character":35},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/ironic.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::ironic () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $ironic_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $ironic_host \u003d hiera(\u0027CONFIG_KEYSTONE_HOST_URL\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_698fd775","line":1,"range":{"start_line":1,"start_character":36,"end_line":1,"end_character":37},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/manila.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::manila () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $manila_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $manila_host \u003d hiera(\u0027CONFIG_STORAGE_HOST_URL\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_c9f6cbf8","line":1,"range":{"start_line":1,"start_character":36,"end_line":1,"end_character":37},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/neutron.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::neutron () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $neutron_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $neutron_host \u003d hiera(\u0027CONFIG_KEYSTONE_HOST_URL\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_896163ab","line":1,"range":{"start_line":1,"start_character":37,"end_line":1,"end_character":38},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/nova.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::nova () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $nova_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $nova_host \u003d hiera(\u0027CONFIG_KEYSTONE_HOST_URL\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_c95b6bf5","line":1,"range":{"start_line":1,"start_character":34,"end_line":1,"end_character":35},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/sahara.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::sahara () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $sahara_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $sahara_host \u003d hiera(\u0027CONFIG_KEYSTONE_HOST_URL\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_29f82fc4","line":1,"range":{"start_line":1,"start_character":36,"end_line":1,"end_character":37},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/swift.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::swift () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $swift_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $swift_host \u003d hiera(\u0027CONFIG_STORAGE_HOST_URL\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_09f573ca","line":1,"range":{"start_line":1,"start_character":35,"end_line":1,"end_character":36},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/keystone/trove.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::keystone::trove () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $trove_protocol \u003d \u0027http\u0027"},{"line_number":4,"context_line":"    $trove_host \u003d hiera(\u0027CONFIG_KEYSTONE_HOST_URL\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_690237b6","line":1,"range":{"start_line":1,"start_character":35,"end_line":1,"end_character":36},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/mariadb/services.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::mariadb::services () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    class { \u0027::keystone::db::mysql\u0027:"},{"line_number":4,"context_line":"      user          \u003d\u003e \u0027keystone_admin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_4945bbb1","line":1,"range":{"start_line":1,"start_character":37,"end_line":1,"end_character":38},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7aa08908_691fd7b7","line":107,"updated":"2016-06-16 03:34:17.000000000","message":"ohhh this is nice javier!!\neasier to check database configuration :)","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/mariadb/services_noinstall.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::mariadb::services_noinstall () {"},{"line_number":2,"context_line":"        remote_database { \u0027keystone\u0027:"},{"line_number":3,"context_line":"          ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":4,"context_line":"          charset     \u003d\u003e \u0027utf8\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_a9ba5f6f","line":1,"range":{"start_line":1,"start_character":48,"end_line":1,"end_character":49},"updated":"2016-06-16 03:34:17.000000000","message":"if i understood correctly this is in the case in which mariadb is remote right?\n\ni was thinking that the module should be named something like: services_remote","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/nagios/server.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":54,"context_line":"export OS_TENANT_NAME\u003dadmin"},{"line_number":55,"context_line":"export OS_PASSWORD\u003d${nagios_cfg_ks_adm_pw}"},{"line_number":56,"context_line":"export OS_AUTH_URL\u003d${nagios_cfg_keystone_url}\","},{"line_number":57,"context_line":"    } "},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    $cfg_nagios_pw \u003d hiera(\u0027CONFIG_NAGIOS_PW\u0027)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_0973b3e8","line":57,"range":{"start_line":57,"start_character":5,"end_line":57,"end_character":6},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/neutron/ovs_agent.pp":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4031c1412c1ffa5acba57617e2dd3d1df5bfa79a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      $localip \u003d choose_my_ip(hiera(\u0027HOST_LIST\u0027))"},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    if $network_host {"},{"line_number":29,"context_line":"      $bridge_ifaces_param \u003d \u0027CONFIG_NEUTRON_OVS_BRIDGE_IFACES\u0027"},{"line_number":30,"context_line":"      $bridge_mappings_param \u003d \u0027CONFIG_NEUTRON_OVS_BRIDGE_MAPPINGS\u0027"},{"line_number":31,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_83779b3a","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":20},"updated":"2016-06-15 14:35:42.000000000","message":"We need to add the logic to find the value for network_host parameter. in the past, it was written by plugin when creating the manifest.","commit_id":"ba24d20030ee1e9dfbd2278a83760bd2a8964670"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"4f7c95ee7017928ec58ef038e404b4140e289fbf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      $localip \u003d choose_my_ip(hiera(\u0027HOST_LIST\u0027))"},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    if $network_host {"},{"line_number":29,"context_line":"      $bridge_ifaces_param \u003d \u0027CONFIG_NEUTRON_OVS_BRIDGE_IFACES\u0027"},{"line_number":30,"context_line":"      $bridge_mappings_param \u003d \u0027CONFIG_NEUTRON_OVS_BRIDGE_MAPPINGS\u0027"},{"line_number":31,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_63cf0f2a","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":20},"in_reply_to":"7aa08908_83779b3a","updated":"2016-06-15 14:39:29.000000000","message":"good catch! I had fixed this same logic in compute.pp, but forgot to include it here.","commit_id":"ba24d20030ee1e9dfbd2278a83760bd2a8964670"}],"packstack/puppet/modules/packstack/manifests/nova/ceilometer.pp":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"5d0b71e8505e5ce256ac10600a27a7a6af75db4b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::nova::ceilometer ()"},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    class { \u0027::ceilometer::agent::auth\u0027:"},{"line_number":4,"context_line":"      auth_url      \u003d\u003e hiera(\u0027CONFIG_KEYSTONE_PUBLIC_URL\u0027),"},{"line_number":5,"context_line":"      auth_password \u003d\u003e hiera(\u0027CONFIG_CEILOMETER_KS_PW\u0027),"},{"line_number":6,"context_line":"      auth_region   \u003d\u003e hiera(\u0027CONFIG_KEYSTONE_REGION\u0027),"},{"line_number":7,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_cda8ac23","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":56},"updated":"2016-06-15 16:32:34.000000000","message":"It should be CONFIG_KEYSTONE_PUBLIC_URL_VERSIONLESS","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/nova/network.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::nova::network () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    $multihost \u003d hiera(\u0027CONFIG_NOVA_NETWORK_MULTIHOST\u0027)"},{"line_number":4,"context_line":"    if $multihost {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_afd41fbd","line":1,"range":{"start_line":1,"start_character":33,"end_line":1,"end_character":34},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/nova/sched.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::nova::sched () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    class {\u0027::nova::scheduler::filter\u0027:"},{"line_number":4,"context_line":"      # OpenStack doesn\u0027t include the CoreFilter (\u003d CPU Filter) by default"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_2ff82f49","line":1,"range":{"start_line":1,"start_character":31,"end_line":1,"end_character":32},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/modules/packstack/manifests/nova/sched/ironic.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class packstack::nova::sched::ironic () "},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    nova_config {"},{"line_number":4,"context_line":"      \u0027DEFAULT/scheduler_host_manager\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_cf9d2b0c","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":40},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"packstack/puppet/templates/controller.pp":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  include \u0027::packstack::nova::conductor\u0027"},{"line_number":74,"context_line":"  if hiera(\u0027CONFIG_IRONIC_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"},{"line_number":75,"context_line":"    include \u0027::packstack::nova::sched::ironic\u0027"},{"line_number":76,"context_line":"  } "},{"line_number":77,"context_line":"  include \u0027::packstack::nova::sched\u0027"},{"line_number":78,"context_line":"  include \u0027::packstack::nova::vncproxy\u0027"},{"line_number":79,"context_line":"  if hiera(\u0027CONFIG_NEUTRON_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_5abd7b01","line":76,"range":{"start_line":76,"start_character":3,"end_line":76,"end_character":4},"updated":"2016-06-16 03:34:17.000000000","message":"whitespace","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}],"releasenotes/notes/manifest-execution-refactor-418c27bbc03df064.yaml":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"d3426db7722f33b8180554a56af4ad26d7980570","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    smaller snippets (templates), and executed them following a certain"},{"line_number":5,"context_line":"    order. This is sub-optimal, since it forces code duplication and goes"},{"line_number":6,"context_line":"    against the Puppet design of running a single manifest."},{"line_number":7,"context_line":"    "},{"line_number":8,"context_line":"    This patch refactors the manifest execution, with the following changes"},{"line_number":9,"context_line":"    "},{"line_number":10,"context_line":"    - Only 4 templates used, so max 4 Puppet executions on a host. Controller"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7aa08908_3a518fd9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2016-06-16 03:34:17.000000000","message":"not shure if it applies here but there are whitespaces","commit_id":"99be34ad2f618cbcbc5687394b6ee4b18ec446c1"}]}