)]}'
{"packstack/puppet/modules/packstack/manifests/neutron/rabbitmq.pp":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"8a3829c363c80aeb8e26260e64d7dc0bf1754103","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      file { $files_to_set_owner:"},{"line_number":16,"context_line":"        owner   \u003d\u003e \u0027neutron\u0027,"},{"line_number":17,"context_line":"        group   \u003d\u003e \u0027neutron\u0027,"},{"line_number":18,"context_line":"        require \u003d\u003e Package[\u0027neutron\u0027],"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"      File[$files_to_set_owner] ~\u003e Service\u003c| tag \u003d\u003d \u0027neutron-service\u0027 |\u003e"},{"line_number":21,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"fa6399be_245e9045","line":18,"updated":"2016-10-19 08:38:29.000000000","message":"Why is that puppet4 change?","commit_id":"3aee627396820a30b060fdea72659ea19b16d160"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"9022e0ee0fe5ac7102a1fd6065b9fe0617cc5fb1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      file { $files_to_set_owner:"},{"line_number":16,"context_line":"        owner   \u003d\u003e \u0027neutron\u0027,"},{"line_number":17,"context_line":"        group   \u003d\u003e \u0027neutron\u0027,"},{"line_number":18,"context_line":"        require \u003d\u003e Package[\u0027neutron\u0027],"},{"line_number":19,"context_line":"      }"},{"line_number":20,"context_line":"      File[$files_to_set_owner] ~\u003e Service\u003c| tag \u003d\u003d \u0027neutron-service\u0027 |\u003e"},{"line_number":21,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"fa6399be_3fbf7dfd","line":18,"in_reply_to":"fa6399be_245e9045","updated":"2016-10-19 08:46:41.000000000","message":"Good question! Short answer is \"it failed when run in Puppet 4 and worked in Puppet 3\" :).\n\nMy best guess is that Package[\u0027neutron\u0027] is the actual resource name, while \u0027openstack-neutron\u0027 is the package name set by puppet-neutron. It failed on one of the early patch sets and was fixed this way, so I didn\u0027t do any more research.","commit_id":"3aee627396820a30b060fdea72659ea19b16d160"}],"packstack/puppet/modules/packstack/manifests/nova/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f1e81057ef75212bbbefd0fa80163e4800b0a882","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      enabled                              \u003d\u003e true,"},{"line_number":32,"context_line":"      neutron_metadata_proxy_shared_secret \u003d\u003e hiera(\u0027CONFIG_NEUTRON_METADATA_PW_UNQUOTED\u0027, undef),"},{"line_number":33,"context_line":"      default_floating_pool                \u003d\u003e $default_floating_pool,"},{"line_number":34,"context_line":"      pci_alias                            \u003d\u003e hiera(\u0027CONFIG_NOVA_PCI_ALIAS\u0027),"},{"line_number":35,"context_line":"      sync_db_api                          \u003d\u003e true,"},{"line_number":36,"context_line":"      osapi_compute_workers                \u003d\u003e hiera(\u0027CONFIG_SERVICE_WORKERS\u0027),"},{"line_number":37,"context_line":"      metadata_workers                     \u003d\u003e hiera(\u0027CONFIG_SERVICE_WORKERS\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_8e9c82c1","side":"PARENT","line":34,"updated":"2016-10-07 15:12:38.000000000","message":"why not defaulting to false like:\nhiera(\u0027CONFIG_NOVA_PCI_ALIAS\u0027, false)","commit_id":"d4ca0ee76d3f0de06437a1b16fea9e848857bfa2"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"e49e7b4c473cf927c9c2938c4e3c68bd5601cc7b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      enabled                              \u003d\u003e true,"},{"line_number":32,"context_line":"      neutron_metadata_proxy_shared_secret \u003d\u003e hiera(\u0027CONFIG_NEUTRON_METADATA_PW_UNQUOTED\u0027, undef),"},{"line_number":33,"context_line":"      default_floating_pool                \u003d\u003e $default_floating_pool,"},{"line_number":34,"context_line":"      pci_alias                            \u003d\u003e hiera(\u0027CONFIG_NOVA_PCI_ALIAS\u0027),"},{"line_number":35,"context_line":"      sync_db_api                          \u003d\u003e true,"},{"line_number":36,"context_line":"      osapi_compute_workers                \u003d\u003e hiera(\u0027CONFIG_SERVICE_WORKERS\u0027),"},{"line_number":37,"context_line":"      metadata_workers                     \u003d\u003e hiera(\u0027CONFIG_SERVICE_WORKERS\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_ee9b4664","side":"PARENT","line":34,"in_reply_to":"1a95cdbc_8e9c82c1","updated":"2016-10-07 15:16:50.000000000","message":"Same issue as with CONFIG_NTP_SERVERS. Packstack is generating the Hiera data for this variable as \u0027\u0027, so we cannot default to false.","commit_id":"d4ca0ee76d3f0de06437a1b16fea9e848857bfa2"}],"packstack/puppet/templates/compute.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f1e81057ef75212bbbefd0fa80163e4800b0a882","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"create_resources(sshkey, hiera(\u0027SSH_KEYS\u0027, {}))"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if hiera(\u0027CONFIG_NTP_SERVERS\u0027, \u0027\u0027) !\u003d \u0027\u0027 {"},{"line_number":13,"context_line":"  include \u0027::packstack::chrony\u0027"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_2edc4e72","line":12,"updated":"2016-10-07 15:12:38.000000000","message":"if hiera(\u0027CONFIG_NTP_SERVERS\u0027, false) should be good and more Puppetish.","commit_id":"b07b91bbc83c37c9ee3c721cb895fb60fb8ef0eb"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"e49e7b4c473cf927c9c2938c4e3c68bd5601cc7b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"create_resources(sshkey, hiera(\u0027SSH_KEYS\u0027, {}))"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if hiera(\u0027CONFIG_NTP_SERVERS\u0027, \u0027\u0027) !\u003d \u0027\u0027 {"},{"line_number":13,"context_line":"  include \u0027::packstack::chrony\u0027"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_ee84260c","line":12,"in_reply_to":"1a95cdbc_2edc4e72","updated":"2016-10-07 15:16:50.000000000","message":"I tried that, but it doesn\u0027t work for us. Packstack is generating a Hiera value for CONFIG_NTP_SERVERS of \u0027\u0027. This was evaluated to false with puppet 3, but not with Puppet 4. \n\nSo we need to make sure that, if it\u0027s \u0027\u0027 or undefined, we won\u0027t enter this section.","commit_id":"b07b91bbc83c37c9ee3c721cb895fb60fb8ef0eb"}],"packstack/puppet/templates/controller.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f1e81057ef75212bbbefd0fa80163e4800b0a882","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  stage \u003d\u003e init,"},{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if hiera(\u0027CONFIG_NTP_SERVERS\u0027, \u0027\u0027) !\u003d \u0027\u0027 {"},{"line_number":11,"context_line":"  include \u0027::packstack::chrony\u0027"},{"line_number":12,"context_line":"}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_aed69e4c","line":10,"updated":"2016-10-07 15:12:38.000000000","message":"dito","commit_id":"b07b91bbc83c37c9ee3c721cb895fb60fb8ef0eb"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"8a3829c363c80aeb8e26260e64d7dc0bf1754103","unresolved":false,"context_lines":[{"line_number":39,"context_line":"if hiera(\u0027CONFIG_CINDER_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"},{"line_number":40,"context_line":"  include \u0027::packstack::keystone::cinder\u0027"},{"line_number":41,"context_line":"  include \u0027::packstack::cinder::rabbitmq\u0027"},{"line_number":42,"context_line":"  include \u0027::packstack::cinder\u0027"},{"line_number":43,"context_line":"  if hiera(\u0027CONFIG_CEILOMETER_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"},{"line_number":44,"context_line":"    include \u0027::packstack::cinder::ceilometer\u0027"},{"line_number":45,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"fa6399be_e43ad8e6","line":42,"updated":"2016-10-19 08:38:29.000000000","message":"Why is that puppet4 change?","commit_id":"3aee627396820a30b060fdea72659ea19b16d160"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c5e7408a606ef2fd89b69bcdef6fa41863c7b7d8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"if hiera(\u0027CONFIG_CINDER_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"},{"line_number":40,"context_line":"  include \u0027::packstack::keystone::cinder\u0027"},{"line_number":41,"context_line":"  include \u0027::packstack::cinder::rabbitmq\u0027"},{"line_number":42,"context_line":"  include \u0027::packstack::cinder\u0027"},{"line_number":43,"context_line":"  if hiera(\u0027CONFIG_CEILOMETER_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"},{"line_number":44,"context_line":"    include \u0027::packstack::cinder::ceilometer\u0027"},{"line_number":45,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"fa6399be_a27a4d86","line":42,"in_reply_to":"fa6399be_df5761c8","updated":"2016-10-20 16:42:44.000000000","message":"Why are those includes even single quoted ? But topic for another patch :)","commit_id":"3aee627396820a30b060fdea72659ea19b16d160"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"9022e0ee0fe5ac7102a1fd6065b9fe0617cc5fb1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"if hiera(\u0027CONFIG_CINDER_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"},{"line_number":40,"context_line":"  include \u0027::packstack::keystone::cinder\u0027"},{"line_number":41,"context_line":"  include \u0027::packstack::cinder::rabbitmq\u0027"},{"line_number":42,"context_line":"  include \u0027::packstack::cinder\u0027"},{"line_number":43,"context_line":"  if hiera(\u0027CONFIG_CEILOMETER_INSTALL\u0027) \u003d\u003d \u0027y\u0027 {"},{"line_number":44,"context_line":"    include \u0027::packstack::cinder::ceilometer\u0027"},{"line_number":45,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"fa6399be_df5761c8","line":42,"in_reply_to":"fa6399be_e43ad8e6","updated":"2016-10-19 08:46:41.000000000","message":"This is probably unneeded, it was a result of trying to fix another CI error. I can revert it, but it works this way.","commit_id":"3aee627396820a30b060fdea72659ea19b16d160"}],"packstack/puppet/templates/network.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f1e81057ef75212bbbefd0fa80163e4800b0a882","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  stage \u003d\u003e init,"},{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if hiera(\u0027CONFIG_NTP_SERVERS\u0027, \u0027\u0027) !\u003d \u0027\u0027 {"},{"line_number":11,"context_line":"  include \u0027::packstack::chrony\u0027"},{"line_number":12,"context_line":"}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a95cdbc_2ec36e8a","line":10,"updated":"2016-10-07 15:12:38.000000000","message":"dito","commit_id":"b07b91bbc83c37c9ee3c721cb895fb60fb8ef0eb"}],"run_tests.sh":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c5e7408a606ef2fd89b69bcdef6fa41863c7b7d8","unresolved":false,"context_lines":[{"line_number":238,"context_line":"fi"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# Make sure there are no other puppet modules in the system (happens in gate)"},{"line_number":241,"context_line":"$SUDO rm -rf /etc/puppet/modules/*"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# Make sure the fqdn is associated to the IP in /etc/hosts"},{"line_number":244,"context_line":"# Needed for Horizon SSL tests in Tempest"}],"source_content_type":"text/x-sh","patch_set":20,"id":"fa6399be_82838955","line":241,"updated":"2016-10-20 16:42:44.000000000","message":"Do we care ? Packstack uses /usr/share/openstack-puppet/modules explicitely, no ?","commit_id":"3aee627396820a30b060fdea72659ea19b16d160"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"f9955a0622b9ff7c186712db1b17be4577901838","unresolved":false,"context_lines":[{"line_number":238,"context_line":"fi"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# Make sure there are no other puppet modules in the system (happens in gate)"},{"line_number":241,"context_line":"$SUDO rm -rf /etc/puppet/modules/*"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# Make sure the fqdn is associated to the IP in /etc/hosts"},{"line_number":244,"context_line":"# Needed for Horizon SSL tests in Tempest"}],"source_content_type":"text/x-sh","patch_set":20,"id":"fa6399be_221f1d09","line":241,"in_reply_to":"fa6399be_82838955","updated":"2016-10-20 16:50:49.000000000","message":"We do care.\n\nFor whatever reason, Puppet was taking some code from /etc/puppet/modules and messing up with the nova_config provider, making it use the ini_setting parent instead of the ruby one. There\u0027s a long trail of failed CI jobs and greyed hair behind this one :).","commit_id":"3aee627396820a30b060fdea72659ea19b16d160"}]}