)]}'
{"packstack/plugins/neutron_350.py":[{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"45e873c7afc125533a6e346b72e057fcc91bba5d","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                            raise KeyError(\u0027Couldn\\\u0027t detect ipaddress of \u0027"},{"line_number":690,"context_line":"                                           \u0027interface %s on node %s\u0027 %"},{"line_number":691,"context_line":"                                           (iface, n_host))"},{"line_number":692,"context_line":"                    else:"},{"line_number":693,"context_line":"                        src_host \u003d n_host"},{"line_number":694,"context_line":"                    tunnel_fw_details(config, host, src_host, fw_details)"},{"line_number":695,"context_line":"                config[cf_fw_nt_key] \u003d fw_details"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"def create_l3_manifests(config, messages):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_cb0fab2c","line":695,"range":{"start_line":692,"start_character":25,"end_line":695,"end_character":49},"updated":"2017-06-12 14:07:10.000000000","message":"Actually, it may not be a good idea to exclude hosts if we are adding compute nodes.\n\nLet\u0027s assume we have 1 controller and 1 compute, and we want to add a second compute. If we use EXCLUDE_SERVERS for the other two, we wouldn\u0027t be generating the firewall rules to allow tunneled traffic between the new compute and the old nodes, which would result in no network access between VMs placed in the new compute and anywhere else.\n\nWe may want to fix lp#1696994 differently, for example by not allowing EXCLUDE_SERVERS when we are setting CONFIG_NEUTRON_OVS_TUNNEL_IF.","commit_id":"324af9ba4ff1d743009688c8140639b6dd74ed75"}]}
