)]}'
{"packstack/plugins/cinder_250.py":[{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"6872a4c42e3dcc08c8a32da63cd0d8177c67cb82","unresolved":false,"context_lines":[{"line_number":520,"context_line":"         \"PRE_CONDITION_MATCH\": True,"},{"line_number":521,"context_line":"         \"POST_CONDITION\": False,"},{"line_number":522,"context_line":"         \"POST_CONDITION_MATCH\": True},"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        {\"GROUP_NAME\": \"CINDERGLUSTERMOUNTS\","},{"line_number":525,"context_line":"         \"DESCRIPTION\": \"Cinder gluster Config parameters\","},{"line_number":526,"context_line":"         \"PRE_CONDITION\": check_gluster_options,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_3e06a253","line":523,"updated":"2017-06-19 10:05:29.000000000","message":"You should add the group name you just created (CINDERVOLUMENAME) here, otherwise it won\u0027t be considered as part of the configuration.","commit_id":"23d1de9c15051fe681626ff9b53b4e32c0865393"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"d0aedfc59a96ba57559b051ad404d8a78692510c","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    return (config[\u0027CONFIG_CINDER_INSTALL\u0027] \u003d\u003d \u0027y\u0027 and"},{"line_number":644,"context_line":"            \u0027lvm\u0027 in config[\u0027CONFIG_CINDER_BACKEND\u0027])"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"def check_lvm_vg_name(config):"},{"line_number":647,"context_line":"    return (config[\u0027CONFIG_CINDER_INSTALL\u0027] \u003d\u003d \u0027y\u0027 and"},{"line_number":648,"context_line":"            \u0027lvm\u0027 in config[\u0027CONFIG_CINDER_BACKEND\u0027])"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"def check_gluster_options(config):"},{"line_number":651,"context_line":"    return (config[\u0027CONFIG_CINDER_INSTALL\u0027] \u003d\u003d \u0027y\u0027 and"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_357118a9","line":648,"range":{"start_line":646,"start_character":0,"end_line":648,"end_character":53},"updated":"2017-06-19 13:53:11.000000000","message":"this is the same as check_lvm_vg_options above, I guess we could just merge them (also with check_lvm_options, but that should be a separate review)","commit_id":"b1f8b00b31e202d20f7fc9310566f751474f36c0"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"fbb8d18d1d8533d2f5a11e72fbeaca0091497ece","unresolved":false,"context_lines":[{"line_number":519,"context_line":"         \"PRE_CONDITION\": check_lvm_vg_options,"},{"line_number":520,"context_line":"         \"PRE_CONDITION_MATCH\": True,"},{"line_number":521,"context_line":"         \"POST_CONDITION\": False,"},{"line_number":522,"context_line":"         \"POST_CONDITION_MATCH\": True},"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        {\"GROUP_NAME\": \"CINDERGLUSTERMOUNTS\","},{"line_number":525,"context_line":"         \"DESCRIPTION\": \"Cinder gluster Config parameters\","}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_3ced59ef","line":522,"updated":"2017-06-21 11:12:10.000000000","message":"The \"CINDERVOLUMENAME\" block shouldn\u0027t be removed. To avoid the duplicate \"check_lvm_vg_name\", just put the block back and set \"PRE_CONTITION\": check_lvm_options.","commit_id":"d3eb6dcb941e55c1ef78ee982d3c174330b12e22"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"78596af12a6e6011004fbb9d1732a0e79a1befe8","unresolved":false,"context_lines":[{"line_number":703,"context_line":"# -------------------------- step functions --------------------------"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"def check_cinder_vg(config, messages):"},{"line_number":706,"context_line":"    cinders_volume \u003d config[\"CONFIG_CINDER_VOLUMES_NAME\"]"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    # Do we have a cinder-volumes vg?"},{"line_number":709,"context_line":"    have_cinders_volume \u003d False"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_a57145e3","line":706,"range":{"start_line":706,"start_character":29,"end_line":706,"end_character":55},"updated":"2017-06-21 14:54:43.000000000","message":"should be CONFIG_CINDER_VOLUME_NAME (extra S)","commit_id":"d0f1ed55496819657a76f6f14551c2dd7b43b560"}],"packstack/puppet/modules/packstack/manifests/cinder/backend/lvm.pp":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2ad14ac2ac1c73ae123937afc9585fddc4df8404","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"          file_line{ \u0027rc.local_losetup_cinder_volume\u0027:"},{"line_number":21,"context_line":"            path  \u003d\u003e \u0027/etc/rc.d/rc.local\u0027,"},{"line_number":22,"context_line":"            match \u003d\u003e \u0027^.*/var/lib/cinder/cinder-volumes.*$\u0027,"},{"line_number":23,"context_line":"            line  \u003d\u003e \u0027losetup -f /var/lib/cinder/cinder-volumes \u0026\u0026 service openstack-cinder-volume restart\u0027,"},{"line_number":24,"context_line":"          }"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f201791_d12771b6","line":22,"range":{"start_line":22,"start_character":41,"end_line":22,"end_character":55},"updated":"2017-06-21 09:59:21.000000000","message":"cinder-volumes name is still hardcoded here.","commit_id":"51658b59b0943a6b73d2ff6b9b7188f73e9f3534"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2ad14ac2ac1c73ae123937afc9585fddc4df8404","unresolved":false,"context_lines":[{"line_number":20,"context_line":"          file_line{ \u0027rc.local_losetup_cinder_volume\u0027:"},{"line_number":21,"context_line":"            path  \u003d\u003e \u0027/etc/rc.d/rc.local\u0027,"},{"line_number":22,"context_line":"            match \u003d\u003e \u0027^.*/var/lib/cinder/cinder-volumes.*$\u0027,"},{"line_number":23,"context_line":"            line  \u003d\u003e \u0027losetup -f /var/lib/cinder/cinder-volumes \u0026\u0026 service openstack-cinder-volume restart\u0027,"},{"line_number":24,"context_line":"          }"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"          file { \u0027/etc/rc.d/rc.local\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f201791_513b61d0","line":23,"range":{"start_line":23,"start_character":49,"end_line":23,"end_character":63},"updated":"2017-06-21 09:59:21.000000000","message":"ditto","commit_id":"51658b59b0943a6b73d2ff6b9b7188f73e9f3534"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2ad14ac2ac1c73ae123937afc9585fddc4df8404","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    [Service]"},{"line_number":43,"context_line":"    Type\u003doneshot"},{"line_number":44,"context_line":"    ExecStart\u003d/usr/bin/sh -c \\\u0027/usr/sbin/losetup -j /var/lib/cinder/cinder-volumes | /usr/bin/grep /var/lib/cinder/cinder-volumes || /usr/sbin/losetup -f /var/lib/cinder/cinder-volumes\\\u0027"},{"line_number":45,"context_line":"    ExecStop\u003d/usr/bin/sh -c \\\u0027/usr/sbin/losetup -j /var/lib/cinder/cinder-volumes | /usr/bin/cut -d : -f 1 | /usr/bin/xargs /usr/sbin/losetup -d\\\u0027"},{"line_number":46,"context_line":"    TimeoutSec\u003d60"},{"line_number":47,"context_line":"    RemainAfterExit\u003dyes"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f201791_f1314dee","line":44,"range":{"start_line":44,"start_character":68,"end_line":44,"end_character":82},"updated":"2017-06-21 09:59:21.000000000","message":"ditto","commit_id":"51658b59b0943a6b73d2ff6b9b7188f73e9f3534"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2ad14ac2ac1c73ae123937afc9585fddc4df8404","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    [Service]"},{"line_number":43,"context_line":"    Type\u003doneshot"},{"line_number":44,"context_line":"    ExecStart\u003d/usr/bin/sh -c \\\u0027/usr/sbin/losetup -j /var/lib/cinder/cinder-volumes | /usr/bin/grep /var/lib/cinder/cinder-volumes || /usr/sbin/losetup -f /var/lib/cinder/cinder-volumes\\\u0027"},{"line_number":45,"context_line":"    ExecStop\u003d/usr/bin/sh -c \\\u0027/usr/sbin/losetup -j /var/lib/cinder/cinder-volumes | /usr/bin/cut -d : -f 1 | /usr/bin/xargs /usr/sbin/losetup -d\\\u0027"},{"line_number":46,"context_line":"    TimeoutSec\u003d60"},{"line_number":47,"context_line":"    RemainAfterExit\u003dyes"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f201791_91569906","line":45,"range":{"start_line":45,"start_character":67,"end_line":45,"end_character":81},"updated":"2017-06-21 09:59:21.000000000","message":"ditto","commit_id":"51658b59b0943a6b73d2ff6b9b7188f73e9f3534"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2ad14ac2ac1c73ae123937afc9585fddc4df8404","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    cinder::backend::iscsi { \u0027lvm\u0027:"},{"line_number":87,"context_line":"      iscsi_ip_address \u003d\u003e hiera(\u0027CONFIG_STORAGE_HOST_URL\u0027),"},{"line_number":88,"context_line":"      require          \u003d\u003e Package[\u0027lvm2\u0027],"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    cinder::type { \u0027iscsi\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5f201791_f1bb8d0b","line":88,"updated":"2017-06-21 09:59:21.000000000","message":"I think you need to add volume_group \u003d\u003e hiera(\u0027CONFIG_CINDER_VOLUME_NAME\u0027)","commit_id":"51658b59b0943a6b73d2ff6b9b7188f73e9f3534"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"d35e6414e9b80aab4a52dbeb7c7edf5fe3741e20","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            path    \u003d\u003e \u0027/usr/lib/systemd/system/openstack-losetup.service\u0027,"},{"line_number":35,"context_line":"            before  \u003d\u003e Service[\u0027openstack-losetup\u0027],"},{"line_number":36,"context_line":"            notify  \u003d\u003e Exec[\u0027reload systemd files for cinder-volume\u0027],"},{"line_number":37,"context_line":"            content \u003d\u003e \u0027[Unit]"},{"line_number":38,"context_line":"    Description\u003dSetup cinder-volume loop device"},{"line_number":39,"context_line":"    DefaultDependencies\u003dfalse"},{"line_number":40,"context_line":"    Before\u003dopenstack-cinder-volume.service"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5f201791_376f9093","line":37,"range":{"start_line":37,"start_character":23,"end_line":37,"end_character":24},"updated":"2017-06-22 11:06:04.000000000","message":"you\u0027ll need to use double quotes here","commit_id":"1ff3d13f042bbf55b44f9f2f3ffad766d088fc2e"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"d35e6414e9b80aab4a52dbeb7c7edf5fe3741e20","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    RemainAfterExit\u003dyes"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    [Install]"},{"line_number":51,"context_line":"    RequiredBy\u003dopenstack-cinder-volume.service\u0027,"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"          exec { \u0027reload systemd files for cinder-volume\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5f201791_b70840d9","line":51,"range":{"start_line":51,"start_character":46,"end_line":51,"end_character":47},"updated":"2017-06-22 11:06:04.000000000","message":"and here","commit_id":"1ff3d13f042bbf55b44f9f2f3ffad766d088fc2e"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"bea8e3f1494edc789a10102fd28726205969fb89","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cinder::backend::iscsi { \u0027lvm\u0027:"},{"line_number":88,"context_line":"      iscsi_ip_address \u003d\u003e hiera(\u0027CONFIG_STORAGE_HOST_URL\u0027),"},{"line_number":89,"context_line":"      require          \u003d\u003e Package[\u0027lvm2\u0027],"},{"line_number":90,"context_line":"      volume_group     \u003d\u003e hiera(\u0027CONFIG_CINDER_VOLUME_NAME\u0027),"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    cinder::type { \u0027iscsi\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"5f201791_f216c6f1","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":60},"updated":"2017-06-22 11:49:52.000000000","message":"nitpick, you could use $cinder_volume_name variable here","commit_id":"c7d9f21d1657c4cefd66c4891c0f9eff0a43b6c0"}]}