)]}'
{".zuul.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"f5f44b2b3edf51818656753b719d1f6e4836ac33","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    post-run: playbooks/upload-logs"},{"line_number":9,"context_line":"    nodeset: centos-7"},{"line_number":10,"context_line":"    irrelevant-files:"},{"line_number":11,"context_line":"      - ^docs/.*$"},{"line_number":12,"context_line":"      - ^releasenotes/.*$"},{"line_number":13,"context_line":"    required-projects:"},{"line_number":14,"context_line":"      - openstack/puppet-aodh"},{"line_number":15,"context_line":"      - openstack/puppet-ceilometer"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7f515b1d_cae4980f","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":25},"updated":"2017-09-29 16:00:04.000000000","message":"We\u0027ll need to test if there are jobs triggering for docs and release notes, otherwise we might not have gate jobs at all for those.","commit_id":"c4e627911241911788284cb5ba45ebcef96323ff"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"f069e23947a85902265f710ad4f39b0a7a8edf4b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      - openstack/puppet-tempest"},{"line_number":36,"context_line":"      - openstack/puppet-trove"},{"line_number":37,"context_line":"      - openstack/puppet-vswitch"},{"line_number":38,"context_line":"      "},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- job:"},{"line_number":41,"context_line":"    name: packstack-integration-scenario001-tempest-centos-7"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7f515b1d_6e0c5194","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":6},"updated":"2017-10-04 07:51:12.000000000","message":"white space","commit_id":"1590548d3ba52a16378cb3e38d6b6e6609b6140d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"289343594ccc36b51a51402750463cf5a7b2b878","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    name: openstack/packstack"},{"line_number":59,"context_line":"    check:"},{"line_number":60,"context_line":"      jobs:"},{"line_number":61,"context_line":"        - packstack-integration-scenario001-tempest-centos-7"},{"line_number":62,"context_line":"        - packstack-integration-scenario002-tempest-centos-7"},{"line_number":63,"context_line":"        - packstack-integration-scenario003-tempest-centos-7"},{"line_number":64,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f4e5783_711a5fcc","line":61,"range":{"start_line":61,"start_character":52,"end_line":61,"end_character":60},"updated":"2017-10-16 10:42:36.000000000","message":"As mentioned in migration guide, it\u0027s good not to use distro names if not testing for other distros. Is there some plan for using for other distros?","commit_id":"b050a260bed537a221abba92533c5809789cb5bd"}],"playbooks/packstack-integration-tempest-centos7.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"5fe1623df110b4c51c6281e18c2d61d79d96ecdf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"              # Uninstall python-requests from pip, since we install it in"},{"line_number":47,"context_line":"              # system-config/install_puppet.sh"},{"line_number":48,"context_line":"              sudo pip uninstall requests -y || true"},{"line_number":49,"context_line":"          elif [ -f /usr/bin/apt-get ]; then"},{"line_number":50,"context_line":"              sudo apt-get update"},{"line_number":51,"context_line":"              sudo apt-get install -y libxml2-dev libxslt-dev ruby-dev zlib1g-dev"},{"line_number":52,"context_line":"          fi"},{"line_number":53,"context_line":"        executable: /bin/bash"},{"line_number":54,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"},{"line_number":55,"context_line":"      environment: \u0027{{ zuul }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f515b1d_5ebbd2c3","line":52,"range":{"start_line":49,"start_character":0,"end_line":52,"end_character":12},"updated":"2017-09-29 12:56:30.000000000","message":"Er, this is probably copy pasta, we don\u0027t run deb distros in this gate :)","commit_id":"ab9e691890bf0a2df4313416651592b7dcba7e32"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"5fe1623df110b4c51c6281e18c2d61d79d96ecdf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  name: packstack-integration-tempest-centos7"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":"    - name: Ensure legacy workspace directory"},{"line_number":5,"context_line":"      file:"},{"line_number":6,"context_line":"        path: \u0027{{ ansible_user_dir }}/workspace\u0027"},{"line_number":7,"context_line":"        state: directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - shell:"},{"line_number":10,"context_line":"        cmd: |"},{"line_number":11,"context_line":"          set -e"},{"line_number":12,"context_line":"          set -x"},{"line_number":13,"context_line":"          CLONEMAP\u003d`mktemp`"},{"line_number":14,"context_line":"          function cleanup {"},{"line_number":15,"context_line":"              # In cases where zuul-cloner is aborted during a git"},{"line_number":16,"context_line":"              # clone operation, git will remove the git work tree in"},{"line_number":17,"context_line":"              # its cleanup. The work tree in these jobs is the"},{"line_number":18,"context_line":"              # workspace directory, which means that subsequent"},{"line_number":19,"context_line":"              # jenkins post-build actions can not run because the"},{"line_number":20,"context_line":"              # workspace has been removed."},{"line_number":21,"context_line":"              # To reduce the likelihood of this having an impact,"},{"line_number":22,"context_line":"              # recreate the workspace directory if needed"},{"line_number":23,"context_line":"              mkdir -p {{ ansible_user_dir }}/workspace"},{"line_number":24,"context_line":"              rm -f $CLONEMAP"},{"line_number":25,"context_line":"          }"},{"line_number":26,"context_line":"          trap cleanup EXIT"},{"line_number":27,"context_line":"          cat \u003e $CLONEMAP \u003c\u003c EOF"},{"line_number":28,"context_line":"          clonemap:"},{"line_number":29,"context_line":"            - name: {{ zuul.project.name }}"},{"line_number":30,"context_line":"              dest: ."},{"line_number":31,"context_line":"          EOF"},{"line_number":32,"context_line":"          /usr/zuul-env/bin/zuul-cloner -m $CLONEMAP --cache-dir /opt/git \\"},{"line_number":33,"context_line":"              git://git.openstack.org {{ zuul.project.name }}"},{"line_number":34,"context_line":"        executable: /bin/bash"},{"line_number":35,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"},{"line_number":36,"context_line":"      environment: \u0027{{ zuul }}\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    - shell:"},{"line_number":39,"context_line":"        cmd: |"},{"line_number":40,"context_line":"          set -e"},{"line_number":41,"context_line":"          set -x"},{"line_number":42,"context_line":"          if [ -f /usr/bin/yum ]; then"},{"line_number":43,"context_line":"              sudo yum -y remove rdo-release \"centos-release-openstack-*\" \"centos-release-ceph-*\""},{"line_number":44,"context_line":"              sudo yum -y install libxml2-devel libxslt-devel ruby-devel zlib-devel"},{"line_number":45,"context_line":"              sudo yum -y groupinstall \"Development Tools\""},{"line_number":46,"context_line":"              # Uninstall python-requests from pip, since we install it in"},{"line_number":47,"context_line":"              # system-config/install_puppet.sh"},{"line_number":48,"context_line":"              sudo pip uninstall requests -y || true"},{"line_number":49,"context_line":"          elif [ -f /usr/bin/apt-get ]; then"},{"line_number":50,"context_line":"              sudo apt-get update"},{"line_number":51,"context_line":"              sudo apt-get install -y libxml2-dev libxslt-dev ruby-dev zlib1g-dev"},{"line_number":52,"context_line":"          fi"},{"line_number":53,"context_line":"        executable: /bin/bash"},{"line_number":54,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"},{"line_number":55,"context_line":"      environment: \u0027{{ zuul }}\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    - shell:"},{"line_number":58,"context_line":"        cmd: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f515b1d_bec9a659","line":55,"range":{"start_line":4,"start_character":0,"end_line":55,"end_character":31},"updated":"2017-09-29 12:56:30.000000000","message":"This entire block is a good candidate for a \u0027pre\u0027 playbook. \u0027pre\u0027 playbook failures will cause the job to restart/retry 3 times, for example if a package installation fails.\nI added the same comment here: https://review.openstack.org/#/c/508296/","commit_id":"ab9e691890bf0a2df4313416651592b7dcba7e32"}],"playbooks/packstack-pre.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8b96b677154823e6928288af4f16d36b6f539e0b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"          clonemap:"},{"line_number":29,"context_line":"            - name: {{ zuul.project.name }}"},{"line_number":30,"context_line":"              dest: ."},{"line_number":31,"context_line":"          EOF"},{"line_number":32,"context_line":"          /usr/zuul-env/bin/zuul-cloner -m $CLONEMAP --cache-dir /opt/git \\"},{"line_number":33,"context_line":"              git://git.openstack.org {{ zuul.project.name }}"},{"line_number":34,"context_line":"        executable: /bin/bash"},{"line_number":35,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"},{"line_number":36,"context_line":"      environment: \u0027{{ zuul }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7f515b1d_acd84052","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":61},"updated":"2017-10-02 11:26:55.000000000","message":"do not use zuul-cloner for new jobs, rework your change to not depend on them. Just add your repo to the required-repositories list and it will be ready for you.","commit_id":"b50387128b24d54ccd1afc352bf1a7e9777be011"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6d6875c39577b14f8d686b3f5f180c4516013029","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        cmd: |"},{"line_number":15,"context_line":"          set -e"},{"line_number":16,"context_line":"          set -x"},{"line_number":17,"context_line":"          sudo yum -y remove rdo-release \"centos-release-openstack-*\" \"centos-release-ceph-*\""},{"line_number":18,"context_line":"          sudo yum -y install libxml2-devel libxslt-devel ruby-devel zlib-devel"},{"line_number":19,"context_line":"          sudo yum -y groupinstall \"Development Tools\""},{"line_number":20,"context_line":"          # Uninstall python-requests from pip, since we install it in"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"7f515b1d_a0d6cd26","line":17,"updated":"2017-10-04 13:37:36.000000000","message":"instead of all sudo, why not use became:?","commit_id":"69468831530e2b80f37005344e1a785a7a97775f"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"c520b5d4370c7aa3f01741fa614f84a4aaa4f199","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        cmd: |"},{"line_number":15,"context_line":"          set -e"},{"line_number":16,"context_line":"          set -x"},{"line_number":17,"context_line":"          sudo yum -y remove rdo-release \"centos-release-openstack-*\" \"centos-release-ceph-*\""},{"line_number":18,"context_line":"          sudo yum -y install libxml2-devel libxslt-devel ruby-devel zlib-devel"},{"line_number":19,"context_line":"          sudo yum -y groupinstall \"Development Tools\""},{"line_number":20,"context_line":"          # Uninstall python-requests from pip, since we install it in"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"7f515b1d_ea794393","line":17,"in_reply_to":"7f515b1d_a0d6cd26","updated":"2017-10-04 13:51:38.000000000","message":"It was a side effect of copying/pasting from the previous job. I\u0027ll fix that","commit_id":"69468831530e2b80f37005344e1a785a7a97775f"}],"playbooks/upload-logs.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8b96b677154823e6928288af4f16d36b6f539e0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7f515b1d_8cdb444d","updated":"2017-10-02 11:26:55.000000000","message":"you should be able to use the default one, no need to copy this","commit_id":"b50387128b24d54ccd1afc352bf1a7e9777be011"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"a983f2b5c913af72867fcaceab72367077d941e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7f515b1d_cca37cb1","in_reply_to":"7f515b1d_8cdb444d","updated":"2017-10-02 11:35:22.000000000","message":"How can we use the default one while changing the src directory?","commit_id":"b50387128b24d54ccd1afc352bf1a7e9777be011"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"184bf6ebc9e8bf7dbed45f9929c15bf70fd86938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7f515b1d_82db0b4d","in_reply_to":"7f515b1d_8cdb444d","updated":"2017-10-02 13:56:03.000000000","message":"I also expected there would be a default location for the logs but it turns out this is actually incorrect.\n\nAll logs that are meant to be uploaded to the logserver must first be explicitely uploaded to the executor through a task like this one.\n\nSee somewhere not too long after [1] (eavesdrop hasn\u0027t caught up yet) between mordred and I.\n\n[1]: http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2017-10-02.log.html#t2017-10-02T13:44:35","commit_id":"b50387128b24d54ccd1afc352bf1a7e9777be011"}]}