)]}'
{"packstack/plugins/puppet_950.py":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"933bb92ccd44e7b27c79e8e8bc5e705e494a859c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"\tif platform.linux_distribution()[0] \u003d\u003d \"Fedora\":"},{"line_number":77,"context_line":"\t    packagelist \u003d [\"puppet\", \"openssh-clients\", \"tar\", \"nmap-ncat\"]"},{"line_number":78,"context_line":"\telse:"},{"line_number":79,"context_line":"\t    packagelist \u003d [\"puppet\", \"openssh-clients\", \"tar\", \"nc\"]\t"},{"line_number":80,"context_line":"        for package in packagelist:"},{"line_number":81,"context_line":"            server.append(\"rpm -q %s || yum install -y %s\" % (package, package))"},{"line_number":82,"context_line":"        server.execute()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FfQ4%3D","line":79,"updated":"2013-10-15 14:35:59.000000000","message":"\"yum install -y nc\" will install nmap-ncat package on Fedora, so this won\u0027t fix anything.","commit_id":"193713445e1f34264924a617a0ed913a99a5658b"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"97f3c0fe49fb464ac92efaf974e9c8829d5ca740","unresolved":false,"context_lines":[{"line_number":76,"context_line":"\tif platform.linux_distribution()[0] \u003d\u003d \"Fedora\":"},{"line_number":77,"context_line":"\t    packagelist \u003d [\"puppet\", \"openssh-clients\", \"tar\", \"nmap-ncat\"]"},{"line_number":78,"context_line":"\telse:"},{"line_number":79,"context_line":"\t    packagelist \u003d [\"puppet\", \"openssh-clients\", \"tar\", \"nc\"]\t"},{"line_number":80,"context_line":"        for package in packagelist:"},{"line_number":81,"context_line":"            server.append(\"rpm -q %s || yum install -y %s\" % (package, package))"},{"line_number":82,"context_line":"        server.execute()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fe5A%3D","line":79,"in_reply_to":"AAAATH%2F%2FfQ4%3D","updated":"2013-10-15 16:04:20.000000000","message":"Yes that bit should probably be dropped:\n\n  $ repoquery -q --repoid\u003drawhide --whatprovides nc\n  nmap-ncat-2:6.40-2.fc20.x86_64","commit_id":"193713445e1f34264924a617a0ed913a99a5658b"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"97f3c0fe49fb464ac92efaf974e9c8829d5ca740","unresolved":false,"context_lines":[{"line_number":78,"context_line":"\telse:"},{"line_number":79,"context_line":"\t    packagelist \u003d [\"puppet\", \"openssh-clients\", \"tar\", \"nc\"]\t"},{"line_number":80,"context_line":"        for package in packagelist:"},{"line_number":81,"context_line":"            server.append(\"rpm -q %s || yum install -y %s\" % (package, package))"},{"line_number":82,"context_line":"        server.execute()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fe4Y%3D","line":81,"updated":"2013-10-15 16:04:20.000000000","message":"However we need to do change this to:\n\n  rpm -q --whatprovides %s || ...","commit_id":"193713445e1f34264924a617a0ed913a99a5658b"}]}
