)]}'
{".gitmodules":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"8b6ef26fca1198a43fe89e957b0adfa4311fd3a1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\turl \u003d https://github.com/puppetlabs/puppetlabs-haproxy.git"},{"line_number":76,"context_line":"[submodule \"packstack/puppet/modules/ceilometer\"]"},{"line_number":77,"context_line":"\tpath \u003d packstack/puppet/modules/ceilometer"},{"line_number":78,"context_line":"\turl \u003d https://github.com/stackforge/puppet-ceilometer.git"},{"line_number":79,"context_line":"[submodule \"packstack/puppet/modules/mongodb\"]"},{"line_number":80,"context_line":"\tpath \u003d packstack/puppet/modules/mongodb"},{"line_number":81,"context_line":"\turl \u003d https://github.com/puppetlabs/puppetlabs-mongodb.git"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATH%2F%2FQ9I%3D","line":78,"updated":"2013-10-18 19:23:19.000000000","message":"could you add your changes to https://github.com/packstack/puppet-ceilometer.git ?\ni think you have rights to write to it","commit_id":"e4e8c03abb23c50115b976d712deb94840e5aec0"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"15ed63362fc3bf9e399ff321189b0d911c89d641","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\turl \u003d https://github.com/puppetlabs/puppetlabs-haproxy.git"},{"line_number":76,"context_line":"[submodule \"packstack/puppet/modules/ceilometer\"]"},{"line_number":77,"context_line":"\tpath \u003d packstack/puppet/modules/ceilometer"},{"line_number":78,"context_line":"\turl \u003d https://github.com/stackforge/puppet-ceilometer.git"},{"line_number":79,"context_line":"[submodule \"packstack/puppet/modules/mongodb\"]"},{"line_number":80,"context_line":"\tpath \u003d packstack/puppet/modules/mongodb"},{"line_number":81,"context_line":"\turl \u003d https://github.com/puppetlabs/puppetlabs-mongodb.git"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATH%2F%2FNeU%3D","line":78,"in_reply_to":"AAAATH%2F%2FNiM%3D","updated":"2013-10-21 12:16:50.000000000","message":"+1 for stackforge, packstack fork is for cases where upstream doesn\u0027t like our patches","commit_id":"e4e8c03abb23c50115b976d712deb94840e5aec0"},{"author":{"_account_id":8083,"name":"Francesco Vollero","email":"fvollero@redhat.com","username":"fvollero"},"change_message_id":"2c8e72916102aa66c09daad26c42d5b8adb26e76","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\turl \u003d https://github.com/puppetlabs/puppetlabs-haproxy.git"},{"line_number":76,"context_line":"[submodule \"packstack/puppet/modules/ceilometer\"]"},{"line_number":77,"context_line":"\tpath \u003d packstack/puppet/modules/ceilometer"},{"line_number":78,"context_line":"\turl \u003d https://github.com/stackforge/puppet-ceilometer.git"},{"line_number":79,"context_line":"[submodule \"packstack/puppet/modules/mongodb\"]"},{"line_number":80,"context_line":"\tpath \u003d packstack/puppet/modules/mongodb"},{"line_number":81,"context_line":"\turl \u003d https://github.com/puppetlabs/puppetlabs-mongodb.git"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATH%2F%2FNiM%3D","line":78,"in_reply_to":"AAAATH%2F%2FQ9I%3D","updated":"2013-10-21 11:31:00.000000000","message":"Ivan, yes, I have the write permission on this, but we want to be in sync with the upstream and there\u0027s nothing that lock us to not be there so stackforge is the right one :)","commit_id":"e4e8c03abb23c50115b976d712deb94840e5aec0"}],"packstack/plugins/ceilometer_800.py":[{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"846f55db1f8a6461a95f8ef0ceeba4ff3b6ab287","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    manifestfile \u003d \"%s_ceilometer.pp\" % config[\u0027CONFIG_CEILOMETER_HOST\u0027]"},{"line_number":96,"context_line":"    manifestdata \u003d getManifestTemplate(\"ceilometer.pp\")"},{"line_number":97,"context_line":"    hosts \u003d config[\u0027CONFIG_CEILOMETER_HOST\u0027]"},{"line_number":98,"context_line":"    config[\u0027FIREWALL_ALLOWED\u0027] \u003d \u0027,\u0027.join([\"\u0027%s\u0027\" % i.strip() for i in hosts if i.strip()])"},{"line_number":99,"context_line":"    config[\u0027FIREWALL_SERVICE_NAME\u0027] \u003d \u0027ceilometer-api\u0027"},{"line_number":100,"context_line":"    config[\u0027FIREWALL_PORTS\u0027] \u003d \u00278777\u0027"},{"line_number":101,"context_line":"    manifestdata +\u003d getManifestTemplate(\"firewall.pp\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FHIw%3D","line":98,"updated":"2013-10-23 02:25:29.000000000","message":"you can\u0027t do that here because hosts does not contain a list. you\u0027ll get something like this inside the template once is rendered: \n\n$hosts \u003d [ \u00271\u0027,\u00279\u0027,\u00272\u0027,\u0027.\u0027,\u00271\u0027,\u00276\u0027,\u00278\u0027,\u0027.\u0027,\u00271\u0027,\u00270\u0027,\u00270\u0027,\u0027.\u0027,\u00272\u0027,\u00272\u0027,\u00275\u0027 ]","commit_id":"2ca0ac0f029d13e344fb2eb15328b06e3ba7437f"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"b4012e79353bfe48f3a132117dcda88ee0c67d11","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    hosts \u003d config[\u0027CONFIG_CEILOMETER_HOST\u0027]"},{"line_number":98,"context_line":"    config[\u0027FIREWALL_ALLOWED\u0027] \u003d hosts"},{"line_number":99,"context_line":"    config[\u0027FIREWALL_SERVICE_NAME\u0027] \u003d \u0027ceilometer-api\u0027"},{"line_number":100,"context_line":"    config[\u0027FIREWALL_PORTS\u0027] \u003d \u00278777\u0027"},{"line_number":101,"context_line":"    manifestdata +\u003d getManifestTemplate(\"firewall.pp\")"},{"line_number":102,"context_line":"    appendManifestFile(manifestfile, manifestdata)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F7S0%3D","line":100,"updated":"2013-10-25 05:23:58.000000000","message":"youre missing quotes the this should be:\nconfig[\u0027FIREWALL_PORTS\u0027] \u003d \"\u00278777\u0027\"\n\nthat gives you this in the generated template:\n\n$hosts \u003d [ \u0027192.168.100.203\u0027]\n\ninstead of this:\n\n$hosts \u003d [ 192.168.100.203 ]\n\nwhich will give error at leas with puppet 3.3.1","commit_id":"eaa8698f82e9fed546a984ce0292449c1f7f9f1c"}],"packstack/puppet/templates/ceilometer.pp":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"15ed63362fc3bf9e399ff321189b0d911c89d641","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class { \u0027ceilometer::collector\u0027:"},{"line_number":32,"context_line":"    require \u003d\u003e Class[\u0027mongodb\u0027],"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class { \u0027ceilometer::agent::central\u0027:"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"AAAATH%2F%2FNbo%3D","line":34,"updated":"2013-10-21 12:16:50.000000000","message":"So, central agent doesn\u0027t need auth anymore?","commit_id":"e4e8c03abb23c50115b976d712deb94840e5aec0"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"15ed63362fc3bf9e399ff321189b0d911c89d641","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    proto    \u003d\u003e \u0027tcp\u0027,"},{"line_number":54,"context_line":"    dport    \u003d\u003e [\u00278777\u0027],"},{"line_number":55,"context_line":"    action   \u003d\u003e \u0027accept\u0027,"},{"line_number":56,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"AAAATH%2F%2FNbs%3D","line":56,"updated":"2013-10-21 12:16:50.000000000","message":"It would be better to use firewall.pp template for this. Good example is following patch: https://review.openstack.org/#/c/47330/3","commit_id":"e4e8c03abb23c50115b976d712deb94840e5aec0"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"4f14b2e47a4400e50b97d5b3f921273097bb3dd8","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class { \u0027ceilometer::agent::central\u0027:"},{"line_number":36,"context_line":"    auth_url      \u003d\u003e \u0027http://%(CONFIG_KEYSTONE_HOST)s:35357/v2.0\u0027,"},{"line_number":37,"context_line":"    auth_password \u003d\u003e \u0027%(CONFIG_CEILOMETER_KS_PW)s\u0027,"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class { \u0027ceilometer::api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"AAAATn%2F%2Fvng%3D","side":"PARENT","line":37,"updated":"2013-10-29 16:13:44.000000000","message":"So double-checked with eglynn and as I wrote before, we need credentials for central agent. Usage of \u0027ceilometer::agent::auth\u0027 is needed in this template.","commit_id":"3ed65320b9653fd3020c6946be7a0db2278bf1da"},{"author":{"_account_id":8083,"name":"Francesco Vollero","email":"fvollero@redhat.com","username":"fvollero"},"change_message_id":"226c44f898d101a1858aa20730620e6f7577a02f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class { \u0027ceilometer::agent::central\u0027:"},{"line_number":36,"context_line":"    auth_url      \u003d\u003e \u0027http://%(CONFIG_KEYSTONE_HOST)s:35357/v2.0\u0027,"},{"line_number":37,"context_line":"    auth_password \u003d\u003e \u0027%(CONFIG_CEILOMETER_KS_PW)s\u0027,"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class { \u0027ceilometer::api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"AAAATn%2F%2FvgA%3D","side":"PARENT","line":37,"in_reply_to":"AAAATn%2F%2Fvng%3D","updated":"2013-10-29 16:39:10.000000000","message":"So, not just in nova_ceilometer is needed? ack. fixing it now.","commit_id":"3ed65320b9653fd3020c6946be7a0db2278bf1da"}]}
