)]}'
{"packstack/plugins/nagios_910.py":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"5893f752ab80d721357a031102a13ea9f1c7ee71","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    controller.CONF[\u0027CONFIG_NAGIOS_MANIFEST_CONFIG\u0027] \u003d manifest_entries"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    manifestfile \u003d \"%s_nagios.pp\" % controller.CONF[\u0027CONFIG_NAGIOS_HOST\u0027]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    manifestdata \u003d getManifestTemplate(\"nagios_server.pp\")"},{"line_number":169,"context_line":"    appendManifestFile(manifestfile, manifestdata)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BFUU%3D","line":167,"updated":"2014-01-31 17:32:59.000000000","message":"Just a nitpick, but is this really required? :)","commit_id":"e52c6203d6522bd3cd399a1d644ef2914d6b5d03"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"46f05ea3c850064a7333c9fc322b771011c6c775","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    controller.CONF[\u0027CONFIG_NAGIOS_MANIFEST_CONFIG\u0027] \u003d manifest_entries"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    manifestfile \u003d \"%s_nagios.pp\" % controller.CONF[\u0027CONFIG_NAGIOS_HOST\u0027]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    manifestdata \u003d getManifestTemplate(\"nagios_server.pp\")"},{"line_number":169,"context_line":"    appendManifestFile(manifestfile, manifestdata)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F99KA%3D","line":167,"in_reply_to":"AAAAUH%2F%2BFUU%3D","updated":"2014-01-31 17:48:26.000000000","message":"whoops! i missed that one","commit_id":"e52c6203d6522bd3cd399a1d644ef2914d6b5d03"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"30fe9d91750317638da7048f87107438d198b649","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    controller.CONF[\u0027CONFIG_NAGIOS_MANIFEST_CONFIG\u0027] \u003d manifest_entries"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    manifestfile \u003d \"%s_nagios.pp\" % controller.CONF[\u0027CONFIG_NAGIOS_HOST\u0027]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    manifestdata \u003d getManifestTemplate(\"nagios_server.pp\")"},{"line_number":169,"context_line":"    appendManifestFile(manifestfile, manifestdata)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F961k%3D","line":167,"in_reply_to":"AAAAUH%2F987U%3D","updated":"2014-02-01 05:00:20.000000000","message":"ohh the blank line hehehe taking it out","commit_id":"e52c6203d6522bd3cd399a1d644ef2914d6b5d03"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"350fd78f7abb3f52b955762b8c17cdd8e1db7566","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    controller.CONF[\u0027CONFIG_NAGIOS_MANIFEST_CONFIG\u0027] \u003d manifest_entries"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    manifestfile \u003d \"%s_nagios.pp\" % controller.CONF[\u0027CONFIG_NAGIOS_HOST\u0027]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    manifestdata \u003d getManifestTemplate(\"nagios_server.pp\")"},{"line_number":169,"context_line":"    appendManifestFile(manifestfile, manifestdata)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F987U%3D","line":167,"in_reply_to":"AAAAUH%2F99Gg%3D","updated":"2014-01-31 18:24:45.000000000","message":"Are you really sure that the blank line is required? :D","commit_id":"e52c6203d6522bd3cd399a1d644ef2914d6b5d03"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"ffe1571be75c4c432f68b226c91f150cc800bf7b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    controller.CONF[\u0027CONFIG_NAGIOS_MANIFEST_CONFIG\u0027] \u003d manifest_entries"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    manifestfile \u003d \"%s_nagios.pp\" % controller.CONF[\u0027CONFIG_NAGIOS_HOST\u0027]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    manifestdata \u003d getManifestTemplate(\"nagios_server.pp\")"},{"line_number":169,"context_line":"    appendManifestFile(manifestfile, manifestdata)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F99Gg%3D","line":167,"in_reply_to":"AAAAUH%2F99KA%3D","updated":"2014-01-31 17:56:52.000000000","message":"giving it another look, i thik it is required. it\u0027s the generated manifest filename right?","commit_id":"e52c6203d6522bd3cd399a1d644ef2914d6b5d03"}],"packstack/puppet/templates/horizon.pp":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3b7061c6da7782ec04dca40062a9a67bb4c7ac77","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class {\u0027memcached\u0027:}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"firewall { \u0027001 horizon %(CONFIG_HORIZON_PORT)s  incoming\u0027:"},{"line_number":27,"context_line":"    proto    \u003d\u003e \u0027tcp\u0027,"},{"line_number":28,"context_line":"    dport    \u003d\u003e [%(CONFIG_HORIZON_PORT)s],"},{"line_number":29,"context_line":"    action   \u003d\u003e \u0027accept\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"AAAAUH%2F93GQ%3D","line":26,"updated":"2014-02-03 07:39:08.000000000","message":"This is causing syntax errors.","commit_id":"4b7b9e44fedd27d428a5473d38575b4f6d0efcce"}],"packstack/puppet/templates/https.pp":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"bb2ecea297d9b0c5eb196b3d2c09fae062815850","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    match \u003d\u003e \u0027SSLEngine .+\u0027,"},{"line_number":48,"context_line":"    line \u003d\u003e \u0027SSLEngine on\u0027,"},{"line_number":49,"context_line":"    require \u003d\u003e  Class[\u0027apache::mod::ssl\u0027]"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# set the name of the ssl cert and key file"},{"line_number":53,"context_line":"file_line{\u0027sslcert\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"AAAAUH%2F%2BR2s%3D","side":"PARENT","line":50,"updated":"2014-01-28 13:12:11.000000000","message":"So why are you removing this? This should enable port 443?, shouldn\u0027t it?","commit_id":"17aa9f6c9d1444f129237c6501d0a04f973aede4"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"cefef058d0162c1ef49a22541eb1f6175a495083","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    match \u003d\u003e \u0027SSLEngine .+\u0027,"},{"line_number":48,"context_line":"    line \u003d\u003e \u0027SSLEngine on\u0027,"},{"line_number":49,"context_line":"    require \u003d\u003e  Class[\u0027apache::mod::ssl\u0027]"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# set the name of the ssl cert and key file"},{"line_number":53,"context_line":"file_line{\u0027sslcert\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"AAAAUH%2F%2BQX4%3D","side":"PARENT","line":50,"in_reply_to":"AAAAUH%2F%2BR2s%3D","updated":"2014-01-28 16:42:13.000000000","message":"you\u0027re right, i missed that as part of an experiment","commit_id":"17aa9f6c9d1444f129237c6501d0a04f973aede4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"5893f752ab80d721357a031102a13ea9f1c7ee71","unresolved":false,"context_lines":[{"line_number":45,"context_line":"} -\u003e file_line{\u0027ssl_engine\u0027:"},{"line_number":46,"context_line":"    path \u003d\u003e \u0027/etc/httpd/conf.d/ssl.conf\u0027,"},{"line_number":47,"context_line":"    match \u003d\u003e \u0027SSLEngine .+\u0027,"},{"line_number":48,"context_line":"    line \u003d\u003e \u0027SSLEngine on\u0027,"},{"line_number":49,"context_line":"    require \u003d\u003e  Class[\u0027apache::mod::ssl\u0027]"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"AAAAUH%2F%2BFUE%3D","side":"PARENT","line":48,"updated":"2014-01-31 17:32:59.000000000","message":"So SSLEngine is on by default or this is not required? I don\u0027t see this parameter neither in /etc/httpd/conf.d/ssl.conf nor /etc/httpd/conf/httpd.conf.","commit_id":"17aa9f6c9d1444f129237c6501d0a04f973aede4"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"46f05ea3c850064a7333c9fc322b771011c6c775","unresolved":false,"context_lines":[{"line_number":45,"context_line":"} -\u003e file_line{\u0027ssl_engine\u0027:"},{"line_number":46,"context_line":"    path \u003d\u003e \u0027/etc/httpd/conf.d/ssl.conf\u0027,"},{"line_number":47,"context_line":"    match \u003d\u003e \u0027SSLEngine .+\u0027,"},{"line_number":48,"context_line":"    line \u003d\u003e \u0027SSLEngine on\u0027,"},{"line_number":49,"context_line":"    require \u003d\u003e  Class[\u0027apache::mod::ssl\u0027]"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"AAAAUH%2F99Kc%3D","side":"PARENT","line":48,"in_reply_to":"AAAAUH%2F%2BFUE%3D","updated":"2014-01-31 17:48:26.000000000","message":"i\u0027ll double check, i was getting an error about re initializing the ssl engine  and it went away when i remoed that statement","commit_id":"17aa9f6c9d1444f129237c6501d0a04f973aede4"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"30fe9d91750317638da7048f87107438d198b649","unresolved":false,"context_lines":[{"line_number":45,"context_line":"} -\u003e file_line{\u0027ssl_engine\u0027:"},{"line_number":46,"context_line":"    path \u003d\u003e \u0027/etc/httpd/conf.d/ssl.conf\u0027,"},{"line_number":47,"context_line":"    match \u003d\u003e \u0027SSLEngine .+\u0027,"},{"line_number":48,"context_line":"    line \u003d\u003e \u0027SSLEngine on\u0027,"},{"line_number":49,"context_line":"    require \u003d\u003e  Class[\u0027apache::mod::ssl\u0027]"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"AAAAUH%2F961o%3D","side":"PARENT","line":48,"in_reply_to":"AAAAUH%2F99Kc%3D","updated":"2014-02-01 05:00:20.000000000","message":"it turns out that now apache needs the SSLEngine on inside a \u003cVirtualHost\u003e statement. adding the proper rules to the template","commit_id":"17aa9f6c9d1444f129237c6501d0a04f973aede4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3b7061c6da7782ec04dca40062a9a67bb4c7ac77","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        line \u003d\u003e \u0027\u003c/VirtualHost\u003e\u0027,"},{"line_number":69,"context_line":"        require \u003d\u003e File_line[\u0027sslkey\u0027],"},{"line_number":70,"context_line":"     },"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"create_resources(file_line, $ssl_lines)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"AAAAUH%2F93Gs%3D","line":71,"updated":"2014-02-03 07:39:08.000000000","message":"Wouldn\u0027t it be more stable to define the whole content of /etc/httpd/conf.d/ssl.conf? Something like:\n\n  $content \u003d \"Listen 443\n  \u003cVirtualHost *:443\u003e\n  ...\n  \u003c/VirtualHost\u003e\"\n\n  file { \u0027/etc/httpd/conf.d/ssl.conf\u0027:\n    ensure \u003d\u003e present,\n    mode \u003d\u003e \u00270644\u0027,\n    content \u003d\u003e $content,\n  }","commit_id":"4b7b9e44fedd27d428a5473d38575b4f6d0efcce"}],"packstack/puppet/templates/nagios_server.pp":[{"author":{"_account_id":8083,"name":"Francesco Vollero","email":"fvollero@redhat.com","username":"fvollero"},"change_message_id":"eb385d1002e6b39c3609c5def3e0dff4df68b7a2","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"$horizon_installed \u003d \u0027%(CONFIG_HORIZON_INSTALL)s\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"if $horizon_installed \u003d\u003d \u0027n\u0027 {"},{"line_number":61,"context_line":"    apache_install {\"horizon_installed\":}"},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"AAAAUH%2F%2BrTs%3D","line":60,"updated":"2014-01-23 09:58:27.000000000","message":"if CONFIG_HORIZON_INSTALL is set to \u0027n\u0027 we are executing the apache_install, but if it\u0027s set to \u0027y\u0027 we don\u0027t to anything, it will not fallback to the original problem ?","commit_id":"ff2ee8acd46c6014f369c8dd7e0ea283014566f9"},{"author":{"_account_id":8083,"name":"Francesco Vollero","email":"fvollero@redhat.com","username":"fvollero"},"change_message_id":"81c25343e66fe3d91d7f964c274372b3ac272852","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"$horizon_installed \u003d \u0027%(CONFIG_HORIZON_INSTALL)s\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"if $horizon_installed \u003d\u003d \u0027n\u0027 {"},{"line_number":61,"context_line":"    apache_install {\"horizon_installed\":}"},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"AAAAUH%2F%2BotQ%3D","line":60,"in_reply_to":"AAAAUH%2F%2BrKE%3D","updated":"2014-01-23 17:27:27.000000000","message":"Yeah. I agree on the decoupling and surely the $horizon_installed confused me a bit this morning.","commit_id":"ff2ee8acd46c6014f369c8dd7e0ea283014566f9"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"31d4e3685d9728c8f7b68e2c7decd899f2839dc6","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"$horizon_installed \u003d \u0027%(CONFIG_HORIZON_INSTALL)s\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"if $horizon_installed \u003d\u003d \u0027n\u0027 {"},{"line_number":61,"context_line":"    apache_install {\"horizon_installed\":}"},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"AAAAUH%2F%2BrKE%3D","line":60,"in_reply_to":"AAAAUH%2F%2BrTs%3D","updated":"2014-01-23 10:22:08.000000000","message":"It won\u0027t. This makes perfect sense, eg.: If Horizon is installed, then we don\u0027t have to install Apache second time. If Horizon is not installed then (well Nagios needs Apache) install it.\n\nBut what concerns me here is that this change will create regression in multihost installation. What if HORIZON_HOST and NAGIOS_HOST is not the same host?\n\nAlso after check of our horizon.pp template we should decouple Horizon and Nagios installation. Which means we should also remove Nagios\u0027 mod::php installation from horizon.pp, because we have it here already.","commit_id":"ff2ee8acd46c6014f369c8dd7e0ea283014566f9"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"de2500b3377f27ee4502d17d9a022814bab63915","unresolved":false,"context_lines":[{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"$horizon_installed \u003d \u0027%(CONFIG_HORIZON_INSTALL)s\u0027"},{"line_number":59,"context_line":"$multihost \u003d %(CONFIG_MULTIHOST)s"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if $horizon_installed \u003d\u003d \u0027n\u0027 or $multihost {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAAUH%2F%2Bkbg%3D","line":59,"updated":"2014-01-24 13:58:06.000000000","message":"Could you rename that to CONFIG_APACHE_MULTIHOST (for example)? Your naming is too much general and can cause problems in the future.","commit_id":"86a6bc95536cfd54b6939f8852ca259cc3965744"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"70bb52db63a667d0a914983a62e6cfb64bf56afd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"$horizon_installed \u003d \u0027%(CONFIG_HORIZON_INSTALL)s\u0027"},{"line_number":59,"context_line":"$multihost \u003d %(CONFIG_MULTIHOST)s"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if $horizon_installed \u003d\u003d \u0027n\u0027 or $multihost {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAAUH%2F%2Bif8%3D","line":59,"in_reply_to":"AAAAUH%2F%2Bkbg%3D","updated":"2014-01-24 16:12:53.000000000","message":"good call i\u0027m on to that","commit_id":"86a6bc95536cfd54b6939f8852ca259cc3965744"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"de2500b3377f27ee4502d17d9a022814bab63915","unresolved":false,"context_lines":[{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"exec { \"reload_httpd\":"},{"line_number":74,"context_line":"    command \u003d\u003e \u0027/sbin/service httpd reload\u0027,"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAAUH%2F%2Bkbs%3D","line":74,"updated":"2014-01-24 13:58:06.000000000","message":"Let\u0027s put here refreshonly \u003d\u003e true [1], so we won\u0027t reload apache in case it\u0027s not required.\n\n[1] http://docs.puppetlabs.com/references/latest/type.html#exec-attribute-refreshonly","commit_id":"86a6bc95536cfd54b6939f8852ca259cc3965744"}]}