)]}'
{"id":"x%2Fpackstack~696257","triplet_id":"x%2Fpackstack~master~Ic967d9446ef68a0257b9448bc8f3f3b664d776e0","project":"x/packstack","branch":"master","hashtags":[],"change_id":"Ic967d9446ef68a0257b9448bc8f3f3b664d776e0","subject":"Set unixsocket to undef in redis class","status":"MERGED","created":"2019-11-27 09:30:59.000000000","updated":"2019-12-11 18:03:18.000000000","submitted":"2019-11-27 14:48:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"696257-1574866086666-8eeca06d","meta_rev_id":"9f18f1c782e5001433c7ecf6d7b8fcfcb013dbb4","_number":696257,"virtual_id_number":696257,"owner":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-27 14:48:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-11-27 09:52:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-11-27 14:00:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-27 14:00:38.000000000","updated_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"reviewer":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"state":"REVIEWER"},{"updated":"2019-11-27 14:48:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"31d70f561ec726c24d7cd3742fcd7966a6948f61","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2019-11-27 09:30:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a8024395cb49e741fce2e9c6b35a917011d9de2","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2019-11-27 09:46:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6443d34afd09e801fb1866486194008123ccca03","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2019-11-27 09:52:23.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"208c076a138a22ff68c1f062ad5be2c660814743","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-27 10:49:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a7797504e08b4f5a8a0bc82f0a715658 : SUCCESS in 3m 32s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/579c05f3794b4bcc9de68f172bc8e84b : SUCCESS in 4m 02s\n- packstack-integration-scenario001-tempest https://zuul.opendev.org/t/openstack/build/e3259f8a83554619a9bfbf5aa4258894 : SUCCESS in 58m 36s\n- packstack-integration-scenario002-tempest https://zuul.opendev.org/t/openstack/build/fa44e0d8d30a49f0a56ae89d3141053a : SUCCESS in 45m 28s\n- packstack-integration-scenario003-tempest https://zuul.opendev.org/t/openstack/build/6d05932ea6494bbd9fd46063cdfd716e : SUCCESS in 50m 35s\n- packstack-multinode-scenario002-tempest https://zuul.opendev.org/t/openstack/build/6afbcbc26c714c5f99e91dbda973313b : SUCCESS in 59m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4adad3adf5b341f39ab09264a9e29f82 : SUCCESS in 3m 21s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"bba908b5ee7693584cd400194a3c98ed83252b2b","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2019-11-27 14:00:38.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bb3cad840d410db57d6ac9cefcb0a00a8a90050e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-27 14:00:49.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c755b46c910f2a701b2806579dc6f0bf58952d1e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-27 14:48:06.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/da0f2f1bae83448e850bb7c42ec129dc : SUCCESS in 4m 00s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/93d08766541346f68e19f55d9030abcf : SUCCESS in 4m 49s\n- packstack-integration-scenario001-tempest https://zuul.opendev.org/t/openstack/build/7e0499a55980490b89fc38b6a8608218 : SUCCESS in 40m 47s\n- packstack-integration-scenario002-tempest https://zuul.opendev.org/t/openstack/build/f07fdd0e91524a99b0c3869cb6bb7881 : SUCCESS in 42m 05s\n- packstack-integration-scenario003-tempest https://zuul.opendev.org/t/openstack/build/012d5c1d807648b28bdb9ae43282723b : SUCCESS in 44m 25s\n- packstack-multinode-scenario002-tempest https://zuul.opendev.org/t/openstack/build/76d585fa76c146d0ae437510e9ed35f6 : SUCCESS in 45m 00s","accounts_in_message":[],"_revision_number":2},{"id":"9c324daf383261a593b2800ab92ace2ddf97cd8a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-27 14:48:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"9f18f1c782e5001433c7ecf6d7b8fcfcb013dbb4","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2019-12-11 18:03:18.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit 07fb4b7fc449dd1eca718b89c8b46a06306a910f","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4a1fd433e8482f58edd741ccfc70ec9fa473806b","revisions":{"f0daf237e0d7302c73366c31fa08c7673b05c182":{"kind":"REWORK","_number":1,"created":"2019-11-27 09:30:59.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/57/696257/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/x/packstack","ref":"refs/changes/57/696257/1","commands":{"Checkout":"git fetch https://review.opendev.org/x/packstack refs/changes/57/696257/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/x/packstack refs/changes/57/696257/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/x/packstack refs/changes/57/696257/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/x/packstack refs/changes/57/696257/1"}}},"commit":{"parents":[{"commit":"b8960f62f89f57c544857051ca4d8541c0327caf","subject":"Enable debug mode for services in scenario000 and scenario001","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/b8960f62f89f57c544857051ca4d8541c0327caf"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-11-27 09:25:43.000000000","tz":60},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-11-27 09:30:57.000000000","tz":60},"subject":"Set unixsocket to undef in redis class","message":"Set unixsocket to undef in redis class\n\nAfter [1], redis class does not longer accepts boolean as value for\nunixsocket, so let\u0027s undefine it. Note that this has the effect of\nenabling unix socket in redis but I don\u0027t see a way to get it disabled\nafter the patch.\n\n[1] https://github.com/voxpupuli/puppet-redis/commit/502ff38c8c035fa143e32dd4ee61b3ec68db461c\n\nChange-Id: Ic967d9446ef68a0257b9448bc8f3f3b664d776e0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/f0daf237e0d7302c73366c31fa08c7673b05c182"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/f0daf237e0d7302c73366c31fa08c7673b05c182"}]},"branch":"refs/heads/master"},"4a1fd433e8482f58edd741ccfc70ec9fa473806b":{"kind":"REWORK","_number":2,"created":"2019-11-27 09:46:40.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/57/696257/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/x/packstack","ref":"refs/changes/57/696257/2","commands":{"Checkout":"git fetch https://review.opendev.org/x/packstack refs/changes/57/696257/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/x/packstack refs/changes/57/696257/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/x/packstack refs/changes/57/696257/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/x/packstack refs/changes/57/696257/2"}}},"commit":{"parents":[{"commit":"b8960f62f89f57c544857051ca4d8541c0327caf","subject":"Enable debug mode for services in scenario000 and scenario001","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/b8960f62f89f57c544857051ca4d8541c0327caf"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-11-27 09:25:43.000000000","tz":60},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2019-11-27 09:46:06.000000000","tz":60},"subject":"Set unixsocket to undef in redis class","message":"Set unixsocket to undef in redis class\n\nAfter [1], redis class does not longer accepts boolean as value for\nunixsocket, so let\u0027s undefine it. Note that this has the effect of\nenabling unix socket in redis but I don\u0027t see a way to get it disabled\nafter the patch.\n\nTo minimize risk, i\u0027m setting permissions of socket to 0700.\n\n[1] https://github.com/voxpupuli/puppet-redis/commit/502ff38c8c035fa143e32dd4ee61b3ec68db461c\n\nChange-Id: Ic967d9446ef68a0257b9448bc8f3f3b664d776e0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/4a1fd433e8482f58edd741ccfc70ec9fa473806b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/4a1fd433e8482f58edd741ccfc70ec9fa473806b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}