)]}'
{"id":"x%2Fpackstack~763971","triplet_id":"x%2Fpackstack~master~I3ed2780b55ff6944aa7bf40f259f9c4e03389373","project":"x/packstack","branch":"master","hashtags":[],"change_id":"I3ed2780b55ff6944aa7bf40f259f9c4e03389373","subject":"Move nova host discovery to a new controller_post step","status":"MERGED","created":"2020-11-24 12:48:01.000000000","updated":"2020-12-01 11:57:45.000000000","submitted":"2020-12-01 11:57:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"763971","meta_rev_id":"1bdd51bdb0b1259c46ed8d7c03f92bca3455d2e4","_number":763971,"virtual_id_number":763971,"owner":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-12-01 11:57:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-11-24 16:50:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-12-01 10:47:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"}],"reviewers":{"REVIEWER":[{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-24 13:21:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-24 13:37:52.000000000","updated_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"reviewer":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"state":"CC"},{"updated":"2020-11-24 16:50:57.000000000","updated_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"reviewer":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"state":"REVIEWER"},{"updated":"2020-11-24 16:51:06.000000000","updated_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"reviewer":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"state":"REVIEWER"}],"messages":[{"id":"f830c75c34ecd503e5aab53dad0952416f26c3b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2020-11-24 12:48:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"936c94d24909df71ba7f521ce9363fbf85b8e3e9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-24 13:21:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/51f84fa2f1bf470f9499bc138aa43ff2 : SUCCESS in 3m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0822b2111cd54f039fb23ff3b35ca55e : SUCCESS in 4m 54s\n- packstack-centos8-multinode-scenario002-tempest https://zuul.opendev.org/t/openstack/build/5e0505fb3aba4f46b1efe99ed92db451 : FAILURE in 28m 55s","accounts_in_message":[],"_revision_number":1},{"id":"7232047a748ba01474352f79ad4839af73d34c19","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2020-11-24 13:37:52.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n+1 to the concept, it fixes a long-standing issue with Nova cell discovery, which ended up being run from the compute nodes even though it was not a good idea.\n\nSome inline comments to fix CI.","accounts_in_message":[],"_revision_number":1},{"id":"1a1d2261ae4b598a67d9a9af1c672337eba2f486","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2020-11-24 13:53:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5c66a4d4df923289d9200b98e2257f82da785cf0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-24 14:56:37.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b886e3c6aae94fa2b733a15dabc8e73e : SUCCESS in 2m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f80cdaba9db6459db11d62b92121722f : SUCCESS in 3m 40s\n- packstack-centos8-multinode-scenario002-tempest https://zuul.opendev.org/t/openstack/build/83acc1d1df93466fb975a4565384b3a4 : FAILURE in 55m 37s","accounts_in_message":[],"_revision_number":2},{"id":"2c65ef2caedfd3c29dca52a56775797e86c60267","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2020-11-24 15:32:49.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"988c94f40017f9af7fc0f6f15ab88ad6b21d056a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-24 16:50:16.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/db6d017dfe354bf2ababf377f665add5 : SUCCESS in 3m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9ca887d0b07b48d382aa5a8bf68a859d : SUCCESS in 3m 48s\n- packstack-centos8-integration-scenario001 https://zuul.opendev.org/t/openstack/build/ffb0d481a1b2442881a6a24deb2ffb3e : SUCCESS in 52m 22s\n- packstack-centos8-integration-scenario002 https://zuul.opendev.org/t/openstack/build/72ccadaa2d2749d582745ad49b19f19b : SUCCESS in 48m 27s\n- packstack-centos8-integration-scenario003 https://zuul.opendev.org/t/openstack/build/3dc33186cf354459aa5c98d7f11776fd : SUCCESS in 56m 59s\n- packstack-centos8-multinode-scenario002-tempest https://zuul.opendev.org/t/openstack/build/6e3bc5053bdb4d088f4298d421f5da42 : SUCCESS in 55m 27s","accounts_in_message":[],"_revision_number":3},{"id":"99e491c6f506eb049ee928285770a9366847ee9b","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2020-11-24 16:50:57.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"81ccc56eae0c282bb63995b8b8fc207f643d8bc4","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2020-12-01 10:47:20.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"c9f5d11e6c94f2824005d8afe33838fdc0f4d1d0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-01 10:47:34.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"8d3375b508930885d397a385ba350f1a72d9157d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-01 11:57:44.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/020a97f068c44d06a1b2f4ac0ea457a0 : SUCCESS in 4m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9da0dc99878c4d69a78f6ae213f62e30 : SUCCESS in 3m 54s\n- packstack-centos8-integration-scenario001 https://zuul.opendev.org/t/openstack/build/a0780384c43e4c6c9d35d4acacb78a78 : SUCCESS in 51m 45s\n- packstack-centos8-integration-scenario002 https://zuul.opendev.org/t/openstack/build/7c5009ba8b4c49b9b9f09fbd4d73e109 : SUCCESS in 49m 08s\n- packstack-centos8-integration-scenario003 https://zuul.opendev.org/t/openstack/build/7163f8e30d4949eba989452166b18184 : SUCCESS in 54m 00s\n- packstack-centos8-multinode-scenario002-tempest https://zuul.opendev.org/t/openstack/build/cd8d34d2902443d48e0db78362a135de : SUCCESS in 1h 01m 20s","accounts_in_message":[],"_revision_number":3},{"id":"1bdd51bdb0b1259c46ed8d7c03f92bca3455d2e4","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-01 11:57:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2086672ae49dab8c98aabf03b8114edfeefab335","revisions":{"31aca9f67570a11c7e9ccc4b55be4f075d50f20e":{"kind":"REWORK","_number":1,"created":"2020-11-24 12:48:01.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/71/763971/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/x/packstack","ref":"refs/changes/71/763971/1","commands":{"Checkout":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/x/packstack refs/changes/71/763971/1"}}},"commit":{"parents":[{"commit":"19c71e92d1455a5d981db178ff6de8e68b2ed7db","subject":"Move nova:pci class invocation to before nova::api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/19c71e92d1455a5d981db178ff6de8e68b2ed7db"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2020-11-24 12:42:25.000000000","tz":60},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2020-11-24 12:47:59.000000000","tz":60},"subject":"[WIP] Move nova host discovery to a new controller_post step","message":"[WIP] Move nova host discovery to a new controller_post step\n\nCurrently, host discovery from the compute nodes after each compute\nconfiguration. This will be a problem in future as it requires db access\nand credentials in nova config file in the compute nodes which is not\nrecommended and will be forbiden in future [1].\n\nThis patch is removing it from the compute.pp template and moving it to\na new step controller_post that will be executed in the controller after\nexecuting the rest of puppet manifests.\n\n[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018875.html\n\nChange-Id: I3ed2780b55ff6944aa7bf40f259f9c4e03389373\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/31aca9f67570a11c7e9ccc4b55be4f075d50f20e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/31aca9f67570a11c7e9ccc4b55be4f075d50f20e"}]},"branch":"refs/heads/master"},"96964a5bf0f83d39521ac7c91b02254a38c80807":{"kind":"REWORK","_number":2,"created":"2020-11-24 13:53:52.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/71/763971/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/x/packstack","ref":"refs/changes/71/763971/2","commands":{"Checkout":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/x/packstack refs/changes/71/763971/2"}}},"commit":{"parents":[{"commit":"19c71e92d1455a5d981db178ff6de8e68b2ed7db","subject":"Move nova:pci class invocation to before nova::api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/19c71e92d1455a5d981db178ff6de8e68b2ed7db"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2020-11-24 12:42:25.000000000","tz":60},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2020-11-24 13:53:43.000000000","tz":60},"subject":"[WIP] Move nova host discovery to a new controller_post step","message":"[WIP] Move nova host discovery to a new controller_post step\n\nCurrently, host discovery from the compute nodes after each compute\nconfiguration. This will be a problem in future as it requires db access\nand credentials in nova config file in the compute nodes which is not\nrecommended and will be forbiden in future [1].\n\nThis patch is removing it from the compute.pp template and moving it to\na new step controller_post that will be executed in the controller after\nexecuting the rest of puppet manifests.\n\n[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018875.html\n\nChange-Id: I3ed2780b55ff6944aa7bf40f259f9c4e03389373\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/96964a5bf0f83d39521ac7c91b02254a38c80807"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/96964a5bf0f83d39521ac7c91b02254a38c80807"}]},"branch":"refs/heads/master"},"2086672ae49dab8c98aabf03b8114edfeefab335":{"kind":"REWORK","_number":3,"created":"2020-11-24 15:32:49.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/71/763971/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/x/packstack","ref":"refs/changes/71/763971/3","commands":{"Checkout":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/x/packstack refs/changes/71/763971/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/x/packstack refs/changes/71/763971/3"}}},"commit":{"parents":[{"commit":"19c71e92d1455a5d981db178ff6de8e68b2ed7db","subject":"Move nova:pci class invocation to before nova::api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/19c71e92d1455a5d981db178ff6de8e68b2ed7db"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2020-11-24 12:42:25.000000000","tz":60},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2020-11-24 15:32:37.000000000","tz":60},"subject":"Move nova host discovery to a new controller_post step","message":"Move nova host discovery to a new controller_post step\n\nCurrently, host discovery is executed from the compute nodes after each\ncompute setup. This will be a problem in future as it requires db access\nand credentials in nova config file in the compute nodes which is not\nrecommended and will be forbiden in future [1].\n\nThis patch is removing it from the compute.pp template and moving it to\na new step controller_post that will be executed in the controller after\nexecuting the rest of puppet manifests.\n\n[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018875.html\n\nChange-Id: I3ed2780b55ff6944aa7bf40f259f9c4e03389373\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/2086672ae49dab8c98aabf03b8114edfeefab335"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/x/packstack/commit/2086672ae49dab8c98aabf03b8114edfeefab335"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}