)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"d41b80d1b65245832abd4877c2b5657640a762ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87744998_15e094bb","updated":"2022-08-16 10:18:33.000000000","message":"recheck","commit_id":"9d8f2ef566e309471112ae02b52632eba4e79b92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4f7c15361e01340ee70a720aca591d6c22da6d24","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4e0baa19_b6a22d81","updated":"2022-08-17 13:50:03.000000000","message":"WIP until I check whether we should replace hiera_undef as well.","commit_id":"fa63bb8d02191b7abefdbaa5c972ef666ef567d9"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"b994d15c92492d16587436ae4897c4b2870d2f67","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b4faf8d9_4d55348b","in_reply_to":"4e0baa19_b6a22d81","updated":"2022-08-17 13:55:25.000000000","message":"hiera_undef comes from https://github.com/redhat-openstack/packstack/blob/eabad465d8656c57a8af0f2612fc1f6cac618cfd/packstack/puppet/modules/packstack/lib/puppet/parser/functions/hiera_undef.rb which uses lookup under the hood so i\u0027d say it should be fine?","commit_id":"fa63bb8d02191b7abefdbaa5c972ef666ef567d9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a8392415e9189d52d679fc6560a15f6b1c170c80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c94f3449_d8699dd5","in_reply_to":"b4faf8d9_4d55348b","updated":"2022-08-17 15:45:12.000000000","message":"It might be fine though I don\u0027t fully understand why we can\u0027t use hiera of lookup.\nI\u0027ve pushed a patch to replace it by built-in lookup as a separate commit.","commit_id":"fa63bb8d02191b7abefdbaa5c972ef666ef567d9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1553a6d161950fc55c7e518ce9372e1c7e0d58a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"22cd53d5_da5bd0d2","updated":"2022-08-20 18:04:35.000000000","message":"recheck","commit_id":"6ff87dd6d4f4d9031a10be9544d24c20fd34244e"}],"packstack/puppet/modules/packstack/manifests/cinder.pp":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"49393c032775251a8f5be68fc46e7b103e12fb85","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    create_resources(packstack::firewall, lookup(\u0027FIREWALL_CINDER_RULES\u0027, undef, undef, {}))"},{"line_number":4,"context_line":"    create_resources(packstack::firewall, lookup(\u0027FIREWALL_CINDER_API_RULES\u0027, undef, undef, {}))"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    $cinder_backends \u003d hiera_array(\u0027CONFIG_CINDER_BACKEND\u0027)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    case $cinder_backends[0] {"},{"line_number":9,"context_line":"      \u0027lvm\u0027:       { $default_volume_type \u003d \u0027iscsi\u0027 }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"a9429e60_a56d0277","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":34},"updated":"2022-08-17 09:32:41.000000000","message":"Should we also replace hiera_array by lookup with hash merge policy?\n\nThere are others hiera_array calls, i\u0027m not sure if those are being deprecated.","commit_id":"52518ae46b8274d0a6fd035af51c776a2a84f081"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4f7c15361e01340ee70a720aca591d6c22da6d24","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    create_resources(packstack::firewall, lookup(\u0027FIREWALL_CINDER_RULES\u0027, undef, undef, {}))"},{"line_number":4,"context_line":"    create_resources(packstack::firewall, lookup(\u0027FIREWALL_CINDER_API_RULES\u0027, undef, undef, {}))"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    $cinder_backends \u003d hiera_array(\u0027CONFIG_CINDER_BACKEND\u0027)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    case $cinder_backends[0] {"},{"line_number":9,"context_line":"      \u0027lvm\u0027:       { $default_volume_type \u003d \u0027iscsi\u0027 }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"c61e6152_1ba48e8d","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":34},"in_reply_to":"a9429e60_a56d0277","updated":"2022-08-17 13:50:03.000000000","message":"hiera_array is also deprecated. Updated the patch to cover that function as well.","commit_id":"52518ae46b8274d0a6fd035af51c776a2a84f081"}]}