)]}'
{"proliantutils/ilo/ribcl.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0f59e6e3846fbd53d1875b5c8e78311e698e2f94","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        etree.SubElement(element, \u0027PASSWORD\u0027, VALUE\u003dpassword)"},{"line_number":491,"context_line":"        d \u003d self._request_ilo(root)"},{"line_number":492,"context_line":"        data \u003d self._parse_output(d)"},{"line_number":493,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_db08a9db","line":493,"updated":"2015-02-10 14:59:28.000000000","message":"What does it return here ? I guess there is nothing to be returned.","commit_id":"43f743e81c7cdcc9dcc2411df20ec8d011905768"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"058c32137b498cd8d126905fc0faefbf19e1d023","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        etree.SubElement(element, \u0027PASSWORD\u0027, VALUE\u003dpassword)"},{"line_number":491,"context_line":"        d \u003d self._request_ilo(root)"},{"line_number":492,"context_line":"        data \u003d self._parse_output(d)"},{"line_number":493,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_ec3756fd","line":493,"in_reply_to":"da86d52c_db08a9db","updated":"2015-02-11 06:52:54.000000000","message":"shouldnt return anything, as parse_output is returning..have kept the same. As we are not consuming anyway , will remove it.","commit_id":"43f743e81c7cdcc9dcc2411df20ec8d011905768"}],"proliantutils/ilo/ris.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0f59e6e3846fbd53d1875b5c8e78311e698e2f94","unresolved":false,"context_lines":[{"line_number":555,"context_line":"        base_config_uri \u003d bios_settings[\u0027links\u0027][\u0027BaseConfigs\u0027][\u0027href\u0027]"},{"line_number":556,"context_line":"        status, headers, config \u003d self._rest_get(base_config_uri)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        if status \u003e\u003d 300:"},{"line_number":559,"context_line":"            msg \u003d self._get_extended_error(config)"},{"line_number":560,"context_line":"            raise exception.IloError(msg)"},{"line_number":561,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_3b7705d6","line":558,"updated":"2015-02-10 14:59:28.000000000","message":"I see this is code being just moved, but we always check status !\u003d 200 for get operations, shouldn\u0027t we check the same ?","commit_id":"43f743e81c7cdcc9dcc2411df20ec8d011905768"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"058c32137b498cd8d126905fc0faefbf19e1d023","unresolved":false,"context_lines":[{"line_number":555,"context_line":"        base_config_uri \u003d bios_settings[\u0027links\u0027][\u0027BaseConfigs\u0027][\u0027href\u0027]"},{"line_number":556,"context_line":"        status, headers, config \u003d self._rest_get(base_config_uri)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        if status \u003e\u003d 300:"},{"line_number":559,"context_line":"            msg \u003d self._get_extended_error(config)"},{"line_number":560,"context_line":"            raise exception.IloError(msg)"},{"line_number":561,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_ac29de9c","line":558,"in_reply_to":"da86d52c_3b7705d6","updated":"2015-02-11 06:52:54.000000000","message":"Done","commit_id":"43f743e81c7cdcc9dcc2411df20ec8d011905768"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0f59e6e3846fbd53d1875b5c8e78311e698e2f94","unresolved":false,"context_lines":[{"line_number":578,"context_line":"            request_headers[\u0027X-HPRESTFULAPI-AuthToken\u0027] \u003d bios_password_hash"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        # perform the patch"},{"line_number":581,"context_line":"        status, headers, response \u003d self._rest_patch(bios_uri, request_headers,"},{"line_number":582,"context_line":"                                                     new_bios_settings)"},{"line_number":583,"context_line":"        if status \u003e\u003d 300:"},{"line_number":584,"context_line":"            msg \u003d self._get_extended_error(response)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1ea94fdf","line":581,"updated":"2015-02-10 14:59:28.000000000","message":"We set bios_uri only if go inside \"if not self._operation_allowed(headers_bios, \u0027PATCH\u0027):\" in L563. Is this expected ?","commit_id":"43f743e81c7cdcc9dcc2411df20ec8d011905768"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"058c32137b498cd8d126905fc0faefbf19e1d023","unresolved":false,"context_lines":[{"line_number":578,"context_line":"            request_headers[\u0027X-HPRESTFULAPI-AuthToken\u0027] \u003d bios_password_hash"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        # perform the patch"},{"line_number":581,"context_line":"        status, headers, response \u003d self._rest_patch(bios_uri, request_headers,"},{"line_number":582,"context_line":"                                                     new_bios_settings)"},{"line_number":583,"context_line":"        if status \u003e\u003d 300:"},{"line_number":584,"context_line":"            msg \u003d self._get_extended_error(response)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_0c102a58","line":581,"in_reply_to":"da86d52c_1ea94fdf","updated":"2015-02-11 06:52:54.000000000","message":"Done","commit_id":"43f743e81c7cdcc9dcc2411df20ec8d011905768"}]}