)]}'
{"proliantutils/redfish/redfish.py":[{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"8d074dad0ad498e104f15667766f84ae01c4faa5","unresolved":false,"context_lines":[{"line_number":769,"context_line":"        \"\"\""},{"line_number":770,"context_line":"        sushy_system \u003d self._get_sushy_system(PROLIANT_SYSTEM_ID)"},{"line_number":771,"context_line":"        memory_gib \u003d sushy_system.memory_summary.size_gib"},{"line_number":772,"context_line":"        memory_mb \u003d memory_gib * 1024"},{"line_number":773,"context_line":"        processor_details \u003d sushy_system.processors.summary"},{"line_number":774,"context_line":"        macs \u003d sushy_system.ethernet_interfaces.summary"},{"line_number":775,"context_line":"        local_gb \u003d sushy_system.storage_summary"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_57f1d4cc","line":772,"range":{"start_line":772,"start_character":8,"end_line":772,"end_character":17},"updated":"2017-07-26 05:35:21.000000000","message":"Make it \"memory_mib\" since you are getting this value from \u0027memory_gib\u0027. There\u0027s a difference in \"mib\" and \"mb\". MiB is 2^20 where as MB is 10^6. So which one do we get? We should also keep the naming conventions accordingly. I can see below that the properties have the naming conventions as \u0027memory_mb\u0027 and \u0027local_gb\u0027. So i am little confused and may be wrong. WDYT?","commit_id":"9ea5c3affc4432d6f43796aa4f3d70bebf9fb89e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"65887d7a0764d7e78e77dcc14d869307a9d8a25a","unresolved":false,"context_lines":[{"line_number":767,"context_line":"        cpu, cpu_arch, local_gb, memory_mb. The MACs are also returned"},{"line_number":768,"context_line":"        as part of this method."},{"line_number":769,"context_line":"        \"\"\""},{"line_number":770,"context_line":"        sushy_system \u003d self._get_sushy_system(PROLIANT_SYSTEM_ID)"},{"line_number":771,"context_line":"        memory_gib \u003d sushy_system.memory_summary.size_gib"},{"line_number":772,"context_line":"        memory_mb \u003d memory_gib * 1024"},{"line_number":773,"context_line":"        processor_details \u003d sushy_system.processors.summary"},{"line_number":774,"context_line":"        macs \u003d sushy_system.ethernet_interfaces.summary"},{"line_number":775,"context_line":"        # TODO(nisha): Add local_gb here and return after"},{"line_number":776,"context_line":"        # local_gb changes are merged."},{"line_number":777,"context_line":"        # local_gb \u003d sushy_system.storage_summary"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_57fe7437","line":774,"range":{"start_line":770,"start_character":8,"end_line":774,"end_character":55},"updated":"2017-07-26 05:39:35.000000000","message":"need exception catching here.\nAnd I feel there\u0027s no need of defining separate variables, use those retrieving logic as part of dict population:\n\n    return {\n      \u0027properties\u0027: {\n        \u0027memory_mb\u0027: sushy_system.memory_summary.size_gib * 1024,\n        \u0027cpus\u0027: sushy_system.processors.summary.count\n        ...\n      }\n      \u0027macs\u0027: sushy_system.ethernet_interfaces.summary\n    }","commit_id":"0a2ba665fe8d6d0b93783ea0c22c91d1d733fdea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0a9ae84773aca48194bcca52c8ee7cd60b37a170","unresolved":false,"context_lines":[{"line_number":775,"context_line":"            prop \u003d {\u0027memory_mb\u0027: (sushy_system.memory_summary.size_gib * 1024),"},{"line_number":776,"context_line":"                    \u0027cpus\u0027: sushy_system.processors.summary.count,"},{"line_number":777,"context_line":"                    \u0027cpu_arch\u0027: sushy_system.processors.summary.architecture,"},{"line_number":778,"context_line":"                    \u0027local_gb\u0027: \u0027dummy_value\u0027}"},{"line_number":779,"context_line":"            return {\u0027properties\u0027: prop,"},{"line_number":780,"context_line":"                    \u0027macs\u0027: sushy_system.ethernet_interfaces.summary}"},{"line_number":781,"context_line":"        except sushy.exceptions.SushyError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_8eb28193","line":778,"range":{"start_line":778,"start_character":20,"end_line":778,"end_character":45},"updated":"2017-07-26 08:30:56.000000000","message":"Remove this dummy code. May be you can add TODO() here instead.","commit_id":"cf2be0e23a2cac62eec38c1bdcff0237edc29ea7"}],"proliantutils/tests/redfish/test_redfish.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0a9ae84773aca48194bcca52c8ee7cd60b37a170","unresolved":false,"context_lines":[{"line_number":936,"context_line":"            exception.IloError,"},{"line_number":937,"context_line":"            \"The Redfish controller failed to get the \""},{"line_number":938,"context_line":"            \"resource data. Error None\","},{"line_number":939,"context_line":"            self.rf_client.get_essential_properties) "},{"line_number":940,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_0e645121","line":939,"range":{"start_line":939,"start_character":50,"end_line":939,"end_character":53},"updated":"2017-07-26 08:30:56.000000000","message":"Extra space at end.","commit_id":"cf2be0e23a2cac62eec38c1bdcff0237edc29ea7"}]}