)]}'
{"proliantutils/ilo/ribcl.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1e30b43e79d18b075bb98a543fe47e188e8aabc9","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"        \"\"\""},{"line_number":1194,"context_line":"        platform \u003d self.get_product_name()"},{"line_number":1195,"context_line":"        msg \u003d (\"`inject_nmi` is not supported on %s\" % platform)"},{"line_number":1196,"context_line":"        raise (exception.IloCommandNotSupportedError(msg))"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"# The below block of code is there only for backward-compatibility"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2e7c521e","line":1196,"range":{"start_line":1196,"start_character":14,"end_line":1196,"end_character":15},"updated":"2018-07-10 07:26:50.000000000","message":"nit: extra parenthesis","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"637d37f9975c65e21f5f5f6186c966b56f19541f","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"        \"\"\""},{"line_number":1194,"context_line":"        platform \u003d self.get_product_name()"},{"line_number":1195,"context_line":"        msg \u003d (\"`inject_nmi` is not supported on %s\" % platform)"},{"line_number":1196,"context_line":"        raise (exception.IloCommandNotSupportedError(msg))"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"# The below block of code is there only for backward-compatibility"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3f21defc","line":1196,"range":{"start_line":1196,"start_character":14,"end_line":1196,"end_character":15},"in_reply_to":"5f7c97a3_2e7c521e","updated":"2018-07-10 11:07:53.000000000","message":"Done","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"}],"proliantutils/ilo/ris.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1e30b43e79d18b075bb98a543fe47e188e8aabc9","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"        \"\"\""},{"line_number":1832,"context_line":"        cur_status \u003d self.get_host_power_status()"},{"line_number":1833,"context_line":"        if cur_status !\u003d \u0027ON\u0027:"},{"line_number":1834,"context_line":"            raise exception.IloError(\"Server is not in power on state.\")"},{"line_number":1835,"context_line":""},{"line_number":1836,"context_line":"        self._perform_power_op(\"Nmi\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6e7d6ae4","line":1834,"range":{"start_line":1834,"start_character":37,"end_line":1834,"end_character":71},"updated":"2018-07-10 07:26:50.000000000","message":"Should we also provide a suggestive remark here to consumer, something similar to:\n\n    Server not in POWER-ON state. Need to be in POWER-OFF state before invoking ``inject_nmi()``.\n\nor something similar.","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"637d37f9975c65e21f5f5f6186c966b56f19541f","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"        \"\"\""},{"line_number":1832,"context_line":"        cur_status \u003d self.get_host_power_status()"},{"line_number":1833,"context_line":"        if cur_status !\u003d \u0027ON\u0027:"},{"line_number":1834,"context_line":"            raise exception.IloError(\"Server is not in power on state.\")"},{"line_number":1835,"context_line":""},{"line_number":1836,"context_line":"        self._perform_power_op(\"Nmi\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_5f085a7e","line":1834,"range":{"start_line":1834,"start_character":37,"end_line":1834,"end_character":71},"in_reply_to":"5f7c97a3_6e7d6ae4","updated":"2018-07-10 11:07:53.000000000","message":"Done","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"}],"proliantutils/redfish/redfish.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1e30b43e79d18b075bb98a543fe47e188e8aabc9","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        \"\"\""},{"line_number":1017,"context_line":"        cur_status \u003d self.get_host_power_status()"},{"line_number":1018,"context_line":"        if cur_status !\u003d \u0027ON\u0027:"},{"line_number":1019,"context_line":"            raise exception.IloError(\"Server is not in power on state.\")"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        sushy_system \u003d self._get_sushy_system(PROLIANT_SYSTEM_ID)"},{"line_number":1022,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2e02123f","line":1019,"range":{"start_line":1019,"start_character":12,"end_line":1019,"end_character":72},"updated":"2018-07-10 07:26:50.000000000","message":"ditto as ris file comment.","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"637d37f9975c65e21f5f5f6186c966b56f19541f","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        \"\"\""},{"line_number":1017,"context_line":"        cur_status \u003d self.get_host_power_status()"},{"line_number":1018,"context_line":"        if cur_status !\u003d \u0027ON\u0027:"},{"line_number":1019,"context_line":"            raise exception.IloError(\"Server is not in power on state.\")"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        sushy_system \u003d self._get_sushy_system(PROLIANT_SYSTEM_ID)"},{"line_number":1022,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9f29118a","line":1019,"range":{"start_line":1019,"start_character":12,"end_line":1019,"end_character":72},"in_reply_to":"5f7c97a3_2e02123f","updated":"2018-07-10 11:07:53.000000000","message":"Done","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1e30b43e79d18b075bb98a543fe47e188e8aabc9","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        if cur_status !\u003d \u0027ON\u0027:"},{"line_number":1019,"context_line":"            raise exception.IloError(\"Server is not in power on state.\")"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        sushy_system \u003d self._get_sushy_system(PROLIANT_SYSTEM_ID)"},{"line_number":1022,"context_line":"        try:"},{"line_number":1023,"context_line":"            sushy_system.reset_system(sushy.RESET_NMI)"},{"line_number":1024,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":1025,"context_line":"            msg \u003d (self._(\u0027The Redfish controller failed to inject nmi to \u0027"},{"line_number":1026,"context_line":"                          \u0027server. Error %(error)s\u0027) % {\u0027error\u0027: str(e)})"},{"line_number":1027,"context_line":"            LOG.debug(msg)"},{"line_number":1028,"context_line":"            raise exception.IloError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4e1e6e74","line":1028,"range":{"start_line":1021,"start_character":8,"end_line":1028,"end_character":41},"updated":"2018-07-10 07:26:50.000000000","message":"this is an unnecessary call which we can (should) avoid. A quick code for it:\n\n\tsushy_system \u003d self._get_sushy_system(PROLIANT_SYSTEM_ID)\n\tif sushy_system.power_state !\u003d sushy.SYSTEM_POWER_STATE_ON:\n\t\traise exception.IloError(...)\n\ttry:\n\t\tsushy_system.reset_system(sushy.RESET_NMI)\n\texcept sushy.exceptions.SushyError as e:\n\t\tmsg \u003d (self._(\u0027The Redfish controller failed to inject nmi to \u0027\n\t\t\t\t\t  \u0027server. Error %(error)s\u0027) % {\u0027error\u0027: str(e)})\n\t\tLOG.debug(msg)\n\t\traise exception.IloError(msg)","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"637d37f9975c65e21f5f5f6186c966b56f19541f","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        if cur_status !\u003d \u0027ON\u0027:"},{"line_number":1019,"context_line":"            raise exception.IloError(\"Server is not in power on state.\")"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        sushy_system \u003d self._get_sushy_system(PROLIANT_SYSTEM_ID)"},{"line_number":1022,"context_line":"        try:"},{"line_number":1023,"context_line":"            sushy_system.reset_system(sushy.RESET_NMI)"},{"line_number":1024,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":1025,"context_line":"            msg \u003d (self._(\u0027The Redfish controller failed to inject nmi to \u0027"},{"line_number":1026,"context_line":"                          \u0027server. Error %(error)s\u0027) % {\u0027error\u0027: str(e)})"},{"line_number":1027,"context_line":"            LOG.debug(msg)"},{"line_number":1028,"context_line":"            raise exception.IloError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_1fd66154","line":1028,"range":{"start_line":1021,"start_character":8,"end_line":1028,"end_character":41},"in_reply_to":"5f7c97a3_4e1e6e74","updated":"2018-07-10 11:07:53.000000000","message":"Done","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"}],"proliantutils/tests/ilo/test_client.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1e30b43e79d18b075bb98a543fe47e188e8aabc9","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"    @mock.patch.object(ribcl.RIBCLOperations, \u0027inject_nmi\u0027)"},{"line_number":1026,"context_line":"    def test_inject_nmi_gen8(self, inject_nmi_mock):"},{"line_number":1027,"context_line":"        self.client.model \u003d \u0027Gen8\u0027"},{"line_number":1028,"context_line":"        self.client.inject_nmi()"},{"line_number":1029,"context_line":"        inject_nmi_mock.assert_called_once_with()"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ae886221","line":1028,"range":{"start_line":1028,"start_character":8,"end_line":1028,"end_character":32},"updated":"2018-07-10 07:26:50.000000000","message":"isn\u0027t it supposed to throw an exception?","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"637d37f9975c65e21f5f5f6186c966b56f19541f","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"    @mock.patch.object(ribcl.RIBCLOperations, \u0027inject_nmi\u0027)"},{"line_number":1026,"context_line":"    def test_inject_nmi_gen8(self, inject_nmi_mock):"},{"line_number":1027,"context_line":"        self.client.model \u003d \u0027Gen8\u0027"},{"line_number":1028,"context_line":"        self.client.inject_nmi()"},{"line_number":1029,"context_line":"        inject_nmi_mock.assert_called_once_with()"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_452f28f4","line":1028,"range":{"start_line":1028,"start_character":8,"end_line":1028,"end_character":32},"in_reply_to":"5f7c97a3_ae886221","updated":"2018-07-10 11:07:53.000000000","message":"Done","commit_id":"58b37aa4c143ce38d135039b34143e83a7e58eb3"}]}