)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"38271395035eebef4361aec99cbfebb16cebf695","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86defc6b_da1dfa6a","updated":"2024-06-19 12:40:35.000000000","message":"Code change looks fine for me. Please let us know if this change is for 2024.2 release as the patch is raised on master or is it also required for prior branches too? And also can you give us a link to a bug from which we can get some more detail of the issue or is it just the test cases failing. Is this a customer reported issue?","commit_id":"19cd045bf6f805e547542bae0e44b26283507a74"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"93fb8e1d201ca81253a872ecaeefcf418bab489b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b3999ef_7f9107fa","updated":"2024-06-26 12:12:07.000000000","message":"Thank you JayF for the information.\n\nallow_reauth paremeter is introduced in sushy version 4.5.2 whereas proliantutils requirements has sushy\u003e\u003d4.5.0 and hence sushy version to be updated in proliantutils requirements to sushy\u003e\u003d4.5.2\n\nRevoked the vote due to the above comment, once that is done, we will merge it.","commit_id":"19cd045bf6f805e547542bae0e44b26283507a74"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"83259774ae5b0690d7944d8af9930ec89ca0181d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"701e71bd_a0e24c9c","updated":"2024-06-19 15:26:55.000000000","message":"This is the fix that\u0027s good for master/next release. AIUI a backported version needs to be different; we\u0027re using something slightly different downstream for xena, where this issue was found.\n\nI\u0027ll let you know the testing results from downstream when I have \u0027em.","commit_id":"19cd045bf6f805e547542bae0e44b26283507a74"},{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"c23cca8c2813b5ad630325a395c382b0b1c5882d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7011cfd1_2bed1426","updated":"2024-06-26 16:35:25.000000000","message":"Thank you JayF for the patch.","commit_id":"fe2f9c2950b283f6fa0018b2b6c85c1928e88276"}],"proliantutils/redfish/connector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21add4e12ae415c5389108184b38668c8c83184c","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        stop_max_attempt_number\u003dMAX_RETRY_ATTEMPTS,"},{"line_number":37,"context_line":"        wait_fixed\u003dMAX_TIME_BEFORE_RETRY)"},{"line_number":38,"context_line":"    def _op(self, method, path\u003d\u0027\u0027, data\u003dNone, headers\u003dNone,"},{"line_number":39,"context_line":"            blocking\u003dFalse, timeout\u003d60, **kwargs):"},{"line_number":40,"context_line":"        \"\"\"Overrides the base method to support retrying the operation."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :param method: The HTTP method to be used, e.g: GET, POST,"}],"source_content_type":"text/x-python","patch_set":1,"id":"080faeaf_17de85f7","line":39,"updated":"2024-06-13 15:22:54.000000000","message":"Probably move everything that the method body does not use to **kwargs?","commit_id":"c3b0a20547070a87dee7eac36056c3286cfe7c8a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"83259774ae5b0690d7944d8af9930ec89ca0181d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        stop_max_attempt_number\u003dMAX_RETRY_ATTEMPTS,"},{"line_number":37,"context_line":"        wait_fixed\u003dMAX_TIME_BEFORE_RETRY)"},{"line_number":38,"context_line":"    def _op(self, method, path\u003d\u0027\u0027, data\u003dNone, headers\u003dNone,"},{"line_number":39,"context_line":"            blocking\u003dFalse, timeout\u003d60, **kwargs):"},{"line_number":40,"context_line":"        \"\"\"Overrides the base method to support retrying the operation."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :param method: The HTTP method to be used, e.g: GET, POST,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1e6948c_cf6d219f","line":39,"in_reply_to":"080faeaf_17de85f7","updated":"2024-06-19 15:26:55.000000000","message":"So, in sushy.Connector.connector; extra kwargs are passed through to requests. This means we gotta be more defensively here overall.","commit_id":"c3b0a20547070a87dee7eac36056c3286cfe7c8a"}]}