)]}'
{"pyghmi/ipmi/command.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4430f01033be21729025a0f69b48979600699a9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"try:"},{"line_number":33,"context_line":"    range \u003d xrange"},{"line_number":34,"context_line":"except NameError:"},{"line_number":35,"context_line":"    pass"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"boot_devices \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_589c9569","line":35,"updated":"2016-05-05 20:29:22.000000000","message":"replace builtin types is not ideal, also I don\u0027t think this code is needed at all because range() works for python2 and 3\n\nOr, if you really need xrange behavior you can use \"six\" the compat layer library for python\n\nfrom six.moves import range","commit_id":"d446e55864d873ce27a08662d9a0afa2dc0b1d7d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"92f1362230fbd57ae42d4fe4f65d32215fd427af","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import socket"},{"line_number":30,"context_line":"import struct"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"try:"},{"line_number":33,"context_line":"    xrange"},{"line_number":34,"context_line":"except NameError:"},{"line_number":35,"context_line":"    xrange \u003d range"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_95802348","line":32,"updated":"2016-06-21 16:01:58.000000000","message":"import six\n\n\nand as needed\n six.range(...)","commit_id":"907b1500ed34d0d87904b52485e8ad276aa88403"}],"pyghmi/ipmi/events.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"92f1362230fbd57ae42d4fe4f65d32215fd427af","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import struct"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"try:"},{"line_number":26,"context_line":"    xrange"},{"line_number":27,"context_line":"except NameError:"},{"line_number":28,"context_line":"    xrange \u003d range"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_7583f756","line":25,"updated":"2016-06-21 16:01:58.000000000","message":"import six\n\n\nand as needed\n six.range(...)","commit_id":"907b1500ed34d0d87904b52485e8ad276aa88403"}],"pyghmi/ipmi/oem/lenovo/handler.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4430f01033be21729025a0f69b48979600699a9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"try:"},{"line_number":48,"context_line":"    range \u003d xrange"},{"line_number":49,"context_line":"except NameError:"},{"line_number":50,"context_line":"    pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"inventory.register_inventory_category(cpu)"},{"line_number":53,"context_line":"inventory.register_inventory_category(dimm)"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_d89d255b","line":50,"updated":"2016-05-05 20:29:22.000000000","message":"ditto","commit_id":"d446e55864d873ce27a08662d9a0afa2dc0b1d7d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"92f1362230fbd57ae42d4fe4f65d32215fd427af","unresolved":false,"context_lines":[{"line_number":44,"context_line":"import socket"},{"line_number":45,"context_line":"import struct"},{"line_number":46,"context_line":"import weakref"},{"line_number":47,"context_line":"try:"},{"line_number":48,"context_line":"    xrange"},{"line_number":49,"context_line":"except NameError:"},{"line_number":50,"context_line":"    xrange \u003d range"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_f5b08745","line":47,"updated":"2016-06-21 16:01:58.000000000","message":"import six\n\n\nand as needed\n six.range(...)","commit_id":"907b1500ed34d0d87904b52485e8ad276aa88403"}],"pyghmi/ipmi/oem/lenovo/nextscale.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4430f01033be21729025a0f69b48979600699a9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"try:"},{"line_number":21,"context_line":"    range \u003d xrange"},{"line_number":22,"context_line":"except NameError:"},{"line_number":23,"context_line":"    pass"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def fpc_read_ac_input(ipmicmd):"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_98e1ddd3","line":23,"updated":"2016-05-05 20:29:22.000000000","message":"ditto","commit_id":"d446e55864d873ce27a08662d9a0afa2dc0b1d7d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"92f1362230fbd57ae42d4fe4f65d32215fd427af","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import pyghmi.ipmi.sdr as sdr"},{"line_number":19,"context_line":"import struct"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    xrange"},{"line_number":23,"context_line":"except NameError:"},{"line_number":24,"context_line":"    xrange \u003d range"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_d5646be6","line":21,"updated":"2016-06-21 16:01:58.000000000","message":"import six\n\n\nand as needed\n six.range(...)","commit_id":"907b1500ed34d0d87904b52485e8ad276aa88403"}],"pyghmi/ipmi/private/session.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4430f01033be21729025a0f69b48979600699a9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return d.iteritems()"},{"line_number":41,"context_line":"except AttributeError:"},{"line_number":42,"context_line":"    def dictitems(d):"},{"line_number":43,"context_line":"        return d.items()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"initialtimeout \u003d 0.5  # minimum timeout for first packet to retry in any given"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_38f8b17c","line":43,"updated":"2016-05-05 20:29:22.000000000","message":"Let\u0027s use six.viewitems() here\n\nhttps://pythonhosted.org/six/#six.viewitems","commit_id":"d446e55864d873ce27a08662d9a0afa2dc0b1d7d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"92f1362230fbd57ae42d4fe4f65d32215fd427af","unresolved":false,"context_lines":[{"line_number":33,"context_line":"import pyghmi.exceptions as exc"},{"line_number":34,"context_line":"from pyghmi.ipmi.private import constants"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"try:"},{"line_number":37,"context_line":"    dict.iteritems"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def dictitems(d):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_552a3b7f","line":36,"updated":"2016-06-21 16:01:58.000000000","message":"In reality using \u0027iteritems\u0027 is rarely needed unless there are thousands of items. Usually just \u0027items\u0027 is good.\n\n http://docs.openstack.org/infra/manual/developers.html#peer-review\n\nUse of six.iteritems without clear justification should be avoided. If a dict will be very large, and the program will be expected to keep many such objects resident, then that should be stated in comments whenever six.iteritems is used. Otherwise, migrate the code to use .items().\n\n http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\n\nBut if needed, then use \u0027six.iteritems\u0027","commit_id":"907b1500ed34d0d87904b52485e8ad276aa88403"}],"pyghmi/ipmi/private/util.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4430f01033be21729025a0f69b48979600699a9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"try:"},{"line_number":21,"context_line":"    range \u003d xrange"},{"line_number":22,"context_line":"except NameError:"},{"line_number":23,"context_line":"    pass"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def decode_wireformat_uuid(rawguid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_18f5ed82","line":23,"updated":"2016-05-05 20:29:22.000000000","message":"ditto re range","commit_id":"d446e55864d873ce27a08662d9a0afa2dc0b1d7d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"92f1362230fbd57ae42d4fe4f65d32215fd427af","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import socket"},{"line_number":18,"context_line":"import struct"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"try:"},{"line_number":21,"context_line":"    xrange"},{"line_number":22,"context_line":"except NameError:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_72966df1","line":19,"updated":"2016-06-21 16:01:58.000000000","message":"import six\n\n\nThen later use:\n\n six.range(....)","commit_id":"907b1500ed34d0d87904b52485e8ad276aa88403"}],"pyghmi/util/webclient.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4430f01033be21729025a0f69b48979600699a9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    import httplib"},{"line_number":24,"context_line":"except ImportError:"},{"line_number":25,"context_line":"    import http.client as httplib"},{"line_number":26,"context_line":"    import http.cookies as Cookie"},{"line_number":27,"context_line":"import json"},{"line_number":28,"context_line":"import pyghmi.exceptions as pygexc"},{"line_number":29,"context_line":"import socket"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_d85ec575","line":26,"updated":"2016-05-05 20:29:22.000000000","message":"from six.moves import http_cookies\nfrom six.moves import http_client","commit_id":"d446e55864d873ce27a08662d9a0afa2dc0b1d7d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"92f1362230fbd57ae42d4fe4f65d32215fd427af","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# 2.6 as is found in commonly used enterprise linux distributions."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"__author__ \u003d \u0027jjohnson2\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    import Cookie"},{"line_number":23,"context_line":"    import httplib"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_327985f7","line":20,"updated":"2016-06-21 16:01:58.000000000","message":"from six import http_client\nfrom six import http_cookies","commit_id":"907b1500ed34d0d87904b52485e8ad276aa88403"}]}