)]}'
{"gbpclient/gbp/v2_0/groupbasedpolicy.py":[{"author":{"_account_id":10965,"name":"Magesh GV","email":"mageshgv@gmail.com","username":"mageshgv"},"change_message_id":"5832b7f4c2de1a4c959b95843e9ae26112407772","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        if \u0027direction\u0027 not in body[self.resource]:"},{"line_number":705,"context_line":"            body[self.resource][\u0027direction\u0027] \u003d \u0027bi\u0027"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        return body"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_6376eca5","line":706,"updated":"2015-11-18 10:22:01.000000000","message":"Empty string in protocol has to be converted to None here","commit_id":"0f2241fbb62123f2df096d35d7b2e1aa2d6336bc"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"0530b46ac1e908a616535940d9b7f6ab92dcb1e7","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        if \u0027direction\u0027 not in body[self.resource]:"},{"line_number":705,"context_line":"            body[self.resource][\u0027direction\u0027] \u003d \u0027bi\u0027"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        return body"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_8db20405","line":706,"in_reply_to":"ba8a016a_6376eca5","updated":"2015-11-18 17:58:40.000000000","message":"This is not required, this part has always worked because the backend defaults to using None when protocol attribute is not specified:\n\n  stack@gbpj1:~/python-gbpclient$ gbp policy-classifier-create empty-protocol\n  Created a new policy_classifier:\n  +-------------+--------------------------------------+\n  | Field       | Value                                |\n  +-------------+--------------------------------------+\n  | description |                                      |\n  | direction   | bi                                   |\n  | id          | 366b6d8a-c8fd-405b-8bd5-814c246ee06e |\n  | name        | empty-protocol                       |\n  | port_range  |                                      |\n  | protocol    |                                      |\n  | shared      | False                                |\n  | tenant_id   | 98e85007e7e54b28bab2146fe52df91e     |\n  +-------------+--------------------------------------+","commit_id":"0f2241fbb62123f2df096d35d7b2e1aa2d6336bc"},{"author":{"_account_id":10965,"name":"Magesh GV","email":"mageshgv@gmail.com","username":"mageshgv"},"change_message_id":"5832b7f4c2de1a4c959b95843e9ae26112407772","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                                \u0027protocol\u0027, \u0027port_range\u0027,"},{"line_number":753,"context_line":"                                \u0027direction\u0027, \u0027shared\u0027])"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        if parsed_args.protocol in [\u0027any\u0027, \u0027\u0027]:"},{"line_number":756,"context_line":"            body[self.resource][\u0027protocol\u0027] \u003d None"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        if parsed_args.port_range \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_43a888db","line":755,"updated":"2015-11-18 10:22:01.000000000","message":"\"any\" is not added as an allowed choice earlier (also in create).","commit_id":"0f2241fbb62123f2df096d35d7b2e1aa2d6336bc"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"864408d878f42fb9b65bd49ce41158274051d02d","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                                \u0027protocol\u0027, \u0027port_range\u0027,"},{"line_number":753,"context_line":"                                \u0027direction\u0027, \u0027shared\u0027])"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        if parsed_args.protocol in [\u0027any\u0027, \u0027\u0027]:"},{"line_number":756,"context_line":"            body[self.resource][\u0027protocol\u0027] \u003d None"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        if parsed_args.port_range \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_d9752098","line":755,"in_reply_to":"ba8a016a_43a888db","updated":"2015-11-18 23:22:08.000000000","message":"Actually I did not intend support \"any\" (since the \"any\" will not be reflected in the response body of the resource\u0027s protocol attribute value). I will remove this in the follow up patch.","commit_id":"0f2241fbb62123f2df096d35d7b2e1aa2d6336bc"}]}
