)]}'
{"oneview_client/client.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"3e9d920c0b0aefb0a44c0c03613a45f305f13886","unresolved":false,"context_lines":[{"line_number":537,"context_line":"    def get_sh_mac_from_ilo(self, server_hardware_uuid, index\u003d0):"},{"line_number":538,"context_line":"        host_ip, ilo_token \u003d self._get_ilo_access(server_hardware_uuid)"},{"line_number":539,"context_line":"        try:"},{"line_number":540,"context_line":"            return ilo_utils.get_mac_for_ilo(host_ip, ilo_token, index)"},{"line_number":541,"context_line":"        finally:"},{"line_number":542,"context_line":"            ilo_utils.ilo_logout(host_ip, ilo_token)"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_803bd69b","line":540,"updated":"2016-03-02 15:34:11.000000000","message":"I\u0027d rename index as nicIndex.","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"088c35eae4d4334a8c3e9a4433ed1d192736da15","unresolved":false,"context_lines":[{"line_number":537,"context_line":"    def get_sh_mac_from_ilo(self, server_hardware_uuid, index\u003d0):"},{"line_number":538,"context_line":"        host_ip, ilo_token \u003d self._get_ilo_access(server_hardware_uuid)"},{"line_number":539,"context_line":"        try:"},{"line_number":540,"context_line":"            return ilo_utils.get_mac_for_ilo(host_ip, ilo_token, index)"},{"line_number":541,"context_line":"        finally:"},{"line_number":542,"context_line":"            ilo_utils.ilo_logout(host_ip, ilo_token)"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_6f482488","line":540,"in_reply_to":"7af24918_803bd69b","updated":"2016-03-02 19:48:34.000000000","message":"is nic_index fine? Python only use CamelCase on class naming.","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"dfdba089bf754158dc73217ac7e0ce696f1bac58","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            node_info"},{"line_number":349,"context_line":"        )"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        primary_boot_connection \u003d None"},{"line_number":352,"context_line":"        if server_profile.connections:"},{"line_number":353,"context_line":"            for connection in server_profile.connections:"},{"line_number":354,"context_line":"                boot \u003d connection.get(\u0027boot\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_f27d3bb2","line":351,"updated":"2016-03-02 19:54:10.000000000","message":"Please move this variable declaration into the if statement below as it is only used there.","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"442f6505723774e366da58fa838302336762846c","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            node_info"},{"line_number":349,"context_line":"        )"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        primary_boot_connection \u003d None"},{"line_number":352,"context_line":"        if server_profile.connections:"},{"line_number":353,"context_line":"            for connection in server_profile.connections:"},{"line_number":354,"context_line":"                boot \u003d connection.get(\u0027boot\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_08319605","line":351,"in_reply_to":"7af24918_f27d3bb2","updated":"2016-03-02 20:27:06.000000000","message":"Done","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"dfdba089bf754158dc73217ac7e0ce696f1bac58","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            mac \u003d primary_boot_connection.get(\u0027mac\u0027)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        else:"},{"line_number":369,"context_line":"            # If no connections on Server Profile, server is rack based."},{"line_number":370,"context_line":"            # Fall back to 1st nic"},{"line_number":371,"context_line":"            server_hardware \u003d self.get_server_hardware(node_info)"},{"line_number":372,"context_line":"            mac \u003d self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_05921f9e","line":369,"updated":"2016-03-02 19:54:10.000000000","message":"Or networking is set to unmanaged --  I think this can be the case with the server profile.","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"442f6505723774e366da58fa838302336762846c","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            mac \u003d primary_boot_connection.get(\u0027mac\u0027)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        else:"},{"line_number":369,"context_line":"            # If no connections on Server Profile, server is rack based."},{"line_number":370,"context_line":"            # Fall back to 1st nic"},{"line_number":371,"context_line":"            server_hardware \u003d self.get_server_hardware(node_info)"},{"line_number":372,"context_line":"            mac \u003d self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_03ca176d","line":369,"in_reply_to":"7af24918_05921f9e","updated":"2016-03-02 20:27:06.000000000","message":"You\u0027re right. Changing the comment.","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"dfdba089bf754158dc73217ac7e0ce696f1bac58","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        else:"},{"line_number":369,"context_line":"            # If no connections on Server Profile, server is rack based."},{"line_number":370,"context_line":"            # Fall back to 1st nic"},{"line_number":371,"context_line":"            server_hardware \u003d self.get_server_hardware(node_info)"},{"line_number":372,"context_line":"            mac \u003d self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_b208d32e","line":370,"updated":"2016-03-02 19:54:10.000000000","message":"... from iLO.","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"442f6505723774e366da58fa838302336762846c","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        else:"},{"line_number":369,"context_line":"            # If no connections on Server Profile, server is rack based."},{"line_number":370,"context_line":"            # Fall back to 1st nic"},{"line_number":371,"context_line":"            server_hardware \u003d self.get_server_hardware(node_info)"},{"line_number":372,"context_line":"            mac \u003d self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_c80dee3f","line":370,"in_reply_to":"7af24918_b208d32e","updated":"2016-03-02 20:27:06.000000000","message":"Done","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"dfdba089bf754158dc73217ac7e0ce696f1bac58","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            # If no connections on Server Profile, server is rack based."},{"line_number":370,"context_line":"            # Fall back to 1st nic"},{"line_number":371,"context_line":"            server_hardware \u003d self.get_server_hardware(node_info)"},{"line_number":372,"context_line":"            mac \u003d self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        is_mac_address_compatible \u003d True"},{"line_number":375,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_e5473349","line":372,"updated":"2016-03-02 19:54:10.000000000","message":"What happens if iLO cannot get the mac address? I think we should warn the user it could not read the ports from OneView but keep things moving with the ports that are registered.\n\nIf it is not feasible to do now, please let me know so I will register the issue.","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"442f6505723774e366da58fa838302336762846c","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            # If no connections on Server Profile, server is rack based."},{"line_number":370,"context_line":"            # Fall back to 1st nic"},{"line_number":371,"context_line":"            server_hardware \u003d self.get_server_hardware(node_info)"},{"line_number":372,"context_line":"            mac \u003d self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        is_mac_address_compatible \u003d True"},{"line_number":375,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_c314af45","line":372,"in_reply_to":"7af24918_e5473349","updated":"2016-03-02 20:27:06.000000000","message":"It raises IloException and the consumer of the library can choose how to proceed.\nThere is no way to warn a user inside the lib as we do not know how the consumer service is handling logs.","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"dfdba089bf754158dc73217ac7e0ce696f1bac58","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            first_physical_port \u003d server_hardware.get_mac(nic_index\u003d0)"},{"line_number":396,"context_line":"            mac \u003d first_physical_port.get(\u0027mac\u0027).lower()"},{"line_number":397,"context_line":"        except exceptions.OneViewException:"},{"line_number":398,"context_line":"            self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        is_mac_address_compatible \u003d True"},{"line_number":401,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_e5c0d32c","line":398,"updated":"2016-03-02 19:54:10.000000000","message":"I think you should have assigned to \"mac\" here: \"mac \u003d \".","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"442f6505723774e366da58fa838302336762846c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            first_physical_port \u003d server_hardware.get_mac(nic_index\u003d0)"},{"line_number":396,"context_line":"            mac \u003d first_physical_port.get(\u0027mac\u0027).lower()"},{"line_number":397,"context_line":"        except exceptions.OneViewException:"},{"line_number":398,"context_line":"            self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        is_mac_address_compatible \u003d True"},{"line_number":401,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_839aa761","line":398,"in_reply_to":"7af24918_e5c0d32c","updated":"2016-03-02 20:27:06.000000000","message":"Done","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"dfdba089bf754158dc73217ac7e0ce696f1bac58","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            mac \u003d first_physical_port.get(\u0027mac\u0027).lower()"},{"line_number":397,"context_line":"        except exceptions.OneViewException:"},{"line_number":398,"context_line":"            self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        is_mac_address_compatible \u003d True"},{"line_number":401,"context_line":"        for port in ports:"},{"line_number":402,"context_line":"            port_address \u003d port.__dict__.get(\u0027_obj_address\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_c555d750","line":399,"updated":"2016-03-02 19:54:10.000000000","message":"The same as for line 372 holds here. What happens if neither OneView nor iLO can retrieve the mac address?","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"442f6505723774e366da58fa838302336762846c","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            mac \u003d first_physical_port.get(\u0027mac\u0027).lower()"},{"line_number":397,"context_line":"        except exceptions.OneViewException:"},{"line_number":398,"context_line":"            self.get_sh_mac_from_ilo(server_hardware.uuid, nic_index\u003d0)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        is_mac_address_compatible \u003d True"},{"line_number":401,"context_line":"        for port in ports:"},{"line_number":402,"context_line":"            port_address \u003d port.__dict__.get(\u0027_obj_address\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_2393d350","line":399,"in_reply_to":"7af24918_c555d750","updated":"2016-03-02 20:27:06.000000000","message":"Replied on line 372.","commit_id":"4f9516961fab7b3b369eee09586b783e8278d0a9"}],"oneview_client/ilo_utils.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"3e9d920c0b0aefb0a44c0c03613a45f305f13886","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2015 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"# Copyright 2015 Universidade Federal de Campina Grande"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_a02c1203","line":1,"updated":"2016-03-02 15:34:11.000000000","message":"I think you should leave a reference for the place where this code has been taken from. This way we can track whether it has been updated in the origin, for example.","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"088c35eae4d4334a8c3e9a4433ed1d192736da15","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2015 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"# Copyright 2015 Universidade Federal de Campina Grande"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_b20f332d","line":1,"in_reply_to":"7af24918_a02c1203","updated":"2016-03-02 19:48:34.000000000","message":"How can we do that without breaking the header format?","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"3e9d920c0b0aefb0a44c0c03613a45f305f13886","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        raise exceptions.IloException(\"HTTP %s\" % status)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def get_mac_for_ilo(host_ip, x_auth_token, index\u003d0):"},{"line_number":147,"context_line":"    # for each system in the systems collection at /rest/v1/Systems"},{"line_number":148,"context_line":"    ilo_hardware \u003d collection(host_ip, \u0027/rest/v1/Systems\u0027, None,"},{"line_number":149,"context_line":"                              x_auth_token, enforce_SSL\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_003ce62d","line":146,"updated":"2016-03-02 15:34:11.000000000","message":"I\u0027d rename this as get_mac_from_ilo. About the \"index\" parameter, ditto in client code.","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"088c35eae4d4334a8c3e9a4433ed1d192736da15","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        raise exceptions.IloException(\"HTTP %s\" % status)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def get_mac_for_ilo(host_ip, x_auth_token, index\u003d0):"},{"line_number":147,"context_line":"    # for each system in the systems collection at /rest/v1/Systems"},{"line_number":148,"context_line":"    ilo_hardware \u003d collection(host_ip, \u0027/rest/v1/Systems\u0027, None,"},{"line_number":149,"context_line":"                              x_auth_token, enforce_SSL\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_b22293ff","line":146,"in_reply_to":"7af24918_003ce62d","updated":"2016-03-02 19:48:34.000000000","message":"Done","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"3e9d920c0b0aefb0a44c0c03613a45f305f13886","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               get_type(system) \u003d\u003d \u0027ComputerSystem.1\u0027)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if \u0027HostMACAddress\u0027 not in system[\u0027HostCorrelation\u0027]:"},{"line_number":159,"context_line":"            print(\u0027\\tNIC resource does not contain \"MacAddress\" property\u0027)"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            # Can have more than a link"},{"line_number":162,"context_line":"            return system[\u0027HostCorrelation\u0027][\u0027HostMACAddress\u0027][index]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_c0ecbe91","line":159,"updated":"2016-03-02 15:34:11.000000000","message":"Shouldn\u0027t this throw an exception instead of printing?","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"088c35eae4d4334a8c3e9a4433ed1d192736da15","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               get_type(system) \u003d\u003d \u0027ComputerSystem.1\u0027)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if \u0027HostMACAddress\u0027 not in system[\u0027HostCorrelation\u0027]:"},{"line_number":159,"context_line":"            print(\u0027\\tNIC resource does not contain \"MacAddress\" property\u0027)"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            # Can have more than a link"},{"line_number":162,"context_line":"            return system[\u0027HostCorrelation\u0027][\u0027HostMACAddress\u0027][index]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_72712be0","line":159,"in_reply_to":"7af24918_c0ecbe91","updated":"2016-03-02 19:48:34.000000000","message":"Done","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"3e9d920c0b0aefb0a44c0c03613a45f305f13886","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        if member.get(\u0027Oem\u0027).get(\u0027Hp\u0027).get(\u0027MySession\u0027) is True:"},{"line_number":170,"context_line":"            status, headers, member \u003d rest_delete(host_ip, memberuri, None,"},{"line_number":171,"context_line":"                                                  x_auth_token, False)"},{"line_number":172,"context_line":"            assert(status \u003d\u003d 200)"},{"line_number":173,"context_line":"            return status, member"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_e0457a70","line":172,"updated":"2016-03-02 15:34:11.000000000","message":"Shouldn\u0027t this be an exception from our exception module?","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"088c35eae4d4334a8c3e9a4433ed1d192736da15","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        if member.get(\u0027Oem\u0027).get(\u0027Hp\u0027).get(\u0027MySession\u0027) is True:"},{"line_number":170,"context_line":"            status, headers, member \u003d rest_delete(host_ip, memberuri, None,"},{"line_number":171,"context_line":"                                                  x_auth_token, False)"},{"line_number":172,"context_line":"            assert(status \u003d\u003d 200)"},{"line_number":173,"context_line":"            return status, member"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_d278ffc6","line":172,"in_reply_to":"7af24918_e0457a70","updated":"2016-03-02 19:48:34.000000000","message":"Done","commit_id":"9b99a66925613839613eac00c110252412870e50"}],"oneview_client/models.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"3e9d920c0b0aefb0a44c0c03613a45f305f13886","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        \u0027processorCoreCount\u0027: \u0027processor_core_count\u0027,"},{"line_number":71,"context_line":"        \u0027memoryMb\u0027: \u0027memory_mb\u0027,"},{"line_number":72,"context_line":"        \u0027portMap\u0027: \u0027port_map\u0027,"},{"line_number":73,"context_line":"        \u0027mpHostInfo\u0027: \u0027host_info\u0027,"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_mac(self, index\u003d0):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_031d100f","line":73,"updated":"2016-03-02 15:34:11.000000000","message":"I\u0027d keep it as mp_host_info in the python side instead. This mp prefix makes host_info specific. Management Processor is too long for a variable name, though \"mp\" is enough to be recognized on the API documentation.","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"088c35eae4d4334a8c3e9a4433ed1d192736da15","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        \u0027processorCoreCount\u0027: \u0027processor_core_count\u0027,"},{"line_number":71,"context_line":"        \u0027memoryMb\u0027: \u0027memory_mb\u0027,"},{"line_number":72,"context_line":"        \u0027portMap\u0027: \u0027port_map\u0027,"},{"line_number":73,"context_line":"        \u0027mpHostInfo\u0027: \u0027host_info\u0027,"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_mac(self, index\u003d0):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_125a674f","line":73,"in_reply_to":"7af24918_031d100f","updated":"2016-03-02 19:48:34.000000000","message":"Done","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"3e9d920c0b0aefb0a44c0c03613a45f305f13886","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \u0027mpHostInfo\u0027: \u0027host_info\u0027,"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_mac(self, index\u003d0):"},{"line_number":77,"context_line":"        if self.port_map:"},{"line_number":78,"context_line":"            device \u003d self.port_map.get(\u0027deviceSlots\u0027)[0]"},{"line_number":79,"context_line":"            physical_port \u003d device.get(\u0027physicalPorts\u0027)[index]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_c3b848e8","line":76,"updated":"2016-03-02 15:34:11.000000000","message":"s/index/nicIndex/","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"088c35eae4d4334a8c3e9a4433ed1d192736da15","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \u0027mpHostInfo\u0027: \u0027host_info\u0027,"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_mac(self, index\u003d0):"},{"line_number":77,"context_line":"        if self.port_map:"},{"line_number":78,"context_line":"            device \u003d self.port_map.get(\u0027deviceSlots\u0027)[0]"},{"line_number":79,"context_line":"            physical_port \u003d device.get(\u0027physicalPorts\u0027)[index]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_52198f87","line":76,"in_reply_to":"7af24918_c3b848e8","updated":"2016-03-02 19:48:34.000000000","message":"Done","commit_id":"9b99a66925613839613eac00c110252412870e50"}],"oneview_client/tests/test_models.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"3e9d920c0b0aefb0a44c0c03613a45f305f13886","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(sh.uuid, \u00271111-2222-3333-4444\u0027)"},{"line_number":119,"context_line":"        self.assertEqual(sh.power_state, \u0027Powered On\u0027)"},{"line_number":120,"context_line":"        self.assertEqual(sh.state_reason, \u0027something5\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_serverprofiletemplate_from_json(self):"},{"line_number":123,"context_line":"        json \u003d {"},{"line_number":124,"context_line":"            \u0027uri\u0027: \u0027http://something.com/1111-2222-3333-4444\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_634b34ca","line":121,"updated":"2016-03-02 15:34:11.000000000","message":"No tests for mpHostInfo?","commit_id":"9b99a66925613839613eac00c110252412870e50"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"088c35eae4d4334a8c3e9a4433ed1d192736da15","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(sh.uuid, \u00271111-2222-3333-4444\u0027)"},{"line_number":119,"context_line":"        self.assertEqual(sh.power_state, \u0027Powered On\u0027)"},{"line_number":120,"context_line":"        self.assertEqual(sh.state_reason, \u0027something5\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_serverprofiletemplate_from_json(self):"},{"line_number":123,"context_line":"        json \u003d {"},{"line_number":124,"context_line":"            \u0027uri\u0027: \u0027http://something.com/1111-2222-3333-4444\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_25a59bb4","line":121,"in_reply_to":"7af24918_634b34ca","updated":"2016-03-02 19:48:34.000000000","message":"Done","commit_id":"9b99a66925613839613eac00c110252412870e50"}]}
