)]}'
{"oneview_client/client.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"64a3ae424fa1f4c1941c93c1a21ae9ea4a0fb13a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    # -- Uplink Set ---"},{"line_number":148,"context_line":"    def get_uplink_set(self, uuid):"},{"line_number":149,"context_line":"        uplink_set_uri \u003d _uri_from_uuid(UPLINK_SET_PREFIX_URI, uuid)"},{"line_number":150,"context_line":"        return self._prepare_and_do_request(uri\u003duplink_set_uri)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def add_network_to_uplink_set(self, uplink_set_uuid, network_uuid):"},{"line_number":153,"context_line":"        uplink_set_uri \u003d _uri_from_uuid(UPLINK_SET_PREFIX_URI, uplink_set_uuid)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_d947e775","line":150,"updated":"2016-05-23 20:26:15.000000000","message":"Please, add UplinkSet to models.py","commit_id":"5cb039b34ecef2fa1d41bd333cecf1b5695c914c"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"fa369354852b35c3d2ee291975e074600b86e1c6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    # -- Uplink Set ---"},{"line_number":148,"context_line":"    def get_uplink_set(self, uuid):"},{"line_number":149,"context_line":"        uplink_set_uri \u003d _uri_from_uuid(UPLINK_SET_PREFIX_URI, uuid)"},{"line_number":150,"context_line":"        return self._prepare_and_do_request(uri\u003duplink_set_uri)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def add_network_to_uplink_set(self, uplink_set_uuid, network_uuid):"},{"line_number":153,"context_line":"        uplink_set_uri \u003d _uri_from_uuid(UPLINK_SET_PREFIX_URI, uplink_set_uuid)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9abb7d3a_baaa9a83","line":150,"in_reply_to":"bab6814e_d947e775","updated":"2016-06-03 12:17:51.000000000","message":"Done","commit_id":"5cb039b34ecef2fa1d41bd333cecf1b5695c914c"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"64a3ae424fa1f4c1941c93c1a21ae9ea4a0fb13a","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            \"fcNetworkUris\": uplink_set_json.get(\"fcNetworkUris\"),"},{"line_number":170,"context_line":"            \"eTag\": uplink_set_json.get(\u0027eTag\u0027),"},{"line_number":171,"context_line":"            \"ethernetNetworkType\": uplink_set_json.get(\"ethernetNetworkType\")"},{"line_number":172,"context_line":"        }"},{"line_number":173,"context_line":"        task \u003d self._prepare_and_do_request("},{"line_number":174,"context_line":"            uri\u003duplink_set_uri, body\u003duplink_set_update_json,"},{"line_number":175,"context_line":"            request_type\u003dPUT_REQUEST_TYPE"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_5902d70c","line":172,"updated":"2016-05-23 20:26:15.000000000","message":"Simplify this by using UplinkSet in models.py, parsing it with its from_json, updating the field that needs to be updated and generating the output with its to_json (or whatever the pattern is).","commit_id":"5cb039b34ecef2fa1d41bd333cecf1b5695c914c"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"fa369354852b35c3d2ee291975e074600b86e1c6","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            \"fcNetworkUris\": uplink_set_json.get(\"fcNetworkUris\"),"},{"line_number":170,"context_line":"            \"eTag\": uplink_set_json.get(\u0027eTag\u0027),"},{"line_number":171,"context_line":"            \"ethernetNetworkType\": uplink_set_json.get(\"ethernetNetworkType\")"},{"line_number":172,"context_line":"        }"},{"line_number":173,"context_line":"        task \u003d self._prepare_and_do_request("},{"line_number":174,"context_line":"            uri\u003duplink_set_uri, body\u003duplink_set_update_json,"},{"line_number":175,"context_line":"            request_type\u003dPUT_REQUEST_TYPE"}],"source_content_type":"text/x-python","patch_set":13,"id":"9abb7d3a_9aafd693","line":172,"in_reply_to":"bab6814e_5902d70c","updated":"2016-06-03 12:17:51.000000000","message":"Done","commit_id":"5cb039b34ecef2fa1d41bd333cecf1b5695c914c"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"e728d346213065aa41b811f83811c8a155b5e101","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            self"},{"line_number":260,"context_line":"        )"},{"line_number":261,"context_line":"        self.ethernet_network \u003d managers.EthernetNetworkManager(self)"},{"line_number":262,"context_line":"        self.uplinkset \u003d managers.UplinkSetManager(self)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"class Client(BaseClient):"}],"source_content_type":"text/x-python","patch_set":25,"id":"dada55a8_b07b35bd","line":262,"updated":"2016-07-21 20:18:13.000000000","message":"s/uplinkset/uplink_set/","commit_id":"9cbd726fba3a03759f549ba584532c9e094b5a37"}],"oneview_client/managers.py":[{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"6327c895b78dc464f1f365acf2d561ee555a6479","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            )"},{"line_number":351,"context_line":"            return task_completed.get(\u0027associatedResource\u0027).get(\u0027resourceUri\u0027)"},{"line_number":352,"context_line":"        except exceptions.OneViewTaskError as e:"},{"line_number":353,"context_line":"            raise exceptions.OneViewErrorCreatingNetwork(e.message)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_2d5e9076","line":353,"range":{"start_line":353,"start_character":29,"end_line":353,"end_character":56},"updated":"2016-06-09 17:40:05.000000000","message":"ctrl c ctrl v error, gonna fix it.","commit_id":"06c1472578ee9fb3225af0e53387f1da58b09348"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"7cec1860313e9b868e4da94d484186e493f2cd60","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    uri_prefix \u003d \u0027/rest/uplink-sets/\u0027"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def create(self, **kwargs):"},{"line_number":331,"context_line":"        raise NotImplementedError(\"ServerProfileTemplate isn\u0027t supposed to be \""},{"line_number":332,"context_line":"                                  \"created.\")"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def delete(self, uuid):"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a9d85d2_165b0256","line":331,"range":{"start_line":331,"start_character":35,"end_line":331,"end_character":56},"updated":"2016-06-19 05:25:53.000000000","message":"UplinkSet","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"f59ccae6c36d4786c7d53842aa81ea7f95fc919e","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    uri_prefix \u003d \u0027/rest/uplink-sets/\u0027"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def create(self, **kwargs):"},{"line_number":331,"context_line":"        raise NotImplementedError(\"ServerProfileTemplate isn\u0027t supposed to be \""},{"line_number":332,"context_line":"                                  \"created.\")"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def delete(self, uuid):"}],"source_content_type":"text/x-python","patch_set":21,"id":"3aaa91ec_7dbb380f","line":331,"range":{"start_line":331,"start_character":35,"end_line":331,"end_character":56},"in_reply_to":"5a9d85d2_165b0256","updated":"2016-06-21 20:15:48.000000000","message":"Done","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"7cec1860313e9b868e4da94d484186e493f2cd60","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                                  \"created.\")"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def delete(self, uuid):"},{"line_number":335,"context_line":"        raise NotImplementedError(\"ServerProfileTemplate isn\u0027t supposed to be \""},{"line_number":336,"context_line":"                                  \"deleted.\")"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def add_network(self, uplink_set_uuid, network_uuid):"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a9d85d2_76588657","line":335,"range":{"start_line":335,"start_character":35,"end_line":335,"end_character":56},"updated":"2016-06-19 05:25:53.000000000","message":"UplinkSet","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"f59ccae6c36d4786c7d53842aa81ea7f95fc919e","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                                  \"created.\")"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def delete(self, uuid):"},{"line_number":335,"context_line":"        raise NotImplementedError(\"ServerProfileTemplate isn\u0027t supposed to be \""},{"line_number":336,"context_line":"                                  \"deleted.\")"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def add_network(self, uplink_set_uuid, network_uuid):"}],"source_content_type":"text/x-python","patch_set":21,"id":"3aaa91ec_9dbee4fd","line":335,"range":{"start_line":335,"start_character":35,"end_line":335,"end_character":56},"in_reply_to":"5a9d85d2_76588657","updated":"2016-06-21 20:15:48.000000000","message":"Done","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"7cec1860313e9b868e4da94d484186e493f2cd60","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        raise NotImplementedError(\"ServerProfileTemplate isn\u0027t supposed to be \""},{"line_number":336,"context_line":"                                  \"deleted.\")"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def add_network(self, uplink_set_uuid, network_uuid):"},{"line_number":339,"context_line":"        network_uri \u003d EthernetNetworkManager.uri_prefix + network_uuid"},{"line_number":340,"context_line":"        uplink_set \u003d self.get(uplink_set_uuid)"},{"line_number":341,"context_line":"        uplink_set.add_network(network_uri)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a9d85d2_e124aeb0","line":338,"range":{"start_line":338,"start_character":26,"end_line":338,"end_character":41},"updated":"2016-06-19 05:25:53.000000000","message":"My way of thinking about this would be to receive an UplinkSet instance here.\n\nActually, I\u0027d have just an update function and have the clients using the add_network from the model, as is done on lines 341.\n\n@author: do the current driver implementation have the UplinkSet instance when it calls this method? If so, it would save a new get, to begin with.\n\n@thiagop: is there any pattern the clients already follow here?","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"f59ccae6c36d4786c7d53842aa81ea7f95fc919e","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        raise NotImplementedError(\"ServerProfileTemplate isn\u0027t supposed to be \""},{"line_number":336,"context_line":"                                  \"deleted.\")"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def add_network(self, uplink_set_uuid, network_uuid):"},{"line_number":339,"context_line":"        network_uri \u003d EthernetNetworkManager.uri_prefix + network_uuid"},{"line_number":340,"context_line":"        uplink_set \u003d self.get(uplink_set_uuid)"},{"line_number":341,"context_line":"        uplink_set.add_network(network_uri)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3aaa91ec_9d06e41e","line":338,"range":{"start_line":338,"start_character":26,"end_line":338,"end_character":41},"in_reply_to":"5a9d85d2_e124aeb0","updated":"2016-06-21 20:15:48.000000000","message":"We don\u0027t have the uplinkset to use this function, just the uuid.\nThe add_network from the model does not save the object in OneView, neither the models have access to the OneView.","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"7cec1860313e9b868e4da94d484186e493f2cd60","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                                  \"deleted.\")"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def add_network(self, uplink_set_uuid, network_uuid):"},{"line_number":339,"context_line":"        network_uri \u003d EthernetNetworkManager.uri_prefix + network_uuid"},{"line_number":340,"context_line":"        uplink_set \u003d self.get(uplink_set_uuid)"},{"line_number":341,"context_line":"        uplink_set.add_network(network_uri)"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5a9d85d2_2110764e","line":339,"updated":"2016-06-19 05:25:53.000000000","message":"Please reuse the appropriate method. I believe it has already been merged.\n\nEven if not, please make this a least a class function from EthernetNetworkManager and avoid leaking the knowledge about how to build a network_uri from a network_uuid.","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"f59ccae6c36d4786c7d53842aa81ea7f95fc919e","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                                  \"deleted.\")"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def add_network(self, uplink_set_uuid, network_uuid):"},{"line_number":339,"context_line":"        network_uri \u003d EthernetNetworkManager.uri_prefix + network_uuid"},{"line_number":340,"context_line":"        uplink_set \u003d self.get(uplink_set_uuid)"},{"line_number":341,"context_line":"        uplink_set.add_network(network_uri)"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3aaa91ec_dddcec1a","line":339,"in_reply_to":"5a9d85d2_2110764e","updated":"2016-06-21 20:15:48.000000000","message":"I wasn\u0027t merged https://github.com/openstack/python-oneviewclient/blob/master/oneview_client/utils.py","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"}],"oneview_client/models.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"7cec1860313e9b868e4da94d484186e493f2cd60","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    def add_network(self, network_uri):"},{"line_number":209,"context_line":"        self.network_uris.append(network_uri)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def to_oneview_dict(self):"},{"line_number":212,"context_line":"        uplink_set_dict \u003d {}"},{"line_number":213,"context_line":"        for attr_key in self.__dict__.keys():"},{"line_number":214,"context_line":"            attribute_value \u003d getattr(self, str(attr_key))"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a9d85d2_2137d6e4","line":211,"updated":"2016-06-19 05:25:53.000000000","message":"Repeated code, again. Please follow the boy scout rule: http://programmer.97things.oreilly.com/wiki/index.php/The_Boy_Scout_Rule","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"f59ccae6c36d4786c7d53842aa81ea7f95fc919e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    def add_network(self, network_uri):"},{"line_number":209,"context_line":"        self.network_uris.append(network_uri)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def to_oneview_dict(self):"},{"line_number":212,"context_line":"        uplink_set_dict \u003d {}"},{"line_number":213,"context_line":"        for attr_key in self.__dict__.keys():"},{"line_number":214,"context_line":"            attribute_value \u003d getattr(self, str(attr_key))"}],"source_content_type":"text/x-python","patch_set":21,"id":"3aaa91ec_1dcaf4a1","line":211,"in_reply_to":"5a9d85d2_2137d6e4","updated":"2016-06-21 20:15:48.000000000","message":"Done","commit_id":"56a2a08cd009dcccb09b6bd3990e79b2368ac959"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"e728d346213065aa41b811f83811c8a155b5e101","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    }"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def add_network(self, network_uri):"},{"line_number":220,"context_line":"        self.network_uris.append(network_uri)"}],"source_content_type":"text/x-python","patch_set":25,"id":"dada55a8_d0050914","line":220,"updated":"2016-07-21 20:18:13.000000000","message":"What if the network is already there? Shouldn\u0027t this be a set? Or remove the network -- if it is there -- then add it back again?","commit_id":"9cbd726fba3a03759f549ba584532c9e094b5a37"}]}