)]}'
{"oneview_client/client.py":[{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"ce88eafb6b2a5b4e7c39dc167b33d6459c3d7834","unresolved":false,"context_lines":[{"line_number":44,"context_line":"SERVER_PROFILE_TEMPLATE_PREFIX_URI \u003d \u0027/rest/server-profile-templates/\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _get_oneview_resource_uuid_from_resource_uri(uri):"},{"line_number":48,"context_line":"    return uri.split(\"/\")[-1]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_2f98b8bf","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":48},"updated":"2016-04-06 20:33:48.000000000","message":"I\u0027d name it _get_resource_uuid_from_uri","commit_id":"f797d029180acbb911de3d3c4acb049bdabfe422"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"71ad7549a1f606e5eea793976314e758a018795e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"SERVER_PROFILE_TEMPLATE_PREFIX_URI \u003d \u0027/rest/server-profile-templates/\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _get_oneview_resource_uuid_from_resource_uri(uri):"},{"line_number":48,"context_line":"    return uri.split(\"/\")[-1]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_1b63081c","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":48},"in_reply_to":"9a061dce_2f98b8bf","updated":"2016-04-12 12:44:53.000000000","message":"Done. And renamed to _uuid_from_uri","commit_id":"f797d029180acbb911de3d3c4acb049bdabfe422"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"ce88eafb6b2a5b4e7c39dc167b33d6459c3d7834","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    return uri.split(\"/\")[-1]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_oneview_resource_uri_from_resource_uuid(resource_prefix, uuid):"},{"line_number":52,"context_line":"    return resource_prefix + uuid"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_0f95f485","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":48},"updated":"2016-04-06 20:33:48.000000000","message":"ditto","commit_id":"f797d029180acbb911de3d3c4acb049bdabfe422"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"71ad7549a1f606e5eea793976314e758a018795e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    return uri.split(\"/\")[-1]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def _get_oneview_resource_uri_from_resource_uuid(resource_prefix, uuid):"},{"line_number":52,"context_line":"    return resource_prefix + uuid"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_fb672c23","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":48},"in_reply_to":"9a061dce_0f95f485","updated":"2016-04-12 12:44:53.000000000","message":"Done","commit_id":"f797d029180acbb911de3d3c4acb049bdabfe422"}],"oneview_client/tests/unit/test_oneview_client.py":[{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"661efbe5b732e1a9f5fc462019f912be3fc56ece","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"        yield status, headers, system, memberuri"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"class OneViewClientFunctionsTestCase(unittest.TestCase):"},{"line_number":1063,"context_line":"    def test__uuid_from_uri(self):"},{"line_number":1064,"context_line":"        expected_resource_uuid \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":1065,"context_line":"        resource_uri \u003d \u0027/rest/resource/\u0027 + expected_resource_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_7f178351","line":1062,"range":{"start_line":1062,"start_character":0,"end_line":1062,"end_character":56},"updated":"2016-04-12 13:56:37.000000000","message":"Please, add negative test cases for malformed URI\u0027s and validate the extracted URI\u0027s (https://gist.github.com/ShawnMilo/7777304)","commit_id":"666df4cd63f2318188e32a268f4202a00d763056"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"ed7f745fad6652637e9dbeb858a81f35c82dbe76","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"        yield status, headers, system, memberuri"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"class OneViewClientFunctionsTestCase(unittest.TestCase):"},{"line_number":1063,"context_line":"    def test__uuid_from_uri(self):"},{"line_number":1064,"context_line":"        expected_resource_uuid \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":1065,"context_line":"        resource_uri \u003d \u0027/rest/resource/\u0027 + expected_resource_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_94903945","line":1062,"range":{"start_line":1062,"start_character":0,"end_line":1062,"end_character":56},"in_reply_to":"5a18252c_59089a2c","updated":"2016-04-13 17:06:58.000000000","message":"The following code would do a request to check it. It is undesirable.","commit_id":"666df4cd63f2318188e32a268f4202a00d763056"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"a2649e35fd30ae9dbe563e534afb64745a21dbb6","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"        yield status, headers, system, memberuri"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"class OneViewClientFunctionsTestCase(unittest.TestCase):"},{"line_number":1063,"context_line":"    def test__uuid_from_uri(self):"},{"line_number":1064,"context_line":"        expected_resource_uuid \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":1065,"context_line":"        resource_uri \u003d \u0027/rest/resource/\u0027 + expected_resource_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_59089a2c","line":1062,"range":{"start_line":1062,"start_character":0,"end_line":1062,"end_character":56},"in_reply_to":"5a18252c_7f178351","updated":"2016-04-13 16:58:51.000000000","message":"Is it really necessary, since when the code gets an invalid UUID or URI, the following code will throws an exception anyway?","commit_id":"666df4cd63f2318188e32a268f4202a00d763056"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"bc40a55de29d95aaf8e2b1e7c1e87867651e4537","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"        yield status, headers, system, memberuri"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"class OneViewClientFunctionsTestCase(unittest.TestCase):"},{"line_number":1063,"context_line":"    def test__uuid_from_uri(self):"},{"line_number":1064,"context_line":"        expected_resource_uuid \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":1065,"context_line":"        resource_uri \u003d \u0027/rest/resource/\u0027 + expected_resource_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_b2ac64a1","line":1062,"range":{"start_line":1062,"start_character":0,"end_line":1062,"end_character":56},"in_reply_to":"5a18252c_94903945","updated":"2016-04-13 17:59:11.000000000","message":"I don\u0027t see the point in validating the uuid, since a malformed uuid will be treat the same way as a non existing uuid. It just add complexity to a function that should be really simple.","commit_id":"666df4cd63f2318188e32a268f4202a00d763056"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"469bd1bb89bac655635f6a502750339367a5ffc5","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"        yield status, headers, system, memberuri"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"class OneViewClientFunctionsTestCase(unittest.TestCase):"},{"line_number":1063,"context_line":"    def test__uuid_from_uri(self):"},{"line_number":1064,"context_line":"        expected_resource_uuid \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":1065,"context_line":"        resource_uri \u003d \u0027/rest/resource/\u0027 + expected_resource_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_e82a9be6","line":1062,"range":{"start_line":1062,"start_character":0,"end_line":1062,"end_character":56},"in_reply_to":"5a18252c_b2ac64a1","updated":"2016-05-24 20:17:12.000000000","message":"I\u0027d at least filter for slashes \u0027/\u0027, question marks \u0027?\u0027 and ampersands \u0027\u0026\u0027 in _uri_from_uuid; either rejecting them (with exception) or escaping them (some url enconding library), to avoid injection attacks.\n\nIt might be faster and safer to ensure the characters are in [A-Fa-f0-9-]\n\nhttps://www.owasp.org/index.php/Injection_Flaws\nhttps://www.owasp.org/index.php/Data_Validation","commit_id":"666df4cd63f2318188e32a268f4202a00d763056"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"9a687f938f6eae79da0924ddf6af5697f7220647","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"        yield status, headers, system, memberuri"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"class OneViewClientFunctionsTestCase(unittest.TestCase):"},{"line_number":1063,"context_line":"    def test__uuid_from_uri(self):"},{"line_number":1064,"context_line":"        expected_resource_uuid \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa\u0027"},{"line_number":1065,"context_line":"        resource_uri \u003d \u0027/rest/resource/\u0027 + expected_resource_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_8ec36037","line":1062,"range":{"start_line":1062,"start_character":0,"end_line":1062,"end_character":56},"in_reply_to":"bab6814e_e82a9be6","updated":"2016-06-02 03:34:32.000000000","message":"Done","commit_id":"666df4cd63f2318188e32a268f4202a00d763056"}]}
