)]}'
{"oneview_client/models.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"8a34aba8e830867a66952afb6f11b69c3f80cf99","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def _get_default_value_or_from_json(self, attr_key, json):"},{"line_number":28,"context_line":"        value \u003d None"},{"line_number":29,"context_line":"        if json is None or json.get(attr_key) is None:"},{"line_number":30,"context_line":"            if hasattr(self, \u0027default_values\u0027):"},{"line_number":31,"context_line":"                value \u003d self.default_values.get(attr_key)"},{"line_number":32,"context_line":"        else:"},{"line_number":33,"context_line":"            value \u003d json.get(attr_key)"},{"line_number":34,"context_line":"        return value"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_d74b8b85","line":31,"range":{"start_line":30,"start_character":12,"end_line":31,"end_character":57},"updated":"2016-07-06 16:06:12.000000000","message":"It seems to me like you are trying to push client code logic into the library by setting default values for the models as attributes.\n\nCan you give an example of default value that would be valid for any client code that uses this library?\n\nIf this is the case, I\u0027d suggest passing the default_values as a parameter for this function, possibly as kwargs, mapping { attribute_name -\u003e value }.","commit_id":"e7d0a1871fe7ba87603db0668d2aa007038ae2fc"}]}
