)]}'
{"oneview_client/client.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"87d7d73b39838952bd23d30864810cb5af0f46b5","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def _set_onetime_boot(self, server_hardware_uuid, boot_device):"},{"line_number":242,"context_line":"        host_ip, ilo_token \u003d self._get_ilo_access(server_hardware_uuid)"},{"line_number":243,"context_line":"        try:"},{"line_number":244,"context_line":"            return ilo_utils.set_onetime_boot(host_ip, ilo_token, boot_device,"},{"line_number":245,"context_line":"                                              self.allow_insecure_connections)"},{"line_number":246,"context_line":"        finally:"},{"line_number":247,"context_line":"            ilo_utils.ilo_logout(host_ip, ilo_token)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_fcf96381","line":244,"range":{"start_line":244,"start_character":66,"end_line":244,"end_character":77},"updated":"2016-07-12 03:16:57.000000000","message":"Are iLO boot targets named the same as OneView and Ironic boot_devices? Shouldn\u0027t there be a mapping here?","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0aa46b83403e020d04265cda7a0ead4c926fb4a0","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def _set_onetime_boot(self, server_hardware_uuid, boot_device):"},{"line_number":242,"context_line":"        host_ip, ilo_token \u003d self._get_ilo_access(server_hardware_uuid)"},{"line_number":243,"context_line":"        try:"},{"line_number":244,"context_line":"            return ilo_utils.set_onetime_boot(host_ip, ilo_token, boot_device,"},{"line_number":245,"context_line":"                                              self.allow_insecure_connections)"},{"line_number":246,"context_line":"        finally:"},{"line_number":247,"context_line":"            ilo_utils.ilo_logout(host_ip, ilo_token)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_d2087493","line":244,"range":{"start_line":244,"start_character":66,"end_line":244,"end_character":77},"in_reply_to":"1aa78d24_fcf96381","updated":"2016-07-13 14:20:28.000000000","message":"Well thought. Indeed, it is different.","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"87d7d73b39838952bd23d30864810cb5af0f46b5","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                        onetime\u003dFalse):"},{"line_number":371,"context_line":"        if onetime:"},{"line_number":372,"context_line":"            sh_uuid \u003d utils.get_uuid_from_uri(node_info[\u0027server_hardware_uri\u0027])"},{"line_number":373,"context_line":"            self._set_onetime_boot(sh_uuid, new_primary_boot_device)"},{"line_number":374,"context_line":"        else:"},{"line_number":375,"context_line":"            self._persistent_set_boot_device(node_info,"},{"line_number":376,"context_line":"                                             new_primary_boot_device)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_7c2d7345","line":373,"updated":"2016-07-12 03:16:57.000000000","message":"From the implementation, this can fail and return an IloException. Let\u0027s make it fall back to the non-optimized _persistent_set_boot_device in those cases. Please test this case as well.","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0aa46b83403e020d04265cda7a0ead4c926fb4a0","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                        onetime\u003dFalse):"},{"line_number":371,"context_line":"        if onetime:"},{"line_number":372,"context_line":"            sh_uuid \u003d utils.get_uuid_from_uri(node_info[\u0027server_hardware_uri\u0027])"},{"line_number":373,"context_line":"            self._set_onetime_boot(sh_uuid, new_primary_boot_device)"},{"line_number":374,"context_line":"        else:"},{"line_number":375,"context_line":"            self._persistent_set_boot_device(node_info,"},{"line_number":376,"context_line":"                                             new_primary_boot_device)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3239f8f2","line":373,"in_reply_to":"1aa78d24_7c2d7345","updated":"2016-07-13 14:20:28.000000000","message":"Done","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"eb53c95a24cb50b196f31281dec2af4c24ab8bc8","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        }"},{"line_number":248,"context_line":"        try:"},{"line_number":249,"context_line":"            return ilo_utils.set_onetime_boot(host_ip, ilo_token,"},{"line_number":250,"context_line":"                                              mapping[boot_device],"},{"line_number":251,"context_line":"                                              self.allow_insecure_connections)"},{"line_number":252,"context_line":"        except exceptions.IloException as e:"},{"line_number":253,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_556c6b07","line":250,"updated":"2016-07-21 20:03:00.000000000","message":"I see a case for an exception in\n\n    mapping[boot_device]\n\nin case the boot_device is not in the map.\n\nLet\u0027s have some way of making it fall back to OneView in this case as well.","commit_id":"d6cbe413cf6f03bbfe0cf193d3a5c5c6083b24bb"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"d8328ea485feb37f94c06212d4ed326be3cc8207","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        }"},{"line_number":248,"context_line":"        try:"},{"line_number":249,"context_line":"            return ilo_utils.set_onetime_boot(host_ip, ilo_token,"},{"line_number":250,"context_line":"                                              mapping[boot_device],"},{"line_number":251,"context_line":"                                              self.allow_insecure_connections)"},{"line_number":252,"context_line":"        except exceptions.IloException as e:"},{"line_number":253,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_342f02f8","line":250,"in_reply_to":"dada55a8_556c6b07","updated":"2016-07-22 18:14:47.000000000","message":"Done","commit_id":"d6cbe413cf6f03bbfe0cf193d3a5c5c6083b24bb"}],"oneview_client/ilo_utils.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"87d7d73b39838952bd23d30864810cb5af0f46b5","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            return system[\u0027HostCorrelation\u0027][\u0027HostMACAddress\u0027][nic_index]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def set_onetime_boot(host_ip, x_auth_token, boottarget, allow_insecure\u003dFalse):"},{"line_number":186,"context_line":"    # for each system in the systems collection at /rest/v1/Systems"},{"line_number":187,"context_line":"    ilo_hardware \u003d collection(host_ip, \u0027/rest/v1/Systems\u0027, None,"},{"line_number":188,"context_line":"                              x_auth_token, enforce_SSL\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_9c43ff12","line":185,"range":{"start_line":185,"start_character":44,"end_line":185,"end_character":54},"updated":"2016-07-12 03:16:57.000000000","message":"boot_target?","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0aa46b83403e020d04265cda7a0ead4c926fb4a0","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            return system[\u0027HostCorrelation\u0027][\u0027HostMACAddress\u0027][nic_index]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def set_onetime_boot(host_ip, x_auth_token, boottarget, allow_insecure\u003dFalse):"},{"line_number":186,"context_line":"    # for each system in the systems collection at /rest/v1/Systems"},{"line_number":187,"context_line":"    ilo_hardware \u003d collection(host_ip, \u0027/rest/v1/Systems\u0027, None,"},{"line_number":188,"context_line":"                              x_auth_token, enforce_SSL\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3d48a92c","line":185,"range":{"start_line":185,"start_character":44,"end_line":185,"end_character":54},"in_reply_to":"1aa78d24_9c43ff12","updated":"2016-07-13 14:20:28.000000000","message":"Done","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"87d7d73b39838952bd23d30864810cb5af0f46b5","unresolved":false,"context_lines":[{"line_number":185,"context_line":"def set_onetime_boot(host_ip, x_auth_token, boottarget, allow_insecure\u003dFalse):"},{"line_number":186,"context_line":"    # for each system in the systems collection at /rest/v1/Systems"},{"line_number":187,"context_line":"    ilo_hardware \u003d collection(host_ip, \u0027/rest/v1/Systems\u0027, None,"},{"line_number":188,"context_line":"                              x_auth_token, enforce_SSL\u003dFalse)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    for status, headers, system, memberuri in ilo_hardware:"},{"line_number":191,"context_line":"        # verify expected type"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_7c38d3a0","line":188,"range":{"start_line":188,"start_character":44,"end_line":188,"end_character":61},"updated":"2016-07-12 03:16:57.000000000","message":"shouldn\u0027t this be (not allow_insecure)?","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0aa46b83403e020d04265cda7a0ead4c926fb4a0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"def set_onetime_boot(host_ip, x_auth_token, boottarget, allow_insecure\u003dFalse):"},{"line_number":186,"context_line":"    # for each system in the systems collection at /rest/v1/Systems"},{"line_number":187,"context_line":"    ilo_hardware \u003d collection(host_ip, \u0027/rest/v1/Systems\u0027, None,"},{"line_number":188,"context_line":"                              x_auth_token, enforce_SSL\u003dFalse)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    for status, headers, system, memberuri in ilo_hardware:"},{"line_number":191,"context_line":"        # verify expected type"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_bd0939df","line":188,"range":{"start_line":188,"start_character":44,"end_line":188,"end_character":61},"in_reply_to":"1aa78d24_7c38d3a0","updated":"2016-07-13 14:20:28.000000000","message":"It should. Thanks.","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"87d7d73b39838952bd23d30864810cb5af0f46b5","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    ilo_hardware \u003d collection(host_ip, \u0027/rest/v1/Systems\u0027, None,"},{"line_number":188,"context_line":"                              x_auth_token, enforce_SSL\u003dFalse)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    for status, headers, system, memberuri in ilo_hardware:"},{"line_number":191,"context_line":"        # verify expected type"},{"line_number":192,"context_line":"        # hint:  don\u0027t limit to version 0 here as we will rev to 1.0 at"},{"line_number":193,"context_line":"        # some point hopefully with minimal changes"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_bc3ebb88","line":190,"range":{"start_line":190,"start_character":33,"end_line":190,"end_character":42},"updated":"2016-07-12 03:16:57.000000000","message":"member_uri?","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0aa46b83403e020d04265cda7a0ead4c926fb4a0","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    ilo_hardware \u003d collection(host_ip, \u0027/rest/v1/Systems\u0027, None,"},{"line_number":188,"context_line":"                              x_auth_token, enforce_SSL\u003dFalse)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    for status, headers, system, memberuri in ilo_hardware:"},{"line_number":191,"context_line":"        # verify expected type"},{"line_number":192,"context_line":"        # hint:  don\u0027t limit to version 0 here as we will rev to 1.0 at"},{"line_number":193,"context_line":"        # some point hopefully with minimal changes"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_5d4db53c","line":190,"range":{"start_line":190,"start_character":33,"end_line":190,"end_character":42},"in_reply_to":"1aa78d24_bc3ebb88","updated":"2016-07-13 14:20:28.000000000","message":"Done","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"eb53c95a24cb50b196f31281dec2af4c24ab8bc8","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    for status, headers, system, member_uri in ilo_hardware:"},{"line_number":189,"context_line":"        # verify expected type"},{"line_number":190,"context_line":"        # hint:  don\u0027t limit to version 0 here as we will rev to 1.0 at"},{"line_number":191,"context_line":"        # some point hopefully with minimal changes"},{"line_number":192,"context_line":"        assert(get_type(system) \u003d\u003d \u0027ComputerSystem.0\u0027 or"},{"line_number":193,"context_line":"               get_type(system) \u003d\u003d \u0027ComputerSystem.1\u0027)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b0e1752c","line":191,"updated":"2016-07-21 20:03:00.000000000","message":"It seems like this code was taken from some tutorial. If so, please note the link to the document in a comment for future reference.","commit_id":"d6cbe413cf6f03bbfe0cf193d3a5c5c6083b24bb"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"d8328ea485feb37f94c06212d4ed326be3cc8207","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    for status, headers, system, member_uri in ilo_hardware:"},{"line_number":189,"context_line":"        # verify expected type"},{"line_number":190,"context_line":"        # hint:  don\u0027t limit to version 0 here as we will rev to 1.0 at"},{"line_number":191,"context_line":"        # some point hopefully with minimal changes"},{"line_number":192,"context_line":"        assert(get_type(system) \u003d\u003d \u0027ComputerSystem.0\u0027 or"},{"line_number":193,"context_line":"               get_type(system) \u003d\u003d \u0027ComputerSystem.1\u0027)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_14aabe19","line":191,"in_reply_to":"dada55a8_b0e1752c","updated":"2016-07-22 18:14:47.000000000","message":"There isn\u0027t a doc explaining how to do that. I took part of the example used on get_mac_from_ilo (above) and part from this one: https://github.com/HewlettPackard/python-ilorest-library/blob/d4abcc57d81c9a4df908c201c0fe7aa62b087001/examples/Rest/ex08_change_temporary_boot_order.py","commit_id":"d6cbe413cf6f03bbfe0cf193d3a5c5c6083b24bb"}],"oneview_client/tests/functional/test_oneview_client.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"87d7d73b39838952bd23d30864810cb5af0f46b5","unresolved":false,"context_lines":[{"line_number":610,"context_line":"#                                          self.username,"},{"line_number":611,"context_line":"#                                          self.password)"},{"line_number":612,"context_line":"#         oneview_client.set_onetime_boot(\u00271111-2222-3333\u0027,"},{"line_number":613,"context_line":"#                                         \u0027Pxe\u0027)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_9c377f4c","line":613,"updated":"2016-07-12 03:16:57.000000000","message":"Should this be really commented?","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0aa46b83403e020d04265cda7a0ead4c926fb4a0","unresolved":false,"context_lines":[{"line_number":610,"context_line":"#                                          self.username,"},{"line_number":611,"context_line":"#                                          self.password)"},{"line_number":612,"context_line":"#         oneview_client.set_onetime_boot(\u00271111-2222-3333\u0027,"},{"line_number":613,"context_line":"#                                         \u0027Pxe\u0027)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_5de935e5","line":613,"in_reply_to":"1aa78d24_9c377f4c","updated":"2016-07-13 14:20:28.000000000","message":"These tests weren\u0027t working. The whole patch should be workflow-1 but the update to fix pep8 removed the workflow. :)","commit_id":"b63d7473dc856cd719425ed6ead68ae3756c10af"}]}
