)]}'
{"oneview_client/client.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c72c4c3c3e9a23ef43a18751ea9bea255dd9416b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if not self._is_oneview_version_compatible():"},{"line_number":119,"context_line":"            msg \u003d (\"The version of the OneView\u0027s API is unsupported. \""},{"line_number":120,"context_line":"                   \"Supported version is \u0027%s\u0027\" % SUPPORTED_ONEVIEW_VERSION)"},{"line_number":121,"context_line":"            LOG.warning(msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _is_oneview_version_compatible(self):"},{"line_number":124,"context_line":"        versions \u003d self.get_oneview_version()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_7c4f616a","line":121,"updated":"2016-07-15 12:58:22.000000000","message":"This is a behavior change where the library should know what it is compatible with.  Where possibly incompatible or future compatible but unsure, a warning should be logged, if known incompatible, as in previous version of OneView, an exception should be raised.","commit_id":"87192b5547abfd39bdc3a1856e2bd8817d7feb40"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"d4f73de8f361d341d7f864968106ff096f850284","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if not self._is_oneview_version_compatible():"},{"line_number":119,"context_line":"            msg \u003d (\"The version of the OneView\u0027s API is unsupported. \""},{"line_number":120,"context_line":"                   \"Supported version is \u0027%s\u0027\" % SUPPORTED_ONEVIEW_VERSION)"},{"line_number":121,"context_line":"            LOG.warning(msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _is_oneview_version_compatible(self):"},{"line_number":124,"context_line":"        versions \u003d self.get_oneview_version()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_a6d097ca","line":121,"in_reply_to":"1aa78d24_7c4f616a","updated":"2016-07-15 14:02:28.000000000","message":"Will put up a patch Where it raises exception when it is less than minimum version compatible and logs warning when it is higher than supported version.","commit_id":"87192b5547abfd39bdc3a1856e2bd8817d7feb40"}],"oneview_client/tests/unit/test_oneview_client.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c72c4c3c3e9a23ef43a18751ea9bea255dd9416b","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        self.oneview_client.verify_oneview_version()"},{"line_number":916,"context_line":"        mock_get_oneview_version.assert_called_once_with()"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"    @unittest.skip(\"skipping version test for time being.\")"},{"line_number":919,"context_line":"    @mock.patch.object(client.Client, \u0027get_oneview_version\u0027)"},{"line_number":920,"context_line":"    def test_verify_oneview_version_fail(self, mock_get_oneview_version):"},{"line_number":921,"context_line":"        mock_get_oneview_version.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e143ae6a","line":918,"range":{"start_line":918,"start_character":4,"end_line":918,"end_character":59},"updated":"2016-07-15 12:58:22.000000000","message":"Unit tests really shouldn\u0027t be disabled.  Truthfully, it seems like the behavior should be such that if known compatible, a warning should be logged.   If known incompatible an exception should be generated, and both outcomes should be tested for.","commit_id":"87192b5547abfd39bdc3a1856e2bd8817d7feb40"}]}